Commit Graph

930 Commits

Author SHA1 Message Date
Weston Ruter
8625ca01ec Bundled Theme: Fix malformed Google Font URL for Twenty Twelve due to double-encoding of +
Amends [45485].
Fixes #47282.


git-svn-id: https://develop.svn.wordpress.org/trunk@45525 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-12 23:32:44 +00:00
Felix Arntz
2264493b0d Bundled Theme: Load Google fonts with display=fallback parameter for better UX in case the font cannot be loaded.
Providing this query parameter ensures the stylesheet contains the `font-display: fallback` rule. This changeset also updates the Open Sans font used by core accordingly.

Props westonruter.
Fixes #47282.


git-svn-id: https://develop.svn.wordpress.org/trunk@45485 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-31 10:09:39 +00:00
Sergey Biryukov
6b254f864b Twenty Seventeen: Accessibility: Add missing focus state for native audio and video embeds.
Props kjellr, karlgroves.
Fixes #47190.

git-svn-id: https://develop.svn.wordpress.org/trunk@45425 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-26 02:00:16 +00:00
Sergey Biryukov
d1be6e34c9 Twenty Nineteen: Add missing icon to Edit link for pages.
Props mukesh27, ianbelanger, ounziw.
Fixes #47332.

git-svn-id: https://develop.svn.wordpress.org/trunk@45397 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-24 01:21:09 +00:00
Sergey Biryukov
df9caed81b Twenty Nineteen: Correct function name in a function_exists() check for twentynineteen_get_user_avatar_markup().
Props mukesh27, diego-la-monica.
Fixes #46410.

git-svn-id: https://develop.svn.wordpress.org/trunk@45383 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-23 01:30:21 +00:00
Jonathan Desrosiers
5b2fb1637c Twenty Nineteen: Fix Docblock spelling error.
Props mukesh27.
Fixes #47129.

git-svn-id: https://develop.svn.wordpress.org/trunk@45299 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-09 20:07:49 +00:00
Jonathan Desrosiers
d69d56abb1 Twenty Nineteen: Remove duplicate code block.
Introduced in [44305].

Props mukesh27, afercia.
Fixes #46455.

git-svn-id: https://develop.svn.wordpress.org/trunk@45297 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-09 18:03:15 +00:00
laurelfulford
6b6671d94b Default Themes: Bump the version numbers and release dates.
Update the theme versions and release dates for the default themes, in time for WordPress 5.2.

The POT files for Twenty Eleven and Twenty Ten have also been updated.

Fixes #47172.



git-svn-id: https://develop.svn.wordpress.org/trunk@45289 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-07 18:48:28 +00:00
Sergey Biryukov
7b1d581339 Twenty Nineteen: Fix padding discrepancies in responsive styles for Column block.
Props kjellr, dianeco.
Fixes #46643, #46999.

git-svn-id: https://develop.svn.wordpress.org/trunk@45264 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-24 18:36:58 +00:00
laurelfulford
8756d56b7e Twenty Nineteen: Prevent too-long strings from causing horizontal scrolling.
Add hyphen and word-wrap styles to the site title, comments, and widget areas to break too-long strings and prevent horizontal scrolling.

Props ianbelanger, dswebsme, mukesh27.
Fixes #46704.



git-svn-id: https://develop.svn.wordpress.org/trunk@45258 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-23 19:47:14 +00:00
laurelfulford
1b9fd43f25 Twenty Seventeen: Prevent too-long strings from causing horizontal scrolling.
Add a `max-width` to the site title, so too-long strings will wrap instead of causing horizontal scrolling. 

Props ianbelanger, dswebsme.
Fixes #46703.



git-svn-id: https://develop.svn.wordpress.org/trunk@45257 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-23 16:43:53 +00:00
Adam Silverstein
5cc7acd1ab Bundled Theme: add a wp_body_open shim for older WordPress versions.
WordPress 5.2 adds the `wp_body_open()` function, and the default themes make use of it. This patch adds a shim for `wp_body_open` to bundled themes so this function will also work in older versions of WordPress.

Props lgedeon, johnbillion, timph, ramiy, pento.
Fixes #46679.



git-svn-id: https://develop.svn.wordpress.org/trunk@45256 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-23 13:03:14 +00:00
Sergey Biryukov
4623540ad1 Bundled Themes: Update readme.txt files to pass Theme Review guidelines.
Props rabmalin.
Fixes #45871.

git-svn-id: https://develop.svn.wordpress.org/trunk@45250 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-19 13:40:14 +00:00
Jonathan Desrosiers
4f3f0fae08 Bundled Themes: Reverts [45213].
Reverting to address backward compatibility concerns in Twenty Eleven and Twenty Ten.

See #39997.

git-svn-id: https://develop.svn.wordpress.org/trunk@45218 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-16 18:21:24 +00:00
Jonathan Desrosiers
1954fa7385 Bundled Themes: Use the theme version when enqueuing theme specific stylesheets.
For many bundled theme related stylesheets, a version is either not specified, or specified as a hardcoded date string when enqueued. This is problematic when a stylesheet is updated and the version number is not (which has happened several times recently). This change ensures that all bundled theme related stylesheets use the theme’s version as the stylesheet version. This ensures cache busting for theme stylesheets every time a theme is updated and guarantees that users receive any new or updated styles included in the update when visiting the site for the first time after an update.

Props parsmizban, ianbelanger, dswebsme.
Fixes #39997.

git-svn-id: https://develop.svn.wordpress.org/trunk@45213 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-16 14:55:48 +00:00
Jonathan Desrosiers
855232ec60 Twenty Thirteen: Correct Genericons stylesheet version number.
In [28693], the Genericons stylesheet was updated to `3.0.3`, but the version was incorrectly indicated as `3.03`.

See #39997.

git-svn-id: https://develop.svn.wordpress.org/trunk@45212 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-16 14:06:33 +00:00
Sergey Biryukov
5895974f10 Bundled Themes: Use consistent HTML comments after closing HTML tags.
Props iamdmitrymayorov.
Fixes #46871.

git-svn-id: https://develop.svn.wordpress.org/trunk@45209 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-16 01:29:20 +00:00
Gary Pendergast
30679d4c83 Twenty Seventeeen: Fix MediaElement control hover colours in the customiser.
When selecting custom colour schemes in the customiser, the hover colour is incorrectly applied to MediaElement controls.

Props xkon, ianbelanger.
Fixes #40843.



git-svn-id: https://develop.svn.wordpress.org/trunk@45146 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 23:37:42 +00:00
Gary Pendergast
8efcc32fde Help: Update support forum links.
There are a lot of places in Core that link to https://wordpress.org/support/ for the support forums, but that's now the URL for HelpHub. The new forums link is https://wordpress.org/support/forums/.

Props jitendrabanjara1991, dilipbheda, mukesh27, ianbelanger.
Fixes #46790.



git-svn-id: https://develop.svn.wordpress.org/trunk@45140 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 22:58:49 +00:00
Sergey Biryukov
639f038dae Twenty Nineteen: Fix inconsistent tab/space indentation in style files.
Props iamdmitrymayorov, mukesh27.
Fixes #46821.

git-svn-id: https://develop.svn.wordpress.org/trunk@45132 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-07 06:17:26 +00:00
Sergey Biryukov
60e5087b36 Bundled Themes: Link to an updated documentation on post thumbnails on developer.wordpress.org, instead of Codex.
Props samanehmirrajabi.
Fixes #46823.

git-svn-id: https://develop.svn.wordpress.org/trunk@45126 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-07 05:22:17 +00:00
Sergey Biryukov
028e4098c7 Twenty Twelve: Correct linear-gradient direction argument syntax.
In CSS, the `linear-gradient` function requires that the direction value explicitly use `to` instead of an implicit `from`.

Props: ianbelanger, joyously, man4toman.
Fixes #46786.

git-svn-id: https://develop.svn.wordpress.org/trunk@45124 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-06 16:16:50 +00:00
Jonathan Desrosiers
0afc9b5119 Twenty Eleven: Correct linear-gradient direction argument syntax.
In CSS, the `linear-gradient` function requires that the direction value explicitly use `to` instead of an implicit `from`.

Props: ianbelanger, Malae, man4toman.
Fixes #46770.

git-svn-id: https://develop.svn.wordpress.org/trunk@45109 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-04 18:25:21 +00:00
Sergey Biryukov
03135696bd Twenty Fifteen: Fix typo in a comment for print styles.
Props mukesh27.
Fixes #46767.

git-svn-id: https://develop.svn.wordpress.org/trunk@45096 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-02 13:06:40 +00:00
Sergey Biryukov
0060f2ccbc Bundled Themes: Link to an updated documentation on child themes on developer.wordpress.org, instead of Codex.
Props man4toman, andraganescu.
Fixes #46450.

git-svn-id: https://develop.svn.wordpress.org/trunk@45081 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-01 11:55:39 +00:00
Sergey Biryukov
87d1821cbf Twenty Nineteen: Update Theme URI to point to the Theme Directory instead of the archived GitHub repository.
Update `style.scss` and `style-rtl.css`, missed in [45032].

Props dimadin.
See #46668.

git-svn-id: https://develop.svn.wordpress.org/trunk@45057 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-28 20:57:05 +00:00
Sergey Biryukov
6f5651a9e4 Twenty Seventeen: Make <th> styling in table block consistent between back end and front end.
Props ianbelanger.
Fixes #46568.

git-svn-id: https://develop.svn.wordpress.org/trunk@45051 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-28 15:24:20 +00:00
Adam Silverstein
01882f477b Bundled Theme: trigger a new wp_body_open action immediately after the opening body tag.
* Enables inserting (asynchronous) JavaScript right after the opening `body` tag.
* Add a `wp_body_open` helper function that triggers the `wp_body_open` action.
* Call `wp_body_open` in core themes immediately after the opening `body` tag.

Props joostdevalk, valendesigns, nacin, saracup, jorbin, mikeschinkel, jonnybojangles, lgedeon, Willscrlt, Denis-de-Bernardy, lexiqueen, sky_76, welcher, westonruter, ramiy, joyously.
Fixes #12563.


git-svn-id: https://develop.svn.wordpress.org/trunk@45042 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-27 21:58:38 +00:00
Sergey Biryukov
8e9425e094 Twenty Nineteen: Update Theme URI to point to the Theme Directory instead of the archived GitHub repository.
Props dimadin.
Fixes #46668.

git-svn-id: https://develop.svn.wordpress.org/trunk@45032 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-27 14:31:16 +00:00
Andrea Fercia
d26542632e Accessibility: Improve the "Hello Dolly" accessibility.
- adds a visually hidden text to give context to the lyrics
- the text is `Quote from Hello Dolly song, by Jerry Herman:`
- adds a `lang` HTML attribute (when the admin language is not English) to better support assistive technologies 
- adds a `dir` HTML attribute to better support the LTR English lyrics with RTL languages 
- CSS adjustments

Props audrasjb, SergeyBiryukov, danieltj, birgire, karmatosed, desrosj, afercia.
Fixes #43632.


git-svn-id: https://develop.svn.wordpress.org/trunk@44929 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-18 17:18:46 +00:00
allancole
315616aa5e Twenty Nineteen: Improve custom color behavior for InnerBlocks
Currently, if a parent block has a custom background color assigned, its child blocks will inherit the parent's text colors — even if the child block has its own custom text color assigned to it. 

This update changes the following: 

- Adjusts Twenty Nineteen's custom background color defaults to target direct children only which fixes the issue

Props kjellr.

See #46432.



git-svn-id: https://develop.svn.wordpress.org/trunk@44818 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-07 22:36:58 +00:00
Aaron Jorbin
e421f262dc Replace usages of basename() with wp_basename() in order to support multibyte filenames
This is focused on the pieces of code that touch media files and the tests that support them. `basename` isn't multibyte compatible out of the box. See http://php.net/basename and https://bugs.php.net/bug.php?id=62119.

See #43170.
Props Viper007Bond.


git-svn-id: https://develop.svn.wordpress.org/trunk@44785 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-01 20:57:26 +00:00
Sergey Biryukov
ebe84c7e52 Twenty Nineteen: Remove stray ÷ character in print.css.
Props mukesh27, laurelfulford.
Fixes #46083.

git-svn-id: https://develop.svn.wordpress.org/trunk@44774 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-28 02:46:39 +00:00
Sergey Biryukov
37c5efcdee Twenty Nineteen: Update style-rtl.css after [44657].
See #45731.

git-svn-id: https://develop.svn.wordpress.org/trunk@44773 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-28 02:43:09 +00:00
Sergey Biryukov
3574d43d28 Twenty Nineteen: Avoid nested comment author links in TwentyNineteen_Walker_Comment::html5_comment().
Props iamdmitrymayorov, mukesh27.
Fixes #46291.

git-svn-id: https://develop.svn.wordpress.org/trunk@44771 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-28 01:54:14 +00:00
laurelfulford
e7e42efe18 Twenty Nineteen: Update the quote block styles.
Update the theme's quote block border styles, so they will work better with the updated styles for the quote block, coming in Gutenberg 5.2.

Props @kjellr.
Fixes #46239.



git-svn-id: https://develop.svn.wordpress.org/trunk@44739 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-13 18:39:59 +00:00
laurelfulford
2a49b5c469 Default Themes: Bump the version numbers and release dates.
Update the theme versions and release dates for the default themes, in time for WordPress 5.1.

The POT files for Twenty Eleven and Twenty Ten have also been updated.

Fixes #46070.



git-svn-id: https://develop.svn.wordpress.org/trunk@44730 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-07 23:22:04 +00:00
laurelfulford
3f7881b77a Twenty Seventeen: Update blockquote alignment on load.
The theme uses JavaScript to check if a right-aligned blockquote is below the sidebar content before pushing it outside of the content area. This was originally only firing on browser resize.

Fixes #40103.



git-svn-id: https://develop.svn.wordpress.org/trunk@44679 602fd350-edb4-49c9-b593-d223f7449a82
2019-01-21 22:07:33 +00:00
laurelfulford
95c496b39e Twenty Seventeen: Prevent YouTube videos from being cut off in Safari.
The theme's `object-fit: cover` styles for the header caused YouTube videos to be positioned too far left in Safari. 

Fixes #40522.



git-svn-id: https://develop.svn.wordpress.org/trunk@44669 602fd350-edb4-49c9-b593-d223f7449a82
2019-01-21 18:02:58 +00:00
laurelfulford
192224a46e Twenty Nineteen: Create separate :lang() selectors for Devanagari.
In the non-latin font fallback styles, languages using the Devanagari alphabet were initially committed in a comma-separated list in the `:lang()` selector, which isn't fully supported. This update separates those languages into their own `:lang()` selectors. 

Props mako09.
Fixes #45731.



git-svn-id: https://develop.svn.wordpress.org/trunk@44657 602fd350-edb4-49c9-b593-d223f7449a82
2019-01-20 20:22:05 +00:00
laurelfulford
7c0a304cf4 Twenty Nineteen: Fix alignment of page title when there are no posts.
Fix the alignment of the "Nothing Found" page title when there are no posts, to match how it appears for the search results when nothing is found, and the 404 page. 

Props kjellr, lorenzone92.
Fixes #45887.



git-svn-id: https://develop.svn.wordpress.org/trunk@44652 602fd350-edb4-49c9-b593-d223f7449a82
2019-01-18 20:45:34 +00:00
laurelfulford
131142486b Twenty Nineteen: Use a less aggressive approach for non-latin font fallbacks.
The theme's original approach to its non-latin font fallbacks required `!important`, which overrode fonts that shouldn't have been changed, like the icon fonts used for editor buttons.

Props kjellr, mako09, allancole.
Fixes #45731.



git-svn-id: https://develop.svn.wordpress.org/trunk@44650 602fd350-edb4-49c9-b593-d223f7449a82
2019-01-18 18:37:26 +00:00
Gary Pendergast
992184cf73 Coding Standards: Upgrade WPCS to 1.2.1.
This upgrade fixes quite a few false positives, as well as auto-fixing some indenting issues.

Fixes #45956.



git-svn-id: https://develop.svn.wordpress.org/trunk@44574 602fd350-edb4-49c9-b593-d223f7449a82
2019-01-12 06:40:16 +00:00
Gary Pendergast
ff53bd388c Coding Standards: Extract extract() from the codebase.
Of the last four instances of `extract()` occurring, three of them are removed by this commit, and the fourth is appropriately documented.

See #45934.



git-svn-id: https://develop.svn.wordpress.org/trunk@44569 602fd350-edb4-49c9-b593-d223f7449a82
2019-01-12 03:19:23 +00:00
Gary Pendergast
33caf61b8b Coding Standards: Fix the Squiz.ControlStructures.ControlSignature.SpaceAfterCloseBrace violations.
See #45934.



git-svn-id: https://develop.svn.wordpress.org/trunk@44566 602fd350-edb4-49c9-b593-d223f7449a82
2019-01-11 06:39:55 +00:00
Gary Pendergast
8cc49330a4 Coding Standards: Fix the minor WordPress.WP.I18n violations.
`WordPress.WP.I18n.MissingTranslatorsComment` is in progress in #44360.

See #45934.



git-svn-id: https://develop.svn.wordpress.org/trunk@44562 602fd350-edb4-49c9-b593-d223f7449a82
2019-01-11 06:03:46 +00:00
Gary Pendergast
31fdd577b4 Bundled Themes: Run the pingback_url through esc_url().
Twenties Ten through Seventeen have been updated to properly escape the pingback URL. Twenty Nineteen is already escaping the URL.

Props soulseekah, sharaz.
Fixes #43717.



git-svn-id: https://develop.svn.wordpress.org/trunk@44500 602fd350-edb4-49c9-b593-d223f7449a82
2019-01-09 06:10:13 +00:00
Gary Pendergast
477adade57 Docs: Update Codex references to the Template_Hierarchy page.
https://codex.wordpress.org/Template_Hierarchy redirects to https://developer.wordpress.org/themes/basics/template-hierarchy/, so we should link to the correct page.

Props kmeze, pento.
Fixes #45222.



git-svn-id: https://develop.svn.wordpress.org/trunk@44496 602fd350-edb4-49c9-b593-d223f7449a82
2019-01-09 05:08:25 +00:00
Jonathan Desrosiers
cd100a117d Docs: Fix typos in Twenty Seventeen function descriptions.
Props faisal03, mukesh27.
Fixes #45466.

git-svn-id: https://develop.svn.wordpress.org/trunk@44479 602fd350-edb4-49c9-b593-d223f7449a82
2019-01-08 19:21:28 +00:00
Gary Pendergast
0cbd818ce8 Docs: Correct the parameters passed to the twentyseventeen_custom_header_args filter.
The documented `$default_text_color` parameter isn't passed, and the `$video` parameter is passed, but not documented.

Props mukesh27.
Fixes #44920.


git-svn-id: https://develop.svn.wordpress.org/trunk@44462 602fd350-edb4-49c9-b593-d223f7449a82
2019-01-08 05:55:55 +00:00