Commit Graph

1762 Commits

Author SHA1 Message Date
Scott Taylor
0675902ec8 Don't use variable variables in wp_salt().
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28741 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 18:35:42 +00:00
Scott Taylor
0d0cdfe1c7 Don't use variable variables in wp_insert_user().
Add a local array, `$meta`, to provide substantial disambiguation among variables. 

See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28740 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 18:20:57 +00:00
Scott Taylor
35af75077b Don't use variable variables in plugins_url().
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28739 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 18:17:52 +00:00
Scott Taylor
ce8cff84aa Don't use variable variables in WP_Comment_Query::query().
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28738 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 17:57:39 +00:00
Scott Taylor
f2b3e0c4e4 Don't use variable variables in WP_Query::get_posts().
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28737 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 17:49:07 +00:00
Scott Taylor
5fe5f8f3ad Don't use variable variables in get_terms().
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28736 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 17:40:11 +00:00
Drew Jaynes (DrewAPicture)
e535d7fe6e Improve inline documention for set_transient() and set_site_transient() to specify the 45- and 40-character limits for their respective transient name values.
Props edwin-at-studiojoyo.com for the original patch.
See #15058, #13310. Fixes #28467.


git-svn-id: https://develop.svn.wordpress.org/trunk@28735 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 16:32:06 +00:00
Scott Taylor
fa03901cd8 Don't use a variable variable in wp_widget_rss_form(). Sidenote: the logic to show hidden fields is bizarre - would result in duplicate fields.
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28734 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 16:17:56 +00:00
Scott Taylor
eadc17c4f9 In wp_insert_term(), when no slug is provided, check for an existing term by name. If it exists, use that slug instead of calling sanitize_title( $name ).
Prevents creating an endless number of terms like `A+` or `$$$$` in any given taxonomy.

Props wonderboymusic, SergeyBiryukov, aaroncampbell.
Fixes #17689.


git-svn-id: https://develop.svn.wordpress.org/trunk@28733 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 02:27:36 +00:00
Andrew Ozz
1b07af046f Fix the layout of the Image Details modal, props gcorne, see #24716 [28682]
git-svn-id: https://develop.svn.wordpress.org/trunk@28732 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 00:22:53 +00:00
John Blackbourn
f54bb586c8 A little more abstraction in the WP_oEmbed class. Fixes #24381.
git-svn-id: https://develop.svn.wordpress.org/trunk@28728 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 18:13:43 +00:00
Scott Taylor
821c052473 In wptexturize(), ensure that texturization does not corrupt contents of HTML elements, HTML comments, and smartcode attributes.
Adds a variety of unit tests/assertions.

Props miqrogroove.
Fixes #12690, #8912, #27602.


git-svn-id: https://develop.svn.wordpress.org/trunk@28727 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 14:33:16 +00:00
Scott Taylor
9e347a40c2 In wptexturize(), allow dashes before and after curly quotes. Example: This is what she said---"Wow that is cool."
Adds unit tests.

Props adamsilverstein, miqrogroove.
Fixes #20342.


git-svn-id: https://develop.svn.wordpress.org/trunk@28726 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 14:21:36 +00:00
Scott Taylor
66b539bdab wptexturize() should handle apostrophes before primes.
Props nacin, miqrogroove.
Fixes #22823.


git-svn-id: https://develop.svn.wordpress.org/trunk@28725 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 14:13:52 +00:00
Drew Jaynes (DrewAPicture)
da0b2f9769 Improve inline documentation for the wp_spaces_regexp filter.
Fixes #27588.


git-svn-id: https://develop.svn.wordpress.org/trunk@28724 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 06:45:38 +00:00
Drew Jaynes (DrewAPicture)
0d0f24fbbb Add inline documentation for the run_wptexturize filter.
Props miqrogroove for the original patch.
Fixes #19550.


git-svn-id: https://develop.svn.wordpress.org/trunk@28723 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 06:28:19 +00:00
Scott Taylor
fe2ca3965e Set a variable for like-escaped string before looping in WP_User_Query::get_search_sql().
Props miqrogroove.
Fixes #10041.


git-svn-id: https://develop.svn.wordpress.org/trunk@28722 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 02:44:35 +00:00
Scott Taylor
013f3f14e3 Fix curly quotes around numbers when applicable.
Adds unit tests.

Props filosofo, mrmist, aliso, MikeHansenMe, miqrogroove.
Fixes #8775.


git-svn-id: https://develop.svn.wordpress.org/trunk@28721 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 02:42:35 +00:00
Scott Taylor
ce59109919 In WP_Comment_Query::get_search_sql(), don't double-like-escape.
Props miqrogroove.
See #10041.


git-svn-id: https://develop.svn.wordpress.org/trunk@28720 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 02:19:30 +00:00
Scott Taylor
a66f776684 In wptexturize(), don't convert C-style hexadecimals to mathematical ×.
Adds unit tests.

Props harrym, kurtpayne, miqrogroove.
Fixes #19308.


git-svn-id: https://develop.svn.wordpress.org/trunk@28719 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 02:17:24 +00:00
Scott Taylor
f9bcf40db7 In wptexturize(), treat   like whitespace when texturizing hyphens.
Adds unit tests.

Props redsweater, miqrogroove.
Fixes #23185.


git-svn-id: https://develop.svn.wordpress.org/trunk@28718 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 02:08:05 +00:00
Scott Taylor
db7816dd0c smilies_init(), treat   like whitespace when converting smilies.
Adds unit tests.

Props miqrogroove.
Fixes #27587.


git-svn-id: https://develop.svn.wordpress.org/trunk@28717 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 02:02:23 +00:00
Scott Taylor
97bacb3121 Ensure that shortcode_unautop() treats   like whitespace.
`shortcode_unautop()` and `wptexturize()` now use `wp_spaces_regexp()` instead of raw regex.

Adds unit tests.

Props miqrogroove.
See #27588.


git-svn-id: https://develop.svn.wordpress.org/trunk@28716 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 01:54:11 +00:00
Scott Taylor
8ec05a3926 Add a $run_texturize static var to wptexturize() that is filterable via a new run-once filter: 'run_wptexturize'. Allows user to disable texturization.
Needs filter docs.

Props nacin, SergeyBiryukov.
See #19550.


git-svn-id: https://develop.svn.wordpress.org/trunk@28715 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 01:45:28 +00:00
Scott Taylor
84ad12b439 Replace all uses of like_escape() with $wpdb->esc_like().
Props miqrogroove.
See #10041.


git-svn-id: https://develop.svn.wordpress.org/trunk@28712 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 00:43:32 +00:00
Scott Taylor
2a551f57a4 LIKE escape sanity:
* Deprecate `like_escape()`
* Add a method to `$wpdb`, `->esc_like()`, and add unit tests

`$wpdb::esc_like()` is not used yet. As such, many unit tests will throw `Unexpected deprecated notice for like_escape`. Subsequent commits will alleviate this.

Props miqrogroove.
See #10041.


git-svn-id: https://develop.svn.wordpress.org/trunk@28711 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 00:29:35 +00:00
John Blackbourn
12ea157f2c Correct the deprecated function parameter in url_is_accessable_via_ssl(). See #19555.
git-svn-id: https://develop.svn.wordpress.org/trunk@28710 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-09 22:26:27 +00:00
John Blackbourn
7a220d7e95 Deprecate url_is_accessable_via_ssl(). Fixes #19555. Props jgadbois.
git-svn-id: https://develop.svn.wordpress.org/trunk@28709 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-09 22:02:50 +00:00
Scott Taylor
b7d411e724 Add a function: wp_spaces_regexp(). It is not used yet.
This function is required by a bunch of patches by miqrogroove. Needs filter docs.

Props miqrogroove.
See #27588.


git-svn-id: https://develop.svn.wordpress.org/trunk@28708 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-09 19:29:55 +00:00
Scott Taylor
faf208de38 Live update the menu item title when the user is editing the "Navigation Label" field.
Props celloexpressions.
See #23076.


git-svn-id: https://develop.svn.wordpress.org/trunk@28707 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-09 18:38:29 +00:00
Scott Taylor
69384c40a3 When a plain URL or email address is selected in the editor and "Insert/edit link" is clicked, pre-populate the URL field with the URL or mailto:<email-address>.
Props tillkruess.
Fixes #19992.


git-svn-id: https://develop.svn.wordpress.org/trunk@28705 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-09 15:34:21 +00:00
Sergey Biryukov
dfffa2cffd Fix JSHint error.
props avryl.
see #24716.

git-svn-id: https://develop.svn.wordpress.org/trunk@28697 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-08 12:32:50 +00:00
Sergey Biryukov
88e8720018 Use get_pages() instead of a raw SQL query in get_body_class().
fixes #28159.

git-svn-id: https://develop.svn.wordpress.org/trunk@28696 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-07 03:21:46 +00:00
Scott Taylor
60cf850c00 As per @gcorne's suggestion, when calling wp.mce.views.register(), automatically set shortcode equal to the passed type in the set of default args instead of introducing a type property. It is still overrideable by the args that are passed.
See #28458.



git-svn-id: https://develop.svn.wordpress.org/trunk@28689 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-06 14:21:12 +00:00
wonderboymusic
655d03da0a Improve inline doc descriptions in media-views.js.
Props ericlewis.
See #28459.


git-svn-id: https://develop.svn.wordpress.org/trunk@28688 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-06 14:12:03 +00:00
Andrew Ozz
67639d7e91 wpView: fix deselecting a view when clicking outside the iframe body. Props avryl, fixes #28268
git-svn-id: https://develop.svn.wordpress.org/trunk@28687 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-06 05:03:33 +00:00
Andrew Ozz
b1b0e54f7f wpView: fire a nodeChanged event after selecting a view so the editor UI gets updated. Props avryl, fixes #28385
git-svn-id: https://develop.svn.wordpress.org/trunk@28686 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-06 04:42:34 +00:00
Andrew Ozz
319299d42b TinyMCE: remove &nbsp from empty paragraphs inside the visual editor, props avryl, fixes #28282
git-svn-id: https://develop.svn.wordpress.org/trunk@28685 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-06 04:19:09 +00:00
Andrew Ozz
73e4f3e13b wpView: use data-mce-selected instead of adding a class to mark a view as selected. This prevents adding an unneeded undo level. Props avryl, fixes #28313
git-svn-id: https://develop.svn.wordpress.org/trunk@28684 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-06 02:11:02 +00:00
Andrew Ozz
6228058b64 Fix JS error in tmpl-editor-gallery, 'string'.trim() is not available in IE < 9. See #28089
git-svn-id: https://develop.svn.wordpress.org/trunk@28683 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-06 01:49:44 +00:00
Helen Hou-Sandi
3d9fc450b2 Grid view for the media library, first pass. This is alpha; expect imperfection. We will be iterating further.
props ericlewis, shaunandrews, wonderboymusic.
see #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@28682 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-05 22:00:24 +00:00
Scott Taylor
c18f082b15 Simplify the creation of MCE views somewhat:
* Rename the `wp.mce.media` mixin (which was named too ambiguously) to `wp.mce.av`.
* Use the same technique for extending mixins for MCE base classes for views and their base.View property class
* `wp.mce.views.register()` should have default constructor logic if one is not passed.

Props avryl.
See #28458.



git-svn-id: https://develop.svn.wordpress.org/trunk@28680 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-05 17:26:24 +00:00
Sergey Biryukov
504f5ad680 Deprecate get_all_category_ids(). Suggest get_terms() as a replacement.
props winterDev, MikeHansenMe.
fixes #21200.

git-svn-id: https://develop.svn.wordpress.org/trunk@28679 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-05 16:25:01 +00:00
Sergey Biryukov
83bffbc6c7 Correct @return value for get_children().
props ghost1227.
fixes #28422.

git-svn-id: https://develop.svn.wordpress.org/trunk@28677 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-05 15:52:51 +00:00
Sergey Biryukov
ff3f4e888f Add a note about return value in case of an expired transient to get_transient() and get_site_transient().
props ruud@joyo.
fixes #28462.

git-svn-id: https://develop.svn.wordpress.org/trunk@28676 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-05 15:33:30 +00:00
Scott Taylor
60a49287f6 Media modal documentation:
Add some clarity to default values for controllers.

Props ericlewis.
See #28459.



git-svn-id: https://develop.svn.wordpress.org/trunk@28675 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-05 14:53:44 +00:00
Andrew Nacin
0dcce859fb Force SSL admin when siteurl is explicitly configured with HTTPS.
see #27954.


git-svn-id: https://develop.svn.wordpress.org/trunk@28674 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-05 14:08:11 +00:00
Sergey Biryukov
7f3b20c45d Remove redundant 'Visit author homepage' title attributes for plugins and themes.
props joedolson.
fixes #26554.

git-svn-id: https://develop.svn.wordpress.org/trunk@28673 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-05 04:51:55 +00:00
Sergey Biryukov
c556e74943 wp_insert_comment() and wp_new_comment() should check if the comment was successfully inserted into the database.
props pento.
fixes #28254.

git-svn-id: https://develop.svn.wordpress.org/trunk@28672 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-05 04:37:02 +00:00
Sergey Biryukov
4fde71e75d Avoid an empty href attribute in paginate_links(). Add unit tests.
props obenland, Nessworthy.
fixes #24606.

git-svn-id: https://develop.svn.wordpress.org/trunk@28671 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-05 02:09:12 +00:00