Commit Graph

103 Commits

Author SHA1 Message Date
Weston Ruter
6ea3026565 Customize: Increase width of controls pane on large monitors to give more room.
Props celloexpressions, timmydcrawford.
Fixes #32296.


git-svn-id: https://develop.svn.wordpress.org/trunk@40511 602fd350-edb4-49c9-b593-d223f7449a82
2017-04-21 05:24:52 +00:00
Weston Ruter
63e6a6b7e7 Customize: Fix visibility of "Hide Controls" link in IE.
Amends [39214].
Props timmydcrawford.
See #32296, #38762.
Fixes #40507.


git-svn-id: https://develop.svn.wordpress.org/trunk@40510 602fd350-edb4-49c9-b593-d223f7449a82
2017-04-21 05:15:29 +00:00
Andrea Fercia
428548f388 Accessibility: Remove inappropriate content from the Themes screen heading.
Props joedolson.

See #26601.


git-svn-id: https://develop.svn.wordpress.org/trunk@39528 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-06 23:11:08 +00:00
Helen Hou-Sandi
9385bda4ce Autoprefixer for [39249].
Fixes one errant value and re-aligns some existing prefixed property values so they don't get doubled when precommit/postcss is run again in the future.

props davidakennedy.
see #29158.


git-svn-id: https://develop.svn.wordpress.org/trunk@39301 602fd350-edb4-49c9-b593-d223f7449a82
2016-11-18 21:05:33 +00:00
Helen Hou-Sandi
d37312f3bf Customize: More visible focus and hover states for close and back buttons.
props celloexpressions, folletto.
fixes #29158.


git-svn-id: https://develop.svn.wordpress.org/trunk@39249 602fd350-edb4-49c9-b593-d223f7449a82
2016-11-15 18:10:16 +00:00
Weston Ruter
2158edc28f Customize: Prevent the "Hide Controls" button label from overrunning the device preview buttons.
Adds translation context for "Hide Controls" strings so translators can supply shorter strings where space is constrained. Adds styles to fade-out long the "Hide Controls" label where it would run into the device preview buttons.

Props westonruter, ocean90.
Fixes #38762.


git-svn-id: https://develop.svn.wordpress.org/trunk@39214 602fd350-edb4-49c9-b593-d223f7449a82
2016-11-13 18:59:21 +00:00
Helen Hou-Sandi
f7e5811287 Customize: Revert theme install feature.
This is a great goal for core, and is close, but it is not in shape to be shipped for 4.7 and there is not enough time left in the development cycle to alter and polish sufficiently. There are bugs, but more than that, there are more fundamental questions around the use of existing UI, general UX, and how findable themes are (not) on the .org side.

see #37661.


git-svn-id: https://develop.svn.wordpress.org/trunk@39140 602fd350-edb4-49c9-b593-d223f7449a82
2016-11-04 15:53:01 +00:00
Weston Ruter
16bfeb6608 Customize: Improve custom background properties UI.
Introduces new control for managing the background position. Adds control for setting the `background-size`.

Props cdog, celloexpressions, grapplerulrich, MikeHansenMe, FolioVision, afercia, helen, melchoyce, karmatosed, westonruter, Kelderic, sebastian.pisula.
Fixes #22058.


git-svn-id: https://develop.svn.wordpress.org/trunk@38948 602fd350-edb4-49c9-b593-d223f7449a82
2016-10-26 06:51:11 +00:00
Weston Ruter
8a79cdc107 Customize: Introduce a new experience for discovering, installing, and previewing themes within the customizer.
Unify the theme-browsing and theme-customization experiences by introducing a comprehensive theme browser and installer directly accessible in the customizer. Replaces the customizer theme switcher with a full-screen panel for discovering/browsing and installing themes available on WordPress.org. Themes can now be installed and previewed directly in the customizer without entering the wp-admin context.

For details, see https://make.wordpress.org/core/2016/10/03/feature-proposal-a-new-experience-for-discovering-installing-and-previewing-themes-in-the-customizer/

Fixes #37661, #34843.
Props celloexpressions, folletto, westonruter, karmatosed, afercia.


git-svn-id: https://develop.svn.wordpress.org/trunk@38813 602fd350-edb4-49c9-b593-d223f7449a82
2016-10-19 03:19:13 +00:00
Andrea Fercia
7ce67a141d Administration: Better consistency for the Media, Add Plugins, and Add Themes toolbars.
Fixes the Add Themes toolbar padding. Standardizes the placeholders to no title
case and three trailing dots. Expands the Media search placeholder in
"Search media items..." for consistency with the Plugins and Themes toolbars.

Props mikeviele, jamesacero, mattking5000, koenschipper, dungengronovius.

Fixes #38010.


git-svn-id: https://develop.svn.wordpress.org/trunk@38795 602fd350-edb4-49c9-b593-d223f7449a82
2016-10-14 21:32:08 +00:00
Andrea Fercia
ee7f970ffa Administration: Improve the usage of the button CSS classes.
Introduces some consistency in the usage of the button CSS classes, fixes the
focus style for accessibility and responsiveness of the buttons.

- Adds the `button` class to all primary buttons make them responsive
- Removes all `secondary-button` classes and replaces it with button when needed. `button-secondary` shouldn't be used and exists just for backward compatibility reasons
- Replaces classes inside `submit_button()` with a shorthand for some buttons, and use an empty string for the default `button` class. Passing `button` is unnecessary
- Adjusts `get_submit_button()` to remove empty items

Props iseulde, dimchik, chris_d2d, mhowell, afercia.
Fixes #27314, #37138, #37448.


git-svn-id: https://develop.svn.wordpress.org/trunk@38672 602fd350-edb4-49c9-b593-d223f7449a82
2016-09-28 19:53:07 +00:00
Helen Hou-Sandi
683f7bc4d3 Customizer: Better hover/focus state for section titles and available widgets.
The 4px border pattern is found in a number of places across the admin, including plugins, notices, and Press This.

props celloexpressions, folletto, hugobaeta.
see #29158.



git-svn-id: https://develop.svn.wordpress.org/trunk@38602 602fd350-edb4-49c9-b593-d223f7449a82
2016-09-14 16:14:20 +00:00
Andrea Fercia
02355cbdb5 Accessibility: Improve the Customizer and Theme Installer initial focus.
The Customizer and Theme Installer open in full overlays that need to receive 
focus. Also, keyboard navigation should be constrained within the overlays. Using
CSS `visibility` to hide all the content except the overlays, makes them the only
available and focusable content and allows browsers to handle focus natively.

See #29158.
Fixes #33228, #27705.


git-svn-id: https://develop.svn.wordpress.org/trunk@38520 602fd350-edb4-49c9-b593-d223f7449a82
2016-09-04 21:50:22 +00:00
Dominik Schilling
dbe140910b Plugins: Use install_plugins_upload action to print the upload form.
Since [37221] the upload form is added to every plugin install screen via `install_plugins_upload()`. Previously the form was added through the `install_plugins_upload` (alias of `install_plugins_$tab`) action which allowed plugin authors to replace the form. This restores the previous behaviour.

* Add the form only to non-upload plugin install screens.
* Replace `install_plugins_upload()` with the `install_plugins_upload` and `install_plugins_pre_upload` actions.
* Remove `$upload_tab_class` and add a CSS class for the current tab to `.wrap`
* Adjust CSS selectors and toggle the whole container to support upload without an `upload-plugin` class.

Props DavidAnderson, ocean90.
Fixes #37495.

git-svn-id: https://develop.svn.wordpress.org/trunk@38172 602fd350-edb4-49c9-b593-d223f7449a82
2016-07-31 18:10:45 +00:00
Konstantin Kovshenin
9b536c37d4 Themes: Wrap unusually long theme names on the Theme Details screen.
Props xavortm
Fixes #37033


git-svn-id: https://develop.svn.wordpress.org/trunk@37872 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-26 14:19:31 +00:00
Andrea Fercia
090ecc34f9 Accessibility: Theme Installer, make the "Upload Theme" button... a button.
UI controls that "do something" on a page shouldn't be links. This link behaves
like a toggle to expand the uploader panel and should be a `button` element with
an aria-expanded attribute. Also:

- improves consistency with the Plugin uploader
- keeps the themes list visible when the uploader is open
- displays a notice when JavaScript is off
- adds some `hide-if-no-js` CSS classes
- removes the `themes.router.navigate()` "upload" route: seems unnecessary and breaks history

Fixes #35457.

git-svn-id: https://develop.svn.wordpress.org/trunk@37742 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-17 20:46:08 +00:00
Helen Hou-Sandi
265fabc1c4 Use numeric font weights instead of keywords.
When Open Sans was in use, the `300`, `400`, and `600` weights were loaded. `400` is the equivalent of `normal`; however, `bold` is equivalent to `700`, not `600`. With the move to system fonts, we need to be specific rather than relying on the lack of a `700` weight. Not all system fonts include a `600` weight; in those instances, they will use the `bold`/`700` weight.

The WordPress CSS Coding Standards have been updated accordingly.

props coderste.
see #36753.


git-svn-id: https://develop.svn.wordpress.org/trunk@37740 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-17 18:36:03 +00:00
Konstantin Obenland
4dd1d9bef9 Update/Install: Shiny Updates v2.
Gone are the days of isolation and feelings of "meh", brought on by The Bleak Screen of Sadness. For a shiny knight has arrived to usher our plugins and themes along their arduous journey of installation, updates, and the inevitable fate of ultimate deletion.

Props swissspidy, adamsilverstein, mapk, afragen, ocean90, ryelle, j-falk, michael-arestad, melchoyce, DrewAPicture, AdamSoucie, ethitter, pento, dd32, kraftbj, Ipstenu, jorbin, afercia, stephdau, paulwilde, jipmoors, khag7, svovaf, jipmoors, obenland.
Fixes #22029, #25828, #31002, #31529, #31530, #31773, #33637, #35032.



git-svn-id: https://develop.svn.wordpress.org/trunk@37714 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-15 16:36:07 +00:00
Dominik Schilling (ocean90)
97dc4022c8 Customize: Increase the target size of the expand/collapse button in the customizer.
To improve accessibility on touch devices increase the size of the button in the collapsed view from 24×28 to 44×45 pixel.

Props celloexpressions.
Fixes #36093.

git-svn-id: https://develop.svn.wordpress.org/trunk@37341 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-01 20:28:22 +00:00
Aaron Jorbin
5ecf38977e Use px instead of in in device preview
Devices are not consistent in how they handle `in` units. `in` was an attempt to cleverly disguise the exact size of the 'tablet'. The PHP code standards mentions avoiding clever code ( https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#clever-code ) but we should extend that idea to the css code as well.

Props celloexpressions
Fixes #36457



git-svn-id: https://develop.svn.wordpress.org/trunk@37247 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-19 20:49:38 +00:00
Andrea Fercia
e4b26366e4 Plugin Install: show the upload form in place rather than sending users to the devoted upload plugin page.
Props Ipstenu, ericlewis, michaelarestad.

Fixes #35429.

git-svn-id: https://develop.svn.wordpress.org/trunk@37221 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-16 16:42:48 +00:00
Sergey Biryukov
021fd49054 Themes: Account for longer strings in Theme Details bar on Themes screen.
Fixes #27939.

git-svn-id: https://develop.svn.wordpress.org/trunk@37219 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-16 13:58:39 +00:00
Konstantin Obenland
6e15892673 Themes: Fix single theme modal on collapsed menu.
Prevents the modal from being displayed off screen, when there is only one
theme available and the menu is collapsed.

Props hardeepasrani for initial patch.
Fixes #36504.



git-svn-id: https://develop.svn.wordpress.org/trunk@37205 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-14 12:19:47 +00:00
Andrea Fercia
7e71bb398c Accessibility: Reduce the WordPress shades of grey, Episode 3.
Also, removes some no more used CSS.

See #35783.

git-svn-id: https://develop.svn.wordpress.org/trunk@36904 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-09 19:50:28 +00:00
Dominik Schilling (ocean90)
e5556666cc Themes: Bring the device preview from [31195] to the theme install previewer.
Props celloexpressions.
Fixes #36017.

git-svn-id: https://develop.svn.wordpress.org/trunk@36858 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-05 22:06:57 +00:00
Andrea Fercia
15a26902a6 Accessibility: Improve color contrast updating any #999 gray used for text or icons to a darker gray.
Fixes #35660.

git-svn-id: https://develop.svn.wordpress.org/trunk@36587 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-19 18:43:04 +00:00
Dominik Schilling (ocean90)
e636f79308 Themes: Fix flickering of the theme screenshot on hover in WebKit browsers.
Props JoeFusco.
Fixes #35787.

git-svn-id: https://develop.svn.wordpress.org/trunk@36579 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-18 21:10:17 +00:00
Andrea Fercia
3e7f4fba19 Accessibility: Reduce the WordPress shades of grey, first part.
See #35783.

git-svn-id: https://develop.svn.wordpress.org/trunk@36537 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-16 16:08:19 +00:00
Andrea Fercia
a64ab83564 Customizer: reduce the spinner re-painted area to the smallest possible one.
Also, changes the "customize container" and the theme installer preview
background from white to the default body `#f1f1f1` background.

Fixes #35649.

git-svn-id: https://develop.svn.wordpress.org/trunk@36518 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-12 18:34:46 +00:00
Andrea Fercia
cde933e306 After [36171] remove all the occurrences of the old CSS clearfix.
The old clearfix was applied to very specific items and defined multiple times
across CSS files. Uses the new generic `.wp-clearfix` utility class instead.

See #26396.

git-svn-id: https://develop.svn.wordpress.org/trunk@36422 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-30 13:45:37 +00:00
Andrea Fercia
d43a7a9f06 Accessibility: Improve the color contrast ratio replacing the residual occurrences of the #777 gray.
Uses the existing `#72777c` on white backgrounds and the new `#555d66` "dark medium gray" on darker backgrounds.

Fixes #35605.

git-svn-id: https://develop.svn.wordpress.org/trunk@36396 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-26 00:03:34 +00:00
Konstantin Obenland
12ac7b2998 Themes: Clear floated theme cards on Themes page.
Also maintains visual separation for Broken Themes table on searches that
return no results.

See [36171] for `.wp-clearfix`.

Props 5um17, obenland, valendesigns, afercia.
Fixes #26646.



git-svn-id: https://develop.svn.wordpress.org/trunk@36270 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-12 17:12:17 +00:00
Andrea Fercia
455ad2fd44 Notices: improve styling consistency of links within notices.
For accessibility, links inside lines or blocks of text should be always underlined.

Props walbo.
Fixes #34606.

git-svn-id: https://develop.svn.wordpress.org/trunk@35801 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 21:59:26 +00:00
Sergey Biryukov
5252cb7fe3 Autoprefixer for [35281].
See #33322.

git-svn-id: https://develop.svn.wordpress.org/trunk@35310 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 03:01:13 +00:00
Scott Taylor
f07367d34c Theme Installer: toggle iframe-ready on the overlay to control the spinner animated GIF and high CPU usage.
Props afercia, adamsilverstein.
Fixes #33322.


git-svn-id: https://develop.svn.wordpress.org/trunk@35281 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 05:35:07 +00:00
Andrea Fercia
cb2285f63e Accessibility: Improve headings hierarchy in the Theme browser modal dialog.
Fixes #34288.

git-svn-id: https://develop.svn.wordpress.org/trunk@35220 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 15:55:06 +00:00
Scott Taylor
b9e34ce4a2 Theme Installer: fix the theme "Install"/"Installed" button's vertical alignment for HiDPI displays.
Props paulwilde.
Fixes #34198.


git-svn-id: https://develop.svn.wordpress.org/trunk@35133 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 13:51:45 +00:00
Sergey Biryukov
975c16f4b2 Use wp_star_rating() on Add Themes screen:
* It works correctly for RTL
* Requires less CSS styling
* Is visually consistent with plugin ratings
* Is more accessible

Fixes #34080.

git-svn-id: https://develop.svn.wordpress.org/trunk@35006 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-10 06:50:35 +00:00
Helen Hou-Sandi
9aaa278e02 Notices: Add styles for use against white backgrounds.
These colored backgrounds can be accessed by adding the `.notice-alt` class to a notice.

There is also now a large version when using the `.notice-large` class, and a `.notice-title` class that is appropriate for headline text within a large notice.

props paulwilde, hugobaeta, melchoyce.
fixes #32244.


git-svn-id: https://develop.svn.wordpress.org/trunk@34365 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-21 15:25:37 +00:00
Scott Taylor
d937112e9f Grunt RTL CSS: swap-dashicons-left-right-arrows in rtlcss:properties expects double-quoted content strings in CSS. It doesn't swap single-quoted values.
Props Ankit K Gupta, yoavf, netweb.
Fixes #33786.


git-svn-id: https://develop.svn.wordpress.org/trunk@34011 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 20:21:57 +00:00
Scott Taylor
b8e30f3ec7 Dashicons CSS: one-word font families don't need quotes. Font families with a space in the name should use double-quotes (doesn't apply here).
Props afercia.
Fixes #32866.


git-svn-id: https://develop.svn.wordpress.org/trunk@33912 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 19:56:15 +00:00
Konstantin Obenland
96437b6d57 Themes: Prevent short descriptions from wrapping version info.
Props mehulkaklotar for initial patch.
Fixes #33248.



git-svn-id: https://develop.svn.wordpress.org/trunk@33651 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-19 19:09:20 +00:00
Mark Jaquith
70dd339fa3 Fix the padding for the feature filter box on the Add Themes screen.
fixes #33132
props SergeyBiryukov

git-svn-id: https://develop.svn.wordpress.org/trunk@33439 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-27 03:33:24 +00:00
Jeremy Felt
7a238fe2d6 Improve styling of .themes-php header on mobile devices.
The Themes page title does not need to be forced to 100% width on smaller devices. This fixes width issues for network admin, site admin, and single site admin theme pages.

See #32846.


git-svn-id: https://develop.svn.wordpress.org/trunk@33165 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-11 20:06:25 +00:00
Dominik Schilling (ocean90)
0730240b9a Customizer: Use a <button> for the collapse sidebar … button.
props afercia.
fixes #32819.

git-svn-id: https://develop.svn.wordpress.org/trunk@33153 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-10 21:21:07 +00:00
Konstantin Obenland
a399fb0b38 Respect the special case of having only one theme.
If there is only one theme, the Pointer won't show and the overlay is active by
default. In that case the overlay covered submenu flyouts, after [33068].
Without the Pointer active, there is no need to bump the `z-index`, so it can
remain at 10.

Fixes #31544.



git-svn-id: https://develop.svn.wordpress.org/trunk@33111 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 17:13:59 +00:00
Konstantin Obenland
e33229a237 Synchronize star ratings of themes and plugins.
Makes themes ratings look like plugins ratings already do.

Props helen.
Fixes #32782.
 


git-svn-id: https://develop.svn.wordpress.org/trunk@33073 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 20:53:18 +00:00
Konstantin Obenland
1757c3f4d4 Don't let wp-pointers cover the theme detail modal.
Fixes #31544.


git-svn-id: https://develop.svn.wordpress.org/trunk@33068 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 17:04:33 +00:00
Scott Taylor
e4aa6ae703 After [32974], tweak some CSS for focus, etc.
See #31650.


git-svn-id: https://develop.svn.wordpress.org/trunk@32977 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 23:12:23 +00:00
Konstantin Obenland
a4fd22608f Additional style changes to accomodate <h1> headings.
See [32974], #31650.



git-svn-id: https://develop.svn.wordpress.org/trunk@32975 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 15:50:59 +00:00