vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2025-10-16 12:05:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
27,443 Commits 1 Branch 0 Tags 243 MiB
7063377539
Commit Graph

45 Commits

Author SHA1 Message Date
Mark Jaquith
7063377539 Use HTTPS URLs for core.trac.wordpress.org 
see #27115

git-svn-id: https://develop.svn.wordpress.org/trunk@29788 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-29 13:27:55 +00:00
Drew Jaynes (DrewAPicture)
198db28c17 Improve and clarify inline commenting inside the check_comment() function. 
Adds logical explanations of what some of the various comment checks are checking for, as well as some general cleanup and syntax fixes.

Fixes #29734.


git-svn-id: https://develop.svn.wordpress.org/trunk@29763 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-23 18:48:31 +00:00
Drew Jaynes (DrewAPicture)
0adb5f14aa Improve documentation in the check_comments() docblock. 
* Removes two duplicate sentences from the long description
* Tightens up phrasing elsewhere in the long description for specific checks
* Clarifies the parameter and return descriptions, and adds periods

See #29734.


git-svn-id: https://develop.svn.wordpress.org/trunk@29762 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-23 18:46:52 +00:00
Sergey Biryukov
947ca94071 Correct references to post-template.php in the inline docs. 
props softmodeling.
fixes #29188.

git-svn-id: https://develop.svn.wordpress.org/trunk@29469 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-12 01:08:19 +00:00
Dominik Schilling (ocean90)
ea34a0bdf7 Replace is_https_url() with 'https' === parse_url( $url, PHP_URL_SCHEME ). 
see #28427, #28487.

git-svn-id: https://develop.svn.wordpress.org/trunk@29311 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-27 17:45:34 +00:00
Drew Jaynes (DrewAPicture)
7ad77d58ee Add periods to short descriptions for magic methods added in [28501], [28521], and [28524]. 
See #22234 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29165 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-14 01:11:55 +00:00
Drew Jaynes (DrewAPicture)
94d5e7b388 Fill out inline documentation for the __call() magic method added to the WP_Comment_Query class in [28519]. 
See #22234 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29162 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-14 00:47:36 +00:00
Andrew Nacin
adbe839132 WP_Comment_Query: Add fields => 'ids' query var. 
props mordauk.
fixes #28434.


git-svn-id: https://develop.svn.wordpress.org/trunk@29045 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-09 18:15:42 +00:00
Sergey Biryukov
0b9fb4f148 Avoid a PHP notice in wp_new_comment() if user ID is not passed. 
see #23231.

git-svn-id: https://develop.svn.wordpress.org/trunk@28922 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-30 11:02:10 +00:00
Sergey Biryukov
7584b25252 Normalize 'user_id' and 'user_ID' values in wp_new_comment() before passing the comment data to 'preprocess_comment' filter. 
props dkotter.
fixes #23231.

git-svn-id: https://develop.svn.wordpress.org/trunk@28915 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-30 00:40:51 +00:00
John Blackbourn
15e019d99e Conditionally set the the secure flag on the test cookie, post password cookie, settings cookies, and comment author cookies depending on whether the front end and/or admin area are served over https. Fixes #28427 
git-svn-id: https://develop.svn.wordpress.org/trunk@28895 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-29 13:24:55 +00:00
Scott Taylor
ce8cff84aa Don't use variable variables in WP_Comment_Query::query(). 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28738 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-11 17:57:39 +00:00
Scott Taylor
ce59109919 In WP_Comment_Query::get_search_sql(), don't double-like-escape. 
Props miqrogroove.
See #10041.


git-svn-id: https://develop.svn.wordpress.org/trunk@28720 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-10 02:19:30 +00:00
Scott Taylor
84ad12b439 Replace all uses of like_escape() with $wpdb->esc_like(). 
Props miqrogroove.
See #10041.


git-svn-id: https://develop.svn.wordpress.org/trunk@28712 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-10 00:43:32 +00:00
Sergey Biryukov
c556e74943 wp_insert_comment() and wp_new_comment() should check if the comment was successfully inserted into the database. 
props pento.
fixes #28254.

git-svn-id: https://develop.svn.wordpress.org/trunk@28672 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-05 04:37:02 +00:00
Drew Jaynes (DrewAPicture)
d068c888f3 Ensure $post_id is documented as optional where applicable. 
See #28388.


git-svn-id: https://develop.svn.wordpress.org/trunk@28654 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-03 04:43:47 +00:00
Scott Taylor
d398ea806c Add missing access modifiers to methods in WP_Comment_Query. Add a magic __call() method for BC. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28519 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 06:18:51 +00:00
Scott Taylor
54bc77cb93 The cache key for comments in WP_Comment_Query::query() needs to do wp_array_slice_assoc( $this->query_vars, array_keys( $defaults ) ) instead of compact( array_keys( $defaults ) ). The latter assumes all of those variables are still floating around. 
See #22400.



git-svn-id: https://develop.svn.wordpress.org/trunk@28460 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 21:08:15 +00:00
Scott Taylor
cb3341c03d (ACTUALLY) Eliminate use of extract() in WP_Comment_Query::query(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28459 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 20:51:23 +00:00
Scott Taylor
8d22270bc1 Eliminate use of extract() in WP_Comment_Query::query(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28458 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 19:32:05 +00:00
Scott Taylor
59f8ba6c9e Eliminate use of extract() in wp_insert_comment(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28457 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 18:51:41 +00:00
Scott Taylor
ce5a31cd62 Eliminate use of extract() in wp_allow_comment(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28437 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 18:09:09 +00:00
Scott Taylor
95394c6e7e Eliminate the use of extract() in wp_update_comment(). All unit tests pass. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28427 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 06:36:17 +00:00
Scott Taylor
5e90fb1b3e In wp_set_comment_status(), the default case returns, so no default value for $status is needed. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28324 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 21:16:42 +00:00
Drew Jaynes (DrewAPicture)
9c66e66ac5 Ensure the wp_set_comment_status action hook is only documented once. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28214 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 06:54:33 +00:00
Andrew Nacin
6a35efe1e5 Revert [27115] and let cache backends handle the stripping of spaces in cache keys as necessary. 
microtime() returns greater precision than microtime(true).

see #27000, #23448, #26903, #14485.


git-svn-id: https://develop.svn.wordpress.org/trunk@27300 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-26 22:04:52 +00:00
Drew Jaynes
647f80595d Remove all @package and @subpackage PHPDoc tags not at the file- or class-levels in core. 
See #27200.


git-svn-id: https://develop.svn.wordpress.org/trunk@27262 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-25 17:13:08 +00:00
Andrew Nacin
a407ae2363 Allow user_id to be an array of IDs in WP_Comment_Query. 
props mordauk.
fixes #27064.


git-svn-id: https://develop.svn.wordpress.org/trunk@27258 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-25 16:34:25 +00:00
Sergey Biryukov
013a4e3381 Correct return values for update_metadata() and related functions. 
fixes #21864.

git-svn-id: https://develop.svn.wordpress.org/trunk@27191 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-18 21:35:07 +00:00
Andrew Nacin
4f5608f653 Use a float for last_changed microtime cache values. 
microtime() by default returns a string with a space, which isn't allowed for keys in some cache backends.

props _jameslee, drozdz.
fixes #27000. see #23448.


git-svn-id: https://develop.svn.wordpress.org/trunk@27115 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-07 08:13:37 +00:00
Scott Taylor
13c1dd0004 get_comment(), wp_get_post_revision(), and get_term() all used to return by reference. Because of this, $null was set to null so the return value would be a variable where applicable. This has not been necessary since [21792], so the $nulls have been removed. 
Props toszcze.
Fixes #24768.



git-svn-id: https://develop.svn.wordpress.org/trunk@27057 602fd350-edb4-49c9-b593-d223f7449a82
 2014-01-29 06:45:54 +00:00
Scott Taylor
99ef83d7aa Add Unit Tests for get_comment_pages_count(). Fix a notice caused when $wp_query->comments is not set in that function. 
Props mdbitz, markjaquith.
Fixes #20633.



git-svn-id: https://develop.svn.wordpress.org/trunk@27055 602fd350-edb4-49c9-b593-d223f7449a82
 2014-01-29 05:16:58 +00:00
Drew Jaynes
e119b7e3df Remove some @uses references to apply_filters and do_action rendered redundant by hook documentation. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26867 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-24 16:42:54 +00:00
Sergey Biryukov
a129345361 Correct @since values. see #25522. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26492 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-01 01:24:41 +00:00
Drew Jaynes
91e00c8ce5 Inline documentation for hooks in wp-includes/comment.php. 
comment.php, a.k.a. "lots 'o hooks".

Props swissspidy for the initial patch. Props danieldudzic, kpdesign, and DrewAPicture.
Fixes #25522.


git-svn-id: https://develop.svn.wordpress.org/trunk@26491 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-01 01:11:26 +00:00
Drew Jaynes
a736126e83 Inline documentation for the following filter hooks in wp-includes/pluggable.php: 
* `comment_notification_recipients`
* `comment_notification_notify_author`

Also removes some generic `@uses` tags from various related doc blocks.

Props markjaquith.
Fixes #25699.


git-svn-id: https://develop.svn.wordpress.org/trunk@26388 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-26 04:09:30 +00:00
Mark Jaquith
9cbffc9222 Fix comment_notification_recipients filter behavior so that it is still respected even on comments left by the post author 
The code was bailing on this-is-a-comment-on-your-own-post detection, ignoring additional recipients. Now:

* Logic check is done within `wp_notify_postauthor()`
* Logic check is overridable via `comment_notification_notify_author` filter (default still false)
* The code doesn't bail on comment-on-own-post detection, but just removes the author from the array
* The code instead now bails if the recipients list is empty, so `comment_notification_recipients` works properly

props ethitter.
fixes #25699


git-svn-id: https://develop.svn.wordpress.org/trunk@26367 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-25 01:46:49 +00:00
Peter Westwood
92ee005ea0 Deprecate the second argument for wp_notify_postauthor because it is unecessary. Fixes #17862 props scribu and wonderboymusic. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26358 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-24 16:25:44 +00:00
Sergey Biryukov
a2aed7b119 Fix docblock formatting. fixes #25893. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26081 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-11 13:31:19 +00:00
Andrew Nacin
c87ad6023d Spell out duplicate hook locations. 
props DrewAPicture.
fixes #25658.


git-svn-id: https://develop.svn.wordpress.org/trunk@25868 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-22 17:21:32 +00:00
Scott Taylor
535ae26afd Fix several esoteric errors related to AJAX unit tests for comments: 
* `wp_ajax_get_comments()` relies on the `$post_id` global - even though `$_POST['p']` is passed to every action in the test methods. If `$post_id` is still lingering in between tests and doesn't match `p` in the request, the cap check might pass while the queries for comments will blow up. I added `unset( $GLOBALS['post_id'] )` to `Tests_Ajax_GetComments::setUp()`.
* If the global `$post_id` is empty, but `$_REQUEST['p']` is not, `$post_id` is now set to `absint( $_REQUEST['p'] )` and sanity-checked in `wp_ajax_get_comments()`.
* `map_meta_cap()` always assumes that `get_comment()` succeeds when checking for the `edit_comment` cap. It doesn't. I added sanity checks in a few places where it will break early if `get_post()` or `get_comment()` are empty.
* `wp_update_comment()` always assumes `get_comment()` succeeds. It doesn't. I added a check for empty.

All AJAX unit tests run and pass in debug mode. All general unit tests pass against these changes.

Fixes #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25438 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-14 18:35:43 +00:00
Scott Taylor
5a75531f19 Replace the ancient phpfreaks.com RegEx to extract urls to ping with a more robust matcher. URLs with commas and things like & were not being pinged. The new matcher even works for most IDN URLs. Adds unit tests. 
Fixes #9064.



git-svn-id: https://develop.svn.wordpress.org/trunk@25313 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-10 03:17:51 +00:00
Andrew Nacin
c637de7316 WP_Date_Query. 
props Viper007Bond.
see #18694.


git-svn-id: https://develop.svn.wordpress.org/trunk@25139 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-27 16:38:32 +00:00
Andrew Nacin
7bc3ebf033 Return 1 from get_comment_pages_count() when pagination is disabled. 
props obenland.
fixes #17778.


git-svn-id: https://develop.svn.wordpress.org/trunk@25126 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-26 18:51:53 +00:00
Andrew Nacin
b43712e0f7 New develop.svn.wordpress.org repository based on the old core.svn repository. 
* All WordPress files move to a src/ directory.
 * New task runner (Grunt), configured to copy a built WordPress to build/.
 * svn:ignore and .gitignore for Gruntfile.js, wp-config.php, and node.js.
 * Remove Akismet external from develop.svn. Still exists in core.svn.
 * Drop minified files from src/. The build process will now generate these.

props koop.
see #24976.

and see http://wp.me/p2AvED-1AI.



git-svn-id: https://develop.svn.wordpress.org/trunk@25001 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-07 05:25:25 +00:00