Commit Graph

35 Commits

Author SHA1 Message Date
Sergey Biryukov
0521e61398 Code Modernisation: Remove redundant calls to func_get_arg() in wp-includes/class-wp-admin-bar.php.
Props jrf.
See #47678.

git-svn-id: https://develop.svn.wordpress.org/trunk@46140 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-15 11:45:45 +00:00
John Blackbourn
b675f56c4f Docs: Add a missing return type.
See #47110


git-svn-id: https://develop.svn.wordpress.org/trunk@45821 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-16 19:34:31 +00:00
Gary Pendergast
4503f93961 Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments violations in wp-includes.
See #47632.



git-svn-id: https://develop.svn.wordpress.org/trunk@45590 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-02 23:41:16 +00:00
Felix Arntz
1f3912e9bf Bootstrap/Load: Introduce a recovery mode for fixing fatal errors.
Using the new fatal handler introduced in [44962], an email is sent to the admin when a fatal error occurs. This email includes a secret link to enter recovery mode. When clicked, the link will be validated and on success a cookie will be placed on the client, enabling recovery mode for that user. This functionality is executed early before plugins and themes are loaded, in order to be unaffected by potential fatal errors these might be causing.

When in recovery mode, broken plugins and themes will be paused for that client, so that they are able to access the admin backend despite of these errors. They are notified about the broken extensions and the errors caused, and can then decide whether they would like to temporarily deactivate the extension or fix the problem and resume the extension.

A link in the admin bar allows the client to exit recovery mode.

Props timothyblynjacobs, afragen, flixos90, nerrad, miss_jwo, schlessera, spacedmonkey, swissspidy.
Fixes #46130, #44458.


git-svn-id: https://develop.svn.wordpress.org/trunk@44973 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-21 21:52:07 +00:00
Andrea Fercia
e8fa2d66d0 Accessibility: Hide the Toolbar sub-menu CSS generated icons from assistive technologies.
CSS generated content is rendered for speech output. When it's not meant to be announced by assistive technologies, for example with font icons, special care should be used to hide it. At the moment, the only reliable way to do this is making use of a wrapper element and set `aria-hidden="true"` on it.

Fixes #37513.


git-svn-id: https://develop.svn.wordpress.org/trunk@44793 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-04 22:45:24 +00:00
Andrea Fercia
6b489bb125 Accessibility: Improve the way Internet Explorer 11 and JAWS announce fieldset legends.
When Internet Explorer encounters a non interactive element with a `tabindex`
attribute, it adds the element to the accessibility tree with a `role=group` and
an accessible name computed from the element. This prevents JAWS from announcing
any fieldset legend within the element.

- removes `tabindex="0"` from the content and the toolbar containers: these tabindex attributes are no longer needed
- removes `aria-label="Main content"` from the content container: not needed
- keeps the media modal focus fallback introduced in [38142] by making the `#wpbody-content` element focusable only when needed

Props stevefaulkner, aardrian.
Fixes #43154.


git-svn-id: https://develop.svn.wordpress.org/trunk@44639 602fd350-edb4-49c9-b593-d223f7449a82
2019-01-17 11:54:23 +00:00
Gary Pendergast
8f95800d52 Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.



git-svn-id: https://develop.svn.wordpress.org/trunk@42343 602fd350-edb4-49c9-b593-d223f7449a82
2017-11-30 23:09:33 +00:00
Gary Pendergast
1c64182c6b Admin Bar: Fix another HTML error introduced in [42128].
Props Otto42.
See #41057.



git-svn-id: https://develop.svn.wordpress.org/trunk@42131 602fd350-edb4-49c9-b593-d223f7449a82
2017-11-08 23:12:37 +00:00
Gary Pendergast
e7d649e621 Admin Bar: Fix a HTML error introduced in [42128].
Props swissspidy.
See #41057.



git-svn-id: https://develop.svn.wordpress.org/trunk@42129 602fd350-edb4-49c9-b593-d223f7449a82
2017-11-08 08:51:03 +00:00
Gary Pendergast
e9282049e8 Admin Bar: Reformat the render methods.
The admin bar render methods use some cute tricks which don't come close to the WordPress coding standards. So that we can more easily apply automated code fixing to the codebase, these tricks need to be removed.

See #41057.



git-svn-id: https://develop.svn.wordpress.org/trunk@42128 602fd350-edb4-49c9-b593-d223f7449a82
2017-11-08 08:34:41 +00:00
Drew Jaynes
b4d81bd654 Docs: Remove @access notations from method DocBlocks in wp-includes/* classes.
Prior to about 2013, many class methods lacked even access modifiers which made the `@access` notations that much more useful. Now that we've gotten to a point where the codebase is more mature from a maintenance perspective and we can finally remove these notations. Notable exceptions to this change include standalone functions notated as private as well as some classes still considered to represent "private" APIs.

See #41452.


git-svn-id: https://develop.svn.wordpress.org/trunk@41162 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-27 00:40:27 +00:00
Drew Jaynes
e995c16086 Docs: Add missing deprecation, introduction, and summary information to the DocBlock for WP_Admin_Bar::recursive_render().
Props coffee2code.
Fixes #40840.


git-svn-id: https://develop.svn.wordpress.org/trunk@40947 602fd350-edb4-49c9-b593-d223f7449a82
2017-06-25 21:57:32 +00:00
Andrea Fercia
8a6fa93b84 Accessibility: Revert [38984] as it needs to be better communicated to plugin authors.
See #37513.


git-svn-id: https://develop.svn.wordpress.org/trunk@39147 602fd350-edb4-49c9-b593-d223f7449a82
2016-11-05 16:27:13 +00:00
Andrea Fercia
6cc9480fd8 Accessibility: Hide the Toolbar sub-menu icons from assistive technologies.
CSS generated content is going to be rendered for speech output more and more in
the next future. When it's not intended to be available for speech output, for
example with font icons, then special care should be used to hide it from
assistive technologies. At the moment, the only reliable way to do this is making 
use of a wrapper element and set `aria-hidden="true"` on it.

Fixes #37513.


git-svn-id: https://develop.svn.wordpress.org/trunk@38984 602fd350-edb4-49c9-b593-d223f7449a82
2016-10-27 20:52:20 +00:00
Scott Taylor
683d828d42 General: revert [38467], wp_is_IE() should not exist.
See #37699.


git-svn-id: https://develop.svn.wordpress.org/trunk@38468 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-31 15:21:04 +00:00
Scott Taylor
f9278a9364 General: use a new function, wp_is_IE(), instead of the $is_IE global in a number of places.
See #37699.


git-svn-id: https://develop.svn.wordpress.org/trunk@38467 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-31 06:41:07 +00:00
Dominik Schilling
e556fec595 Toolbar: Allow 0 as a value for the tabindex property of a menu item.
To enhance accessibility for items without a link you can now define `tabindex="0"`, which makes descendant dropdowns accessible.

Props joedolson, afercia, ocean90.
Fixes #32495.

git-svn-id: https://develop.svn.wordpress.org/trunk@38035 602fd350-edb4-49c9-b593-d223f7449a82
2016-07-12 11:18:00 +00:00
Sergey Biryukov
920f29616a Docs: Use 3-digit, x.x.x-style semantic versioning for _doing_it_wrong(), _deprecated_function(), _deprecated_argument(), and _deprecated_file() throughout core.
Props metodiew.
Fixes #36495.

git-svn-id: https://develop.svn.wordpress.org/trunk@37985 602fd350-edb4-49c9-b593-d223f7449a82
2016-07-06 12:39:01 +00:00
Drew Jaynes
8424db5879 Docs: Improve the DocBlock summary and add a missing initial @since version for WP_Admin_Bar::add_node().
See #32246. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36833 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 15:57:46 +00:00
Pascal Birchler
b09fd386fd Toolbar: Allow adding lang and dir attributes to toolbar items.
This is useful from a multilingual and accessibility perspective.

Props Chouby, leemon.
Fixes #33513.

git-svn-id: https://develop.svn.wordpress.org/trunk@35795 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 21:36:49 +00:00
Drew Jaynes
5ffe8f5aef Docs: Add missing file headers to two Toolbar API files: wp-includes/admin-bar.php and wp-includes/class-wp-admin-bar.php.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35157 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 17:26:28 +00:00
Helen Hou-Sandi
f5043ab022 Toolbar: Disambiguate links to the dashboard vs. to the customizer.
All links in the site name menu now point to admin screens, and Customize is its own top-level link. This makes it clear which context you are about to enter.

fixes #32924. see #32678.


git-svn-id: https://develop.svn.wordpress.org/trunk@33130 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-08 20:02:44 +00:00
Scott Taylor
ef6315a7a2 After [32656], add @access annotations to methods that have no doc block in wp-includes/*.
Makes it easier to search for no doc blocks via `}[\n\t\r ]+(protected|private|public)`.

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32657 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 21:36:38 +00:00
Scott Taylor
39ef6a72c5 Use void instead of null where appropriate when pipe-delimiting @return types. If a @return only contains void, remove it.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32568 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-24 05:39:47 +00:00
Scott Taylor
369903cd85 In class-wp-admin-bar.php, clarify/add some doc blocks.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32534 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-21 21:38:41 +00:00
Dominik Schilling (ocean90)
14dc44fb83 Accessibility: Add landmark roles to WordPress admin areas.
props afercia, joedolson.
fixes #31450.

git-svn-id: https://develop.svn.wordpress.org/trunk@31955 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 13:16:47 +00:00
Scott Taylor
376125e0b7 In wp-includes/class-wp-admin-bar.php, break is unreachabled after return.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28318 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:28:46 +00:00
Drew Jaynes
cc6836dc55 Convert argument array documentation to the hash-notation style for WP_Admin_Bar::add_node() and WP_Admin_Bar::add_group().
Fixes #27258.


git-svn-id: https://develop.svn.wordpress.org/trunk@27370 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-03 06:10:22 +00:00
Andrew Nacin
1a91bee772 Accept rel attributes in the toolbar's add_node() method.
props stephcook22.
fixes #27234.


git-svn-id: https://develop.svn.wordpress.org/trunk@27367 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-03 02:13:07 +00:00
Matt Thomas
58f312f95e Bring in the responsive component of MP6. See #25858.
* Makes the admin fully responsive down to 320px wide.
* Adds a touch-optimized main menu that can be opened and closed from the toolbar.
* Size and positioning adjustments to icons, buttons, and text elements for better touch usability.

A few changes since MP6:

* Removed jQuery mobile. This script was used to add swipe controls to open/close the sidebar menu. This feature was apparently buggy and due to the pending demise of jQuery mobile, it was removed.
* Removed use of Backbone.js. Adding Backbone.js to this script would add a dependency of Backbone.js for all of the admin. Additionally, it was used to add a menu item. Instead of doing that, it was added via the admin menu API. This also fixes a bad delay in the item showing in the menu.
* CSS layout is standardized. Comments have also been cleaned up.
* Jetpack and Akismet code is removed.
* RTL CSS is removed.
* JS passes hinting other than one small issue that will likely be removed when parts of the code are reviewed.

A number of areas for improvement remain; we're tracking these issues in the comments of #25858.

Props to tollmanz, tillkruess, helen, dd32, and apeatling.



git-svn-id: https://develop.svn.wordpress.org/trunk@26134 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-13 17:59:32 +00:00
Ryan Boren
30f822b8ee Pinking shears
git-svn-id: https://develop.svn.wordpress.org/trunk@25880 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-23 14:37:54 +00:00
Drew Jaynes
24d1818527 Improve inline comment for removing default padding styles for the Toolbar.
Props nofearinc.
Fixes #25373.


git-svn-id: https://develop.svn.wordpress.org/trunk@25563 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-22 14:33:11 +00:00
Sergey Biryukov
959be34093 Correct @since for hooks in wp-includes/class-wp-admin-bar.php. see #25229.
git-svn-id: https://develop.svn.wordpress.org/trunk@25478 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-18 11:57:59 +00:00
Peter Westwood
5331611baa Inline documentation for hooks in wp-includes/class-wp-admin-bar.php
See #25229 props betzster


git-svn-id: https://develop.svn.wordpress.org/trunk@25475 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-18 07:41:54 +00:00
Andrew Nacin
b43712e0f7 New develop.svn.wordpress.org repository based on the old core.svn repository.
* All WordPress files move to a src/ directory.
 * New task runner (Grunt), configured to copy a built WordPress to build/.
 * svn:ignore and .gitignore for Gruntfile.js, wp-config.php, and node.js.
 * Remove Akismet external from develop.svn. Still exists in core.svn.
 * Drop minified files from src/. The build process will now generate these.

props koop.
see #24976.

and see http://wp.me/p2AvED-1AI.



git-svn-id: https://develop.svn.wordpress.org/trunk@25001 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-07 05:25:25 +00:00