Scott Taylor
5beca90d40
The query-attachments AJAX action immediately errors out if the user doesn't have the upload_files cap. As such, the Customizer shouldn't show buttons that launch the media modal when the user doesn't have the proper permissions to query attachments.
...
See #32654 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32913 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-23 18:19:43 +00:00
Scott Taylor
7af8195803
In unregister_setting(), search for $option_name in a segment of $new_whitelist_options keyed by $option_group.
...
Props nofearinc.
Fixes #26479 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32905 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-22 20:50:30 +00:00
Scott Taylor
a147a92046
List table views: fix missing current class for "All" when logged in as an author.
...
Props afercia.
Fixes #32015 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32903 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-22 20:38:32 +00:00
Helen Hou-Sandi
3f4a902051
Add "Scheduled" to post states.
...
props rclations.
fixes #32131 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32902 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-22 16:06:45 +00:00
Sergey Biryukov
ef8ed3e279
Avoid a PHP notice in WP_Press_This::get_suggested_content() after [32828].
...
props kraftbj.
fixes #32751 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32901 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-22 15:19:53 +00:00
Andrew Ozz
e366658072
Update the TinyMCE initialization:
...
- Replace `wp_htmledit_pre()` and `wp_richedit_pre()` with `format_for_editor()`.
- Replace the `'htmledit_pre'` and `'richedit_pre'` filters with `'format_for_editor'`.
- Do not run the post content through `wpautop()` in PHP when the visual editor is default. Run the textarea content through the JS wpautop on initializing TinyMCE.
- Simplify both editors initialization.
- Improve setting of `wpActiveEditor` in Quicktags.
- Improve editor.js, use `tinymce.$` when possible.
See #32425 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32899 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-21 22:00:42 +00:00
Dominik Schilling (ocean90)
724b22938e
Customizer: Accessibility improvements for menu item searches.
...
* Add a description and an `aria-describedby` attribute to inform users this is a "live" search.
* Announce the number of search results via `wp.a11y.speak`.
* Use `aria-busy` attribute to stop screen readers announcing content while the "loading more results" is running.
* Increase the search debounce wait interval to 500ms to be consistent with other live searches.
* If a search fails don't call `wp.a11y.speak` with an undefined variable.
props afercia.
see #32720 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32891 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-20 19:21:38 +00:00
Dominik Schilling (ocean90)
842347841e
Customizer: Don't add a menu item twice when using the keyboard.
...
Buttons don't need keyboard events, they natively support keyboard interaction and they just need a click event.
fixes #32665 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32890 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-20 19:00:05 +00:00
Scott Taylor
a968694338
Use valid markup in Walker_Nav_Menu_Edit::start_el() - replace <d(l|t)> with <div> for .menu-item-bar and .menu-item-handle.
...
Props sagarjadhav.
Fixes #31817 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32879 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 22:22:00 +00:00
Scott Taylor
6ffc540366
Add access modifier to WP_Upgrader::clear_destination()
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32871 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 21:52:44 +00:00
Scott Taylor
53a3137e1a
Edit Post screen messages need to run preview URLs through the preview_post_link filter.
...
Props pareshradadiya.
Fixes #32191 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32870 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 21:48:11 +00:00
Scott Taylor
c5f72c4ab7
Use <button> instead of <a> for non-link links in Quick Edit.
...
Props afercia.
Fixes #32213 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32869 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 21:41:07 +00:00
Scott Taylor
bb292c74c1
Cleanup (ms-)?admin-filters.php
...
Props johnjamesjacoby.
Fixes #32529 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32865 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 21:17:20 +00:00
Scott Taylor
da826f59a5
Media Library Bulk Select button size should be smaller.
...
Props afercia.
Fixes #32325 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32862 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 18:55:52 +00:00
Dominik Schilling (ocean90)
bd272f3188
Customizer: Improve accessibility of the toggle button in the available menu items panel.
...
Prevents focus lost in Safari because the button was "invisible" until it got focused.
fixes #32709 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32859 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 17:23:46 +00:00
Konstantin Obenland
82a26045e5
Check that current changes can be lost before editing another comment.
...
When replying to or editing a comment, double-clicking another comment will
open it in quick edit and changes to the current comment are lost.
Props pareshradadiya, chriscct7.
Fixes #21845 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32857 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 13:47:35 +00:00
Ella Iseulde Van Dorpe
fa5ec5077b
Editor: restructure word count
...
* The WordCounter should only do one thing: count words. This makes it also easier to test.
* Add some really basic unit tests.
* Instead of only refreshing the count on enter and delete, refresh the count when the user stops typing. Also look at paste and content changes in TinyMCE.
* Use `match` instead of `replace` when it is appropriate.
* More readable code.
See #30966 . Fixes #26620 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32856 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 10:34:59 +00:00
Dion Hulse
9c0750ac52
When updating plugins/themes verify that the files to be deleted can be modified before starting the deletion process.
...
This will avoid partially deleting an item during update which has inconsistent permissions.
This change only affects those using the direct & ssh transports as FTP's is_writable() currently always returns `true`.
Fixes #30921
git-svn-id: https://develop.svn.wordpress.org/trunk@32854 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 03:48:55 +00:00
Dion Hulse
4ff7f27c83
Remove a redundant index drop, it'll be dropped and re-created a few lines further down.
...
Fixes a warning during updating from 4.0 or earlier.
Fixes #31388 for trunk
git-svn-id: https://develop.svn.wordpress.org/trunk@32852 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 03:17:12 +00:00
Dominik Schilling (ocean90)
413d24c47f
Customizer: Improve accessibility of Add Menu Items button and its panel.
...
props afercia, ocean90.
fixes #32682 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32848 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 20:51:48 +00:00
Dominik Schilling (ocean90)
ee24335ba5
Autoprefixer for [32844].
...
git-svn-id: https://develop.svn.wordpress.org/trunk@32847 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 20:48:52 +00:00
Scott Taylor
646c19accf
Make sure that all Gravatars are generated by get_avatar() or at least run through apply_filters( 'get_avatar', $avatar ) for the sake of extensibility.
...
Props miqrogroove, GlennM, SergeyBiryukov.
Fixes #22650 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32845 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 18:35:04 +00:00
Konstantin Obenland
9bf79ed862
Semanticize Help and Screen Options toggle.
...
Links used as UI controls that are not real links but act as buttons, should be buttons.
Props afercia.
Fixes #32494 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32844 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 16:35:12 +00:00
Konstantin Obenland
2ae17175b2
Use https for Google API external libraries.
...
Google recommends it and users are more likely to have the https version cached in their browser already.
Props rommelxcastro.
Fixes #32552 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32843 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 15:50:42 +00:00
Konstantin Obenland
771509a452
Show the posts meta box by default in Appearance > Menus.
...
Lessens user confusion and the likelyhood of misusing custom links
to add menu items for posts.
Props bcole808.
Fixes #32440 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32842 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 15:03:29 +00:00
Konstantin Obenland
b758c6cec4
More consistent spacing around the excerpt textarea.
...
Props paulwilde.
Fixes #32242 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32841 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 14:18:53 +00:00
Konstantin Obenland
f88225549e
Revert [32834].
...
It's not ready yet and was a product of misusing vim.
See #30729 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32835 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 12:26:40 +00:00
Konstantin Obenland
1fc76c997f
Emphasise previewing new themes
...
git-svn-id: https://develop.svn.wordpress.org/trunk@32834 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 12:23:30 +00:00
Konstantin Obenland
77d2e23a69
Make posts in the 'Most recent' tab of post type meta boxes filterable.
...
Provides parity with the 'View All' tab of post type meta boxes in Appearance > Menus.
Props jpyper, chriscct7.
Fixes #19365 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32833 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 11:34:33 +00:00
Konstantin Obenland
cfbff5b495
Recommend a user updates keys/salts in maint/repair.php.
...
Since they are already going into `wp-config.php`, we should also encourage
them to update their unique phrases for keys and salts, assuming they do not
have a complete set of 8 unique ones already.
Props nacin, chriscct7.
Fixes #20779 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32830 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 11:06:09 +00:00
Andrew Ozz
80a511015b
Press This: Check the embeds list against all of the oembed providers.
...
Props stephdau. Fixes #32069 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32828 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 00:11:30 +00:00
Andrew Ozz
675de40f11
Press This: show error message when the user is attempting to add a category that already exists.
...
Fixes #32339 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32827 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-17 23:12:08 +00:00
Dominik Schilling (ocean90)
9031531071
Customizer: Remove an overflow: hidden declaration to prevent cutting off the left and right edge focus style of the "Add a Menu" input field.
...
props paulwilde.
fixes #32680 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32825 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-17 21:42:45 +00:00
Dominik Schilling (ocean90)
59230dd5ab
Customizer: Fix keyboard events for the menu items search field.
...
Replace the `change` event with `keyup`, see https://core.trac.wordpress.org/ticket/26600#comment:59 for background.
props tywayne.
fixes #32677 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32824 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-17 21:36:11 +00:00
Dominik Schilling (ocean90)
71cdd9a3e1
Customizer: Revert the blue on hover color which was introduced in [32649].
...
Blue is meant to be the primary action which isn't the case in this context. Colors need to be revised in #29158 .
see #31336 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32823 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-17 21:07:01 +00:00
Dominik Schilling (ocean90)
2481eec41d
Customizer: Replace usage of calc() with box-sizing: border-box.
...
IE8 doesn't support `calc()`.
props afercia.
see #31336 .
fixes #32664 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32821 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-17 19:34:44 +00:00
Boone Gorges
322b6cc54f
Bail out of 4.3 term splitting routine when no shared terms are found.
...
Props dd32.
See #30261 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32819 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-17 11:39:19 +00:00
Ella Iseulde Van Dorpe
2b857dfdc3
JSHint after [32806]
...
See #32576 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32815 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-17 04:14:06 +00:00
Boone Gorges
f9ae6b826a
Split all shared taxonomy terms on upgrade to 4.3.
...
Dear Shared Terms, Welcome to Splitsville. Population: You.
See #30261 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32814 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-17 01:52:46 +00:00
Dominik Schilling (ocean90)
b31928788d
Fix a typo in [32806].
...
see #32576 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32808 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 23:08:09 +00:00
Dominik Schilling (ocean90)
c0a66eba79
Add menu management to the Customizer.
...
This brings in the Menu Customizer plugin: https://wordpress.org/plugins/menu-customizer/ .
props celloexpressions, westonruter, valendesigns, voldemortensen, ocean90, adamsilverstein, kucrut, jorbin, designsimply, afercia, davidakennedy, obenland.
see #32576 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32806 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 22:07:08 +00:00
Helen Hou-Sandi
0433b87fdf
Media list table: Avoid PHP notices by using the proper variables.
...
Also visually tightens up the row actions.
props tyxla.
fixes #32657 . see #29881 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32805 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 21:32:53 +00:00
Scott Taylor
862c761c08
Avoid using HTML in translation strings in edit-form-comment.php.
...
Fixes #31847 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32801 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 20:07:14 +00:00
Scott Taylor
296c559baf
if is a statment, not a function.
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32800 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 20:00:15 +00:00
Scott Taylor
9cf3adb204
Avoid using <code> in a translation string.
...
Props ramiy.
Fixes #31848 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32799 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 19:52:39 +00:00
Helen Hou-Sandi
d878ce73f5
Media list table: Restore row actions.
...
see #29881 , #32657 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32798 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 19:46:27 +00:00
Helen Hou-Sandi
b9b36d1c57
Comments: Better markup for the edit screen.
...
Previously there were no labels, and since labels can't contain links and the links were of dubious value, we've removed those.
props afercia, DrewAPicture.
fixes #31326 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32796 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 18:53:16 +00:00
Boone Gorges
91512a9161
Tag/category conversion link on edit-tags.php should point to specific importer page when cat2tag plugin is active.
...
Props solarissmoke, c3mdigital.
Fixes #16369 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32792 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 04:29:04 +00:00
Dion Hulse
9f2ad2538e
Updates: Consistently use the same variable to refer to the plugin, avoids a potential PHP Notice when an external update script adds data without that key.
...
Props mordauk. Fixes #31784
git-svn-id: https://develop.svn.wordpress.org/trunk@32784 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-15 06:25:58 +00:00
Dion Hulse
8455dd10da
Updats: Add a filter for the options params for the update being performed.
...
Props nofearinc. Fixes #27754
git-svn-id: https://develop.svn.wordpress.org/trunk@32783 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-15 05:34:52 +00:00