Commit Graph

1384 Commits

Author SHA1 Message Date
Sergey Biryukov
77a1f39484 Upgrade/Install: Bring some consistency to installation screen styles.
* Include `forms.css` and `l10n.css`, for consistency with login screen and other admin screens.
* Remove redundant `@import` directives from `login.css` for files already declared as dependencies.
* Adjust margin on password strength meter for consistency with other fields.
* Increase font size for "You will need this password to log in" notice.
* Fix misaligned icon on "Hide" button for the password.

Props iseulde, dan@micamedia.com, bassgang, cdog, johnbillion, nmenescardi, mukesh27, SergeyBiryukov.
Fixes #35776, #47757, #47758.

git-svn-id: https://develop.svn.wordpress.org/trunk@45673 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-25 19:10:33 +00:00
Sergey Biryukov
03b7742ee9 Customize: Fix text direction for color picker in RTL.
Props vjik for the report.
Fixes #47688. See #23740.

git-svn-id: https://develop.svn.wordpress.org/trunk@45626 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-12 00:04:41 +00:00
Andrea Fercia
725c77a13d Plugins: Fix the plugin details modal layout after [45520].
Props mukesh27, marybaum, audrasjb.
Fixes #47561.


git-svn-id: https://develop.svn.wordpress.org/trunk@45563 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-25 14:10:29 +00:00
Andrea Fercia
6551660d55 Accessibility: Improve focus management in the Media Views.
- keeps focus management only where necessary to avoid focus losses
- removes focus management where a specific user workflow was assumed
- makes the "Attachment Details" navigation buttons really disabled when there are no next or previous attachments
- adds inline comments to clarify all the usages of focus()

Fixes #43169.


git-svn-id: https://develop.svn.wordpress.org/trunk@45524 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-12 21:02:03 +00:00
Andrea Fercia
2b919ee051 Administration: Improve the horizontal centering of the Site Health tabs.
Props dkarfa, davidbaumwald, Clorith, tinkerbelly, afercia.
Fixes #46881.


git-svn-id: https://develop.svn.wordpress.org/trunk@45522 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-12 19:30:49 +00:00
Andrea Fercia
7bd553f13b Administration: Fix the responsive layout after changes to the Screen Options and Help buttons position.
Fixes #45094.


git-svn-id: https://develop.svn.wordpress.org/trunk@45520 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-12 19:20:13 +00:00
Andrea Fercia
c14ea1630f Accessibility: Improve the Screen Options and Help buttons order.
- makes the buttons visual order match the DOM order
- also, restores the focus style on the "hero" primary button after [34948]

Props vrimill, mukesh27 for reporting and testing.
Fixes #45094.


git-svn-id: https://develop.svn.wordpress.org/trunk@45503 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-08 16:30:15 +00:00
Andrea Fercia
7c04864ef5 Administration: Improve the Screen Options and Help buttons focus style after [45501].
Amends [45501].
See #46749.


git-svn-id: https://develop.svn.wordpress.org/trunk@45502 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-08 16:06:19 +00:00
Andrea Fercia
dfb4b20cbd Administration: Remove extra border from the Screen Options and Help buttons.
The extra border was visible in the responsive view for smaller screens after [32844].

Props jitendrabanjara1991.
Fixes #46749.


git-svn-id: https://develop.svn.wordpress.org/trunk@45501 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-08 14:49:50 +00:00
Andrea Fercia
226dc75154 Accessibility: Improve accessibility of all the media views form controls.
- changes the media views form controls to have explicitly associated labels with for/id attributes
- adds a few missing labels / aria-labels
- improves a few existing labels / aria-labels
- improves semantics in a few places, by adding visually hidden headings, fieldset + legend elements, aria-describedby attributes
- improves the image custom size input fields and their labelling
- adds `role="status"` to the "saved" indicator so that status messages are announced to assistive technologies
- swaps the columns source order in the image details template, to make visual and DOM order match
- swaps the "Replace" and "Back" buttons source order in the Replace Image view, to make visual and DOM order match
- gallery settings: move checkbox label to the right: checkboxes are supposed to have labels on the right
- merge similar strings, unified to "Drop files to upload" (removed "Drop files here", and "Drop files anywhere to upload")
- makes the "upload-ui" consistent across the media views
- hides the IE 11 "X" `::-ms-clear` button in the Insert from URL field, as it conflicts with the uploading spinner
- adds comments to all the media templates to clarify their usage
- slightly increases vertical spacing between form fields in the media sidebar
- removes some CSS selectors introduced as backwards compatibility for WordPress pre-4.4
- removes some CSS still targeting Internet Explorer 7 and 8

Fixes #47141.
Fixes #47122.


git-svn-id: https://develop.svn.wordpress.org/trunk@45499 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-07 20:43:26 +00:00
Andrea Fercia
f32683249d Fix the media player controls bar width in the media views.
Props vaishalipanchal, chetan200891.
Fixes #47457.


git-svn-id: https://develop.svn.wordpress.org/trunk@45497 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-07 13:28:37 +00:00
Sergey Biryukov
3ecc8d3f42 Media: Restore correct arrow direction in RTL in Attachment Details modal.
Reverts [29264]. As we now have a build task to replace dashicons for RTL, the CSS rules no longer worked as expected and had the opposite effect.

Props ramiy, SergeyBiryukov.
Fixes #46289.

git-svn-id: https://develop.svn.wordpress.org/trunk@45495 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-06 01:24:51 +00:00
Sergey Biryukov
37e745c041 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/media.css.
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46530. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45484 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 16:44:02 +00:00
Sergey Biryukov
454cdf5f54 Media: Move tag cloud styles that accidentally ended up in Media section after the reorganization in [16136] to a more appropriate place.
Remove styles for `wp-admin/update-core.php` accidentally duplicated in Media section as part of the same reorganization.

See #46530.

git-svn-id: https://develop.svn.wordpress.org/trunk@45483 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 16:39:59 +00:00
Sergey Biryukov
0b50df57a7 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/revisions.css.
Props ianbelanger, pbiron, afercia.
Fixes #46517. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45468 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 12:15:21 +00:00
Sergey Biryukov
efe514a8c2 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/list-tables.css.
Props ianbelanger, pbiron, afercia.
Fixes #46515. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45467 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 12:14:11 +00:00
Sergey Biryukov
2254e86861 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/login.css.
Props ianbelanger, pbiron, afercia.
Fixes #46514. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45466 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 12:08:53 +00:00
Sergey Biryukov
ca40b4ef9f CSS Coding Standards: Use unitless values for line-height in wp-admin/css/install.css.
Props ianbelanger, pbiron, afercia.
Fixes #46513. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45465 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 11:52:20 +00:00
Sergey Biryukov
e9f7b9a81d CSS Coding Standards: Use unitless values for line-height in wp-admin/css/forms.css.
Props ianbelanger, pbiron, afercia.
Fixes #46512. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45464 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 11:48:09 +00:00
Andrea Fercia
79e2b83b8f Administration: Improve the Site Health tables layout for small screens.
Props immeet94, jankimoradiya, desrosj, shashank3105, chetan200891, Clorith, hedgefield.	
Fixes #46960.


git-svn-id: https://develop.svn.wordpress.org/trunk@45463 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-29 18:21:45 +00:00
Sergey Biryukov
663c2f6562 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/edit.css.
Props ianbelanger, pbiron, afercia.
Fixes #46511. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45462 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-29 16:04:38 +00:00
Sergey Biryukov
febf206326 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/dashboard.css.
Props ianbelanger, pbiron, afercia.
Fixes #46510. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45461 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-29 16:02:49 +00:00
Sergey Biryukov
84efe08557 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/customize-widgets.css.
Props ianbelanger, pbiron, afercia.
Fixes #46509. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45460 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-29 16:00:40 +00:00
Andrea Fercia
d013696652 Accessibility: Improve toggling the "Post locked" information visibility.
- effectively hides the "Post locked" information from assistive technologies
- when a post is locked, reveals the "Post locked" information without CSS animation
- the height CSS animation didn't work anyways after [24906]

See #24553.
Fixes #44946.


git-svn-id: https://develop.svn.wordpress.org/trunk@45417 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-25 17:14:29 +00:00
Sergey Biryukov
56b2957c2e CSS Coding Standards: Update unitless values for line-height in wp-admin/css/widgets.css with more precise calculations.
Props ianbelanger.
Fixes #46531.

git-svn-id: https://develop.svn.wordpress.org/trunk@45415 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-25 14:43:29 +00:00
Sergey Biryukov
1752bc29a7 CSS Coding Standards: Update unitless values for line-height in wp-admin/css/nav-menus.css with more precise calculations.
Props ianbelanger.
Fixes #46516.

git-svn-id: https://develop.svn.wordpress.org/trunk@45414 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-25 14:41:55 +00:00
John Blackbourn
a4d9f02eef I18N: Add a language icon next to language selectors.
This change means that users who can't read the site's current language can more easily identify controls that allow them to change either the site language or their own admin area language.

Props janak007, atlasmahesh, afercia, birgire, JoshuaWold

Fixes #43144


git-svn-id: https://develop.svn.wordpress.org/trunk@45402 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-24 20:42:06 +00:00
John Blackbourn
2756e6a27f Administration: Don't apply italic formatting to code blocks in setting descriptions.
Props chetan200891

Fixes #42651


git-svn-id: https://develop.svn.wordpress.org/trunk@45389 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-23 23:13:51 +00:00
Jonathan Desrosiers
c18460698f Privacy: Prevent email field for personal data requests from overflowing.
Props anischarolia, ianbelanger, afercia.
Fixes #46961.

git-svn-id: https://develop.svn.wordpress.org/trunk@45326 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-16 20:44:41 +00:00
Jonathan Desrosiers
cd511054a0 Menus: Fix alignment of menu actions on mobile.
In [41197], changes were made to improve the responsive view for the Menu Name field and Save buttons. This caused the Delete Menu button to be misaligned.

Props ianbelanger, audrasjb, afercia, mukesh27.
Fixes #47173.

git-svn-id: https://develop.svn.wordpress.org/trunk@45324 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-16 19:04:42 +00:00
Jonathan Desrosiers
b7a79cf126 Site Health: Improve alignment and spacing for section headers.
This changes the CSS for Site Health headers to use flexbox, which helps ensure the text is vertically aligned center and consistently spaced in both the Status and Info tabs. It also fixes an issue where the loading spinner GIF was cut off on smaller screens (originally reported in #47203.

Props Presskopp, odminstudios, kjellr, afercia, desrosj, hedgefield, ianbelanger, xavortm.
Fixes #47063.

git-svn-id: https://develop.svn.wordpress.org/trunk@45322 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-16 18:29:47 +00:00
Jonathan Desrosiers
851cb8b8f2 Site Health: Improve vertical alignment of icons in test result descriptions.
This change removes redundant CSS properties for different health check statuses in favor of utilizing the `.dashicons` class already in Core to define them more consistently. This also fixes the vertical alignment issues.

Props chetan200891, Clorith, desrosj.
Fixes #46940.

git-svn-id: https://develop.svn.wordpress.org/trunk@45309 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-15 14:24:15 +00:00
Andrea Fercia
cae0608a7f Accessibility: Improve the "skip links" position for medium and small screens.
Fixes #47065.


git-svn-id: https://develop.svn.wordpress.org/trunk@45301 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-09 21:10:20 +00:00
Jonathan Desrosiers
a72dd388f5 Administration: Prevent cards on the Tools page from overflowing on small screens.
Props anischarolia, mukesh27.
Fixes #46972.

git-svn-id: https://develop.svn.wordpress.org/trunk@45296 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-09 14:55:18 +00:00
Jonathan Desrosiers
6289d9e304 Help/About: Final 5.2 about page updates.
Use final image URLs and fix a bug in IE11 where images were being cut off.

Props afercia, SergeyBiryukov, ianbelanger, desrosj, audrasjb.
See #46901.

git-svn-id: https://develop.svn.wordpress.org/trunk@45287 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-07 17:18:34 +00:00
Jonathan Desrosiers
994950ea8c Help/About: Polish the About page for 5.2.
- The About page now uses a CSS grid to layout its design, making the page’s structure more obvious and hopefully easier for contributors in the future.
- Removes some code that is no longer used (such as videos, mejs elements, etc.).
- Update images.
- Unnecessary HTML is removed from a string on the page. This was a regression.
- Only users with the correct capability should be instructed to check their site status.
- Fixes the placement of commas.

Reviewed by melchoyce, afercia, jeremyfelt, and desrosj.

Props ryelle, melchoyce, cathibosco1, man4toman, SergeyBiryukov, afercia, ramiy, kjellr, tellyworth, earnjam, andreamiddleton, marybaum.
See #46901.

git-svn-id: https://develop.svn.wordpress.org/trunk@45278 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-02 15:43:10 +00:00
Jonathan Desrosiers
f33df7cde4 Help/About: Fix tab display issues.
This change restores About page tab heights and fixes bugs with the tab bottom border caused by [44905] and [45243].

Reviewed by SergeyBiryukov and desrosj.

Props ixkaito, ianbelanger, afercia, SergeyBiryukov.
See #46901.
Fixes #47075.

git-svn-id: https://develop.svn.wordpress.org/trunk@45276 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-02 10:36:02 +00:00
Gary Pendergast
3477102cec Admin: Add the text for the WordPress 5.2 About page.
This changes includes placeholder images for now, they'll be replaced by the final images before final release.

Props chanthaboune, melchoyce, karmatosed, pento, marybaum, birgire, earnjam, andreamiddleton.
See #46901.



git-svn-id: https://develop.svn.wordpress.org/trunk@45271 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-26 00:56:57 +00:00
Gary Pendergast
b074b74489 CSS: Remove the units from line-height properties in common.css.
Props ianbelanger, talldanwp.
Fixes #46493.



git-svn-id: https://develop.svn.wordpress.org/trunk@45243 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-18 06:01:56 +00:00
Andrea Fercia
e1022a6184 Site Health: Improve the accordions styles for small screens.
Also, changes the hex color values to lowercase.

Props subrataemfluence, man4toman, garrett-eclipse, chetan200891, mukesh27, melchoyce, karmatosed, Clorith.
Fixes #46949.


git-svn-id: https://develop.svn.wordpress.org/trunk@45229 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-17 10:59:12 +00:00
Andrea Fercia
f969e1dfd7 Administration: Improve the Site Health "Passed tests" button style for small screens.
Props chetan200891.
Fixes #46939.


git-svn-id: https://develop.svn.wordpress.org/trunk@45217 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-16 16:22:41 +00:00
Mel Choyce
1442389a75 Administration: Update chevron color in Site Health.
Props afercia.
Fixes #46934. See #46730.


git-svn-id: https://develop.svn.wordpress.org/trunk@45202 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-15 18:55:34 +00:00
Andrea Fercia
94af7683fe Administration: Add a chevron icon to the Site Health "Passed tests" button.
The chevron icon helps clarify what the button does.

Props garrett-eclipse, Clorith, xkon, melchoyce.
Fixes #46730.


git-svn-id: https://develop.svn.wordpress.org/trunk@45201 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-15 18:00:57 +00:00
Sergey Biryukov
5f93c86b84 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/customize-controls.css.
Props ianbelanger, audrasjb, pbiron, afercia.
Fixes #46494. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45189 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-13 04:36:01 +00:00
Sergey Biryukov
4de00af6f8 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/themes.css.
Props ianbelanger, mukesh27, audrasjb, pbiron, afercia.
Fixes #46518. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45188 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-13 04:31:08 +00:00
Sergey Biryukov
eb2f56da08 CSS Coding Standards: Use unitless values for line-height for count bubbles in wp-admin/css/admin-menu.css.
Missed in [45186].

Props ianbelanger.
See #46489, #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45187 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-13 04:19:52 +00:00
SergeyBiryukov
10112902ce CSS Coding Standards: Use unitless values for line-height in wp-admin/css/admin-menu.css.
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46489. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45186 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-13 00:16:01 +00:00
Andrew Ozz
05981179e4 Site health: Load the "Info" tab immediately and notify the user while gathering site data. Changes the Info tab to work similarly to the Status tab: it does separate request to fetch the directories sizes and doesn't "block" the loading of the page.
Props xkon, afercia, Clorith, azaozz.
See #46707.

git-svn-id: https://develop.svn.wordpress.org/trunk@45176 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 19:23:13 +00:00
Andrew Ozz
ac97906269 TinyMCE: Fix keyboard navigation when the dfw button is present but hidden. Ensure that button is added last in the DOM to match where it appears visually.
Props afercia, azaozz.
Fixes #46640.

git-svn-id: https://develop.svn.wordpress.org/trunk@45172 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 18:07:47 +00:00
Jonathan Desrosiers
94b6167a04 Site Health: Add missing actions to tests.
This change adds missing actions for several tests. This ensures that the user is provided with a next step, whenever possible.

Also, change the URL displayed in the WordPress.org communication test description to `api.wordpress.org` for accuracy.

Props: garrett-eclipse, Clorith, vaishalipanchal.
Fixes #46734.

git-svn-id: https://develop.svn.wordpress.org/trunk@45170 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 17:39:37 +00:00