Commit Graph

742 Commits

Author SHA1 Message Date
Dominik Schilling (ocean90)
790b60ffb2 Customizer: Use visibility to hide available widgets and menu items panels from screen readers and to move them out of tab order.
props afercia.
fixes #32883.

git-svn-id: https://develop.svn.wordpress.org/trunk@33136 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-08 21:20:54 +00:00
Boone Gorges
002dd563e0 Improvements to responsive styling on my-sites.php.
* Ensure that floated elements break to a new line at the end of a row.
* Allow enough vertical space for long site titles.
* Give more breathing room to cells at narrow widths.

Fixes #31685.

git-svn-id: https://develop.svn.wordpress.org/trunk@33135 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-08 21:01:40 +00:00
Helen Hou-Sandi
013e8d2263 Spinners: Ensure one appears in the lost connection notice.
fixes #32914.


git-svn-id: https://develop.svn.wordpress.org/trunk@33132 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-08 20:19:44 +00:00
Sergey Biryukov
863ce98362 Menus: Restore visibility of up/down arrows for reordering menu items with JS disabled.
props afercia.
fixes #32916.

git-svn-id: https://develop.svn.wordpress.org/trunk@33121 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-08 06:47:45 +00:00
Helen Hou-Sandi
41705c3e7c Ensure error messages look like, well, errors.
props obenland, rachelbaker.
fixes #32475.


git-svn-id: https://develop.svn.wordpress.org/trunk@33117 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 23:10:57 +00:00
Konstantin Obenland
312f5179cb Hide notices introduced in [30505] on about page.
See #19237.

Props jadpm.
Fixes #32625.



git-svn-id: https://develop.svn.wordpress.org/trunk@33113 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 18:46:13 +00:00
Konstantin Obenland
a399fb0b38 Respect the special case of having only one theme.
If there is only one theme, the Pointer won't show and the overlay is active by
default. In that case the overlay covered submenu flyouts, after [33068].
Without the Pointer active, there is no need to bump the `z-index`, so it can
remain at 10.

Fixes #31544.



git-svn-id: https://develop.svn.wordpress.org/trunk@33111 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 17:13:59 +00:00
Helen Hou-Sandi
68b5d643d0 Better styling for .form-invalid inputs.
props liljimmi.
fixes #32490.


git-svn-id: https://develop.svn.wordpress.org/trunk@33109 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 16:40:34 +00:00
Helen Hou-Sandi
62670c5adb Menu customizer: Ensure item type doesn't collide with the handle focus glow.
props andg, metodiew.
fixes #32813.


git-svn-id: https://develop.svn.wordpress.org/trunk@33107 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 15:51:50 +00:00
Helen Hou-Sandi
0e6e1e6612 List tables: Ensure special CSS for the title column gets applied.
This could have some side effects if a custom list table has a title column with a strong element inside that is not the post title, but that is fairly edge and we can address that if it comes up. Also moves the rules into `list-tables.css`.

see #25408.


git-svn-id: https://develop.svn.wordpress.org/trunk@33105 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 15:20:45 +00:00
Helen Hou-Sandi
6d8f6f8d11 List tables: Account for comments being reused on the post edit screen.
Adding the `.wp-list-table` class gets us a few responsive goodies for free. And now it won't show a strange button outline.

see #32395.


git-svn-id: https://develop.svn.wordpress.org/trunk@33101 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 00:08:46 +00:00
Helen Hou-Sandi
9c1265181c List tables: Get rid of double borders for plugins and themes on narrow screens.
see #32395.


git-svn-id: https://develop.svn.wordpress.org/trunk@33099 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-06 23:48:16 +00:00
Helen Hou-Sandi
94cd2d47eb List tables: Ensure the no items message appears on narrow screens.
fixes #32900. see #32395.


git-svn-id: https://develop.svn.wordpress.org/trunk@33098 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-06 23:29:44 +00:00
Dominik Schilling (ocean90)
45e6228070 Customizer: Fix tabindex of reorder buttons for menu items with depth 1 and 10.
props celloexpressions.
fixes #32767.

git-svn-id: https://develop.svn.wordpress.org/trunk@33077 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 22:20:04 +00:00
Dominik Schilling (ocean90)
787016376a Customizer: Improve descriptive text and focus for menu items reorder button.
props afercia.
fixes #32725.

git-svn-id: https://develop.svn.wordpress.org/trunk@33074 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 21:23:12 +00:00
Konstantin Obenland
e33229a237 Synchronize star ratings of themes and plugins.
Makes themes ratings look like plugins ratings already do.

Props helen.
Fixes #32782.
 


git-svn-id: https://develop.svn.wordpress.org/trunk@33073 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 20:53:18 +00:00
Boone Gorges
02bd602dfe Improve the display of my-sites.php on small screens.
Props tryon.
Fixes #31685.

git-svn-id: https://develop.svn.wordpress.org/trunk@33072 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 20:46:54 +00:00
Weston Ruter
a21c6e76d6 Customizer: Fix saving menus with empty names or names that are already used.
Adds validation for initially-supplied nav menu name, blocking empty names from being supplied. If later an empty name is supplied and the nav menu is saved, the name "(unnamed)" will be supplied instead and supplied back to the client. If a name is supplied for the menu which is currently used by another menu, then the name conflict is resolved by adding a numerical counter similar to how `post_name` conflicts are resolved. Includes unit tests.

Fixes #32760.



git-svn-id: https://develop.svn.wordpress.org/trunk@33071 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 20:46:48 +00:00
Dominik Schilling (ocean90)
e430245d00 Customizer: Accessibility enhancements.
* Move tabindex/focus code into `onChangeExpanded` so that it works for cases where `expand()` is called directly.
* Use `visibility: hidden` to hide hidden elements from keyboard focus and screen readers.

props celloexpressions.
fixes #31336.

git-svn-id: https://develop.svn.wordpress.org/trunk@33069 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 20:18:17 +00:00
Konstantin Obenland
1757c3f4d4 Don't let wp-pointers cover the theme detail modal.
Fixes #31544.


git-svn-id: https://develop.svn.wordpress.org/trunk@33068 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 17:04:33 +00:00
Konstantin Obenland
8d40cdcb1b Use a less element-specific class name for links within page titles.
After [32974] these links are no longer within an `h2`, making the class name
inaccurate. `add-new-h1` has the potential to expose the same problem for in a
possible future change.

Fixes #31650.



git-svn-id: https://develop.svn.wordpress.org/trunk@33067 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 16:41:18 +00:00
Helen Hou-Sandi
e7a184a832 Toolbar: Allow submenus to be closed with a second tap on touch devices.
Also closes submenus when the admin menu is toggled open, as it opens below and thus can be obscured.

props stephdau, seanchayes.
see #29906.


git-svn-id: https://develop.svn.wordpress.org/trunk@33056 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 03:28:15 +00:00
Konstantin Obenland
9532df3c9f Site Icon: Improve responsiveness for small screen devices.
Using Jcrop's `trueSize` argument also allows us to get rid of all that behind
the scenes temp image creating and back and forth calculating of image sizes.

Props tyxla for initial patch.
See #16434.



git-svn-id: https://develop.svn.wordpress.org/trunk@33053 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 21:15:52 +00:00
Konstantin Obenland
40b504fffc Add missing prefixed attributes, introduced in [33023].
See ##32589.


git-svn-id: https://develop.svn.wordpress.org/trunk@33050 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 17:39:31 +00:00
Konstantin Obenland
8f4774104b Site Icon: Show correct background preview for transparent images.
iOS will show transparent parts as black, where as the icon itself stays
transparent when used as a favicon.

See #16434.


git-svn-id: https://develop.svn.wordpress.org/trunk@33049 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 17:15:47 +00:00
Helen Hou-Sandi
b896a4e31b Customizer: Build flips the panel arrow for RTL on our behalf.
see #31336.


git-svn-id: https://develop.svn.wordpress.org/trunk@33045 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 01:28:43 +00:00
Konstantin Obenland
dd28f15179 Prevent link to customizer from wrpping on small screens.
Fixes #32808.


git-svn-id: https://develop.svn.wordpress.org/trunk@33040 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 23:35:57 +00:00
Dominik Schilling (ocean90)
54cd46c1d0 Customizer: Fix height calculation of placeholders when dragging menu items.
props adamsilverstein.
fixes #32857.

git-svn-id: https://develop.svn.wordpress.org/trunk@33028 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 16:19:51 +00:00
Dominik Schilling (ocean90)
caab22e5b2 l10n: Update wp_get_installed_translations() to support variants of a language.
* A variant of a language has its own locale, for example the locale of the formal variant of German is `de_DE_formal`.
* Update `remove_accents()` and some CSS rules to support `de_DE_formal`.
* Add tests for `get_bloginfo( 'language' )`.
* API changes will be deployed over the next few days.

see #28303.

git-svn-id: https://develop.svn.wordpress.org/trunk@33027 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 15:42:32 +00:00
Mark Jaquith
cc23659078 New password change/set UI.
* Generate the password for the user
* More tightly integrate password strength meter
* Warn on weak passwords

see #32589

props MikeHansenMe, adamsilverstein, binarykitten

git-svn-id: https://develop.svn.wordpress.org/trunk@33023 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 14:47:24 +00:00
Helen Hou-Sandi
e5c4c584c0 List tables: A better responsive view.
Instead of truncating columns, the data that's already in the markup can now be toggled into view. Only seems appropriate to celebrate four years of contributing by finally doing the first thing I ever mocked up.

Known issues / concerns:
* Custom list tables that don't define a primary column will show nothing at all. These are not extremely common, as `WP_List_Table` isn't really recommended for plugin consumption, but it happens. We need to come up with some kind of fallback.
* Some visual elements, particularly whitespace, could use refining.
* Needs a11y review.
* Touch performance on iOS feels sluggish - is there anything we can do about that?
* Would this be better accordion-style (only one expanded at a time)?
* Is `wp_strip_all_tags()` good enough for column titles that have HTML in them? It's essentially a workaround for the fact that core's comments column does that for the icon, which maybe it shouldn't. Perhaps worth another ticket, as a markup change would be fairly independent.
* Visual hierarchy is not great when expanded (also worthy of another ticket).
* Quick edit now becomes noticeably more annoying to cancel out of, as you have to scroll all the way down and you lose your position from before it was opened. Again, worthy of another ticket.

props Michael Arestad, helen.
see #32395.


git-svn-id: https://develop.svn.wordpress.org/trunk@33016 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 01:30:23 +00:00
Konstantin Obenland
f733d8a91d Customizer: Fresh colors for Reorder Done button.
When reordering Widgets or Menus, the red colorcould suggest
it would cancel the changes, rather than save them. The blue
suggests it's clickable and is more in line with the Close
link on open Widgets.

Fixes #32811.



git-svn-id: https://develop.svn.wordpress.org/trunk@33012 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 00:18:46 +00:00
Helen Hou-Sandi
e681cb8ba7 Image edit: Consistent whitespace for the side boxes.
props tyxla.
fixes #31845.


git-svn-id: https://develop.svn.wordpress.org/trunk@33002 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-30 15:18:29 +00:00
azaozz
f27883ce42 Press This:
- Add support for the Text editor.
- Add auto-scrolling when the caret moves out of the viewport while the user is typing (similarly to editor-expand).
- Add auto-resize for the textarea.
See #32706.

git-svn-id: https://develop.svn.wordpress.org/trunk@32999 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-30 03:57:42 +00:00
Konstantin Obenland
ffa682bee4 Introducing Site Icon, favicon management for WordPress.
This v1 marries Jetpack's Site Icon module with the Media Modal, reusing code
from the Custom Header admin. For now, the core-provided icons will be limited
to a favicon, an iOS app icon, and a Windows tile icon, leaving `.ico` support
and additional icons to plugins to add.

Props obenland, tyxla, flixos90, jancbeck, markjaquith, scruffian.
See #16434.



git-svn-id: https://develop.svn.wordpress.org/trunk@32994 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-29 12:57:35 +00:00
Konstantin Obenland
e43ee8d41d Customizer: Correct position for menu item delete icon in IE8.
Props valendesigns.
Fixes #32675.



git-svn-id: https://develop.svn.wordpress.org/trunk@32987 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-28 11:48:35 +00:00
Sergey Biryukov
0916133d43 List tables: Select All should not be a column header.
It sets a redundant relationship with all checkboxes in its column and also conveys wrong information for screen readers.

props afercia, valendesigns.
see #31654.

git-svn-id: https://develop.svn.wordpress.org/trunk@32984 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-28 05:45:49 +00:00
Andrew Ozz
c72d42d922 Press This:
- Save a draft before opening the standard editor window.
- While saving a post show Saving... instead of Publish for the main visible part of the split button (same as the Save Draft button before).
See #32757.

git-svn-id: https://develop.svn.wordpress.org/trunk@32983 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-28 04:58:56 +00:00
Sergey Biryukov
8baa10c377 Customizer: Increase color contrast ratio for menu locations text.
props celloexpressions.
fixes #32727.

git-svn-id: https://develop.svn.wordpress.org/trunk@32982 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-28 04:44:03 +00:00
Scott Taylor
e4aa6ae703 After [32974], tweak some CSS for focus, etc.
See #31650.


git-svn-id: https://develop.svn.wordpress.org/trunk@32977 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 23:12:23 +00:00
Konstantin Obenland
a4fd22608f Additional style changes to accomodate <h1> headings.
See [32974], #31650.



git-svn-id: https://develop.svn.wordpress.org/trunk@32975 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 15:50:59 +00:00
Konstantin Obenland
e59592f87e Proper heading for admin screens.
First step towards restoring a good heading structure in wp-admin.
The previous `<h1>` contained the site title and a link to the front page and was removed with the toolbar refactoring in 3.2.

Props joedolson, afercia.
Fixes #31650.



git-svn-id: https://develop.svn.wordpress.org/trunk@32974 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 15:40:27 +00:00
Sergey Biryukov
1be584d477 Fix the dismissable notice button focus style, broken in [32475].
props afercia.
fixes #32797.

git-svn-id: https://develop.svn.wordpress.org/trunk@32973 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 15:06:22 +00:00
Dominik Schilling (ocean90)
3dd7ca4ed6 Customizer: Remove top margin when dragging menu items.
The markup was changed in [32889].

props tywayne.
fixes #32745.

git-svn-id: https://develop.svn.wordpress.org/trunk@32970 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 09:46:10 +00:00
Scott Taylor
d0c3281ea8 In Media microtemplates after [32467], use <button> instead of <a> for several more non-links.
Props afercia.
Fixes #26550.


git-svn-id: https://develop.svn.wordpress.org/trunk@32952 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-26 05:00:42 +00:00
Scott Taylor
229a9cc434 List tables: when post navigation links point to the current page, use <span>s and text instead of <a>s.
Props afercia.
Fixes #32253.


git-svn-id: https://develop.svn.wordpress.org/trunk@32948 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 20:31:51 +00:00
Scott Taylor
9f5df5d045 Admin menu: improve accessibility when collapsed.
Props afercia.
Fixes #32346.


git-svn-id: https://develop.svn.wordpress.org/trunk@32946 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 19:32:36 +00:00
Scott Taylor
53bc964fc1 After [32796], improve the accessibility and markup for instances of touch_time().
Props rianrietveld, afercia.
Fixes #31714.


git-svn-id: https://develop.svn.wordpress.org/trunk@32945 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 19:30:00 +00:00
Andrew Ozz
e06cc095b4 Press This, split button: wrap the sub-buttons in an unordered list to aid accessibility.
Props afercia. See #32757.

git-svn-id: https://develop.svn.wordpress.org/trunk@32934 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 01:54:36 +00:00
Andrew Ozz
bdace7c8b5 Press This: fix spinner position relative to the split button.
See #32757.

git-svn-id: https://develop.svn.wordpress.org/trunk@32922 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 03:31:03 +00:00