Commit Graph
5036 Commits
Author SHA1 Message Date
Drew Jaynes 7cb8fc1b3b Multisite: Improve two error strings specifying allowed characters in usernames and site names.
Also removes two error strings that were likely never being triggered anyway due to the stricter character matching higher up.

Props atomicjack, bjornjohansen, DrewAPicture.
Fixes #33336.


git-svn-id: https://develop.svn.wordpress.org/trunk@35142 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 17:32:17 +00:00
Scott Taylor 16b02b6768 KSES: have you ever heard of the <bdo> HTML tag? Same. http://www.w3schools.com/tags/tag_bdo.asp
Adds unit test.

Props iandunn.
Fixes #34063.


git-svn-id: https://develop.svn.wordpress.org/trunk@35141 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 17:17:13 +00:00
Scott Taylor 55a42e8afa Taxonomy: in wp_list_categories(), add an arg: separator, to allow the overriding of <br/>.
Props wojtek.szkutnik.
Fixes #9025.


git-svn-id: https://develop.svn.wordpress.org/trunk@35140 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 17:01:10 +00:00
Drew Jaynes 0a8b41c950 Users: Restore changes from [35114] accidentally reverted in [35135].
See #28631.


git-svn-id: https://develop.svn.wordpress.org/trunk@35138 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 15:44:14 +00:00
Drew Jaynes 5e37130fcd Docs: Add a changelog entry mentioning that the number argument now supports -1 (all).
Also fixes the argument description.

-1 support was added in [35114].

See #28631.


git-svn-id: https://develop.svn.wordpress.org/trunk@35135 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 15:15:30 +00:00
Sergey Biryukov c5c5bd31dd Toolbar: Improve padding of toolbar submenu items on small screens.
Props tillkruess.
Fixes #28608.

git-svn-id: https://develop.svn.wordpress.org/trunk@35132 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 07:39:54 +00:00
Scott Taylor da6e194d93 Admin Bar: fix the alignment of secondary menu item arrows.
Props juhise.
Fixes #33836.


git-svn-id: https://develop.svn.wordpress.org/trunk@35125 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 03:53:16 +00:00
Scott Taylor a6a0045460 Fotmatting: in sanitize_file_name(), escape % when uploads contain them, otherwise attachment URLs will unescape the char and break.
Adds unit tests.

Props mordauk, simonwheatley, dd32, solarissmoke.
Fixes #16226.


git-svn-id: https://develop.svn.wordpress.org/trunk@35122 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 03:21:13 +00:00
Sergey Biryukov 0f2f946736 Feeds: Remove a confusing comment from add_feed(), added in [3638].
It always overrides the default callback if it's set, regardless of the `in_array()` check.

See #34259.

git-svn-id: https://develop.svn.wordpress.org/trunk@35121 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 03:13:31 +00:00
Boone Gorges 0d28b59c0b Use a more reliable method for generating get_terms() cache key.
Previously, the cache key included a serialization of `list_terms_exclusions`
callbacks, to ensure that the cache was differentiated properly for different
uses of the `list_terms_exclusions` filter. This strategy was flawed in a
couple of ways: serialization doesn't work equally well for all callable types;
the serialization required reaching into the `$wp_filter` global; serializing
the callback itself didn't properly account for the possibility that the
callback might return different values in different contexts; the cache key
didn't account for other filters that similarly affect the cached values, such
as `terms_clauses`.

We skirt all these issues by concatenating the cache key using the SQL query
string, which will reflect all filters applied earlier in `get_terms()`.

Props boonebgorges, wonderboymusic.
Fixes #21267.

git-svn-id: https://develop.svn.wordpress.org/trunk@35120 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 03:06:27 +00:00
SergeyBiryukov d5e0f87530 Docs: Describe the $feedname argument of add_feed().
Fixes #34259.

git-svn-id: https://develop.svn.wordpress.org/trunk@35119 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 03:00:03 +00:00
Sergey Biryukov 77e2cd9e18 Feeds: Pass the second parameter of "do_feed_{$feed}" action, feed name, to callbacks added via add_feed().
The `$feed` parameter was added in [35115].

Props slimndap.
See #34259.

git-svn-id: https://develop.svn.wordpress.org/trunk@35118 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 02:58:21 +00:00
Boone Gorges f9094e546a In get_terms(), don't store WP_Term objects in cache.
Fixes #34282.

git-svn-id: https://develop.svn.wordpress.org/trunk@35117 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 02:57:21 +00:00
Scott Taylor 34cb01e2f1 Users: when passing a WP_User instance to wp_update_user(), ensure that the user password is not accidentally double-hashed. This is terrifying.
Adds unit tests.

Props tbcorr, salcode.
Fixes #28435.


git-svn-id: https://develop.svn.wordpress.org/trunk@35116 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 02:47:09 +00:00
Sergey Biryukov 4a2184d00c Feeds: Pass the feed name to do_feed_{$feed} action.
Props johnbillion.
See #34259.

git-svn-id: https://develop.svn.wordpress.org/trunk@35115 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 02:43:30 +00:00
Scott Taylor 4c0b89553a Users: allow -1 (no limit, use with extreme caution on large sites) as the value for number in WP_User_Query - similar to posts_per_page => -1 in WP_Query.
Adds unit tests.

Props mordauk, jesin, nofearinc.
Fixes #28631.


git-svn-id: https://develop.svn.wordpress.org/trunk@35114 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 02:39:05 +00:00
Boone Gorges ae96d16ed9 Remove dead code from WP_Query::lazyload_term_meta().
git-svn-id: https://develop.svn.wordpress.org/trunk@35111 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 02:35:30 +00:00
Scott Taylor 65c8adc252 Widgets: When using the_widget(), the $before_widget argument only receives the widget class if using the default sidebar arguments. Run sprintf after parsing the args to fix this.
Adds unit test.

Props coffee2code.
Fixes #19450.


git-svn-id: https://develop.svn.wordpress.org/trunk@35106 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 01:48:41 +00:00
Sergey Biryukov c0c0305749 Replace get_bloginfo( 'wpurl' ) with site_url() in rsd_link().
Ensure the correct scheme is used for the `application/rsd+xml` link URL.

Props johnbillion.
See #34280.

git-svn-id: https://develop.svn.wordpress.org/trunk@35105 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 01:48:32 +00:00
Drew Jaynes 72c81e01d4 Widgets: Rename the $name parameter in is_registered_sidebar() to $sidebar_id and adjust the accepted types to string|int as sidebar IDs can be numeric.
See #24878.


git-svn-id: https://develop.svn.wordpress.org/trunk@35104 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 01:44:44 +00:00
Scott Taylor b272dc68b9 Widgets: add a default filter for widget_text (used by the Text widget), balanceTags, which respects the option for use_balanceTags.
Props MikeHansenMe.
Fixes #23083.


git-svn-id: https://develop.svn.wordpress.org/trunk@35103 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 01:39:43 +00:00
Scott Taylor 3616fe5939 Widgets: add a function, is_registered_sidebar() - helps us avoid touching the $wp_registered_sidebars global.
Props GaryJ, wonderboymusic.
Fixes #24878.


git-svn-id: https://develop.svn.wordpress.org/trunk@35102 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 01:32:27 +00:00
Boone Gorges 9f551a4630 Don't match partial roles in WP_User_Query.
Because 'role=ocean90' shouldn't match 'role=bocean901'.

Props bocean901, ocean90.
Fixes #22212.

git-svn-id: https://develop.svn.wordpress.org/trunk@35101 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 01:31:53 +00:00
Scott Taylor d936110f7c Widgets: when getting settings, and none exist, set them to empty to avoid extraneous database queries on subsequent requests.
Adds unit tests.

Props kovshenin, MikeHansenMe, dlh.
Fixes #26876.


git-svn-id: https://develop.svn.wordpress.org/trunk@35100 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 01:12:12 +00:00
Drew Jaynes 681d100fd6 Feeds: Simplify logic for checking if the do_feed_{$feed} action is hooked to any callbacks.
See [35097] for where the aforementioned hook was renamed to actually be dynamic, thus rendering creation of the extra `$hook` variable moot.

See #34264.


git-svn-id: https://develop.svn.wordpress.org/trunk@35098 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 01:06:26 +00:00
Drew Jaynes 1246590769 Feeds: Adjust the do_feed_{$feed} hook name to actually be dynamic, rather than pre-storing the tag name in a variable and referencing that.
Props johnbillion.
Fixes #34264.


git-svn-id: https://develop.svn.wordpress.org/trunk@35097 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 01:02:47 +00:00
Sergey Biryukov 6aa28b5bd3 Format the number of comments in wp-includes/embed-template.php for the locale.
Props johnbillion.
Fixes #34276.

git-svn-id: https://develop.svn.wordpress.org/trunk@35096 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 01:01:53 +00:00
Scott Taylor 380d27331e XML-RPC: Add a filter, xmlrpc_memory_limit, to allow the value of $xmlrpc_memory_limit to be increased.
Props ankit.gade.
Fixes #29957.


git-svn-id: https://develop.svn.wordpress.org/trunk@35095 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 01:00:04 +00:00
Sergey Biryukov 34a716709c In number_format_i18n(), check if $wp_locale is set before using it.
Props pauldewouters.
Fixes #31553.

git-svn-id: https://develop.svn.wordpress.org/trunk@35092 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 00:29:18 +00:00
John Blackbourn 91583fe499 Add missing @since params and update the docs for site_icon_url() and has_site_icon().
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@35090 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 23:27:18 +00:00
John Blackbourn d32c6cfbc9 Remove another unnecessary function_exists() call.
See [35087]
See #32522


git-svn-id: https://develop.svn.wordpress.org/trunk@35089 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 23:19:43 +00:00
Drew Jaynes 33d083e263 Version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@35088 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 22:58:22 +00:00
John Blackbourn 4d8c6f6e08 Remove an unnecessary function_exists() call which was included in the oEmbed feature plugin for compatibility with WordPress < 4.3.
See #32522


git-svn-id: https://develop.svn.wordpress.org/trunk@35087 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 22:53:28 +00:00
John Blackbourn 2eaae4739b Correct two escaping functions used in wp-includes/embed-template.php.
See #32522


git-svn-id: https://develop.svn.wordpress.org/trunk@35086 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 22:51:32 +00:00
John Blackbourn da6090d9f7 Add missing @since docs for the filters in wp-includes/embed-template.php
See #32522, #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@35085 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 22:50:34 +00:00
John Blackbourn d04e6dc919 Correct the @since doc for WP_Query::is_embed().
See #32522


git-svn-id: https://develop.svn.wordpress.org/trunk@35084 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 22:12:42 +00:00
Scott Taylor 743d22415f oEmbed: add fallback icons (not used yet) for older browsers.
Props melchoyce.
See #34204.


git-svn-id: https://develop.svn.wordpress.org/trunk@35083 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 21:16:10 +00:00
John Blackbourn f5d2e0dd61 Add $transient as a parameter to the set_transient_{transient} action.
Props SergeyBiryukov
Fixes #34269


git-svn-id: https://develop.svn.wordpress.org/trunk@35082 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 21:01:24 +00:00
Scott Taylor e05891a7ec Media: avoid "divide by zero" in wp_get_attachment_image_srcset_array().
Fixes #34238.


git-svn-id: https://develop.svn.wordpress.org/trunk@35081 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 20:59:12 +00:00
Drew Jaynes 6ca6c6fc1c Docs: The $size parameter for the get_image_tag hook also accepts an array.
See #34257. See [35038].


git-svn-id: https://develop.svn.wordpress.org/trunk@35078 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 17:10:59 +00:00
Drew Jaynes 03481541aa Docs: The $size parameter for the get_image_tag_class hook also accepts an array.
See #34257. See [35037].


git-svn-id: https://develop.svn.wordpress.org/trunk@35077 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 17:08:39 +00:00
Drew Jaynes 2f5be3afcf Docs: Adjust documentation for the $size parameter in the_post_thumbnail_url() to clarify the required order of width and height values when passing an array.
Fixes #34257. Whew!


git-svn-id: https://develop.svn.wordpress.org/trunk@35076 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 16:59:48 +00:00
Drew Jaynes 663d71de0d Docs: The post_thumbnail_size hook can also accept an array (already supported).
See #34257. See [35069].


git-svn-id: https://develop.svn.wordpress.org/trunk@35075 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 16:56:54 +00:00
Drew Jaynes 38141969f2 Docs: The $size parameters in the begin_fetch_post_thumbnail_html and end_fetch_post_thumbnail_html hooks can also accept an array (already supported).
See #34257. See #32246. See [35070] and [35071].


git-svn-id: https://develop.svn.wordpress.org/trunk@35074 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 16:55:08 +00:00
Drew Jaynes 581723a924 Docs: Normalize spacing in the post_thumbnail_html hook doc following [35072].
See #34257. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35073 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 16:52:15 +00:00
Drew Jaynes a92ba46df9 Docs: Adjust documentation for the $size parameter in the post_thumbnail_html hook doc to clarify the required order of width and height values when an array is passed.
Also adds the `array` type to the parameter documentation (already supported).

See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35072 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 16:51:15 +00:00
Drew Jaynes ecf49d9f10 Docs: Adjust documentation for the $size parameter in the end_fetch_post_thumbnail_html hook doc to clarify the required order of width and height values when an array is passed.
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35071 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 16:49:14 +00:00
Drew Jaynes 73cfcece73 Docs: Adjust documentation for the $size parameter in the begin_fetch_post_thumbnail_html hook doc to clarify the required order of width and height values when an array is passed.
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35070 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 16:48:26 +00:00
Drew Jaynes e918b66538 Docs: Adjust documentation for the $size parameter in the post_thumbnail_size hook doc to clarify the required order of width and height values when an array is passed.
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35069 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 16:47:22 +00:00
Drew Jaynes debd363cd7 Docs: Adjust documentation for the $size parameter in get_the_post_thumbnail() to clarify the required order of width and height values when passing an array.
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35068 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 16:46:15 +00:00