Commit Graph
141 Commits
Author SHA1 Message Date
Joe McGill 7ddf1b3ce1 Fix broken audio/video functions when sanitizing ID3 data
This fixes a bug where running `wp_kses_post_deep()` on all the ID3
tag data corrupted blob data.

Fixes #40075, #40085.


git-svn-id: https://develop.svn.wordpress.org/trunk@40400 602fd350-edb4-49c9-b593-d223f7449a82
2017-04-10 01:27:30 +00:00
jeremyfelt e24a96c734 Validate video and audio metadata.
git-svn-id: https://develop.svn.wordpress.org/trunk@40148 602fd350-edb4-49c9-b593-d223f7449a82
2017-03-06 08:00:06 +00:00
John Blackbourn 347040745d I18n: Introduce more translator comments for strings that contain placeholders but don't have an accompanying translator comment.
See #38882


git-svn-id: https://develop.svn.wordpress.org/trunk@39326 602fd350-edb4-49c9-b593-d223f7449a82
2016-11-21 02:45:53 +00:00
Mike Schroder 35e6dbe14f Media: Add support for rendering PDF thumbnails.
When support for PDFs is available, on upload,
render 'Thumbnail', 'Medium', 'Large', and 'Full' sizes of
the first page, and save them in attachment meta.

Use these renders within Add Media, Media Gallery and List views,
Attachment Details, Post/Attachment Edit screens, and Attachment pages.

Support available by default via Imagick -> ImageMagick -> Ghostscript,
but can be provided by any `WP_Image_Editor` that supports PDFs.

Props adamsilverstein, azaozz, celloexpressions, desrosj, dglingren, ericlewis, ipstenu, joemcgill, joyously, markoheijnen, melchoyce, mikeschroder, tomauger.
Fixes #31050.

git-svn-id: https://develop.svn.wordpress.org/trunk@38949 602fd350-edb4-49c9-b593-d223f7449a82
2016-10-26 07:27:51 +00:00
Joe McGill 5d1f571508 Media: Improve docs for image_send_to_editor filter.
This updates inline docs for the `image_send_to_editor` filter to better
describe when it is fired.

Props adamsilverstein.
Fixes #34823.

git-svn-id: https://develop.svn.wordpress.org/trunk@38734 602fd350-edb4-49c9-b593-d223f7449a82
2016-10-05 19:56:26 +00:00
Joe McGill 0d0e2bf2ba Media: Use wp_basename() to create attachment titles from filenames.
In [38294], `pathinfo()` was used with the `PATHINFO_BASENAME` constant to
get the basename of the file to be used as an attachment title, which depends
on PHP locale and can cause issues with UTF-8 characters. This uses
`wp_basename()` instead, which is a more i18n-friendly version of `basename()`.

Props SergeyBiryukov.
Fixes #37608, #37989.

git-svn-id: https://develop.svn.wordpress.org/trunk@38673 602fd350-edb4-49c9-b593-d223f7449a82
2016-09-29 01:20:10 +00:00
Andrea Fercia ee7f970ffa Administration: Improve the usage of the button CSS classes.
Introduces some consistency in the usage of the button CSS classes, fixes the
focus style for accessibility and responsiveness of the buttons.

- Adds the `button` class to all primary buttons make them responsive
- Removes all `secondary-button` classes and replaces it with button when needed. `button-secondary` shouldn't be used and exists just for backward compatibility reasons
- Replaces classes inside `submit_button()` with a shorthand for some buttons, and use an empty string for the default `button` class. Passing `button` is unnecessary
- Adjusts `get_submit_button()` to remove empty items

Props iseulde, dimchik, chris_d2d, mhowell, afercia.
Fixes #27314, #37138, #37448.


git-svn-id: https://develop.svn.wordpress.org/trunk@38672 602fd350-edb4-49c9-b593-d223f7449a82
2016-09-28 19:53:07 +00:00
Aaron D. Campbell 6eb3e0bf5f Media: Improved media titles when created from filename.
Preserves spaces and generally creates more accurate, cleaner titles from filenames of uploaded media.

Props joemcgill.
Fixes #37989.



git-svn-id: https://develop.svn.wordpress.org/trunk@38614 602fd350-edb4-49c9-b593-d223f7449a82
2016-09-17 05:41:27 +00:00
Jeremy Felt 8079863586 Media: Sanitize upload filename.
git-svn-id: https://develop.svn.wordpress.org/trunk@38538 602fd350-edb4-49c9-b593-d223f7449a82
2016-09-07 13:54:57 +00:00
Scott Taylor 683d828d42 General: revert [38467], wp_is_IE() should not exist.
See #37699.


git-svn-id: https://develop.svn.wordpress.org/trunk@38468 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-31 15:21:04 +00:00
Scott Taylor f9278a9364 General: use a new function, wp_is_IE(), instead of the $is_IE global in a number of places.
See #37699.


git-svn-id: https://develop.svn.wordpress.org/trunk@38467 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-31 06:41:07 +00:00
Drew Jaynes b4fca4a558 Hooks: Standardize naming of dynamic hooks to use interpolation vs concatenation.
Benefits gained in discoverability and self-documentation throughout core trump the negligible performance hit in using interpolation in hook names.

Props ramiy.
See #37748.


git-svn-id: https://develop.svn.wordpress.org/trunk@38307 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-22 18:24:48 +00:00
Scott Taylor d911ef44dc Media: when calling pathinfo(), also pass a PATHINFO_* constant to avoid array notices for unset keys.
Props JaworskiMatt.
Fixes #37608.


git-svn-id: https://develop.svn.wordpress.org/trunk@38294 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-20 23:35:50 +00:00
Drew Jaynes 13ec34335a Docs: Standardize references to "meta box" or "meta boxes" as two distinct words throughout core documentation per the core spelling guide.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@38029 602fd350-edb4-49c9-b593-d223f7449a82
2016-07-10 00:55:21 +00:00
Drew Jaynes ea78fbdcdb Docs: Fix minor formatting and syntax for wp-admin/* elements introduced in 4.6.
See #37318.


git-svn-id: https://develop.svn.wordpress.org/trunk@38024 602fd350-edb4-49c9-b593-d223f7449a82
2016-07-09 13:59:16 +00:00
Pascal Birchler ce7b53fb3f Docs: Fix a typo across some function and hook docs.
s/filterss/filters.

See #32246.

git-svn-id: https://develop.svn.wordpress.org/trunk@37961 602fd350-edb4-49c9-b593-d223f7449a82
2016-07-04 22:44:10 +00:00
Dominik Schilling (ocean90) 206380180e Text Changes: Unify permission error messages.
The new format looks like "Sorry, you are not allowed to <action>.". This provides a consistent experience for all error messages related to missing permissions. It also reduces the number of similar strings and allows translators to provide a consistent style in their language.

Props ramiy, Presskopp.
Fixes #34521.

git-svn-id: https://develop.svn.wordpress.org/trunk@37914 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-29 15:15:40 +00:00
Joe McGill 2705524260 Docs: Add missing variable reference for wp_edit_form_attachment_display.
This adds the missing `$post` reference in the inline docblock for
the `wp_edit_form_attachment_display` hook after [37879].

Props DrewAPicture.
See 36052.

git-svn-id: https://develop.svn.wordpress.org/trunk@37880 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-27 01:53:23 +00:00
Joe McGill 726057bc41 Media: Add action to display attachments on the edit screen.
This adds a new action hook, `wp_edit_form_attachment_display` to
`edit_form_image_editor()`, which can be used as a fallback to render
previews of an attachment that isn't an image, audio, or video file
included in the media library.

Props georgestephanis.
Fixes #36502.

git-svn-id: https://develop.svn.wordpress.org/trunk@37879 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-26 22:37:00 +00:00
Drew Jaynes 2111185ab9 Docs: Apply inline @see tags to hooks referenced in DocBlocks for wp-admin/* files.
Applying these specially-crafted `@see` tags allows the Code Reference parser to recognize and link these elements as actions and filters.

See #36921.


git-svn-id: https://develop.svn.wordpress.org/trunk@37537 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-23 17:27:19 +00:00
Drew Jaynes 1cd420af5e Docs: Standardize hook docs in wp-admin/* to use third-person singular verbs per the inline documentation standards for PHP.
See #36913.


git-svn-id: https://develop.svn.wordpress.org/trunk@37488 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-22 18:00:23 +00:00
Drew Jaynes 1d6fff7f66 Docs: Fix some parameter alignment and backtick-escaping in two DocBlocks in wp-admin/includes/media.php.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@37484 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-22 17:17:11 +00:00
Drew Jaynes ca67aa233d Docs: Remove invalid inline @link tags from docs in wp-admin/includes/media.php.
See #36910.


git-svn-id: https://develop.svn.wordpress.org/trunk@37483 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-22 17:09:16 +00:00
Drew Jaynes c7bed4f8c6 Docs: Remove inline @see tags from function, class, and method references in inline docs.
Known functions, classes, and methods are now auto-linked in Code Reference pages following #meta1483.

Note: Hook references are still linked via inline `@see` tags due to the unlikelihood of reliably matching for known hooks based on a RegEx pattern.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@37342 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-02 03:59:56 +00:00
Sergey Biryukov 2014288c62 Docs: Fix typo in get_image_send_to_editor() description.
Props yoavf.
See #36349.

git-svn-id: https://develop.svn.wordpress.org/trunk@37194 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-13 07:27:15 +00:00
Andrew Ozz 058a2f558d Media: fix erroneously inserting a rel attribute in get_image_send_to_editor(). Reverts most of [34259] and [34260] and adds a unit test.
Props joemcgill, azaozz.
Fixes #36084.

git-svn-id: https://develop.svn.wordpress.org/trunk@37035 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-18 20:04:19 +00:00
Andrea Fercia 137bcc1fca Accessibility: Remove the title attributes from the old Media UI.
Also, adds better indication and attributes for the required form fields.
Moves some styles to `deprecated-media.css`.

Props andg, afercia.
Fixes #34944.

git-svn-id: https://develop.svn.wordpress.org/trunk@36879 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-07 22:28:15 +00:00
Andrea Fercia b723d3fb75 CSS: Rename the handle for deprecated-media.css after [36341].
The `media` handle is now used for `media.css` thus the stylesheet
for the old media UI needs a different handle name.

See #35229.

git-svn-id: https://develop.svn.wordpress.org/trunk@36869 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-06 15:37:25 +00:00
John Blackbourn 021401424b Docs: @param fixes for a variety of docblocks.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@36232 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 01:44:31 +00:00
Andrea Fercia 05934ebd87 Media: make the Image Editor usable with a keyboard.
For accessibility, all interactive controls must be operable from the keyboard.
Replaces `<div>`s used as UI controls with buttons. Groups some logically-related
form elements.

Fixes #28864.

git-svn-id: https://develop.svn.wordpress.org/trunk@36223 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-08 19:12:11 +00:00
John Blackbourn 6b718eaa83 Correct the position of the $alt parameter's @param doc in image_add_caption().
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@35918 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 03:00:09 +00:00
Ella Iseulde Van Dorpe 14c3f3c871 Make date format consistent across the admin
The 'date_format' and 'time_format' options shouldn't affect the backend.

See #30864



git-svn-id: https://develop.svn.wordpress.org/trunk@35811 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-07 04:25:53 +00:00
Scott Taylor f16f273cd2 Media: in media_send_to_editor(), use wp_json_encode() instead of addslashes().
Props TobiasBg.
Fixes #22135.


git-svn-id: https://develop.svn.wordpress.org/trunk@35677 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-18 19:39:19 +00:00
Andrea Fercia 29f271da44 Media: Improve form fields labels association in the Edit Media screen.
Fixes #34548.

git-svn-id: https://develop.svn.wordpress.org/trunk@35493 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-03 16:01:11 +00:00
Sergey Biryukov d21d397d49 Don't use <code> in translatable string in wp-admin/includes/media.php.
Add translator commment.

Props ramiy.
Fixes #34499.

git-svn-id: https://develop.svn.wordpress.org/trunk@35439 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 00:57:22 +00:00
Sergey Biryukov d842c03e02 Docs: Correct the type and description of $post parameter passed to the attachment_fields_to_save filter.
Props swissspidy.
Fixes #34404.

git-svn-id: https://develop.svn.wordpress.org/trunk@35374 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-23 13:00:11 +00:00
Helen Hou-Sandi 61ef1ff96f Make some primary action buttons look primary.
* User deletion/removal
* Site status change (multisite)
* Network upgrade
* Import file upload
* Media browser upload

props Dezzy for the initial patch.
fixes #23738.


git-svn-id: https://develop.svn.wordpress.org/trunk@35182 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 03:07:48 +00:00
Drew Jaynes 0cb7c0bd9f Docs: Add missing descriptions for the $wpdb global in DocBlocks all the places.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35170 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 23:43:10 +00:00
Drew Jaynes 6e6d9f9830 Docs: Specify the default image size in the $size parameter description for the image_send_to_editor hook.
See #34257. See #32246. See [35058].


git-svn-id: https://develop.svn.wordpress.org/trunk@35080 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 17:17:19 +00:00
Drew Jaynes dd7b3a62fd Docs: Normalize spacing in the DocBlock for get_image_send_to_editor() following [35056].
See #34257. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35079 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 17:15:16 +00:00
Drew Jaynes 6db985862a Docs: Normalize spacing in the image_send_to_editor hook doc following [35058].
See #34257. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35059 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 16:18:32 +00:00
Drew Jaynes 59db8cfe93 Docs: Adjust documentation for the $size parameter in the image_send_to_editor hook doc to clarify the required order of width and height values when an array is passed.
Also adds the `array` type to the parameter documentation (already supported).

See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35058 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 16:16:35 +00:00
Drew Jaynes 25c0710f4c Docs: Fix syntax and properly mark optional parameters as such in the DocBlock for get_image_send_to_editor().
Also fixes the return description, and adds the `$size` default value, missed in [35055].

See #34257. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35056 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 16:10:44 +00:00
Drew Jaynes 4d967258f2 Docs: Adjust documentation for the $size parameter in get_image_send_to_editor() to clarify the required order of width and height values when passing an array.
Also adds the `array` type to the parameter documentation (already supported).

See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35055 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 16:07:25 +00:00
Sergey Biryukov d58bcae1ad Media: Return early from media_sideload_image() if $file didn't match the pattern for images.
Props MikeHansenMe, serpent7776.
Fixes #32755.

git-svn-id: https://develop.svn.wordpress.org/trunk@34984 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-09 04:46:00 +00:00
Scott Taylor bb2c59c3a8 Media: in wp_read_video|audio_metadata(), set GETID3_TEMP_DIR to get_temp_dir() if it is not defined. This is a workaround for when safe_mode is enabled pre-PHP 5.3.
Props chriscct7, tomsommer.
Fixes #26265.


git-svn-id: https://develop.svn.wordpress.org/trunk@34866 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-06 14:13:49 +00:00
Drew Jaynes e9e26c5726 Docs: Add missing DocBlock summaries for a multitude of functions in wp-admin/includes/media.php.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34823 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-05 02:43:49 +00:00
Scott Taylor ed7d34cb13 Pass false as the 2nd argument to class_exists() to disable autoloading and to not cause problems for those who define __autoload().
Fixes #20523.


git-svn-id: https://develop.svn.wordpress.org/trunk@34348 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 03:51:55 +00:00
Scott Taylor 337c87e7c7 Media: In get_image_send_to_editor(), allow a custom value for $rel.
Props tychay.
Fixes #32074.


git-svn-id: https://develop.svn.wordpress.org/trunk@34259 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 05:45:31 +00:00
Scott Taylor c95d6b3ec8 Use get_attached_file() in attachment_submitbox_metadata().
Props kitchin.
Fixes #33386.


git-svn-id: https://develop.svn.wordpress.org/trunk@34171 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-15 04:17:38 +00:00