Commit Graph

39 Commits

Author SHA1 Message Date
Drew Jaynes (DrewAPicture)
39ba840e04 Add @access tags to constructor docblocks in list table classes.
See #28679. See [29459].


git-svn-id: https://develop.svn.wordpress.org/trunk@29460 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-10 02:21:56 +00:00
Drew Jaynes (DrewAPicture)
126147a877 Document default arguments for the WP_List_Table class. Also add referenced docblocks to extending class constructors.
Props mikejolley for the initial patch.
Fixes #28679. See #28298.


git-svn-id: https://develop.svn.wordpress.org/trunk@29459 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-10 02:17:14 +00:00
Drew Jaynes (DrewAPicture)
a84d50dfa3 Fix some words that aren't words.
See #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29454 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-09 19:29:37 +00:00
Scott Taylor
9b9b4a82da Mark WP_List_Table::bulk_actions()'s argument $which as optional for BC.
Fixes #29026.


git-svn-id: https://develop.svn.wordpress.org/trunk@29440 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 21:30:01 +00:00
Scott Taylor
e0083f398b Add screen reader text to list table date dropdown.
See #29026.


git-svn-id: https://develop.svn.wordpress.org/trunk@29433 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 19:43:17 +00:00
Scott Taylor
0653e60a5d Revert [29428] to avoid errors with Add Media for now.
See #29026.


git-svn-id: https://develop.svn.wordpress.org/trunk@29432 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 19:39:10 +00:00
Scott Taylor
adff7dfb8e Media Grid: add screen reader labels with more context to filters and bulk actions. Ditto for list view.
Props afercia.
Fixes #29026.


git-svn-id: https://develop.svn.wordpress.org/trunk@29428 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 05:19:14 +00:00
Scott Taylor
67ef6c5e18 WP_List_Table::items should be public, not protected. It is accessed in a subclass directly via wp_ajax_get_comments().
See [28493].
Fixes #29072.


git-svn-id: https://develop.svn.wordpress.org/trunk@29423 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 02:50:40 +00:00
Dominik Schilling (ocean90)
0e42ce2dc0 Add missing screen-reader-text CSS class in [29294].
see #28867.

git-svn-id: https://develop.svn.wordpress.org/trunk@29308 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-27 13:42:49 +00:00
Scott Taylor
ced3f94927 Adds <label>s to current page selector and bulk actions <select> field so that screen readers have an explicit label.
Props joedolson.
Fixes #28867.


git-svn-id: https://develop.svn.wordpress.org/trunk@29294 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 00:19:21 +00:00
Drew Jaynes (DrewAPicture)
6ddc1e5f6d Fix syntax for single- and multi-line comments in wp-admin-directory files.
See #28931.


git-svn-id: https://develop.svn.wordpress.org/trunk@29206 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 09:13:53 +00:00
Drew Jaynes (DrewAPicture)
8a5d825fac Fix a typo in the @access tag for WP_List_Table::__get().
Props joehoyle.
Fixes #28925. See #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29199 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 22:12:11 +00:00
Drew Jaynes (DrewAPicture)
1bf87b2c9e Fill out inline documentation for magic methods added to the WP_List_Table class in [28493], [28521], and [28524].
See #22234 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29148 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-13 23:54:15 +00:00
Scott Taylor
510ad2e1e9 Fix mismatches in access modifiers for WP_List_Table + subclasses.
Fixes #28843, #28879.


git-svn-id: https://develop.svn.wordpress.org/trunk@29137 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-13 22:08:22 +00:00
Dominik Schilling (ocean90)
33db0d4ff2 Lists View Switcher: Replace blank image with screen reader text.
props davidakennedy.
fixes #28871.

git-svn-id: https://develop.svn.wordpress.org/trunk@29133 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-13 11:04:21 +00:00
Scott Taylor
63cb20cc5a Repent for our original OOP sins and doc blocks as pertains to access modifiers in List Table + subclasses.
Props SergeyBiryukov.
See #28843 and [28583].


git-svn-id: https://develop.svn.wordpress.org/trunk@29118 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-12 03:26:40 +00:00
Drew Jaynes (DrewAPicture)
b1b454c7a0 Remove backticks on $post variables in some short parameter descriptions.
See [28653], [28654].
See #28388.


git-svn-id: https://develop.svn.wordpress.org/trunk@28976 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 19:27:54 +00:00
Sergey Biryukov
29aabd08a9 Prevent bulk actions from being performed when Filter button is clicked.
props jesin.
fixes #28555.

git-svn-id: https://develop.svn.wordpress.org/trunk@28916 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-30 01:09:25 +00:00
Sergey Biryukov
6719d08d2d Revert [28766].
see #28555.

git-svn-id: https://develop.svn.wordpress.org/trunk@28772 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-18 02:22:45 +00:00
Sergey Biryukov
63596d6868 Prevent bulk actions from being performed when Filter button is clicked.
props layotte.
fixes #28555.

git-svn-id: https://develop.svn.wordpress.org/trunk@28766 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 22:16:11 +00:00
Helen Hou-Sandi
3d9fc450b2 Grid view for the media library, first pass. This is alpha; expect imperfection. We will be iterating further.
props ericlewis, shaunandrews, wonderboymusic.
see #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@28682 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-05 22:00:24 +00:00
Scott Taylor
daecbc9659 Classes that have __set() also need __isset() and __unset().
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28524 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 06:51:35 +00:00
Scott Taylor
77c6420969 Some classes with __get() method also need __set().
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28521 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 06:31:00 +00:00
Scott Taylor
e43d2a73d8 Fix some hackificator odds and ends in wp-admin:
* `wp-activate.php` and `wp-admin/themes.php` don't need the closing PHP tag
* Switch single quotes for HTML attribute values to double in a few places
* Convert `include_once file.php` syntax to `include_once( 'file.php' )`
* Add access modifiers to methods/members in: `_WP_List_Table_Compat`, `Walker_Nav_Menu_Edit`, `Walker_Nav_Menu_Checklist`, `WP_Screen`, `Walker_Category_Checklist`
* `edit_user()` doesn't need to import the `$wpdb` global
* `wp_list_widgets()` doesn't need to import the `$sidebars_widgets` global
* switch/endswitch syntax is not supported in Hack
* A `<ul>` in `wp-admin/users.php` is unclosed

See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28500 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 05:03:44 +00:00
Scott Taylor
eef0d99ed8 hackificator doesn't like mixed quote styles in some generated HTML. The switch from single to double allows these files to be parsed.
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28497 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 01:58:28 +00:00
Scott Taylor
d6a3c2a0de Add access modifiers to methods and members of list table classes:
* `WP_List_Table` is the base class that implements `__get()` and `__call()` for BC
* Adds unit tests to confirm that subclasses properly inherit magic methods
* Add modifiers to subclasses: `WP_Links_List_Table`, `WP_Media_List_Table`, `WP_MS_Sites_List_Table`, `WP_MS_Themes_List_Table`, `WP_MS_Users_List_Table`, `WP_Plugin_Install_List_Table`, `WP_Plugins_List_Table`, `WP_Posts_List_Table`, `WP_Terms_List_Table`, `WP_Theme_Install_List_Table`, `WP_Themes_List_Table`

See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28493 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 01:16:16 +00:00
Scott Taylor
7c0e12f5c6 Eliminate use of extract() in WP_List_Table::pagination():
* Set variables instead of extracting `$this->_pagination_args`
* Weird: `$infinite_scroll` is only presently set in subclasses of `WP_List_Table` and never initialized otherwise. 		

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28389 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 05:26:34 +00:00
Scott Taylor
fac2faee93 Eliminate use of extract() in WP_List_Table::ajax_response():
* Extracting `$this->_args` is unnecessary since none of the variables produced are present in the method.
* `total_items` and `total_pages` can be read directly from `$this->_pagination_args`

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28387 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 05:13:09 +00:00
Scott Taylor
a2122e6f7b Eliminate use of extract() in WP_List_Table::display(). The method only needs to read singular from $this->_args. Extraction is unnecessary.
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28386 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 05:07:11 +00:00
Scott Taylor
555937dc43 In WP_List_Table::display_rows_or_placeholder(), the call to get_column_info() in unnecessary and unused. The call to get_column_count() immediately after makes the same call internally.
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28279 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 05:31:07 +00:00
Dominik Schilling (ocean90)
9e92a95ec5 Remove "Show" prefix from filter dropdowns, see #26743.
git-svn-id: https://develop.svn.wordpress.org/trunk@27626 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-19 22:12:13 +00:00
Sergey Biryukov
1a769c0e11 Remove duplicate description of WP_List_Table class.
props bravokeyl.
fixes #27346.

git-svn-id: https://develop.svn.wordpress.org/trunk@27502 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-11 16:22:44 +00:00
Andrew Ozz
88fecbeff9 Remove table cellspacing attribute from the admin, part-props MattyRob, fixes #22086.
git-svn-id: https://develop.svn.wordpress.org/trunk@27036 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-26 20:27:21 +00:00
Drew Jaynes
7c6dfbf0f8 Inline documentation for hooks in wp-admin/includes/class-wp-list-table.php.
Props miyauchi, kpdesign.
Fixes 25848.


git-svn-id: https://develop.svn.wordpress.org/trunk@26401 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-26 08:11:33 +00:00
Helen Hou-Sandi
9ac7b0ce32 Saner CSS for row actions - now we can just target .row-actions instead of both .row-actions and .row-actions-visible. CSS for .row-actions-visible remains for now due to usage in plugins. Visibility is controlled by toggling a .visible class. fixes #25403.
git-svn-id: https://develop.svn.wordpress.org/trunk@25592 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-24 01:53:08 +00:00
Drew Jaynes
8c8a0b990c Make the WP_List_Table::months_dropdown() query results filterable.
Introduces the `months_dropdown_results` filter.

Fixes #17022.


git-svn-id: https://develop.svn.wordpress.org/trunk@25556 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-21 18:34:26 +00:00
Helen Hou-Sandi
68f34a5d80 Add a class to the bulk actions wrapper div. props nofearinc. fixes #25197.
git-svn-id: https://develop.svn.wordpress.org/trunk@25509 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-19 21:00:02 +00:00
Scott Taylor
16ef2c2e36 Remove lingering instances of call time pass-by-reference, limited to instances of callable - use $this instead of &$this.
Props jdgrimes.
See #25160.



git-svn-id: https://develop.svn.wordpress.org/trunk@25254 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 16:33:50 +00:00
Andrew Nacin
b43712e0f7 New develop.svn.wordpress.org repository based on the old core.svn repository.
* All WordPress files move to a src/ directory.
 * New task runner (Grunt), configured to copy a built WordPress to build/.
 * svn:ignore and .gitignore for Gruntfile.js, wp-config.php, and node.js.
 * Remove Akismet external from develop.svn. Still exists in core.svn.
 * Drop minified files from src/. The build process will now generate these.

props koop.
see #24976.

and see http://wp.me/p2AvED-1AI.



git-svn-id: https://develop.svn.wordpress.org/trunk@25001 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-07 05:25:25 +00:00