Commit Graph

31 Commits

Author SHA1 Message Date
Gary Pendergast
8f95800d52 Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.



git-svn-id: https://develop.svn.wordpress.org/trunk@42343 602fd350-edb4-49c9-b593-d223f7449a82
2017-11-30 23:09:33 +00:00
Gary Pendergast
574821573a General: Fix some precision alignment formatting warnings.
The WPCS `WordPress.WhiteSpace.PrecisionAlignment` rule throws warnings for a bunch of code that will likely cause issues for `wpcbf`. Fixing these manually beforehand gives us better auto-fixed results later.

See #41057.



git-svn-id: https://develop.svn.wordpress.org/trunk@42228 602fd350-edb4-49c9-b593-d223f7449a82
2017-11-26 23:56:25 +00:00
Gary Pendergast
3b734f0e65 Editor: Add the replace_editor filter.
This filter allows the Core editor to be replaced by an entirely different editor (coughcoughGUTENBERGcough).

Props azaozz, who is supposed to be on sabbatical right now.
Fixes #42119.



git-svn-id: https://develop.svn.wordpress.org/trunk@41829 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-11 12:05:21 +00:00
Sergey Biryukov
26514215a7 Posts, Post Types: Use an existing string for "Invalid post type" error message.
Props ramiy.
Fixes #39171.

git-svn-id: https://develop.svn.wordpress.org/trunk@39756 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-10 02:40:00 +00:00
Dominik Schilling (ocean90)
206380180e Text Changes: Unify permission error messages.
The new format looks like "Sorry, you are not allowed to <action>.". This provides a consistent experience for all error messages related to missing permissions. It also reduces the number of similar strings and allows translators to provide a consistent style in their language.

Props ramiy, Presskopp.
Fixes #34521.

git-svn-id: https://develop.svn.wordpress.org/trunk@37914 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-29 15:15:40 +00:00
Dominik Schilling (ocean90)
7773a713c4 Posts: Fire a post_action_{$action} action for a custom post action request.
Props jfarthing84, Mte90, brianvan, sudar, DrewAPicture.
Fixes #27056.

git-svn-id: https://develop.svn.wordpress.org/trunk@37424 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-12 15:43:48 +00:00
Scott Taylor
eb6bdb59cd Dashboard: use the create_posts cap on the post type object when determining if the Quick Press widget can be displayed.
Props jim912, ocean90, chriscct7.
Fixes #25681.


git-svn-id: https://develop.svn.wordpress.org/trunk@35282 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 05:48:11 +00:00
Sergey Biryukov
68f5a79880 Respect the force_delete parameter of get_delete_post_link().
Previously, it only worked if `EMPTY_TRASH_DAYS` was disabled.

Props johnbillion, chriscct7.
Fixes #26832.

git-svn-id: https://develop.svn.wordpress.org/trunk@34794 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-03 01:49:52 +00:00
John Blackbourn
a923d36085 Remove the ability to view the post listing screen and post editing screen for post types with show_ui set to false. It is unexpected and unintended behaviour that this is allowed.
If your plugin or site does rely on this behaviour, the arguments that are passed to `register_post_type()` should be altered so that `show_ui` is `true`, and arguments such as `show_in_menu`, `show_in_nav_menus`, and `show_in_admin_bar` are `false`.

Fixes #33763
Props swissspidy, johnbillion


git-svn-id: https://develop.svn.wordpress.org/trunk@34177 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-15 10:26:22 +00:00
John Blackbourn
bdd42a0902 Set the secure flag on the wp-saving-post cookie when using HTTPS.
This cookie doesn't contain any sensitive information, but this change brings its behaviour in line with all other core cookies.

Fixes #31056


git-svn-id: https://develop.svn.wordpress.org/trunk@34027 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 22:41:08 +00:00
Scott Taylor
d7670b6a38 Move redirect_post() from wp-admin/post.php to wp-admin/includes/post.php.
See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34020 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 21:30:24 +00:00
Dominik Schilling (ocean90)
ad74207fa7 Heartbeat: Ensure post locks are released.
git-svn-id: https://develop.svn.wordpress.org/trunk@33542 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-03 21:11:35 +00:00
Sergey Biryukov
5a23543cc8 Merge duplicate strings related to Trash.
props pavelevap.
fixes #33133.

git-svn-id: https://develop.svn.wordpress.org/trunk@33431 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-26 22:47:05 +00:00
Gary Pendergast
7439dd7354 Capabilities: When creating an auto-draft, ensure that the current user still has permission to do so.
git-svn-id: https://develop.svn.wordpress.org/trunk@33357 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-22 04:01:53 +00:00
Konstantin Obenland
bfbdb6f0b2 Use get_default_comment_status() globally.
Also makes the filter name static and passes the post type for context.

Props valendesigns.
Fixes #31168.



git-svn-id: https://develop.svn.wordpress.org/trunk@33054 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 22:31:58 +00:00
Scott Taylor
ec5758225c Add missing doc blocks to wp-admin/includes/*.
Fix some egregious uses of tabbing.
Some functions can simply return `apply_filters(...)` instead of setting a variable that is immediately returned.

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32654 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 20:16:22 +00:00
Scott Taylor
23ce2efd12 Add @global annotations for wp-admin/*.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32642 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-28 21:40:27 +00:00
Scott Taylor
78bab0c4eb When adding post_type to $sendback in wp-admin/post.php, use add_query_arg() instead of string concatenation.
Props podpirate.
Fixes #31492.


git-svn-id: https://develop.svn.wordpress.org/trunk@31633 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-05 22:30:32 +00:00
Scott Taylor
77cffd8edf Admin globals:
* Declare `$wp_importers` as a global in `admin.php`
* Declare `$post_type`, `$post_type_object`, and  `$post` as globals where applicable

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31121 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-10 05:28:46 +00:00
Andrew Ozz
0f83364811 Autosave: prevent setting multiple stale wp-saving-post-* cookies when the browser disregards "session cookies" expiration on quit:
- Add expiration time of 24 hours for these cookies.
- Rename them to `wp-saving-post` (no post_id) so there is never more than one cookie per domain.
Fixes #29294.

git-svn-id: https://develop.svn.wordpress.org/trunk@29572 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-22 00:24:56 +00:00
Scott Taylor
0f9b925ed5 In wp-admin/post.php, break is unreachabled after exit.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28312 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:14:16 +00:00
Helen Hou-Sandi
352e5c61cd Avoid an undefined function due to /wp-admin/includes/dashboard.php being included too late. props obenland. fixes #27457.
git-svn-id: https://develop.svn.wordpress.org/trunk@27630 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-20 01:30:49 +00:00
Andrew Ozz
9aba880b53 Autosave: refactor autosave.js, use heartbeat for transport and move all "Add/Edit Post" related functionality to post.js. See #25272.
git-svn-id: https://develop.svn.wordpress.org/trunk@26995 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 04:55:37 +00:00
Andrew Nacin
d375be7148 Don't let Quick Draft ignore default comment_status and ping_status.
props kovshenin.
fixes #26722.


git-svn-id: https://develop.svn.wordpress.org/trunk@26959 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-16 20:23:21 +00:00
Drew Jaynes
0cf54f5344 Inline documentation for hooks in wp-admin/post.php.
Props nukaga, kpdesign.
Fixes #25846.


git-svn-id: https://develop.svn.wordpress.org/trunk@26399 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-26 07:43:02 +00:00
Sergey Biryukov
dfd8f30724 PHPDoc and i18n fixes for dashboard widgets.
props dimadin for initial patch.
see #25824.

git-svn-id: https://develop.svn.wordpress.org/trunk@26241 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-17 03:20:38 +00:00
Andrew Nacin
b05fb903ac Revert these action blocks in wp-admin/post.php to their pre-[26144] state.
see #25824.


git-svn-id: https://develop.svn.wordpress.org/trunk@26231 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-15 22:28:57 +00:00
Andrew Nacin
f000be8af3 More dash updates.
* Shuffle around some pixels.
 * Rename some things that weren't caught in [26220].
 * Revert default-widgets.php change from [26144].
props lessbloat.
see #25824.


git-svn-id: https://develop.svn.wordpress.org/trunk@26230 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-15 22:22:43 +00:00
Andrew Nacin
3b82749eba Merge the new dashboard design into core.
Merges https://github.com/growthdesigner/wp-dash.

props lessbloat, joen, helen, dbernar1, kraftbj, ryelle, tillkruess, grapplerulrich, markjaquith.
see #25824.


git-svn-id: https://develop.svn.wordpress.org/trunk@26144 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-13 22:08:47 +00:00
Andrew Nacin
8d72ad52ff Don't rely on include_path to include files.
Always use dirname() or, once available, ABSPATH.

props ketwaroo, hakre.
fixes #17092.


git-svn-id: https://develop.svn.wordpress.org/trunk@25616 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-25 00:17:40 +00:00
Andrew Nacin
b43712e0f7 New develop.svn.wordpress.org repository based on the old core.svn repository.
* All WordPress files move to a src/ directory.
 * New task runner (Grunt), configured to copy a built WordPress to build/.
 * svn:ignore and .gitignore for Gruntfile.js, wp-config.php, and node.js.
 * Remove Akismet external from develop.svn. Still exists in core.svn.
 * Drop minified files from src/. The build process will now generate these.

props koop.
see #24976.

and see http://wp.me/p2AvED-1AI.



git-svn-id: https://develop.svn.wordpress.org/trunk@25001 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-07 05:25:25 +00:00