Commit Graph

1591 Commits

Author SHA1 Message Date
Scott Taylor
8bb3b642ec Add missing access modifiers to methods/members in WP_Customize_*.
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28509 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 05:44:49 +00:00
Scott Taylor
ddce296dd3 Add access modifier to methods/members in WP_Ajax_Response. Adds a magic __get() method for BC.
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28508 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 05:40:11 +00:00
Scott Taylor
4a5a7cb88a Add access modifier to methods/members in WP_oEmbed. Adds a magic __call() method for BC.
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28507 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 05:36:38 +00:00
Scott Taylor
0d5768f0f4 Add access modifier to methods of HTTP classes. There are no new private or protected methods, so no need for __call().
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28506 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 05:33:08 +00:00
Scott Taylor
8c2ccf6d7c Add access modifiers to methods/members in WP_Feed_Cache, WP_SimplePie_File, and WP_Feed_Cache_Transient.
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28505 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 05:26:48 +00:00
Scott Taylor
1d13dc8a85 Add access modifiers to methods/members in Walker_Category and Walker_CategoryDropdown.
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28504 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 05:22:38 +00:00
Scott Taylor
599dff5c3d Add access modifiers to methods/members in WP_Roles. Add a magic __call() method for BC.
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28503 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 05:19:36 +00:00
Scott Taylor
241d1a4d99 Add access modifiers to methods/members in WP_Object_Cache. Add a magic __get() method for BC.
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28502 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 05:15:20 +00:00
Scott Taylor
b185ac51b2 In wp_list_bookmarks(), $categorize should now be $r['categorize].
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28501 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 05:10:45 +00:00
Scott Taylor
e43d2a73d8 Fix some hackificator odds and ends in wp-admin:
* `wp-activate.php` and `wp-admin/themes.php` don't need the closing PHP tag
* Switch single quotes for HTML attribute values to double in a few places
* Convert `include_once file.php` syntax to `include_once( 'file.php' )`
* Add access modifiers to methods/members in: `_WP_List_Table_Compat`, `Walker_Nav_Menu_Edit`, `Walker_Nav_Menu_Checklist`, `WP_Screen`, `Walker_Category_Checklist`
* `edit_user()` doesn't need to import the `$wpdb` global
* `wp_list_widgets()` doesn't need to import the `$sidebars_widgets` global
* switch/endswitch syntax is not supported in Hack
* A `<ul>` in `wp-admin/users.php` is unclosed

See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28500 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 05:03:44 +00:00
Drew Jaynes (DrewAPicture)
f228c5b16e Improve inline documentation of default arguments for the_title_attribute().
See #28298.


git-svn-id: https://develop.svn.wordpress.org/trunk@28498 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 02:27:08 +00:00
Scott Taylor
1b4e4e665a hackificator complains if you call include 'file.php' without the parens, needs to be include( 'file.php' )
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28479 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-18 20:51:44 +00:00
Drew Jaynes (DrewAPicture)
b5fdb2dc06 Improve inline documentation for default arguments in wp_get_archives().
See #28298.


git-svn-id: https://develop.svn.wordpress.org/trunk@28476 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-18 17:19:56 +00:00
Scott Taylor
5eecd2e62b Eliminate the use of extract() in MO::import_from_reader().
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28472 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-17 17:20:26 +00:00
Scott Taylor
7205796cec Eliminate the use of extract() in get_pages().
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28471 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-17 17:11:23 +00:00
Scott Taylor
b76a0d791b Eliminate the use of extract() in wp_insert_attachment().
`wp_insert_attachment()` and `wp_insert_post()` are incredibly similar, but have branched logic. I have annotated many places where they diverge.

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28470 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-17 16:53:44 +00:00
Scott Taylor
9787ea4e2a Eliminate the use of extract() in wp_insert_post().
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28469 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-17 15:52:11 +00:00
Scott Taylor
ff8ae69fce Eliminate the use of extract() in wp_delete_term().
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28466 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-17 14:54:03 +00:00
Scott Taylor
06c87f681a Eliminate the use of extract() in get_terms().
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28465 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-17 14:46:07 +00:00
Scott Taylor
02066d4241 Eliminate the use of extract() in wp_insert_term().
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28464 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-17 14:15:40 +00:00
Scott Taylor
b1b30ad58c Eliminate use of extract() in wp_update_term().
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28461 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 21:28:05 +00:00
Scott Taylor
54bc77cb93 The cache key for comments in WP_Comment_Query::query() needs to do wp_array_slice_assoc( $this->query_vars, array_keys( $defaults ) ) instead of compact( array_keys( $defaults ) ). The latter assumes all of those variables are still floating around.
See #22400.



git-svn-id: https://develop.svn.wordpress.org/trunk@28460 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 21:08:15 +00:00
Scott Taylor
cb3341c03d (ACTUALLY) Eliminate use of extract() in WP_Comment_Query::query().
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28459 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 20:51:23 +00:00
Scott Taylor
8d22270bc1 Eliminate use of extract() in WP_Comment_Query::query().
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28458 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 19:32:05 +00:00
Scott Taylor
59f8ba6c9e Eliminate use of extract() in wp_insert_comment().
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28457 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 18:51:41 +00:00
Andrew Ozz
6fa89637e5 DFW: fix closing only the wpLink or media modal when pressing Esc.
git-svn-id: https://develop.svn.wordpress.org/trunk@28455 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 18:16:59 +00:00
Scott Taylor
0d92bb2552 Eliminate use of extract() in wp_insert_user().
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28454 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 18:15:00 +00:00
Scott Taylor
61d2e52e4b In wp_xmlrpc_server::mw_editPost, also set $post_type = $postdata['post_type'].
See #22400, [28448].



git-svn-id: https://develop.svn.wordpress.org/trunk@28453 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 18:05:21 +00:00
Scott Taylor
8a25c0ea1e Eliminate use of extract() in wp_widget_rss_form().
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28449 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 15:37:53 +00:00
Scott Taylor
cf3574516a Eliminate use of extract() in wp_xmlrpc_server::mw_editPost() (MetaWeblog API, y'all).
A lot of the extracted variables are overwritten by being explicitly set later. 
Only set variables that would otherwise not be present with `compact()` is called.

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28448 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 15:18:17 +00:00
Sergey Biryukov
4585195977 Filter out empty and duplicate values in Comment Moderation and Comment Blacklist settings.
props GaVrA.
fixes #23800.

git-svn-id: https://develop.svn.wordpress.org/trunk@28444 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 11:09:28 +00:00
Sergey Biryukov
6100833f0c DFW: Properly handle Esc key when the content is focused or when switching browser tabs.
props avryl.
fixes #28279.

git-svn-id: https://develop.svn.wordpress.org/trunk@28443 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 10:42:03 +00:00
Sergey Biryukov
e76bfbefbd Don't include caption tags in gallery template when there is no caption.
props avryl.
fixes #28089.

git-svn-id: https://develop.svn.wordpress.org/trunk@28442 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 21:02:04 +00:00
Scott Taylor
ae938f524e Eliminate use of extract() in wp_get_object_terms().
There are 3 properties, just set them to variables. They are used too often to warrant a refactor.

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28441 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 19:57:57 +00:00
Scott Taylor
1b93413580 Eliminate use of extract() in wp_widget_rss_output().
Add `'items' => 0` to `$default_args`. When `0`, the value is set to `10` (the fallback). 
Every other default arg has a default value of `0`.

`items` is expected to always be passed to this function.

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28440 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 19:41:41 +00:00
Scott Taylor
ce6f3de8ff Eliminate use of extract() in WP_Widget_RSS::widget().
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28439 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 19:35:31 +00:00
Scott Taylor
5c28e2986c In Walker_Category::start_el(), $title might not be set when $args are passed multiple levels into walk_category_tree().
See #22400.



git-svn-id: https://develop.svn.wordpress.org/trunk@28438 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 19:13:45 +00:00
Scott Taylor
ce5a31cd62 Eliminate use of extract() in wp_allow_comment().
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28437 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 18:09:09 +00:00
Scott Taylor
737ad1a878 Eliminate use of extract() in Walker_Category::start_el().
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28436 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 17:57:13 +00:00
Scott Taylor
cc64187e28 Eliminate use of extract() in wp_generate_tag_cloud().
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28435 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 17:47:21 +00:00
Scott Taylor
7793a90fd1 Eliminate use of extract() in wp_list_categories().
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28434 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 17:27:18 +00:00
Scott Taylor
812493f259 Eliminate use of extract() in default-widgets.php.
Props rzen, wonderboymusic.

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28433 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 16:32:18 +00:00
Scott Taylor
29efc53b6a Eliminate use of extract() in wp_dropdown_categories().
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28432 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 15:47:43 +00:00
Scott Taylor
4aa28e9cdc Eliminate use of extract() in get_comment_reply_link().
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28431 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 15:34:37 +00:00
Scott Taylor
7d8a053aeb Eliminate use of extract() in WP_Ajax_Response::add(). Just set most of the properties to variables to avoid interpolation churn.
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28430 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 15:24:21 +00:00
Scott Taylor
e06aa222ea Eliminate the use of extract() in get_post_reply_link().
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28429 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 06:48:16 +00:00
Scott Taylor
2a5a75e6d3 Eliminate the use of extract() in wp_list_comments(). All unit tests pass.
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28428 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 06:42:19 +00:00
Scott Taylor
95394c6e7e Eliminate the use of extract() in wp_update_comment(). All unit tests pass.
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28427 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 06:36:17 +00:00
Scott Taylor
bb4ea7ae3f Eliminate the use of extract() in wp_check_filetype_and_ext().
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28426 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 06:21:51 +00:00
Scott Taylor
6dd449551e Eliminate the use of extract() in wp_mail(). Check the filtered array for each value before re-setting variables.
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28425 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 06:16:34 +00:00