Commit Graph

168 Commits

Author SHA1 Message Date
Scott Taylor
186a94fb78 More-specific docs for wp_embed_handler_youtube().
Fixes #30711.


git-svn-id: https://develop.svn.wordpress.org/trunk@31018 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-01 19:20:44 +00:00
Scott Taylor
be8211beac Support chromeless Vimeo via MEjs:
* Bump MediaElement script loader versions to 2.16.2 - missed in [30634], oops!
* Add `Froogaloop` to `js/mediaelement` scripts for Vimeo
* Check for Vimeo in the same locations that YouTube is checked
* Dynamically load Froogaloop script in admin when editing a TinyMCE view
* Edit MediaElement to call `mejs.$.extend` instead of `$.extend` in `mejs.HtmlMediaElementShim.createPlugin()`, since `$` is not available via WP's jQuery (I will report this upstream):
6f9a78e008/src/js/me-shim.js (L631)

Fixes #29267.


git-svn-id: https://develop.svn.wordpress.org/trunk@31016 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-31 20:40:05 +00:00
Scott Taylor
218dd4fd6b For clarity, initialize some arrays that previously were only assigned via short circuit in loops.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30982 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 22:46:53 +00:00
Scott Taylor
0632a3de68 Improve various @param docs.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30674 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 23:23:37 +00:00
Scott Taylor
35708f61f8 Use round() instead of floor() when resizing image dimensions.
Updates unit tests.

Props SergeyBiryukov, kitchin.
Fixes #18532.


git-svn-id: https://develop.svn.wordpress.org/trunk@30660 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 19:53:18 +00:00
Drew Jaynes (DrewAPicture)
e587324180 Docs Formatting: Backtick-escape inline code for all remaining dynamic hook docs in wp-includes/*.
Affects DocBlocks for the following hooks:
* `auth_post_meta_{$meta_key}`
* `term_links-$taxonomy`
* `customize_render_control_ . $this->id`
* `customize_render_panel_{$this->id}`
* `customize_render_section_{$this->id}`
* `customize_preview_{$this->id}`
* `customize_save_ . $this->id_data[ 'base' ]`
* `customize_update_ . $this->type`
* `customize_value_ . $this->id_data[ 'base' ]`
* `customize_sanitize_js_{$this->id}`
* `comment_form_field_{$name}`
* `comment_{$old_status}_to_{$new_status}`
* `comment_{$new_status}_{$comment->comment_type}`
* `extra_{$context}_headers`
* `get_template_part_{$slug}`
* `get_the_generator_{$type}`
* `get_{$adjacent}_post_join`
* `get_{$adjacent}_post_where`
* `get_{$adjacent}_post_sort`
* `{$adjacent}_post_rel_link`
* `{$adjacent}_post_link`
* `{$adjacent}_image_link`
* `blog_option_{$option}`
* `$permastructname . _rewrite_rules`
* `{$type}_template`
* `theme_mod_{$name}`
* `pre_set_theme_mod_$name`
* `current_theme_supports-{$feature}`
* `get_user_option_{$option}`
* `edit_user_{$field}`
* `pre_user_{$field}`
* `user_{$field}`

See #30552.


git-svn-id: https://develop.svn.wordpress.org/trunk@30656 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 12:09:56 +00:00
Drew Jaynes (DrewAPicture)
1f66186c4a Improve inline documentation for image_constrain_size_for_editor().
Includes:
* Proper formatting, plus adding a type for the `$context` parameter
* Inline `@see` tags in the description and backtick-escaping inline code
* Parameter, type, and description alignment

Props tillkruess for the initial patch.
Fixes #30508.


git-svn-id: https://develop.svn.wordpress.org/trunk@30646 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 10:05:26 +00:00
Scott Taylor
b59b9f466a Fix edge-case in media cropping where selection and destination are the same size.
Adds unit tests.

Props mboynes.
Fixes #19793.


git-svn-id: https://develop.svn.wordpress.org/trunk@30639 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 06:26:26 +00:00
Drew Jaynes (DrewAPicture)
2afe26faa5 Remove an invalid parameter from the DocBlock for the gallery_style hook.
Props keesiemeijer.
Fixes #30507.


git-svn-id: https://develop.svn.wordpress.org/trunk@30635 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 05:57:43 +00:00
Drew Jaynes (DrewAPicture)
7c421791c2 Remove return descriptions from the DocBlocks for add_image_size() and set_post_thumbnail_size() as they don't return anything.
Also document the `$_wp_additional_image_sizes` global, leveraged in `add_image_size()`.

Props stevegrunwell.
Fixes #30511.


git-svn-id: https://develop.svn.wordpress.org/trunk@30633 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 05:48:03 +00:00
Drew Jaynes (DrewAPicture)
9a9489db7f Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Markdown-indent a code snippet in the file header for wp-admin/install-helper.php
* Add markdown formatting and two inline `@see` tags to the description for `translate()`
* Markdown-indent a code snippet in the description for `_n_noop()`
* Remove HTML tags from the summary for `get_media_embedded_in_content()`
* Remove an HTML tag from the summary for `wpview_media_sandbox_styles()`

Props rarst.
See #30473.


git-svn-id: https://develop.svn.wordpress.org/trunk@30542 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 05:46:04 +00:00
Sergey Biryukov
917a469052 Replace invalid use of ltrim() in attachment_url_to_postid() with substr().
props bradyvercher.
fixes #30346.

git-svn-id: https://develop.svn.wordpress.org/trunk@30501 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-21 06:34:23 +00:00
Andrew Nacin
912dbf3fd0 Playlists are video by default. props duck_
git-svn-id: https://develop.svn.wordpress.org/trunk@30422 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-20 13:10:45 +00:00
Dominik Schilling (ocean90)
437d90710d Media: Remove another unused string.
props pavelevap.
see #29741.

git-svn-id: https://develop.svn.wordpress.org/trunk@30342 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-14 17:45:39 +00:00
Dominik Schilling (ocean90)
fd6bf722b7 Media: Remove unused string.
props pavelevap.
fixes #29741.

git-svn-id: https://develop.svn.wordpress.org/trunk@30341 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-14 17:30:57 +00:00
Scott Taylor
3663a276f1 In wp_audio|video_shortcode(), make sure that autoplay and loop are booleans. Passing 'false' to them will force them to be active, which is bad.
Fixes #29825.


git-svn-id: https://develop.svn.wordpress.org/trunk@30185 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:02:18 +00:00
Scott Taylor
143d248292 In gallery_shortcode(), when the link attribute is equal to file, make sure to pass $attr as the 6th (!) argument, not 5th, to wp_get_attachment_link().
Props bradyvercher.
Fixes #27402.


git-svn-id: https://develop.svn.wordpress.org/trunk@30161 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 21:46:51 +00:00
Drew Jaynes (DrewAPicture)
7cd15026bd Correct references of @uses $wpdb in core documentation to use @global.
See #30191, [30105].
Fixes #30217.


git-svn-id: https://develop.svn.wordpress.org/trunk@30122 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-31 17:55:39 +00:00
Drew Jaynes (DrewAPicture)
3cc10d77a0 Remove redundant and erroneous @uses tag from most core inline documentation.
Per our inline documentation standards, no further use of the `@uses` tag is recommended as used and used-by relationships can be derived through other means. This removes most uses of the tag in core documentation, with remaining tags to be converted to `@global` or `@see` as they apply.

Fixes #30191.


git-svn-id: https://develop.svn.wordpress.org/trunk@30105 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-30 01:04:55 +00:00
Scott Taylor
e6bbbb3db9 Don't hardcode height for videos - this was a workaround for MediaElement internals causing problems. Responsive videos now work properly and don't cause extra whitespace.
Fixes MediaElement by hand in the interim: https://github.com/johndyer/mediaelement/pull/1337
Video playlists were completely broken by this.

Fixes #30078.



git-svn-id: https://develop.svn.wordpress.org/trunk@30082 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 00:46:15 +00:00
Scott Taylor
74ed2089b4 The gallery shortcode used to accept a SQL chunk for the value of the orderby attribute. The reason? get_posts() used to be called in the shortcode handler with a query-string blob of arguments passed to it. To mitigate breakage, sanitize_sql_orderby() was created in [7592].
`sanitize_sql_orderby()` expects a comma to be present when multiple `orderby` values were passed. The correct syntax for multiple fields is space-delimited. Since [29027], comma-separated values would never be parsed correctly when passed to `WP_Query->parse_orderby()`.

`sanitize_sql_orderby()` is used nowhere else in core, save for the `playlist` shortcode - I only added it there because I was mimic'ing the `gallery` logic. The function call can be removed from both shortcode handlers.
 
See #6476.
Fixes #23873.


git-svn-id: https://develop.svn.wordpress.org/trunk@30068 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 20:42:20 +00:00
Gary Pendergast
0e68ecc0b6 Add wp_json_encode(), a wrapper for json_encode() that ensures everything is converted to UTF-8.
Change all core calls from `json_encode()` to `wp_json_encode()`.

Fixes #28786.



git-svn-id: https://develop.svn.wordpress.org/trunk@30055 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 18:34:16 +00:00
Scott Taylor
076c7e8902 Add a 6th (!) attribute to wp_get_attachment_link() to allow aria-describedby to be added to gallery output.
Props joedolson, DrewAPicture, rianrietveld.
Fixes #27402.


git-svn-id: https://develop.svn.wordpress.org/trunk@29914 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-16 04:27:07 +00:00
Sergey Biryukov
4ba75673d8 Update @param docs for wp_get_attachment_image().
see #29869.

git-svn-id: https://develop.svn.wordpress.org/trunk@29837 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-05 17:51:42 +00:00
Sergey Biryukov
a21e5041dd Pass the requested size to 'wp_get_attachment_image_attributes' filter.
props mattheu.
fixes #29869.

git-svn-id: https://develop.svn.wordpress.org/trunk@29836 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-05 17:49:32 +00:00
Andrew Ozz
3b757232d0 Media: disable multi-file uploading in iOS 7.x Safari as it prevents uploading of videos. Fixes #29602 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@29776 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 00:13:47 +00:00
Sergey Biryukov
fe6f5b3af3 Add context for 'Trash' string in media modal.
props pavelevap.
fixes #29739.

git-svn-id: https://develop.svn.wordpress.org/trunk@29764 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-24 13:48:27 +00:00
Scott Taylor
0b0eb4fb20 Ordering by RAND():
The shortcode callbacks for `gallery` and `playlist` check for `'RAND' == $atts['order']`, which isn't a valid value for `order`. Remove those checks and update the docs.

In `WP_Query`, if the value of `orderby` is `rand`, `order` is irrelevant and should be unset.

Adds unit tests.

Fixes #29629.


git-svn-id: https://develop.svn.wordpress.org/trunk@29760 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-23 03:51:24 +00:00
Sergey Biryukov
5b2c58d5b3 Correct 'wp_get_attachment_image_attributes' filter docs.
props tillkruess.
fixes #29701.

git-svn-id: https://develop.svn.wordpress.org/trunk@29750 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-18 12:35:25 +00:00
Andrew Ozz
123fae73b5 Media: revert enabling of multi-file uploading for mobile devices. Currently only iOS Safari supports it but has a bug that prevents uploading of videos. Fixes #29602
git-svn-id: https://develop.svn.wordpress.org/trunk@29729 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-10 22:39:39 +00:00
Sergey Biryukov
00bfc5bc34 Avoid PHP notices in media modal caused by orphaned attachments.
fixes #29566 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@29724 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-09 10:02:36 +00:00
Andrew Nacin
896bbfacae Media: Ensure media-views is enqueued and registered before localizing.
fixes #24724.


git-svn-id: https://develop.svn.wordpress.org/trunk@29678 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-02 19:35:35 +00:00
Andrew Ozz
4e846f9af7 Media: add a class to the <script> tag for the JSON encoded playlist data so it can be easily selected in WPPlaylistView. Props SergeyBiryukov, fixes #29383
git-svn-id: https://develop.svn.wordpress.org/trunk@29660 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-01 19:54:44 +00:00
Helen Hou-Sandi
14313673d5 Media grid: Don't show a misleading message for an empty library.
This uses the existing string from the list table. We should revisit a better overall experience for the two situations (empty library vs. search with no results) in 4.1.

props voldemortensen.
fixes #29404.


git-svn-id: https://develop.svn.wordpress.org/trunk@29655 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-01 18:38:35 +00:00
Scott Taylor
c88c4d4f21 MCE View sandboxes:
* Use a `MutationObserver` to listen to the `body` class of the parent editor frame.
* In `wpview_media_sandbox_styles()`, only return the MEjs stylesheets.
* In `wp_ajax_parse_media_shortcode()` and `wp_ajax_parse_embed()`, return an object instead of an HTML blob to allow passing `body` and `head` separately	

Props avryl, azaozz.
Fixes #29048.


git-svn-id: https://develop.svn.wordpress.org/trunk@29615 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-26 04:45:54 +00:00
Scott Taylor
097147c9b6 After [29543], the iframe sandboxes for media need to load Open Sans. Playlists look aggressively bad without it. Adds font styles for the body.
See #29048.


git-svn-id: https://develop.svn.wordpress.org/trunk@29564 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-21 03:35:11 +00:00
Andrew Ozz
5e838e6f4a TinyMCE wpView: add a filter for the stylesheet URLs loaded in the sandbox iframes. See #29048.
git-svn-id: https://develop.svn.wordpress.org/trunk@29559 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-20 21:33:56 +00:00
Andrew Ozz
d8fac44995 TinyMCE wpView sandbox iframes:
- Make them transparent.
- Don't load tons of unrelated styles that can break them. This could result in minimal styling mismatch to the front-end, but keeps the views working well and looking good.
Props avryl, fixes #29048.

git-svn-id: https://develop.svn.wordpress.org/trunk@29543 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-19 21:52:19 +00:00
Sergey Biryukov
97eb710697 Media Grid: Use an existing string for posts without a title.
see #24716.

git-svn-id: https://develop.svn.wordpress.org/trunk@29493 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-14 21:40:11 +00:00
Scott Taylor
d0441a6b42 Media Grid, support MEDIA_TRASH: add AYS to bulk actions.
See #29145.


git-svn-id: https://develop.svn.wordpress.org/trunk@29492 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-14 19:07:06 +00:00
Scott Taylor
8661fcf0d9 Media Grid, support MEDIA_TRASH:
* Add a setting to `_wpMediaViewsL10n.settings`: `mediaTrash`
* In the attachment edit modal, properly toggle between Trash/Untrash
* In `media.view.Attachment`, add a method for `untrashAttachment`
* When creating the grid toolbar, switch the setting order of subviews so that `media.view.DeleteSelectedButton` can listen to the instance of `media.view.AttachmentFilters.All` to update the text in its UI.
* Add a new filter to `media.view.AttachmentFilters.All`, `trash`, when `settings.mediaTrash` is true
* Allow the cached queries in `Query.get()` to be flushed when race conditions exist and collections need to be refreshed. This is currently only being used when `MEDIA_TRASH` is set, to refresh the filtered/mirrored collections related to `all`, `trash`, and any already queried filter.
* Cleanup the bootstrapping of `media.view.MediaFrame.Manage`
* Allow `wp_ajax_query_attachments()` to return items from the trash when `MEDIA_TRASH` is `true`
* Allow `wp_ajax_save_attachment()` to set `post_status` when `MEDIA_TRASH` is `true`. It allows `wp_delete_post()` to be called, which will trash the attachment instead of deleting when the flag is set.

Props koop for the knowledge sharing and thought partnership.
See #29145.


git-svn-id: https://develop.svn.wordpress.org/trunk@29490 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-14 18:30:49 +00:00
Helen Hou-Sandi
cc51f62262 Remove now-unused strings. see #28842.
git-svn-id: https://develop.svn.wordpress.org/trunk@29486 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-14 04:22:34 +00:00
Scott Taylor
3ed9e02d0b Media Grid: add Bulk Selection mode for deleting attachments.
* Toolbar is sticky when `select` mode is active
* Selection is toggled when clicking an attachment preview
* Unselected attachments fade out, selected fade in.

See #28842.


git-svn-id: https://develop.svn.wordpress.org/trunk@29484 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-13 22:44:48 +00:00
Scott Taylor
e23c1ae3ff Upgrade MediaElement to 2.15.0:
* It is required to set `height` on the parent `.wp-video` wrapper for video
* Fixes the play button hover problem in Chrome
* Includes my pull request: https://github.com/johndyer/mediaelement/pull/1273

All changes:
https://github.com/johndyer/mediaelement/compare/2.14.2...master

See #29110.


git-svn-id: https://develop.svn.wordpress.org/trunk@29457 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-09 20:43:25 +00:00
Scott Taylor
45368dbfaa Video:
* Don't set height on responsive `<div>` when generating markup
* Move some CSS rules from the style tag to `.wp-video`
* Use Video Details view event delegation instead of click events delegated from `<body>`
* Fix some CSS rule collision in the grid modal

See #29110.


git-svn-id: https://develop.svn.wordpress.org/trunk@29456 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-09 19:38:40 +00:00
Drew Jaynes (DrewAPicture)
8feaba4ca2 Clean up some missing @access tags and other tweaks for 4.0.0-functionality docs.
See #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29455 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-09 19:31:35 +00:00
Scott Taylor
dc74104c21 Media Grid:
* Use a `media.view.Label` instance in the toolbar for the screen reader text for the "all" dropdown.
* Adjust the spinner's priority.

Fixes #29026.


git-svn-id: https://develop.svn.wordpress.org/trunk@29438 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 21:00:45 +00:00
Scott Taylor
7b95dc861b Media Grid: use a media.view.Label instance in the toolbar for the screen reader text for Search.
See #29026.


git-svn-id: https://develop.svn.wordpress.org/trunk@29437 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 20:53:03 +00:00
Scott Taylor
42c1f07705 Media Grid: add screen reader text in a subview on the toolbar, a media.view.Label instance before media.view.DateFilter.
See #29026.


git-svn-id: https://develop.svn.wordpress.org/trunk@29435 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 20:24:25 +00:00
Scott Taylor
b0d1b8b433 Create a new Backbone view, media.view.Label, which can be used as a subview in things like toolbars, which need screen reader text.
Make an initial instance of it for the label for Bulk Actions in Media Grid.

See #29026.


git-svn-id: https://develop.svn.wordpress.org/trunk@29434 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 20:08:18 +00:00