Commit Graph

1453 Commits

Author SHA1 Message Date
Sergey Biryukov
47e38ea2e9 Accessibility: Administration: Correct active button color for the alternative color schemes.
Follow-up to [46815].

Props melchoyce, ryelle, larrach, audrasjb, studiotwee, afercia, azaozz.
Fixes #48598.

git-svn-id: https://develop.svn.wordpress.org/trunk@46817 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-05 22:10:29 +00:00
Sergey Biryukov
94b37d4f90 Accessibility: Administration: Apply a unified design to all secondary buttons across all color schemes.
This ensures that secondary buttons have an appropriate color contrast in the alternative color schemes.

Props melchoyce, ryelle, audrasjb, ate-up-with-motor, afercia, sabernhardt.
Fixes #48585.

git-svn-id: https://develop.svn.wordpress.org/trunk@46815 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-05 21:30:58 +00:00
Sergey Biryukov
bf3295d10f Administration: Correct font size for comment count in "At a Glance" dashboard widget on mobile.
Props donmhico, jeremyfelt.
Fixes #48799.

git-svn-id: https://develop.svn.wordpress.org/trunk@46807 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-30 00:40:24 +00:00
Sergey Biryukov
10d5efa604 Administration: Properly wrap long titles in list tables on smaller screens.
Props mukesh27, iihglobal, wpamitkumar.
Fixes #48805.

git-svn-id: https://develop.svn.wordpress.org/trunk@46790 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-27 16:50:59 +00:00
SergeyBiryukov
dc486308e6 Accessibility: Administration: Underline links on Dashboard that are located within a line of text and thus need to be underlined:
* "change your theme completely"
* Active theme in the "At a Glance" box
* "View all drafts" in the Quick Draft box

Split "Manage widgets or menus" into separate items for consistency with other links.

For better accessibility, links that are a part of other text should be underlined and not rely on color alone to be distinguished.

Per accessibility coding standards:
> When links can be identified as such by the context, for example because they’re part of a menu, or a set of links clearly identified as user interface controls, they don’t necessarily need to be underlined. In all the other cases, especially for links surrounded by other text (in a line or block of text), links need to be always underlined.
https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/#links-underline-or-no-underline
https://make.wordpress.org/accessibility/handbook/design/use-of-color/#not-by-color-alone

Props afercia, audrasjb, karmatosed.
Fixes #48406.

git-svn-id: https://develop.svn.wordpress.org/trunk@46770 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-24 19:55:01 +00:00
Sergey Biryukov
206ea67257 Editor: Improve the appearance of tag cloud in Tags meta box in classic editor.
Props sathyapulse, Spaceshipone, tmatsuur, audrasjb, afercia.
Fixes #48592.

git-svn-id: https://develop.svn.wordpress.org/trunk@46758 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-22 00:02:12 +00:00
Sergey Biryukov
22eb74c67b Administration: Switch rgb() CSS property for paused plugin error message in Plugins list table to rgba().
While technically correct as is, the latter is more consistent with other admin styles and causes less confusion.

Props manikmist09.
Fixes #48629.

git-svn-id: https://develop.svn.wordpress.org/trunk@46744 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-18 13:16:54 +00:00
Sergey Biryukov
895ec7224b Help/About: Update the 5.3 About page.
* Remove extra padding on the Credits tab.

Previously [46556], [46572], [46616], [46705].
Props ryelle.
See #47708.

git-svn-id: https://develop.svn.wordpress.org/trunk@46709 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-11 20:43:48 +00:00
Sergey Biryukov
385d0794ae Help/About: Update the 5.3 About page.
* Remove the SVG from the upper right corner.
* Make sure admin notices that should be hidden stay hidden.
* Address a11y issues with contrast.
* Fix an issue with the active nav tab hover.
* Prevent names on the credits from breaking out of the box.
* Update two strings with a more accurate information.

Previously [46556], [46572], [46616].

Props ryelle, afercia, audrasjb, francina, mapk, desrosj, YordanSoares, melchoyce, azaozz, johnbillion, davidbaumwald, luminuu, bwmarkle, la-geek, SergeyBiryukov.
See #47708.

git-svn-id: https://develop.svn.wordpress.org/trunk@46705 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-11 16:05:39 +00:00
Sergey Biryukov
9b1fc27c3f Docs: Correct some inconsistencies in comments with Dashicon class references in wp-admin/css/customize-widgets.css.
Prepend all class name references with `dashicons-` for clarity.

Props 1naveengiri, marcio-zebedeu, hareesh-pillai, SergeyBiryukov.
Fixes #48417.

git-svn-id: https://develop.svn.wordpress.org/trunk@46681 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-09 00:01:40 +00:00
Jonathan Desrosiers
7d2bb9f8c6 Help/About: Update the 5.3 About page for RC3.
Previously [46556], [46572].
Props ryelle, SergeyBiryukov, afercia, desrosj, davidbaumwald, azaozz.
See #47708.

git-svn-id: https://develop.svn.wordpress.org/trunk@46616 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-29 20:08:32 +00:00
Andrea Fercia
5952a5dcf7 Accessibility: Restore the primary buttons original background color for alternate color schemes after [46241].
Props david.binda, audrasjb, azaozz.
See #34904.
Fixes #48396.


git-svn-id: https://develop.svn.wordpress.org/trunk@46575 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-23 20:55:31 +00:00
John Blackbourn
3cd121d5d7 Administration: Revert changes to the admin menu styles for long line lengths.
This reverts [46555], [46453], and [46332].

See #42201


git-svn-id: https://develop.svn.wordpress.org/trunk@46561 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-17 18:36:27 +00:00
Andrea Fercia
aa37e6e2f8 Script Loader: Partially revert [46550] as it brought in unrelated CSS changes.
[46550] was meant to revert [46440] but it also merged some unrelated CSS changes.

See #47069.


git-svn-id: https://develop.svn.wordpress.org/trunk@46559 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-16 17:47:28 +00:00
John Blackbourn
9d2aa0f442 Administration: Fix the appearance of update bubbles in submenus and when the admin menu is collapsed.
Props afercia, amolv, sabernhardt

Fixes #42201, #48294


git-svn-id: https://develop.svn.wordpress.org/trunk@46555 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-15 19:37:03 +00:00
Andrea Fercia
943320fa03 Accessibility: Script Loader: Remove jQuery as dependency of admin-bar after [46440].
A better approach needs to be explored, as there are valid concerns for potential conflicts between different jQuery versions added by themes or plugins.

See #47069.


git-svn-id: https://develop.svn.wordpress.org/trunk@46550 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-15 17:21:50 +00:00
Anthony Burchell
42493b7ed8 Administration: Prevents horizontal scroll jumping around while admin menu is open.
This sets the `#adminmenuback` `position` CSS property to `fixed`.

Props promz, man4toman.
Fixes #47010.


git-svn-id: https://develop.svn.wordpress.org/trunk@46460 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-11 19:20:43 +00:00
Jake Spurlock
c608c85b67 Administration: Ensure visual consistency with large titles in the sidebar.
Custom posts, and other menu titles that are long aren't wrapping correctly.

Props jagirbaheshwp, munyagu, harshbarach, hareesh-pillai, pratikkry, naveenkharwar, mukesh27, dushanthi, worldweb, audrasjb, afercia, amolv, iqbalbary, davidbaumwald.
Fixes #42201


git-svn-id: https://develop.svn.wordpress.org/trunk@46453 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-09 04:56:55 +00:00
Sergey Biryukov
af634cc62a Themes: Properly align Close/Previous/Next icons in theme preview overlay.
Props chetan200891.
Fixes #48248.

git-svn-id: https://develop.svn.wordpress.org/trunk@46444 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-08 19:05:13 +00:00
Sergey Biryukov
a15cc93479 Themes: Adjust CSS media query for theme overlay to match the breakpoint for a folded admin menu.
Props chetan200891.
Fixes #48250.

git-svn-id: https://develop.svn.wordpress.org/trunk@46443 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-08 18:47:18 +00:00
Andrea Fercia
5e943fad4a Accessibility: Improve and modernize user interface controls: Revert the new links focus style.
Thew new dotted outline for the links focus style introduced in [46241] doesn't appear to be ready to guarantee a good indication of focus.
It was agreed to restore the previous links focus style and postpone exploration for a new style to the next release cycle.
Partially reverts [46241] and [46293].

See #34904, #47153.


git-svn-id: https://develop.svn.wordpress.org/trunk@46425 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-07 19:55:58 +00:00
Andrea Fercia
ae8bef6419 Accessibility: Improve and modernize user interface controls: Improve the buttons active CSS class.
- improves the buttons `.active` CSS class for buttons that need to be styled as "pressed"
- update the alternate color schemes `.active` CSS class accordingly
- improves a few icons colors in the alternate color schemes

See #34904.


git-svn-id: https://develop.svn.wordpress.org/trunk@46423 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-07 18:45:45 +00:00
Andrea Fercia
c2ffe16248 Accessibility: Improve and modernize user interface controls for better contrast: Further improvements to input heights and alignments.
- improves input fields height in the customizer
- improves input fields height for Internet Explorer 11
- improves input fields height in the Image Editor
- improves alignment of selects and buttons in the privacy policy pages
- makes the search themes fields font-size consistent

Props garrett-eclipse, afercia.
See #47477.


git-svn-id: https://develop.svn.wordpress.org/trunk@46419 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-07 13:18:19 +00:00
Andrea Fercia
42ef147e5d Accessibility: Media: Improve the search media field labelling.
Visible `<label>` elements benefit all users. The `placeholder` attribute should not be used as a replacement for visible labels.
Instead, it's supposed to be used only for a short hint to aid users with data entry e.g. a sample value or a brief description of the expected format.

Screen readers may not announce a `placeholder` attribute at all. Other users may suffer from the lack of a visible label and a placeholder used as replacement, for example:

- users with cognitive disabilities may have trouble remembering what the filled field does
- speech recognition users cannot see the name they can speak to set focus on the field
- low-vision users with high text-size may not be able to see the whole placeholder even when it's visible, if its value is clipped by the edge of the input

Props anevins, audrasjb, karmatosed, azaozz, SergeyBiryukov, afercia.
See #40331.
Fixes #47138.


git-svn-id: https://develop.svn.wordpress.org/trunk@46418 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-07 12:41:50 +00:00
Jake Spurlock
de0efbb825 Administration: Add a max-width to the Privacy Policy Page dropdown.
If there's a page with an extra long title, the Privacy Policy page dropdown in Privacy Settings overflows the page width.

Fixes #47366
Props garrett-eclipse, SergeyBiryukov, mukesh27, desrosj, adhitya03, jalpa1984, nrqsnchz, paresh07.


git-svn-id: https://develop.svn.wordpress.org/trunk@46411 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-06 06:40:36 +00:00
Sergey Biryukov
f6357458f4 Taxonomy: Prevent Parent Category dropdown and field descriptions on Categories and Edit Category screens from extending beyond the other fields.
Props garrett-eclipse, dkarfa.
Fixes #48188.

git-svn-id: https://develop.svn.wordpress.org/trunk@46405 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-05 15:40:31 +00:00
Andrea Fercia
dc0b9dc2d3 Login and Registration: Hide the Edge browser "Reveal password" native button.
Props Clorith.
Fixes #42888.


git-svn-id: https://develop.svn.wordpress.org/trunk@46372 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-01 17:59:18 +00:00
Andrea Fercia
5ddfa37db0 Accessibility: Improve and modernize user interface controls for better contrast: Login screen improvements.
- allows the login input fields to better scale with text 
- improves the input fields layout on Internet Explorer 11
- uses the new focus style on the "Show password" button 
- adjusts the CSS for the interim login

See #47153.
See #42888.


git-svn-id: https://develop.svn.wordpress.org/trunk@46371 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-01 15:54:39 +00:00
Andrea Fercia
74f9cf79a0 Accessibility: Improve and modernize user interface controls: Improve new styles for the color picker.
Props audrasjb, garrett-eclipse.
Fixes #48131.


git-svn-id: https://develop.svn.wordpress.org/trunk@46360 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 18:04:59 +00:00
Anthony Burchell
4b152de517 Media: Prevents clipping of text when scaling image edit screen.
This reapplies [46354] clean as the previous commit had remnants of an unrelated patch.

Props sabernhardt, audrasjb, afercia.
See #47115.


git-svn-id: https://develop.svn.wordpress.org/trunk@46359 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 17:55:07 +00:00
Andrea Fercia
f93cd8ceea Accessibility: Improve and modernize user interface controls: Improve the new form controls styles and heights.
Improves cross-browsers rendering and addresses most of the reported edge cases.

See #47477.


git-svn-id: https://develop.svn.wordpress.org/trunk@46356 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 17:23:06 +00:00
Anthony Burchell
48564fa823 Media: Revert [46354] preventing bad clipping of text in image details page.
See #47115.


git-svn-id: https://develop.svn.wordpress.org/trunk@46355 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 17:11:14 +00:00
Anthony Burchell
32b7a5e076 Media: Prevents clipping of text when scaling image edit screen.
Props sabernhardt, audrasjb, afercia.
See #47115.


git-svn-id: https://develop.svn.wordpress.org/trunk@46354 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 16:33:39 +00:00
Andrea Fercia
9288beb7b5 Accessibility: Improve and modernize user interface controls: Remove the CSS transform 1 pixel shift from the buttons active state.
Props Joen.
See #34904.


git-svn-id: https://develop.svn.wordpress.org/trunk@46350 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 10:52:36 +00:00
Andrea Fercia
f00bceaa86 Accessibility: Improve and modernize user interface controls: Improve the radio buttons blue dot alignment.
Props desrosj, garrett-eclipse, afercia.
See #47498.


git-svn-id: https://develop.svn.wordpress.org/trunk@46345 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-29 21:55:51 +00:00
Andrea Fercia
ef206a787f Accessibility: Improve and modernize user interface controls: Make the secondary buttons border blue.
Props drw158, youknowriad, kjellr, melchoyce, talldanwp, audrasjb.
See #34904.


git-svn-id: https://develop.svn.wordpress.org/trunk@46344 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-29 21:52:38 +00:00
Andrea Fercia
d020b72508 Accessibility: After [46337]: make the select elements background white also on hover, active, and focus states.
See #47477.
See #48128.


git-svn-id: https://develop.svn.wordpress.org/trunk@46340 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-28 16:44:09 +00:00
Andrea Fercia
8408e42de9 Accessibility: Improve and modernize user interface controls. Style the select elements disabled state.
Props adhitya03, MarcosAlexandre, kjellr.
See #47477.
Fixes #48129.


git-svn-id: https://develop.svn.wordpress.org/trunk@46339 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-28 16:34:43 +00:00
Andrew Ozz
d47627d555 Fix the context (right-click) menu when clicking the placeholder for the post title field on the classic Edit Post screen.
Props masummdar, audrasjb, afercia.
Fixes #47318.

git-svn-id: https://develop.svn.wordpress.org/trunk@46338 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-28 16:19:49 +00:00
Andrea Fercia
91f5592886 Accessibility: Improve and modernize user interface controls. Make the select elements background white.
Props adhitya03.
See #47477.
Fixes #48128.


git-svn-id: https://develop.svn.wordpress.org/trunk@46337 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-28 16:14:50 +00:00
Jake Spurlock
f2e9aa79f5 Administration: Ensure visual consistency with large titles in the sidebar.
Custom posts, and other menu titles that are long aren't wrapping correctly.

Props jagirbaheshwp, munyagu, harshbarach, hareesh-pillai, pratikkry, naveenkharwar, mukesh27, dushanthi, worldweb, audrasjb
Fixes #42201


git-svn-id: https://develop.svn.wordpress.org/trunk@46332 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-26 21:50:10 +00:00
Andrea Fercia
4369b82732 Media: Restore the original Image Editor columns layout after [46326].
Fixes #47116.


git-svn-id: https://develop.svn.wordpress.org/trunk@46331 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-26 20:37:01 +00:00
Andrea Fercia
d6770e5c61 Accessibility: Media: Make the Image Editor buttons text visible.
User interface controls that use only icons aren't ideal for many users. 

Universal icons are rare. Icons must communicate meaning but their actual meaning varies depending on many factors including the users cultural background.
Moreover, users with cognitive impairments and speech recognition users need interface controls with visible text to be able to operate them.

- shortens some of the buttons text to: Rotate left, Rotate right, Flip vertical, Flip horizontal
- moves the Undo and Redo buttons underneath the main buttons group

Props nrqsnchz, melchoyce, karmatosed, sabernhardt, mikeschroder.
Fixes #47116.


git-svn-id: https://develop.svn.wordpress.org/trunk@46326 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-26 17:15:34 +00:00
Jake Spurlock
8f43c53a99 Menus: Duplicate Page Entry in View All Pages when generating a Menu
Simplifies the interface in menu creation.

Fixes [37782]
Props garrett-eclipse, mdgl, birgire, xkon, audrasjb, pento, girlieworks



git-svn-id: https://develop.svn.wordpress.org/trunk@46309 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-25 21:51:00 +00:00
Andrea Fercia
00de1af85d Accessibility: Implement the new focus styles on the login screen after [46247].
Props @kjellr.
See #47153.


git-svn-id: https://develop.svn.wordpress.org/trunk@46293 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-25 16:38:57 +00:00
Sergey Biryukov
7ae0a5985f Privacy: Show a success message for personal data erasure.
Props garrett-eclipse, allendav, birgire, JoshuaWold, karmatosed, pputzer.
Fixes #44135.

git-svn-id: https://develop.svn.wordpress.org/trunk@46264 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-23 19:12:04 +00:00
Andrea Fercia
0ff03b3290 Login and Registration: Add a "Show password" button on the login page.
The ability for users to see the password they're typing improves usability and accessibility of the login users flow.

- brings the login screen in line with the same feature already used in the New User, Edit User, and Reset Password pages
- improves association of labels and input fields by using explicit association with `for` / `id` attributes
- slightly increases the "Remember me" label font size

Props johnbillion, Iceable, audrasjb, joyously, adamsilverstein, boemedia, DrewAPicture, shadyvb, birgire, peterwilsoncc, pento, anevins, davidbaumwald, whyisjake, afercia.
Fixes #42888.


git-svn-id: https://develop.svn.wordpress.org/trunk@46256 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-23 18:05:16 +00:00
Andrea Fercia
aba005be39 Accessibility: Make sortable meta boxes non sortable when there are no locations they can be dragged to.
Depending on the amount of meta boxes and the layout settings under Screen Options, sortable meta boxes may not be actually sortable.
In these cases, jQuery UI sortable needs to be disabled and the user interface shouldn't use a CSS `cursor: move`.

The use of consistent and relevant cursors may be important for users who have a cognitive disability, since cursors give a visual clue as to an element's functionality. Using the move cursor for elements which cannot be moved may be confusing or counter-intuitive for users.

Props adamsilverstein, antpb, anevins.
Fixes #47131.


git-svn-id: https://develop.svn.wordpress.org/trunk@46250 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-23 17:29:46 +00:00
Andrea Fercia
e3db9a1361 Accessibility: Improve and modernize user interface controls. Sixth part: allow checkboxes and radio buttons to scale with text.
- uses a SVG icon for checkboxes
- uses CSS `rem` relative units

Props kjellr, afercia, audrasjb.
Fixes #47498.


git-svn-id: https://develop.svn.wordpress.org/trunk@46248 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-23 16:50:17 +00:00
Andrea Fercia
e994411a99 Accessibility: Improve and modernize user interface controls for better contrast. Fifth part: Common form controls.
Props anevins, melchoyce, audrasjb, kjellr.
Fixes #47153.


git-svn-id: https://develop.svn.wordpress.org/trunk@46247 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-23 16:20:24 +00:00