Commit Graph
120 Commits
Author SHA1 Message Date
Gary Pendergast 8f95800d52 Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.



git-svn-id: https://develop.svn.wordpress.org/trunk@42343 602fd350-edb4-49c9-b593-d223f7449a82
2017-11-30 23:09:33 +00:00
John Blackbourn fc40dea2fd Docs: Correct parameter type documentation for various __call() methods.
See #42505


git-svn-id: https://develop.svn.wordpress.org/trunk@42151 602fd350-edb4-49c9-b593-d223f7449a82
2017-11-10 22:56:01 +00:00
John Blackbourn 93fc60f36a Embeds: Add oEmbed support for someecards.com.
Props someecards

Fixes #40792


git-svn-id: https://develop.svn.wordpress.org/trunk@41681 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-02 19:09:46 +00:00
John Blackbourn a89374bc30 Embeds: Switch the collegehumor.com oEmbed endpoint to HTTPS, as it redirects there by default now.
See #28507


git-svn-id: https://develop.svn.wordpress.org/trunk@41680 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-02 19:05:18 +00:00
John Blackbourn 493805239e Embeds: Alignment following [41615].
See #38181


git-svn-id: https://develop.svn.wordpress.org/trunk@41676 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-02 18:37:53 +00:00
John Blackbourn 9d23f61503 Embeds: Documentation alignment following [41615].
See #38181


git-svn-id: https://develop.svn.wordpress.org/trunk@41616 602fd350-edb4-49c9-b593-d223f7449a82
2017-09-27 13:26:53 +00:00
John Blackbourn c2e30ec382 Embeds: Add support for Amazon Kindle instant previews.
Props jsepia, morganestes, adamsilverstein, swissspidy, jbpaul17, johnbillion, rugved

Fixes #38181


git-svn-id: https://develop.svn.wordpress.org/trunk@41615 602fd350-edb4-49c9-b593-d223f7449a82
2017-09-27 13:25:06 +00:00
Dion Hulse dd065164f4 Embeds: Switch the Imgur oEmbed endpoint to use SSL as the HTTP version has been deprecated.
Props swissspidy.
Fixes #41984.


git-svn-id: https://develop.svn.wordpress.org/trunk@41599 602fd350-edb4-49c9-b593-d223f7449a82
2017-09-26 08:32:21 +00:00
John Blackbourn 7f3deb9988 Embeds: Remove support for oEmbedded videos from Vine.
* Vine effectively shut down in December 2016.
* The oEmbed endpoint no longer works and returns a 404.
* Developer documentation for Vine has been removed.

Fixes #41817


git-svn-id: https://develop.svn.wordpress.org/trunk@41347 602fd350-edb4-49c9-b593-d223f7449a82
2017-09-08 15:00:33 +00:00
John Blackbourn 5c3d713beb Embeds: Add the dnt (Do Not Track) query parameter to all oEmbed provider URLs.
This means that, for those providers that support this somewhat de-facto standard, visitor tracking is disabled by default for all embeds.

Props norcross, joostdevalk

Fixes #41784


git-svn-id: https://develop.svn.wordpress.org/trunk@41345 602fd350-edb4-49c9-b593-d223f7449a82
2017-09-08 12:30:03 +00:00
Drew Jaynes b4d81bd654 Docs: Remove @access notations from method DocBlocks in wp-includes/* classes.
Prior to about 2013, many class methods lacked even access modifiers which made the `@access` notations that much more useful. Now that we've gotten to a point where the codebase is more mature from a maintenance perspective and we can finally remove these notations. Notable exceptions to this change include standalone functions notated as private as well as some classes still considered to represent "private" APIs.

See #41452.


git-svn-id: https://develop.svn.wordpress.org/trunk@41162 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-27 00:40:27 +00:00
Pascal Birchler e67238f480 Embeds: Update oEmbed endpoint URL for VideoPress.
Props NomNom99.
Fixes #41019.

git-svn-id: https://develop.svn.wordpress.org/trunk@40901 602fd350-edb4-49c9-b593-d223f7449a82
2017-06-15 05:37:51 +00:00
James Nylen d59f437268 REST API: Add endpoint for proxying requests to external oEmbed providers.
This endpoint is a prerequisite for the media widgets work (see https://github.com/xwp/wp-core-media-widgets).

Also use the new endpoint in the media modal instead of the `parse-embed` AJAX action.

Props westonruter, timmydcrawford, swissspidy, jnylen0.
Fixes #40450.


git-svn-id: https://develop.svn.wordpress.org/trunk@40628 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-11 18:18:00 +00:00
Pascal Birchler 9a2188dd56 Embeds: Add screencast.com to oEmbed provider whitelist.
Props ENDif Media.
Fixes #38367.


git-svn-id: https://develop.svn.wordpress.org/trunk@40574 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-06 14:24:37 +00:00
Sergey Biryukov a0bdc5efe4 Embeds: After [31148], list correct method in WP_oEmbed::$compat_methods.
Props LewisCowles.
Fixes #39292.

git-svn-id: https://develop.svn.wordpress.org/trunk@40026 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-29 07:31:29 +00:00
Dominik Schilling (ocean90) ade972bf86 Embeds: Realign the provider list after [38693].
See #38003.

git-svn-id: https://develop.svn.wordpress.org/trunk@38923 602fd350-edb4-49c9-b593-d223f7449a82
2016-10-25 20:15:45 +00:00
Dominik Schilling (ocean90) 41fc5ba881 Embeds: Add oEmbed support for User, List and Like Twitter timelines.
Props earnjam.
Fixes #38003.

git-svn-id: https://develop.svn.wordpress.org/trunk@38693 602fd350-edb4-49c9-b593-d223f7449a82
2016-09-30 21:42:01 +00:00
Dominik Schilling (ocean90) 22d4eb63b6 Embeds: Add support for embedding Facebook photos of a user/page.
See #34737.

git-svn-id: https://develop.svn.wordpress.org/trunk@38691 602fd350-edb4-49c9-b593-d223f7449a82
2016-09-30 20:39:32 +00:00
Sergey Biryukov 335cb0223f Embeds: Escape periods in oEmbed regex.
Props jrf.
Fixes #38187.

git-svn-id: https://develop.svn.wordpress.org/trunk@38684 602fd350-edb4-49c9-b593-d223f7449a82
2016-09-30 11:24:08 +00:00
Sergey Biryukov 84b67c9e6b Docs: Correct 'Since' version number for Cloudup in oembed_providers filter description.
Props jrf.
Fixes #38188.

git-svn-id: https://develop.svn.wordpress.org/trunk@38675 602fd350-edb4-49c9-b593-d223f7449a82
2016-09-29 17:12:07 +00:00
John Blackbourn 87c1b26ee7 Docs: Correct various documentation around object and stdClass types.
See #37770


git-svn-id: https://develop.svn.wordpress.org/trunk@38369 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-26 16:48:17 +00:00
John Blackbourn bc38f711cf Embeds: Add a missing regex delimiter for Facebook URLs.
See #34737


git-svn-id: https://develop.svn.wordpress.org/trunk@38368 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-26 12:16:56 +00:00
John Blackbourn cb0048a6c5 Embeds: Add support for embedding Facebook posts and videos via oEmbed.
Fixes #34737
Props pento, GaryJ


git-svn-id: https://develop.svn.wordpress.org/trunk@38367 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-26 11:56:47 +00:00
John Blackbourn d9b3ae759a Embeds: Many of our oEmbed providers now default to HTTPS embeds, redirect to the HTTPS oEmbed endpoint, or have complete support for HTTPS even if they don't default to HTTPS.
This change defaults to using HTTPS endpoints for oEmbeds for those providers that have full HTTPS support and don't redirect back to HTTP when clicking through from the embed. It covers:

* Vimeo
* SmugMug
* Scribd
* WordPress.tv
* SoundCloud
* Meetup
* issuu
* Mixcloud
* TED

See #28507


git-svn-id: https://develop.svn.wordpress.org/trunk@38366 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-26 11:24:38 +00:00
John Blackbourn acc91a60e0 Embeds: Always use the HTTPS endpoint for YouTube embeds. The scheme parameter is no longer required as all YouTube assets now use HTTPS.
See #36274, #28507
Props zsusag, tollmanz


git-svn-id: https://develop.svn.wordpress.org/trunk@38365 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-26 10:38:05 +00:00
Scott Taylor 1ff3356d22 OEmbed: move _wp_oembed_get_object() to embed.php, where all of the other embed functions live. WP_oEmbed is then in a file by itself. Load class-oembed.php in wp-settings.php and remove extraneous include calls.
See #37827.


git-svn-id: https://develop.svn.wordpress.org/trunk@38361 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-26 09:48:32 +00:00
Sergey Biryukov 5e99f1ef34 Embeds: Fix copy/paste error in WP_oEmbed::_add_provider_early() description.
Props ivantedja.
Fixes #37602.

git-svn-id: https://develop.svn.wordpress.org/trunk@38230 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-09 14:10:00 +00:00
Sergey Biryukov b1f3926bcb Embeds: In WP_oEmbed::get_provider() and WP_oEmbed::get_html(), parse the $args string to an array, as we treat it as an array later.
See #37071.

git-svn-id: https://develop.svn.wordpress.org/trunk@37720 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-15 18:51:32 +00:00
Pascal Birchler b2671c3880 Embeds: Improve performance when embedding a post from the current site.
When the post being embedded is from the same site, there's no reason to do an HTTP request for it. The data can be fetched directly using `get_oembed_response_data()`.

Fixes #36767 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@37708 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-15 11:22:52 +00:00
Drew Jaynes d11f7ed391 Docs: Standardize filter docs in remaining wp-includes/* files to use third-person singular verbs per the inline documentation standards for PHP.
See #36913.


git-svn-id: https://develop.svn.wordpress.org/trunk@37518 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-22 18:49:05 +00:00
Drew Jaynes 195572596b Docs: Standardize on 'backward compatibility/compatible' nomenclature in core inline docs.
Also use 'back-compat' in some inline comments where backward compatibility is the subject and shorthand feels more natural.

Note: 'backwards compatibility/compatibile' can also be considered correct, though it's primary seen in regular use in British English.

Props ocean90.
Fixes #36835.


git-svn-id: https://develop.svn.wordpress.org/trunk@37431 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-13 18:40:19 +00:00
Drew Jaynes 979d8931d3 Docs: Properly mark $args parameters in two WP_oEmbed methods as optional.
Also clarify that the `$args` parameters can accept a string (the default) in addition to an array.

Props ramiy.
See #36296.


git-svn-id: https://develop.svn.wordpress.org/trunk@37069 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-23 17:07:58 +00:00
Drew Jaynes 79150b2561 Docs: Use third-person singular verbs for summary DocBlocks in WP_oEmbed.
Also fixes inline `@see` formatting in appropriate places (summaries should not contain tags or markdown).

Props ramiy.
See #36296.


git-svn-id: https://develop.svn.wordpress.org/trunk@37068 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-23 16:57:08 +00:00
Drew Jaynes d793244e3c Docs: Improve and add missing DocBlocks for methods and properties in WP_oEmbed.
Props ramiy.
See #36296.


git-svn-id: https://develop.svn.wordpress.org/trunk@37067 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-23 16:51:48 +00:00
Drew Jaynes 033c7465d5 Docs: Change the 'HTTPS' column header to 'Supports HTTPS' in the markdown providers tables in the hook doc for the oembed_providers filter.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@37039 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-21 00:57:45 +00:00
Drew Jaynes 669cb94db9 Docs: Add Twitter timelines and moments to the table in the hook doc for the oembed_provders filter, introduced in [36954].
See #36197. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@37038 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-21 00:39:44 +00:00
Dominik Schilling (ocean90) 3046ac771c oEmbed: Extend the provider list to support moments and timelines from Twitter.
Fixes #36197.

git-svn-id: https://develop.svn.wordpress.org/trunk@36954 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 20:03:09 +00:00
John Blackbourn 4db068e862 Embeds: Add support for dai.ly embeds over HTTPS.
Fixes #36189


git-svn-id: https://develop.svn.wordpress.org/trunk@36951 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 19:48:15 +00:00
Aaron Jorbin 6c3d9fe803 Update Twitter oEmbed URL.
Twitter moved its preferred oEmbed URL for single Tweets from api.twitter.com to publish.twitter.com. They also are deprecating XML responses. 

Props niallkennedy.
Fixes #36197.



git-svn-id: https://develop.svn.wordpress.org/trunk@36946 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 18:39:12 +00:00
Dion Hulse d32216787e oEmbed: During discovery, only request the first 150kb of linked content to avoid timouts requesting larger documents.
Fixes #35979.


git-svn-id: https://develop.svn.wordpress.org/trunk@36880 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-08 05:57:13 +00:00
Aaron Jorbin 3969f2968f Remove RDIO from oEmbed providers
RDIO is shutting down. https://www.rdio.com/farewell/

Props swissspidy
Fixes #35152



git-svn-id: https://develop.svn.wordpress.org/trunk@36007 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-18 18:15:28 +00:00
John Blackbourn 3636f0dc1a Add support for oEmbeds from Speaker Deck.
Fixes #28597


git-svn-id: https://develop.svn.wordpress.org/trunk@35693 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-18 22:04:59 +00:00
Gary Pendergast 70bb2173c0 Embeds: Add support for the www subdomain to Instagram embed URLs.
Props skithund.

Fixes #34651.



git-svn-id: https://develop.svn.wordpress.org/trunk@35634 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-12 23:03:33 +00:00
Scott Taylor a37f75eb87 oEmbed: add Reddit Comments as a provider
Docs: https://github.com/reddit/reddit/wiki/oEmbed

Props swissspidy.
Fixes #31752.



git-svn-id: https://develop.svn.wordpress.org/trunk@35356 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 18:16:12 +00:00
John Blackbourn 13e8899262 Update the explanatory text which accompanies the list of whitelisted oEmbed providers, following the change to the default value of the discover argument in WP_oEmbed::get_provider().
See #32522


git-svn-id: https://develop.svn.wordpress.org/trunk@34907 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-07 13:04:32 +00:00
John Blackbourn 337b94a0a5 Add VideoPress as a trusted oEmbed provider.
Fixes #34031
Props kraftbj


git-svn-id: https://develop.svn.wordpress.org/trunk@34785 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-02 23:19:18 +00:00
Drew Jaynes c64bab4531 Docs: Slightly improve the readability of the data table in the DocBlock description for the oembed_providers hook by centering the HTTPS column.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34644 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 22:11:01 +00:00
John Blackbourn 60660b0055 Remove the unnecessary horizontal rules in the oEmbed providers table to tidy up the Code Reference.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@34597 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 15:16:05 +00:00
Drew Jaynes 8ec9d5e9e9 Docs: Adjust the table of providers in the hook doc for oembed_providers to use "No" instead of "!" to signify lack of SSL support.
When displayed in the Code Reference, the "!" doesn't convey enough information.

See #32246. See #28507.


git-svn-id: https://develop.svn.wordpress.org/trunk@34589 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 12:49:44 +00:00
John Blackbourn 4b9cee0af7 Switch to the https oEmbed endpoint for Animoto because it redirects there anyway.
See #28507


git-svn-id: https://develop.svn.wordpress.org/trunk@34588 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 12:23:21 +00:00