Commit Graph

2063 Commits

Author SHA1 Message Date
Dominik Schilling (ocean90)
8fefe4e13c Database: Remove debug comments in dbDelta().
git-svn-id: https://develop.svn.wordpress.org/trunk@37533 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-23 15:03:18 +00:00
Dominik Schilling (ocean90)
9f19752175 Database: Reduce the number of strtolower() calls in dbDelta().
Fixes #36919.

git-svn-id: https://develop.svn.wordpress.org/trunk@37532 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-23 14:57:19 +00:00
Dominik Schilling (ocean90)
5ca8f56abf Menus: Use new colors for error/info notices.
Props barryceelen.
Fixes #36857.

git-svn-id: https://develop.svn.wordpress.org/trunk@37529 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-23 09:39:13 +00:00
Gary Pendergast
2d14d5abab Database: dbDelta() will no longer try to downgrade the size of TEXT and BLOB columns.
When upgrading to `utf8mb4`, `TEXT` fields will be upgraded to `MEDIUMTEXT` (and likewise for all other `*TEXT` and `*BLOB` fields). This is to allow for the additional space requirements of `utf8mb4`.

On the subsequent upgrade, after the `utf8mb4` upgrade, `dbDelta()` would try and downgrade the fields to their original size again. At best, this it a waste of time, at worst, this could truncate any data larger than the original size. There's no harm in leaving them at their original size, so let's do that.

Fixes #36748.



git-svn-id: https://develop.svn.wordpress.org/trunk@37525 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-23 08:35:59 +00:00
Gary Pendergast
448896a2c7 Database: Remove some duplicate code.
`schema.php` was manually defining the character set/collation query, instead of using `wpdb::get_charset_collate()`.

Props sudar.

Fixes #35756.



git-svn-id: https://develop.svn.wordpress.org/trunk@37524 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-23 06:37:53 +00:00
Drew Jaynes
1cd420af5e Docs: Standardize hook docs in wp-admin/* to use third-person singular verbs per the inline documentation standards for PHP.
See #36913.


git-svn-id: https://develop.svn.wordpress.org/trunk@37488 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-22 18:00:23 +00:00
Drew Jaynes
b537c97778 Docs: Remove/replace invalid inline @link tags from DocBlocks in wp-admin/includes/*.
See #36910.


git-svn-id: https://develop.svn.wordpress.org/trunk@37485 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-22 17:21:48 +00:00
Drew Jaynes
1d6fff7f66 Docs: Fix some parameter alignment and backtick-escaping in two DocBlocks in wp-admin/includes/media.php.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@37484 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-22 17:17:11 +00:00
Drew Jaynes
ca67aa233d Docs: Remove invalid inline @link tags from docs in wp-admin/includes/media.php.
See #36910.


git-svn-id: https://develop.svn.wordpress.org/trunk@37483 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-22 17:09:16 +00:00
Andrea Fercia
86b5802d75 Refine the FTP credentials form interaction.
Properly toggle SSH2 Authentication Keys fieldset visibility.
JavaScript and CSS clean-up.

Props Mte90.
Fixes #34376.

git-svn-id: https://develop.svn.wordpress.org/trunk@37467 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-19 22:58:55 +00:00
Jeremy Felt
c5944fedf8 Multisite: Filter the links displayed on "Edit Site" views
Introduce the `network_edit_site_nav` function, which DRYs up the code used to display a common set of links at the top of "Edit Site" views.

Introduce the `network_edit_site_nav_links` filter, which allows plugins to modify the list of links displayed at the top of Edit Site views as a "tabbed" interface.

Props johnjamesjacoby, c3mdigital, Bueltge.
Fixes #15800.


git-svn-id: https://develop.svn.wordpress.org/trunk@37466 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-19 21:47:06 +00:00
Sergey Biryukov
ce467a3191 Docs: Correct variable type for WP_Upgrader::$strings.
Props mt8.biz.
Fixes #36883.

git-svn-id: https://develop.svn.wordpress.org/trunk@37462 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-19 00:35:32 +00:00
Dominik Schilling (ocean90)
5925994a30 Upgrader: Add changelog entries for when the classes were moved to its own file.
See #36618.

git-svn-id: https://develop.svn.wordpress.org/trunk@37432 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-13 20:58:47 +00:00
Drew Jaynes
195572596b Docs: Standardize on 'backward compatibility/compatible' nomenclature in core inline docs.
Also use 'back-compat' in some inline comments where backward compatibility is the subject and shorthand feels more natural.

Note: 'backwards compatibility/compatibile' can also be considered correct, though it's primary seen in regular use in British English.

Props ocean90.
Fixes #36835.


git-svn-id: https://develop.svn.wordpress.org/trunk@37431 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-13 18:40:19 +00:00
Dominik Schilling (ocean90)
ab3afd670d List Tables: Pass the $which parameter to restrict_manage_posts and restrict_manage_users.
`$which` contains the location of the extra table nav markup: 'top' or 'bottom'.

Props martin.krcho.
Fixes #35307.

git-svn-id: https://develop.svn.wordpress.org/trunk@37422 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-12 15:12:11 +00:00
Dominik Schilling (ocean90)
954eeba053 Filesystem API: Don't add '.' to the list of directories which need to be checked/created when extracting a file.
Prevents a PHP warning by `WP_Filesystem_Direct::mkdir()` when installing a language pack which doesn't have subdirectories.

Props tfrommen.
Fixes #36570.

git-svn-id: https://develop.svn.wordpress.org/trunk@37421 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-12 12:39:49 +00:00
Dominik Schilling (ocean90)
c9570340dd Upgrader: Remove debug cruft.
See #36618.

git-svn-id: https://develop.svn.wordpress.org/trunk@37413 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-10 18:31:29 +00:00
Dominik Schilling (ocean90)
0f47b70106 Upgrader: After [37409] move the hook docs for upgrader_process_complete to WP_Upgrader::run().
Add changelog entry for [23912].

Part 7/8.
See #36618.

git-svn-id: https://develop.svn.wordpress.org/trunk@37412 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-10 12:19:18 +00:00
Dominik Schilling (ocean90)
f76181d7af Upgrader: Update wp-admin/includes/class-wp-upgrader.php to require_once the new files added in [37406] and [37409].
Part 6/8.
See #36618.

git-svn-id: https://develop.svn.wordpress.org/trunk@37411 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-10 11:58:03 +00:00
Dominik Schilling (ocean90)
859f72cc00 Upgrader: Update file headers for new files added in [37409].
Part 5/8.
See #36618.

git-svn-id: https://develop.svn.wordpress.org/trunk@37410 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-10 11:51:16 +00:00
Dominik Schilling (ocean90)
e646bb2dd2 Upgrader: Copy WP_Upgrader subclasses into one file per class.
Part 4/8.
See #36618.

git-svn-id: https://develop.svn.wordpress.org/trunk@37409 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-10 11:44:06 +00:00
Dominik Schilling (ocean90)
8fe4831358 Upgrader: Update wp-admin/includes/class-wp-upgrader-skins.php to require_once the new files added in [37406].
Part 3/8.
See #36618.

git-svn-id: https://develop.svn.wordpress.org/trunk@37408 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-10 11:41:23 +00:00
Dominik Schilling (ocean90)
d9804f51c0 Upgrader: Update file headers and class DocBlocks for new files added in [37406].
Part 2/8.
See #36618.

git-svn-id: https://develop.svn.wordpress.org/trunk@37407 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-10 11:30:18 +00:00
Dominik Schilling (ocean90)
32c731b696 Upgrader: Copy WP_Upgrader_Skin and its subclasses into one file per class.
Part 1/8.
See #36618.

git-svn-id: https://develop.svn.wordpress.org/trunk@37406 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-10 11:10:22 +00:00
Helen Hou-Sandi
0671f3a8d3 Drop Open Sans in the admin in favor of system fonts.
Rejoice, for your admins will feel more native to your surrounding computing environment and likely load faster, especially when offline, as they no longer have to talk to The Google Overlord.

At the time of introduction in 3.8, there were not good system fonts common to all platforms at the time. In the years since, Windows, Android, OS X, iOS, Firefox OS, and various flavors of Linux have all gotten their own (good) system UI fonts.

There will definitely be visual bugs, mainly around alignment and spacing; these should be documented and reported on the ticket and fixed more atomically so that our current and future selves have a better understanding of what happened and why.

The style remains registered, as it is almost certainly in use by themes and plugins.

props mattmiklic.
see #36753.


git-svn-id: https://develop.svn.wordpress.org/trunk@37361 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-04 22:06:27 +00:00
Drew Jaynes
1c25b93a97 Links: Rename the $link_id parameter in get_link_to_edit() to $link to better reflect that it can accept a link ID or object.
Props tloureiro for the initial patch.
Fixes #36736.


git-svn-id: https://develop.svn.wordpress.org/trunk@37353 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-02 23:42:27 +00:00
Drew Jaynes
a76767e2ed Links: Clarify documentation for the $link_id parameter to mention that it accepts either an integer or object.
Props tloureiro.
See #36736.


git-svn-id: https://develop.svn.wordpress.org/trunk@37351 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-02 23:39:12 +00:00
Drew Jaynes
c7bed4f8c6 Docs: Remove inline @see tags from function, class, and method references in inline docs.
Known functions, classes, and methods are now auto-linked in Code Reference pages following #meta1483.

Note: Hook references are still linked via inline `@see` tags due to the unlikelihood of reliably matching for known hooks based on a RegEx pattern.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@37342 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-02 03:59:56 +00:00
Sergey Biryukov
8d99819276 Dashboard: Display the comment counts in wp_dashboard_right_now() in the rare initial condition when there are 0 approved comments and only pending comments, so the AJAX count update could work.
Props afercia.
Fixes #35519.

git-svn-id: https://develop.svn.wordpress.org/trunk@37335 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-01 11:05:48 +00:00
Dominik Schilling (ocean90)
c39a438d65 Plugins: In uninstall_plugin() pass the plugin file to wp_register_plugin_realpath().
`wp_register_plugin_realpath()` calls `dirname( $file );` to remove the basename. The basename must be included in the argument or the symlinked directory won't be registered.

Props andy.
Fixes #36709.

git-svn-id: https://develop.svn.wordpress.org/trunk@37331 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-30 15:03:14 +00:00
Andrea Fercia
ee30b90714 Accessibility: improve the Star Ratings hiding empty elements for assistive technologies.
Fixes #36725.

git-svn-id: https://develop.svn.wordpress.org/trunk@37330 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-30 14:32:40 +00:00
Rachel Baker
024c8003c9 Users: Remove the “Name” column of the Users table from appearing sortable.
The “Name” column of the Users WP List Table is not sortable because this column displays a concatenation of two optional values, `first_name` and `last_name`. Even if WP_User_Query supported ordering queries in this manner, the resulting sequence would be chaotic.

Fixes #28064.

Props jesin, and rachelbaker.

git-svn-id: https://develop.svn.wordpress.org/trunk@37314 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-26 20:34:05 +00:00
Scott Taylor
e2b9072267 Dashboard: toggle the "View" link for comments when Approving / Unapproving from the Dashboard widget.
Fixes #35518.


git-svn-id: https://develop.svn.wordpress.org/trunk@37302 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-22 21:29:19 +00:00
Sergey Biryukov
0cc8d27fda Text Changes: Consistently refer to https://wordpress.org/plugins/ and https://wordpress.org/themes/ as WordPress Plugin Directory and WordPress Theme Directory, respectively.
Props mpol.
Fixes #35938.

git-svn-id: https://develop.svn.wordpress.org/trunk@37297 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-22 06:56:20 +00:00
Dominik Schilling (ocean90)
153610292d Media: Remove an extra quote when sending a link of a media file to the editor.
Introduced in [37035].

Props joemcgill, swissspidy, boonebgorges.
Fixes #36578.

git-svn-id: https://develop.svn.wordpress.org/trunk@37288 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-21 21:20:26 +00:00
Dominik Schilling (ocean90)
d434c58404 Themes: Update list of WordPress theme features.
* Remove color tags.
* Layout: Add Grid Layout, remove Fixed Layout, Fluid Layout, and Responsive Layout.
* Features: Add Footer Widgets, remove Blavatar.
* Subject: Add Blog, E-Commerce, Education, Entertainment, Food & Drink, Holiday, News, Photography and Portfolio, remove Photoblogging and Seasonal.

Props grapplerulrich, davewarfel.
Fixes #33407.

git-svn-id: https://develop.svn.wordpress.org/trunk@37287 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-21 21:10:03 +00:00
Sergey Biryukov
23d737bc53 Administration: Introduce admin_print_footer_scripts-$hook_suffix", a dynamic version of the admin_print_footer_scripts hook.
This is now more consistent with the generic `admin_print_scripts` and the dynamic `admin_print_scripts-$hook_suffix` hooks fired in `wp-admin/admin-header.php`.

Props tfrommen.
Fixes #34334.

git-svn-id: https://develop.svn.wordpress.org/trunk@37279 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-21 15:16:52 +00:00
Pascal Birchler
c52f851308 Rewrite Rules: After [36953], correctly replace existing rules on IIS when updating them.
Props WiZZarD_.
Fixes #36506 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@37273 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-21 09:32:42 +00:00
Dominik Schilling (ocean90)
eec3f16b24 Upgrader: Clear plugin/theme caches directly after a plugin/theme has been updated.
`wp_update_plugins()` and `wp_update_themes()` are both hooked into `upgrader_process_complete` with priority 10. But at this stage the caches in `get_plugins()`, `search_theme_directories()`, and `wp_get_themes()` aren't refreshed yet so both functions couldn't fetch any translations for the new plugin/theme.
To reset the caches, `wp_clean_themes_cache()` and `wp_clean_plugins_cache()` are now hooked into `upgrader_process_complete` with priority 9.

This is a follow-up to [34751].

See #34029.
Fixes #36383.

git-svn-id: https://develop.svn.wordpress.org/trunk@37272 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-21 09:08:11 +00:00
Drew Jaynes
6261a0b439 Docs: Add missing return descriptions for WP_Filesystem_SSH2::chown() and WP_Filesystem_SSH2::run_command().
Fixes #30989.


git-svn-id: https://develop.svn.wordpress.org/trunk@37270 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-21 02:37:36 +00:00
Boone Gorges
07fa16713d Include taxonomy term metadata in WXR export.
Because term XML nodes now include termmeta and can thus be much larger, this
changeset also includes adds some newlines and indentation to make the XML
easier to read.

Props Chouby.
See #34062.

git-svn-id: https://develop.svn.wordpress.org/trunk@37240 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-18 03:37:04 +00:00
Sergey Biryukov
2f3c1769fa Theme Editor: After [37217], add other embed templates to file descriptions.
Props Frozzare.
Fixes #34561. See #34561.

git-svn-id: https://develop.svn.wordpress.org/trunk@37232 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-18 01:04:15 +00:00
Andrea Fercia
8309ab055f Accessibility: change the close "X" in the Media "Attach to existing content" modal in a button.
Props joedolson.

Fixes #36554.

git-svn-id: https://develop.svn.wordpress.org/trunk@37231 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-17 16:57:54 +00:00
Andrea Fercia
e4b26366e4 Plugin Install: show the upload form in place rather than sending users to the devoted upload plugin page.
Props Ipstenu, ericlewis, michaelarestad.

Fixes #35429.

git-svn-id: https://develop.svn.wordpress.org/trunk@37221 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-16 16:42:48 +00:00
Sergey Biryukov
25f590a423 Theme Editor: Add embed.php to file descriptions.
Props ramiy.
Fixes #36551.

git-svn-id: https://develop.svn.wordpress.org/trunk@37217 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-16 12:46:26 +00:00
John Blackbourn
f2f356acfe Docs: Clarify possible types passed to the themes_api_result filter.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@37209 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-15 01:42:11 +00:00
Jeremy Felt
137d716ebb Multisite: Remove theme from network allowed themes when deleted
Previously, a deleted theme would remain in the list of allowed themes until manually cleared. This uses `WP_Theme::network_disable_theme()`, added in [37202].

Fixes #34182.


git-svn-id: https://develop.svn.wordpress.org/trunk@37203 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-14 03:49:01 +00:00
Jeremy Felt
85a6518c57 Multisite: Relocate revoke_super_admin() and grant_super_admin()
Moving these functions to `wp-includes/capabilities.php` allows plugins to access more than just `is_super_admin()` and `get_super_admin()` from the front end without including a file via `wp-admin/`. Add an `is_multisite()` check to prevent use of these on single site environments now that they have left `ms.php`..

Props johnjamesjacoby.
Fixes #21788.


git-svn-id: https://develop.svn.wordpress.org/trunk@37200 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-14 03:34:07 +00:00
Boone Gorges
dbf17abf5c Pass thumbnail ID to the admin_post_thumbnail_html filter.
Also updates changelog to reflect that `$post->ID` was added in 3.5

Props johnjamesjacoby.
Fixes #36443.

git-svn-id: https://develop.svn.wordpress.org/trunk@37196 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-13 16:17:10 +00:00
Sergey Biryukov
2014288c62 Docs: Fix typo in get_image_send_to_editor() description.
Props yoavf.
See #36349.

git-svn-id: https://develop.svn.wordpress.org/trunk@37194 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-13 07:27:15 +00:00