Commit Graph
2116 Commits
Author SHA1 Message Date
Scott Taylor 91dcf8796b In image_size_input_fields():
* Declare `$out` as an empty array - this is not a strict PHP requirement, but is a good practice before loops
* Most of this function was tabbed twice, instead of once

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30981 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 22:18:12 +00:00
Scott Taylor a75c7977b9 In wp_import_handle_upload():
`$file` was essentially getting declared/overwritten 3 times. In lieu of this, return an array containing the error immediately instead of doing a short-circuit array key assignment on error. Rename the local variable to `$upload` and use its properties instead of creating 3 new local vars, one of which stomped the array.

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30980 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 21:09:11 +00:00
Scott Taylor f6f12912e2 Improve some docs for @param. Remove an unneeded $wpdb global import.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30979 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 20:55:21 +00:00
Scott Taylor 04ed6499cd Improve some wp-admin/includes/class-wp-filesystem-*.php docs for @param.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30978 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 20:39:41 +00:00
Andrew Ozz 6695ac3bab Editor: when switching editor-expand off for the first time use the default editor height. Props avryl, fixes #30760 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@30977 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 19:33:01 +00:00
Andrew Nacin 26eeb623a6 About page: CDN images.
git-svn-id: https://develop.svn.wordpress.org/trunk@30971 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-18 17:54:43 +00:00
Helen Hou-Sandi 908a2e87c8 Ensure inline code examples stay LTR, punctuation and all.
props alex-ye.
see #30748.


git-svn-id: https://develop.svn.wordpress.org/trunk@30952 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-17 16:21:54 +00:00
Helen Hou-Sandi d34709eaa5 About page: Don't allow tab text to wrap.
Some language, browser, and OS combinations (notably Arabic, Chrome, and Windows) were wrapping.

see #30743.


git-svn-id: https://develop.svn.wordpress.org/trunk@30951 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-17 16:01:42 +00:00
Dominik Schilling (ocean90) fabd47a2ff About: Fix the WordPress badge.
`css-clean` (minifies our CSS) has an issue when using multiple backgrounds and background position together. Instead of relying on browser support for multiple backgrounds to display the WP logo as SVG, use the `.svg` CSS class.

see #30735.

git-svn-id: https://develop.svn.wordpress.org/trunk@30946 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 22:53:25 +00:00
Dominik Schilling (ocean90) 7560f4cf8c Pass locale to wordpress.org theme/plugin API.
In the future this will be used to return localized plugin/theme info.

see #30735.

git-svn-id: https://develop.svn.wordpress.org/trunk@30944 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 22:38:52 +00:00
Andrew Nacin b4dc6629cd Last about page string. props celloexpressions. fixes #30435.
git-svn-id: https://develop.svn.wordpress.org/trunk@30929 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 21:26:34 +00:00
John Blackbourn 9189fbcff9 Make the DFW paragraph on the About page narrower to mitigate an orphan in Firefox.
See #30435
Props melchoyce


git-svn-id: https://develop.svn.wordpress.org/trunk@30921 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 20:01:56 +00:00
John Blackbourn 2069d52fa1 Move a <code> tag out of a localised string on the About page.
Props pavelevap
See #30435


git-svn-id: https://develop.svn.wordpress.org/trunk@30903 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 14:03:53 +00:00
Andrew Nacin daf16cdb63 Call it 'Distraction-free writing mode' and update the help string. fixes #30657.
git-svn-id: https://develop.svn.wordpress.org/trunk@30890 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 10:06:17 +00:00
Andrew Nacin 855ff22a53 Update/add plugin recommendation strings.
Update [30887], add a translation function to the Vine string.

fixes #30337. see #30435.


git-svn-id: https://develop.svn.wordpress.org/trunk@30889 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 10:05:09 +00:00
Andrew Nacin 07e7f03373 Updates to the 'Log out everywhere' implementation.
* Include a message and a disabled button when you're only logged in at one location.
 * Avoid leaking the session token in HTML.
 * Simplify, simplify, simplify.

see #30264.


git-svn-id: https://develop.svn.wordpress.org/trunk@30888 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 09:15:01 +00:00
Andrew Nacin 82d0ba4b60 Finalize two more about page strings. see #30435.
git-svn-id: https://develop.svn.wordpress.org/trunk@30887 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 08:57:11 +00:00
Dominik Schilling (ocean90) c959c4d4b3 Customizer: Add _wp_attachment_is_custom_background meta to uploaded background images.
Adds `$type` property to `WP_Customize_Background_Image_Control` (PHP) and introduces `wp.customize.BackgroundControl` (JS).

see #30707.

git-svn-id: https://develop.svn.wordpress.org/trunk@30885 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-15 23:27:17 +00:00
Dominik Schilling (ocean90) d5299a9522 Autoprefixer for [30857].
see #30435.

git-svn-id: https://develop.svn.wordpress.org/trunk@30884 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-15 23:19:06 +00:00
John Blackbourn 0533e9bd8c Correct the height of the search type select element when searching the plugin directory.
See #30719
Props pavelevap, eliorivero


git-svn-id: https://develop.svn.wordpress.org/trunk@30879 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-15 22:31:35 +00:00
Dominik Schilling (ocean90) 663d12c8f8 Customizer: Remove date filter from the Header/Background Image upload frames.
Adds an option to `wp.media.view.AttachmentsBrowser` to hide the date filter added in [29813].

see #30689.

git-svn-id: https://develop.svn.wordpress.org/trunk@30872 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-15 20:26:54 +00:00
Dominik Schilling (ocean90) c17317912a Customizer: Import missing wp.customize.Control.prototype._toggleActive.
Check also if `completeCallback` is set before calling it.

props westonruter.
see #30701.

git-svn-id: https://develop.svn.wordpress.org/trunk@30871 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-15 19:53:55 +00:00
Dion Hulse 28e22a4ec4 Background Updates: Pass back whether Group Writable support is being leveraged for an update to the WordPress.org API.
See #30245


git-svn-id: https://develop.svn.wordpress.org/trunk@30860 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-15 14:07:35 +00:00
Andrew Nacin 5c04326ba6 About page design for 4.1.
props melchoyce and ryelle, who again outdid themselves.
see #30435.


git-svn-id: https://develop.svn.wordpress.org/trunk@30857 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-15 10:46:43 +00:00
Andrew Nacin b38c603682 Rename _wp_clear_update_cache() to wp_clean_update_cache().
This makes it match most cache-clearing functions, including the ones it wraps. Also no need for it to be prefixed as "private."

wp_clean_plugins_cache() doesn't always exist, so as a quick fix, clear the transient we care to clear.

see #30369.


git-svn-id: https://develop.svn.wordpress.org/trunk@30856 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-15 08:54:14 +00:00
Andrew Nacin 0375edc8c6 No need for wp_get_password_hint() to be prefixed as if it is private.
see #21243.


git-svn-id: https://develop.svn.wordpress.org/trunk@30855 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-15 08:33:48 +00:00
Andrew Ozz 34a2576fd6 Editor, new DFW: fix fading out for the right sidebar in IE. Fixes #30714.
git-svn-id: https://develop.svn.wordpress.org/trunk@30853 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-15 03:08:12 +00:00
Andrew Ozz 284bfd81b9 Improve the fix for menu shakiness when over-scrolling. Recalculate heights on editor auto-resize.
See #30692.

git-svn-id: https://develop.svn.wordpress.org/trunk@30852 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-15 00:10:18 +00:00
Dominik Schilling (ocean90) 326d7f8c5f Customizer: Re-add the possibility to remove and restore a default background image.
see #21483.
fixes #30683 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@30849 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-14 19:36:27 +00:00
Andrew Ozz 35c763f795 Fix menu shakiness when over-scrolling in Chrome and Safari on MacOS.
See #30692.

git-svn-id: https://develop.svn.wordpress.org/trunk@30844 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-14 01:46:39 +00:00
Andrew Ozz 560a1ba478 iOS: do not autofocus the readonly textarea with the code for wp-config.php in setup-config.php.
See #30703.

git-svn-id: https://develop.svn.wordpress.org/trunk@30843 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-14 00:10:05 +00:00
Andrew Ozz 2fc1155920 Do not autofocus text fields on page load on mobile devices. This is currently broken in many mobile browsers:
- iOS Safari opens the keyboard and auto-scrolls on the first tap anywhere on the screen triggering the click at an unexpected place. That makes it impossible to follow links or press buttons.
- Chrome on iOS opens the keyboard on load and may scroll the focused field off screen.
- The Android 4.4 browser only highlights the field, the user has to tap it to open the keyboard and type.
See #30703.

git-svn-id: https://develop.svn.wordpress.org/trunk@30842 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-13 22:07:58 +00:00
Andrew Nacin 074d8c1ad7 Finalize more about page strings. see #30435.
git-svn-id: https://develop.svn.wordpress.org/trunk@30841 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-13 22:04:51 +00:00
Andrew Nacin 095c9857ef About page updates.
* Live-update the number of active translations.
 * Finalize most strings.
 * Lazily remove links to admin-only screens based on cap checks.
see #30435.


git-svn-id: https://develop.svn.wordpress.org/trunk@30840 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-13 20:11:49 +00:00
Andrew Ozz 1bbc18c390 Improve text for the DFW admin pointer. Remove the concatenation.
Props kpdesign, ianmjones.
See #30671.

git-svn-id: https://develop.svn.wordpress.org/trunk@30837 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-12 22:11:46 +00:00
Dominik Schilling (ocean90) 163c32126f Revisions: Fix initial state of compareTwoMode.
Broken since [30131].

fixes #30672.

git-svn-id: https://develop.svn.wordpress.org/trunk@30831 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-12 09:53:10 +00:00
Andrew Ozz d8f6e64596 Fix search box position on the Add Plugins screen after resizing the window to narrower than 1000px and then back to wider than 1200px. Fixes #30658.
git-svn-id: https://develop.svn.wordpress.org/trunk@30830 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-12 00:53:51 +00:00
Andrew Nacin 3c2f9a9ccf About page, text only (not released for translation), first pass.
Design and finalized text to follow. This is just for the RC crowd.

props johnbillion, helen, markjaquith, nacin.
see #30435.


git-svn-id: https://develop.svn.wordpress.org/trunk@30821 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-11 10:15:14 +00:00
Andrew Nacin 560b6f7978 Editor focus: Don't trigger when typing while the mouse is outside the editor.
props avryl.
fixes #20668.


git-svn-id: https://develop.svn.wordpress.org/trunk@30817 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-11 09:33:46 +00:00
Andrew Ozz 9bda766f54 Fix the search field width in the media modal, media library grid and on the install new plugins screen. Props helen, fixes #30658.
git-svn-id: https://develop.svn.wordpress.org/trunk@30813 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-11 04:11:28 +00:00
Dominik Schilling (ocean90) 23d0e8392e Remove a stray $ from [30793].
props ipm-frommen.
see #30553.

git-svn-id: https://develop.svn.wordpress.org/trunk@30794 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-09 11:26:27 +00:00
Dominik Schilling (ocean90) 4975d4255f Themes: Use Customizer deep-links inside the theme modal.
props DrewAPicture, ocean90.
see #25569, #25571.
fixes #30553.

git-svn-id: https://develop.svn.wordpress.org/trunk@30793 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-08 22:22:23 +00:00
Sergey Biryukov 27fefdf04b Revert [28948], which caused a regression.
see #29573 for trunk. see #28350.

git-svn-id: https://develop.svn.wordpress.org/trunk@30791 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-08 21:13:56 +00:00
Andrew Ozz c8e8281a05 Plugins: move the recommender results to a separate tab. Any outstanding quality issues will be fixed on the API side without needing core changes. Props tellyworth, fixes #30337.
git-svn-id: https://develop.svn.wordpress.org/trunk@30782 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 23:39:54 +00:00
Drew Jaynes (DrewAPicture) ac47dd2cd0 Tweak formatting in the DocBlock for the install_themes_tabs hook.
Props kpdesign.
See #28578.


git-svn-id: https://develop.svn.wordpress.org/trunk@30772 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 18:40:03 +00:00
Andrew Ozz fce20e9784 Better docs for Plugin_Upgrader::deactivate_plugin_before_upgrade(). Props DrewAPicture. Fixes #29088.
git-svn-id: https://develop.svn.wordpress.org/trunk@30762 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 01:18:21 +00:00
Andrew Ozz d948f0bf32 Always return a value in Plugin_Upgrader::deactivate_plugin_before_upgrade(). Props jdgrimes. Fixes #29088.
git-svn-id: https://develop.svn.wordpress.org/trunk@30761 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 00:52:06 +00:00
Andrew Ozz af5c93a432 Customizer - Widgets: add feedback for screen readers when moving up or down. Props adamsilverstein, afercia. Fixes #28892.
git-svn-id: https://develop.svn.wordpress.org/trunk@30760 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 00:44:49 +00:00
Drew Jaynes (DrewAPicture) 3cdbc730d3 Add missing DocBlocks and parameter descriptions for a wide variety of properties and methods in WP_Upgrader, Plugin_Upgrader, Theme_Upgrader, Language_Pack_Upgrader, Core_Upgrader, and File_upload_Upgrader.
Props jdgrimes, DrewAPicture.

See #29086.


git-svn-id: https://develop.svn.wordpress.org/trunk@30758 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 00:25:44 +00:00
Drew Jaynes (DrewAPicture) 716984e94d Add a blank line preceding a Markdown-formatted ordered list in the DocBlock for the admin_body_class filter.
Props kpdesign.
See #30558.


git-svn-id: https://develop.svn.wordpress.org/trunk@30756 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-06 23:20:12 +00:00