Sergey Biryukov
13382740b9
Escape class attribute in edit_post_link() after [34098].
...
Props Offereins.
See #30563 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34117 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-14 13:00:31 +00:00
Sergey Biryukov
217c84e613
Docs: Add a changelog entry for the $class argument added to edit_post_link() in [34098].
...
Fixes #30563 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34115 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-14 12:19:55 +00:00
Scott Taylor
f20622f394
In edit_post_link(), add an argument for the class attribute that defaults to post-edit-link.
...
Props voldemortensen.
Fixes #30563 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34098 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-13 23:33:30 +00:00
Boone Gorges
4ebab4dc16
Remove extraneous table join in get_adjacent_post().
...
Since [29248], a table join has not been necessary to process the
`$excluded_terms` parameter of `get_adjacent_post()`. Aside from adding extra
overhead, this join meant that post records that don't have any corresponding
rows in `wp_term_relationships` were erroneously excluded from results.
Fixes #32833 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34088 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-12 20:33:07 +00:00
Scott Taylor
5cce4a3262
After [33961], pass $comment to get_comment_link() where possible to avoid extra cache/db lookups.
...
See #33638 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34042 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-11 06:20:56 +00:00
Scott Taylor
4016b77b1a
Add a parameter, $post, to get_{$adjacent}_post_join, get_{$adjacent}_post_where, and get_{$adjacent}_post_sort
...
Props JustinSainton.
Fixes #24597 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33968 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 03:49:00 +00:00
Scott Taylor
38d374ab01
After [33891], get_comment() returns global $comment if no args are passed and the global is set (after setting the default to null here). This allows us to ditch global comment imports.
...
See #33638 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33963 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 02:50:43 +00:00
Scott Taylor
60ba8b05e4
Introduce WP_Comment class to model/strongly-type rows from the comments database table. Inclusion of this class is a pre-req for some more general comment cleanup and sanity.
...
* Takes inspiration from `WP_Post` and adds sanity to comment caching.
* Clarifies when the current global value for `$comment` is returned. The current implementation in `get_comment()` introduces side effects and an occasion stale global value for `$comment` when comment caches are cleaned.
* Strongly-types `@param` docs
* This class is marked `final` for now
Props wonderboymusic, nacin.
See #32619 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33891 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 18:16:35 +00:00
Boone Gorges
0c7f2237f0
Pass taxonomy name to filters in get_adjacent_post().
...
Props sboisvert.
Fixes #33568 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33805 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-29 19:58:13 +00:00
Scott Taylor
1fb94edb99
In get_home_url(), import the $pagenow global to avoid having to check if it exists before comparing against it.
...
Props KalenJohnson.
See #33545 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33736 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 21:02:14 +00:00
Drew Jaynes
83476bb77f
Docs: Add a description and example to the hook docs for the navigation_markup_template filter, introduced in [33714].
...
Since the value of the filter is passed through `sprintf()` it's important to note that any filtered output needs to contain the expected specifiers.
See #31315 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33717 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-23 18:07:41 +00:00
Scott Taylor
d8ba4fde1b
Add a filter to _navigation_markup: 'navigation_markup_template'
...
Props joedolson, mordauk.
Fixes #31315 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33714 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-23 16:33:25 +00:00
Drew Jaynes
dfa9da5356
Docs: Fix a minor alignment issue in the DocBlock for get_pagenum_link().
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33712 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-23 07:18:19 +00:00
Scott Taylor
4b746c4b4e
Deprecate post_permalink() (Introduced in 1.0, already had a deprecated argument in 1.3), which just wraps get_permalink() and was only used by XML-RPC in 4 places.
...
Props solarissmoke.
Fixes #16982 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33659 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-20 06:24:00 +00:00
Scott Taylor
f162be6046
For doc block types, favor bool over the few remaining booleans
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32964 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 01:02:12 +00:00
Boone Gorges
4f60683623
Improve error checking in get_edit_term_link().
...
The function should not throw notices when an improper term or taxonomy is
passed.
Props tmatsuur, MikeHansenMe.
Fixes #32786 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32954 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-26 14:12:27 +00:00
Drew Jaynes
e95626a94f
Document default values for optional arguments in edit_term_link().
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32926 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 10:55:13 +00:00
Drew Jaynes
bdd00bc8c7
Add missing documentation for the $echo parameter in the DocBlock for edit_term_link().
...
Props tmatsuur.
Fixes #32776 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32925 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 10:52:32 +00:00
Scott Taylor
89328eb69f
Customizer et al, use elseif in PHP, not else if.
...
This was corrected via brute force in [31090].
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32874 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 22:00:33 +00:00
Scott Taylor
646c19accf
Make sure that all Gravatars are generated by get_avatar() or at least run through apply_filters( 'get_avatar', $avatar ) for the sake of extensibility.
...
Props miqrogroove, GlennM, SergeyBiryukov.
Fixes #22650 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32845 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 18:35:04 +00:00
Scott Taylor
22ba68ccb8
Fix doc blocks to link-template.php
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32606 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-26 18:43:48 +00:00
Andrew Ozz
301bb0b9da
Press This: check the bookmarklet version and add the update notice from PHP.
...
Fixes #31942 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32106 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-10 21:07:42 +00:00
Drew Jaynes
f372dd828e
Various inline documentation syntax fixes in wp-includes/link-template.php.
...
See #31888 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32042 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-05 16:03:12 +00:00
Andrew Ozz
21da2ccd85
Press This: bump bookmarklet's version. See #31657 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@31800 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-17 01:18:01 +00:00
Andrew Ozz
e0f843cd81
PressThis:
...
- Filter and select the content on the PHP side. Then pass only the needed data to JS.
- Add the suggested post title and contend directly to the HTML.
- Standardise the data type names.
- Some cleanup/reduction of the code in the bookmarklet.
See #31373 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31693 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-09 21:48:38 +00:00
Boone Gorges
07abae914e
In get_next_comments_link(), ensure proper pagination when no 'cpage' query var is found.
...
The 'cpage' query var is only set when using `comments_template()` to display
comments. If displaying them in a context where 'cpage' is not yet set, the
default value should be 1, not 0.
Props MomDad, couturefreak.
Fixes #20319 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31617 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-05 03:56:21 +00:00
Andrew Ozz
f9a6a7aa56
PressThis:
...
- Improve handling of the data, both from the bookmarklet and from server-side parsing.
- Standardize on processing the data in PHP and remove duplicate code from JS.
- Improve the bookmarklet code and remove pre-filtering of the data.
Part props stephdau, see #31373 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31609 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-04 19:28:53 +00:00
Drew Jaynes
79a3048412
Adjust the description for the $extra_attr argument in the DocBlocks for get_avatar_data() and get_avatar().
...
See [31561]. See #31469 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31591 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-01 07:18:42 +00:00
wonderboymusic
2f86fcd9a9
In get_avatar_data() and get_avatar(), allow height and width to be specified separately (both default to size). Also allow arbitrary attributes on the <img> via the extra_attr arg.
...
Props miqrogroove.
See #31469 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31561 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-26 21:16:02 +00:00
Andrew Ozz
2fb11a4ae4
PressThis: go back to loading the minified bookmarklet content with file_get_contents(). Add Grunt task to minify bookmarklet.js on precommit and update it in /src. See #31373 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@31545 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-25 20:15:46 +00:00
Andrew Ozz
e6bbea8fe7
Press This: JSON encode the URL before appending it to the bookmarklet. See #31373 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@31537 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-25 03:57:43 +00:00
Andrew Ozz
578a785440
PressThis:
...
- Hard-code the minified bookmarklet js. Adding the non-minified bookmarklet to the browser bookmarks bar may have unexpected effect.
- Fix type juggling when checking the bookmarklet version.
Props stephdau, see #31373 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31535 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-25 03:02:48 +00:00
Andrew Ozz
2e3afd2760
PressThis v2, first run. Props michael-arestad, stephdau, marcelomazza, DrewAPicture, iseulde, afercia, kraftbj, rachelbaker, AramZS, dd32. See #31373 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@31534 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-25 01:49:26 +00:00
Sergey Biryukov
45d5c5ddbe
Remove src from duplicate hook comments for get_avatar and get_avatar_data.
...
see #21195 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31480 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-19 14:58:40 +00:00
Sergey Biryukov
5aac59d178
Replace hardcoded usage of comment-page with the comment pagination base.
...
props johnbillion, SergeyBiryukov, webord.
fixes #18084 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31459 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-14 03:47:02 +00:00
Boone Gorges
9cb4d3c1ce
In get_adjacent_post(), return private post if the current user has the capacity to read it.
...
This mirrors the check that happens post-query in `WP_Query`. See #30911 .
Props bswatson.
Fixes #30287 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31302 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-30 02:19:46 +00:00
Scott Taylor
1d3b42d226
Fix some erroneous @param annotations.
...
See #30799 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31219 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 22:43:13 +00:00
Boone Gorges
5b7baae907
In get_edit_term_link(), default to a valid $object_type.
...
The $object_type param is used to set the 'post_type' query var, which
determines the post type menu that will be expanded when clicking through to
the term edit page. Not all taxonomies are associated with Posts, so it makes
sense to default to a post_type that the taxonomy is actually associated with.
Props DzeryCZ, juliobox.
Fixes #29251 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31218 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 21:36:12 +00:00
Gary Pendergast
0b993ffe35
If get_avatar_data() is passed an empty value for the default avatar, we should be using the site's avatar_default option instead.
...
See #21195
git-svn-id: https://develop.svn.wordpress.org/trunk@31154 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-12 00:22:12 +00:00
Gary Pendergast
69f8b26d89
In get_avatar_data(), there's no need to return false if we couldn't find an avatar, as Gravatar can handle being given an empty email hash. This allows the default avatar to show when no email address is given.
...
See #21195
git-svn-id: https://develop.svn.wordpress.org/trunk@31153 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-12 00:19:34 +00:00
Boone Gorges
d5c9eb41d7
In get_permalink(), don't resolve to pretty permalink if post has 'future' status.
...
We already do this for other non-public statuses, to prevent leaking non-public
information about unpublished posts.
Props e.mazovetskiy, CalEvans.
Fixes #30910 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31114 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-09 16:39:56 +00:00
Gary Pendergast
dec1cba410
Add get_avatar_url(), for retrieving just the URL of an avatar, rather than the entire <img> tag that get_avatar() produces.
...
Unlike `get_avatar()`, `get_avatar_url()` is not pluggable. It can be extended/or modified through the new filters included.
Fixes #21195 .
Props mdawaffe, pento, pathawks, DrewAPicture
git-svn-id: https://develop.svn.wordpress.org/trunk@31107 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-09 04:42:48 +00:00
Sergey Biryukov
22c9a89602
Add context for 'Previous' and 'Next' strings in get_the_posts_pagination().
...
fixes #30762 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@31071 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-07 23:06:20 +00:00
Sergey Biryukov
0d308bfd6b
Pass the $adjacent parameter to the "{$adjacent}_post_link" filter.
...
props ankit.gade@rtcamp.com , kpdesign.
fixes #30440 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31000 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-30 06:56:19 +00:00
John Blackbourn
22b5e67b10
Rename (get_)the_pagination() to (get_)the_posts_pagination() for clarity.
...
See #29808
Props obenland
git-svn-id: https://develop.svn.wordpress.org/trunk@30823 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-11 10:22:47 +00:00
John Blackbourn
9dc69a9fa6
Allow the type argument to be passed through get_the_pagination() as long as its value isn't array.
...
For trunk.
See #29808
git-svn-id: https://develop.svn.wordpress.org/trunk@30820 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-11 09:38:18 +00:00
Drew Jaynes (DrewAPicture)
7187da0b32
Convert various uses of (optional) in core parameter descriptions to use the style prescribed in the inline documentation standards for PHP.
...
The style for marking parameters optional in inline PHP docs is: `@param type $var Optional. Description. Accepts. Default.`, where Accepts can be omitted on a case-by-case basis.
Props coffee2code.
Fixes #30591 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30753 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-06 21:23:52 +00:00
Drew Jaynes (DrewAPicture)
e587324180
Docs Formatting: Backtick-escape inline code for all remaining dynamic hook docs in wp-includes/*.
...
Affects DocBlocks for the following hooks:
* `auth_post_meta_{$meta_key}`
* `term_links-$taxonomy`
* `customize_render_control_ . $this->id`
* `customize_render_panel_{$this->id}`
* `customize_render_section_{$this->id}`
* `customize_preview_{$this->id}`
* `customize_save_ . $this->id_data[ 'base' ]`
* `customize_update_ . $this->type`
* `customize_value_ . $this->id_data[ 'base' ]`
* `customize_sanitize_js_{$this->id}`
* `comment_form_field_{$name}`
* `comment_{$old_status}_to_{$new_status}`
* `comment_{$new_status}_{$comment->comment_type}`
* `extra_{$context}_headers`
* `get_template_part_{$slug}`
* `get_the_generator_{$type}`
* `get_{$adjacent}_post_join`
* `get_{$adjacent}_post_where`
* `get_{$adjacent}_post_sort`
* `{$adjacent}_post_rel_link`
* `{$adjacent}_post_link`
* `{$adjacent}_image_link`
* `blog_option_{$option}`
* `$permastructname . _rewrite_rules`
* `{$type}_template`
* `theme_mod_{$name}`
* `pre_set_theme_mod_$name`
* `current_theme_supports-{$feature}`
* `get_user_option_{$option}`
* `edit_user_{$field}`
* `pre_user_{$field}`
* `user_{$field}`
See #30552 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30656 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 12:09:56 +00:00
Drew Jaynes (DrewAPicture)
c1d0555b32
Add missing return descriptions for a variety of functions in wp-includes/link-template.php.
...
Props colorful-tones, dustyf.
See #30406 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30628 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 04:43:44 +00:00
Drew Jaynes (DrewAPicture)
8c059c65a4
4.1 Docs Audit: Ensure optional arguments in get_the_post_navigation(), the_post_navigation(), get_the_posts_navigation(), the_posts_navigation(), get_the_pagination(), and the_pagination() are properly documented with defaults.
...
See #30469 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30616 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-28 11:56:20 +00:00