vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-10-02 21:56:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
41,210 Commits 1 Branch 0 Tags
9793244c74f4c310a0b0052e122bfd5b9bedd2f8
Commit Graph
40 Commits
Author SHA1 Message Date
Sergey Biryukov 130751cda3 Coding Standards: Use Yoda conditions where appropriate. 
See #49222.

git-svn-id: https://develop.svn.wordpress.org/trunk@47219 602fd350-edb4-49c9-b593-d223f7449a82
 2020-02-09 16:52:28 +00:00
Sergey Biryukov cfc3b57488 Docs: Improve inline comments per the documentation standards. 
Includes minor code layout fixes for better readability.

See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47122 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-29 00:43:23 +00:00
Sergey Biryukov 4c2ee4e9ff Docs: In various @return tags, list the expected type first, instead of false. 
Follow-up to [46696].

See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47060 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-11 18:30:58 +00:00
Sergey Biryukov 7bb2a562a6 Docs: Correct spelling of "subclass" and "overridden" in various docblocks and error messages. 
Props garrett-eclipse.
Fixes #48676.

git-svn-id: https://develop.svn.wordpress.org/trunk@46739 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-17 07:41:49 +00:00
John Blackbourn 3cdee7a705 Docs: Further improve documentation of known return types, plus other docs fixes. 
See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46661 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-05 21:25:53 +00:00
Andrew Ozz 89939327e3 Media/Upload: rotate images on upload according to EXIF Orientation. 
Props msaggiorato, wpdavis, markoheijnen, dhuyvetter, msaggiorato, n7studios, triplejumper12, pbiron, mikeschroder, joemcgill, azaozz.

Fixes #14459.

git-svn-id: https://develop.svn.wordpress.org/trunk@46202 602fd350-edb4-49c9-b593-d223f7449a82
 2019-09-20 18:20:26 +00:00
Gary Pendergast 4503f93961 Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments violations in wp-includes. 
See #47632.



git-svn-id: https://develop.svn.wordpress.org/trunk@45590 602fd350-edb4-49c9-b593-d223f7449a82
 2019-07-02 23:41:16 +00:00
Sergey Biryukov c6c4edb47a Docs: Remove @static notations from method DocBlocks in wp-includes/* classes. 
This tag has been used in the past, but should no longer be used. Just using the `static` keyword in code is enough for PhpDocumentor on PHP5+ to recognize static variables and methods, and PhpDocumentor will mark them as static.

Props birgire.
See #42803.

git-svn-id: https://develop.svn.wordpress.org/trunk@42746 602fd350-edb4-49c9-b593-d223f7449a82
 2018-02-25 20:21:37 +00:00
Sergey Biryukov a62a77eeb7 Media: After [42695], remove redundant check that is already performed a few lines above. 
Props gnif.
See #43255.

git-svn-id: https://develop.svn.wordpress.org/trunk@42702 602fd350-edb4-49c9-b593-d223f7449a82
 2018-02-11 21:54:23 +00:00
Sergey Biryukov 909424b9af Media: In WP_Image_Editor::make_image(), close previously opened output buffer if the file could not be created. 
Props dhanendran, gnif.
Fixes #43255.

git-svn-id: https://develop.svn.wordpress.org/trunk@42695 602fd350-edb4-49c9-b593-d223f7449a82
 2018-02-11 16:24:05 +00:00
Gary Pendergast 8f95800d52 Code is Poetry. 
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.



git-svn-id: https://develop.svn.wordpress.org/trunk@42343 602fd350-edb4-49c9-b593-d223f7449a82
 2017-11-30 23:09:33 +00:00
John Blackbourn 0613540ea2 Media: Rename several attachment related parameters from $post_id to $attachment_id for clarity, and improve related 
documentation.

See #41017


git-svn-id: https://develop.svn.wordpress.org/trunk@41288 602fd350-edb4-49c9-b593-d223f7449a82
 2017-08-22 11:11:23 +00:00
Drew Jaynes b4d81bd654 Docs: Remove @access notations from method DocBlocks in wp-includes/* classes. 
Prior to about 2013, many class methods lacked even access modifiers which made the `@access` notations that much more useful. Now that we've gotten to a point where the codebase is more mature from a maintenance perspective and we can finally remove these notations. Notable exceptions to this change include standalone functions notated as private as well as some classes still considered to represent "private" APIs.

See #41452.


git-svn-id: https://develop.svn.wordpress.org/trunk@41162 602fd350-edb4-49c9-b593-d223f7449a82
 2017-07-27 00:40:27 +00:00
Sergey Biryukov a661557bce Docs: Correct @access entry for ::load() in WP_Image_Editor, WP_Image_Editor_GD, and WP_Image_Editor_Imagick. 
Props upadalavipul.
Fixes #41423.

git-svn-id: https://develop.svn.wordpress.org/trunk@41125 602fd350-edb4-49c9-b593-d223f7449a82
 2017-07-24 14:10:45 +00:00
Scott Taylor d911ef44dc Media: when calling pathinfo(), also pass a PATHINFO_* constant to avoid array notices for unset keys. 
Props JaworskiMatt.
Fixes #37608.


git-svn-id: https://develop.svn.wordpress.org/trunk@38294 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-20 23:35:50 +00:00
Drew Jaynes c49afe285c Docs: Standardize filter docs in core classes in wp-includes/* to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.


git-svn-id: https://develop.svn.wordpress.org/trunk@37492 602fd350-edb4-49c9-b593-d223f7449a82
 2016-05-22 18:14:19 +00:00
Drew Jaynes 195572596b Docs: Standardize on 'backward compatibility/compatible' nomenclature in core inline docs. 
Also use 'back-compat' in some inline comments where backward compatibility is the subject and shorthand feels more natural.

Note: 'backwards compatibility/compatibile' can also be considered correct, though it's primary seen in regular use in British English.

Props ocean90.
Fixes #36835.


git-svn-id: https://develop.svn.wordpress.org/trunk@37431 602fd350-edb4-49c9-b593-d223f7449a82
 2016-05-13 18:40:19 +00:00
Mike Schroder c270654d2c Media: Reduce default image compression quality to '82'. 
Changes default image compression quality from '90' to '82'.

This reduces generated image file sizes by ~25% while
keeping DSSIM < 0.0023, with both Imagick and GD.

Props @joemcgill, @dnewton.
See #33642.

git-svn-id: https://develop.svn.wordpress.org/trunk@36615 602fd350-edb4-49c9-b593-d223f7449a82
 2016-02-22 22:18:14 +00:00
John Blackbourn ba5f0fdc7b Docs: Various docblock corrections. 
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@36250 602fd350-edb4-49c9-b593-d223f7449a82
 2016-01-10 01:25:44 +00:00
Scott Taylor 3b8c5529cb foreach is a statement, not a function. 
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33734 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 20:27:56 +00:00
Scott Taylor f162be6046 For doc block types, favor bool over the few remaining booleans 
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32964 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-27 01:02:12 +00:00
Scott Taylor 296c559baf if is a statment, not a function. 
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32800 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-16 20:00:15 +00:00
Scott Taylor c8a44d437a Add @static* annotations where they are missing. 
Initialize all static vars that are not, most to `null`.

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32650 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-29 15:42:40 +00:00
Scott Taylor f67ecbdadc Add missing doc blocks to wp-image-editor*.php. 
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32546 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-22 06:17:16 +00:00
Scott Taylor 979ba60a57 Fix some @param docs that have chars too close them. 
Add `@property` annotations to `WP_User` and `WP_Post`.
Remove erroneous `@param`s from image editor class methods.
Officially add the property `$_column_headers` to `WP_List_Table`.	

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31127 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 06:56:51 +00:00
Scott Taylor f6f12912e2 Improve some docs for @param. Remove an unneeded $wpdb global import. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30979 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-20 20:55:21 +00:00
John Blackbourn 5918c5d365 Clarify the behaviour of the wp_editor_set_quality and jpeg_quality filters. 
Props DH-Shredder
See #29856


git-svn-id: https://develop.svn.wordpress.org/trunk@30874 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-15 21:42:32 +00:00
Sergey Biryukov 99224928bf Move the logic from WP_Image_Editor::get_quality() to WP_Image_Editor::set_quality(), so that 'wp_editor_set_quality' and 'jpeg_quality' filters run when setting the default value. 
props markoheijnen.
fixes #29856.

git-svn-id: https://develop.svn.wordpress.org/trunk@30788 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-08 16:18:42 +00:00
Sergey Biryukov 1a7c4efa13 Fix setting default quality in WP_Image_Editor. 
props markoheijnen.
fixes #29856 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@29834 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-04 13:11:38 +00:00
Scott Taylor c2b7f8022c Add ->get_quality() method to WP_Image_Editor class. 
Adds unit tests.

Props markoheijnen.
Fixes #28154.


git-svn-id: https://develop.svn.wordpress.org/trunk@28879 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-28 03:49:55 +00:00
Scott Taylor 0f4f941900 In WP_Image_Editor::get_output_format(), $file_mime and $file_ext are set twice before they are used. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28320 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 18:36:34 +00:00
Scott Taylor 7b7e5305c7 In multi_resize() image editor methods, assert that null can only be passed for one of the arguments, not both. Add a lot more unit test assertions to ensure this. 
Props pbearne, DH-Shredder.
Fixes #26823.



git-svn-id: https://develop.svn.wordpress.org/trunk@27794 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-27 20:39:08 +00:00
Drew Jaynes fa376b16cd Two more hook docs fixes. 
`image_memory_limit` filter:
* Go with int|string on the limit, and simply notate '256M' as an acceptable string value.

`wp_editor_set_quality` filter:
* Add a missing parameter description for the mime type.

See #25721.


git-svn-id: https://develop.svn.wordpress.org/trunk@26650 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-04 23:50:33 +00:00
Drew Jaynes ba4187de33 Hook docs fixes following [26645]. 
See #25721.


git-svn-id: https://develop.svn.wordpress.org/trunk@26648 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-04 23:31:21 +00:00
Andrew Nacin 8a3c33c861 Improvements to image quality handling in the image editor classes. 
props markoheijnen, DH-Shredder.
fixes #25721.


git-svn-id: https://develop.svn.wordpress.org/trunk@26645 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-04 22:48:45 +00:00
Drew Jaynes e7ee404ec9 Improve inline documentation for the multi_resize() method in WP_Image_Editor, WP_Image_Editor_GD, and WP_Image_Editor_Imagick. 
Props paolal for the initial patch.
Fixes #25530.


git-svn-id: https://develop.svn.wordpress.org/trunk@25728 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-08 17:19:00 +00:00
Drew Jaynes 46a60cc6d5 Fix phpdoc indentation for hooks in wp-includes/class-wp-image-editor.php. 
Props gayadesign.
Fixes #25504.


git-svn-id: https://develop.svn.wordpress.org/trunk@25714 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-07 16:27:34 +00:00
Drew Jaynes 3da73dfa3f Inline documentation for hooks in wp-includes/class-wp-image-editor.php. 
Props tomauger.
Fixes #25504


git-svn-id: https://develop.svn.wordpress.org/trunk@25705 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-06 22:18:29 +00:00
Ryan Boren c8889d984f Pinking shears 
git-svn-id: https://develop.svn.wordpress.org/trunk@25085 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-22 15:55:07 +00:00
Andrew Nacin b43712e0f7 New develop.svn.wordpress.org repository based on the old core.svn repository. 
* All WordPress files move to a src/ directory.
 * New task runner (Grunt), configured to copy a built WordPress to build/.
 * svn:ignore and .gitignore for Gruntfile.js, wp-config.php, and node.js.
 * Remove Akismet external from develop.svn. Still exists in core.svn.
 * Drop minified files from src/. The build process will now generate these.

props koop.
see #24976.

and see http://wp.me/p2AvED-1AI.



git-svn-id: https://develop.svn.wordpress.org/trunk@25001 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-07 05:25:25 +00:00