Andrew Nacin
a2892990f1
Introduce a img_caption_shortcode_width filter for controlling the inline style of the image caption shortcode.
...
props iandunn for the initial patch.
fixes #14380 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25444 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-14 20:44:26 +00:00
Andrew Nacin
730574eeb5
Don't allow critical scripts to be deregistered on wp-login.php, just as we do in the rest of the admin.
...
props atimmer.
fixes #25017 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25443 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-14 20:20:46 +00:00
Andrew Nacin
db7501f3fa
Move to JSON for the plugin and theme update-check API endpoints. see #25311 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25442 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-14 19:57:27 +00:00
Scott Taylor
535ae26afd
Fix several esoteric errors related to AJAX unit tests for comments:
...
* `wp_ajax_get_comments()` relies on the `$post_id` global - even though `$_POST['p']` is passed to every action in the test methods. If `$post_id` is still lingering in between tests and doesn't match `p` in the request, the cap check might pass while the queries for comments will blow up. I added `unset( $GLOBALS['post_id'] )` to `Tests_Ajax_GetComments::setUp()`.
* If the global `$post_id` is empty, but `$_REQUEST['p']` is not, `$post_id` is now set to `absint( $_REQUEST['p'] )` and sanity-checked in `wp_ajax_get_comments()`.
* `map_meta_cap()` always assumes that `get_comment()` succeeds when checking for the `edit_comment` cap. It doesn't. I added sanity checks in a few places where it will break early if `get_post()` or `get_comment()` are empty.
* `wp_update_comment()` always assumes `get_comment()` succeeds. It doesn't. I added a check for empty.
All AJAX unit tests run and pass in debug mode. All general unit tests pass against these changes.
Fixes #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25438 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-14 18:35:43 +00:00
Dominik Schilling (ocean90)
1de9497eef
Add 'image' type/extensions to wp_ext2type() and make it case insensitive. props xparham. fixes #25176 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25437 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-14 14:33:19 +00:00
Dion Hulse
87e014a245
Account for Windows and CLI instances in wp_guess_url(). Props SergeyBiryukov. See #25317
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25436 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-14 03:42:38 +00:00
Scott Taylor
402e61f269
Fix some undefined index notices related to Comment unit tests:
...
* There are several places where a `$_POST` index was unchecked before setting a variable
* In `wp_notify_postauthor()`, `$comment` was being returned null, but its properties were being accessed.
* In `check_ajax_referer()`, 3 different values can be checked for nonce on `$_REQUEST`, but only 1 had an `isset()`
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25433 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-13 22:17:51 +00:00
Sergey Biryukov
1a621e7615
Inline documentation for hooks in wp-includes/author-template.php.
...
props Frank Klein.
see #25229 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25429 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-13 19:24:26 +00:00
Sergey Biryukov
631d5edf3a
Inline documentation for get_comment_reply_link() and 'comment_reply_link' filter.
...
props DrewAPicture.
fixes #25310 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25428 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-13 19:19:45 +00:00
Dion Hulse
4da6ecff26
WP_HTTP: correct the SSL root certificates property, set svn:eol-style to native, and remove the svn:executable property. See #25007
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25426 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-13 12:29:27 +00:00
Sergey Biryukov
d60cbb399e
Inline documentation for hooks in wp-includes/shortcodes.php.
...
props natejacobs.
see #25229 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25423 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-13 09:01:20 +00:00
Dion Hulse
63956aa479
WordPress Core Automatic Updates: Add the first slice of Automatic Upgrades, This is presently disabled, and requires a filter to enable ( 'auto_upgrade_core' ). See #22704
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25421 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-13 06:18:16 +00:00
Andrew Nacin
bb2908d613
Clear all transients (regardless of expiration) on all database upgrades. see #20316 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25416 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 21:13:18 +00:00
Helen Hou-Sandi
f72bc15544
Inline docs for hooks in wp-includes/nav-menu-template.php. props Faison. see #25229 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25410 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 18:47:27 +00:00
Scott Taylor
404fd85586
Fix the failing Tests_Link::test_wp_get_shortlink() assertion:
...
* `wp_get_shortlink()` was firing a notice when reading `$post->ID` while `$post` was null in some cases
* Before the assertions that assume `$GLOBALS['post']` is not set, call `unset( $GLOBALS['post'] );` - there was global spillage from other tests
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25404 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 17:30:01 +00:00
Andrew Nacin
1851da1382
Return false from wp_get_original_referer() if it is called before wp_validate_redirect() is defined.
...
see #25294 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25400 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 13:35:35 +00:00
Andrew Nacin
cc5477c7d9
Return false from wp_get_referer() if it is called before wp_validate_redirect() is defined.
...
see #25294 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25399 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 13:32:41 +00:00
Scott Taylor
3ae18e68ff
* Fill in undefined var in Tests_Option_BlogOption
...
* Add `defined()` check for `BLOGSUPLOADDIR`
* Suppress deprecated function notices for `is_blog_user()` and `get_dashboard_blog()`
* Check existence of `$user` in `wpmu_log_new_registrations()` before arbitrarily making a database query
Fixes all notices in multisite unit tests.
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25397 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 07:16:30 +00:00
Dion Hulse
cccac649d5
Fix wp_guess_url() to work in every scenario I could find, allows us to use it to determine the correct path to the WordPress Site URL before installation for install.php and setup-config.php redirects. Fixes #24480 Fixes #16884
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25396 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 06:56:20 +00:00
Scott Taylor
d1d5bcf036
* Add isset() checks all over WP_User_Query::prepare_query() and WP_User_Query::query(). When a WP_User_Query instance is constructed without passing args, no query vars are filled in, thus $qv doesn't contain most of the expected indices.
...
* Suppress an undefined index notice in `tests/user/query.php`
Fixes #25292 .
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25392 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 06:24:09 +00:00
Scott Taylor
c5c88eb85b
Add sanity checks to get_*_template() functions to ensure that the return value of get_queried_object() is compatible with the assumed context.
...
Fixes #25291 .
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25386 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 05:31:14 +00:00
Scott Taylor
f9877147f6
Use reset() to access the first element of an array, don't assume there is an item at index 0.
...
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25384 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 05:08:33 +00:00
Helen Hou-Sandi
f1ef5c0e23
Indicate that the fall-through in is_serialized() is deliberate. fixes #24023 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25371 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 03:40:25 +00:00
Scott Taylor
d091e1d0b7
Avoid a notice by casting $args['rewrite'] to array() before adding a slug property and running array_merge().
...
Fixes #23668 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25351 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 17:17:00 +00:00
Dion Hulse
23d3b372d7
Fix the action that set_site_transient() fires so as not to include the private option prefix. This brings set_site_transient() back in line with it's documented behaviour, and the behaviour of all other transient functions. Fixes #25213
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25350 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 08:45:43 +00:00
Dion Hulse
7ebad3db1c
Switch WP_HTTP over to using the mbstring.func_overload helper functions. This change moves the check from within the Streaming-handling function to wrap the individual request, this fixes it for both cURL and Streams and any future changes to the transports which use strlen() on binary data. See #25259 See #16057
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25348 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 08:12:24 +00:00
Dion Hulse
052d276215
Add a set of helpers to turn the behaviour of mbstring.func_overload off when needed. Fixes #25259
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25346 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 07:22:05 +00:00
Andrew Nacin
a1470e6161
Avoid error in ms-files.php after [25317].
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25344 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 04:48:43 +00:00
Andrew Nacin
adf6fab55b
Bump version in trunk.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25343 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 04:19:36 +00:00
Andrew Nacin
1848709736
SimplePie: Fix use of DOMElement as array.
...
props MikeSchinkel.
fixes #25274 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25342 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 04:01:44 +00:00
Andrew Nacin
760e9e02d1
Avoid string offset notices in [25319].
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25340 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 03:57:00 +00:00
Andrew Nacin
3b314a0adf
Improve clarity and speed of [25320].
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25338 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 03:22:09 +00:00
Andrew Nacin
cedb15724a
Bump TinyMCE version for [25132]. See #25131 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25337 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 02:43:12 +00:00
Scott Taylor
3ee8135baa
Don't call sanitize_title_with_dashes( $taxonomy ) in register_taxonomy() unless $args['rewrite']['slug'] is empty.
...
Props SergeyBiryukov.
Fixes #23668 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25335 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 00:08:04 +00:00
Scott Taylor
0c0c81d81c
Add term_taxonomy_id to available fields in get_term_by(). Adds unit test.
...
Props jchristopher.
Fixes #21651 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25334 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 00:01:19 +00:00
Scott Taylor
a963ab0852
Remove dead code in add_query_arg().
...
Props hakre, c3mdigital.
Fixes #16942 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25333 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 23:37:23 +00:00
Scott Taylor
1a46a76c18
Use wp_get_nav_menus() instead of get_terms('nav_menu') in WP_Nav_Menu_Widget to preserve use of `wp_get_nav_menus' filter.
...
Props Frank Klein.
Fixes #25263 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25332 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 23:29:04 +00:00
Scott Taylor
d738f5e586
Support orderby => meta_value in WP_User_Query. Adds unit test.
...
Props wpsmith.
Fixes #21581 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25331 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 23:09:10 +00:00
Scott Taylor
c71a0422c0
Add an additional available param (the WP_User instance) to the user_has_cap filter.
...
Props Viper007Bond.
Fixes #24490 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25329 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 22:22:34 +00:00
Scott Taylor
4fccea305f
Add filter flush_rewrite_rules_hard to give devs chance to prevent writing to file when hard-flushing rewrite rules.
...
Props jeremyfelt, nacin.
Fixes #23491 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25328 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 22:18:21 +00:00
Scott Taylor
a98660d517
Introduce get_previous_post_link(), get_next_post_link(), and get_adjacent_post_link(). Allows developers to retrieve the value without echoing.
...
Props yoavf, markjaquith, SergeyBiryukov.
Fixes #17302 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25327 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 22:11:53 +00:00
Andrew Nacin
9d7689c4ba
Loose validation for is_serialized() in maybe_serialize().
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25320 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 18:09:36 +00:00
Andrew Nacin
0281fc61da
Better protocol validation in set_url_scheme().
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25319 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 18:07:19 +00:00
Andrew Nacin
ac3361e997
Validate referrers to prevent off-domain redirects.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25318 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 18:06:43 +00:00
Andrew Nacin
31482a7968
Tighten allowed upload file types.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25317 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 18:03:26 +00:00
Scott Taylor
d141191598
Consistently wrap author and excerpt nodes with CDATA in feeds.
...
Fixes #18056 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25315 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 16:54:16 +00:00
Scott Taylor
5a75531f19
Replace the ancient phpfreaks.com RegEx to extract urls to ping with a more robust matcher. URLs with commas and things like & were not being pinged. The new matcher even works for most IDN URLs. Adds unit tests.
...
Fixes #9064 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25313 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 03:17:51 +00:00
Scott Taylor
e72ffa5d96
Move checks for post_type being an array inline. See [25291], [25292], #18614 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25312 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 03:01:10 +00:00
Scott Taylor
9ece28e545
Add an action at the end of WP_Query::parse_tax_query() called (wait for it...) parse_tax_query which will enable developers to alter $this->tax_query->queries before SQL is generated. pre_get_posts is too early for many scenarios.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25311 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 02:35:26 +00:00
Scott Taylor
14e44dcd05
Make sure the queried object is non-null before accessing its properties.
...
Props markoheijnen, ryan.
Fixes #21394 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25310 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 02:27:24 +00:00