Commit Graph
35 Commits
Author SHA1 Message Date
Scott Taylor eef0d99ed8 hackificator doesn't like mixed quote styles in some generated HTML. The switch from single to double allows these files to be parsed.
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28497 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 01:58:28 +00:00
Scott Taylor 27ff2a1cd0 Eliminate use of extract() in get_media_item().
To test, fire open the old media in the console: `tb_show('Old Media is Weird', 'media-upload.php?type=image&TB_iframe=true&post_id=0');`	
	
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28407 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 02:45:01 +00:00
Scott Taylor 3f59b86ec5 In media_upload_gallery_form()'s inline JavaScript, remove unnecessary comment tags.
Fixes #25637.



git-svn-id: https://develop.svn.wordpress.org/trunk@28368 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 06:11:08 +00:00
Scott Taylor 7531fd0070 Leverage size_format() when displaying max_upload_size:
* In `media_upload_form()` 
* The `uploader-inline` Underscore template in the media modal. 

Replaces 2 buggy inline implementations that could display size units off by one, or size values off by one.

Fixes #25643.



git-svn-id: https://develop.svn.wordpress.org/trunk@28343 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-07 18:24:47 +00:00
Scott Taylor d92f5aa154 In get_media_item(), $tags and $_tags are set and never used.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28297 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 16:40:52 +00:00
Scott Taylor f95a4c70be In edit_form_image_editor(), $filename and $title are set and then unused. They shall be removed.
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28271 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 04:44:56 +00:00
Andrew Ozz bff230b422 Plupload: restore the settings in media_upload_form(), see #27763
git-svn-id: https://develop.svn.wordpress.org/trunk@28110 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-14 00:40:45 +00:00
Drew Jaynes (DrewAPicture) 33acf29a46 Clarify PHPDoc return description for media_handle_upload().
Props jdgrimes.
Fixes #27519.


git-svn-id: https://develop.svn.wordpress.org/trunk@27880 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-31 22:32:47 +00:00
Scott Taylor d8d26a4f79 Cleanup up the display, escaping, and handling of ID3 data for media. Rename wp_get_relevant_id3_keys() to wp_get_attachment_id3_keys().
Props nacin.
See #27574.



git-svn-id: https://develop.svn.wordpress.org/trunk@27869 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-31 05:15:39 +00:00
Andrew Nacin 877ffc087f Cleanups for audio/video metadata, see [27862].
see #27574.


git-svn-id: https://develop.svn.wordpress.org/trunk@27864 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-30 21:07:04 +00:00
Scott Taylor 149f36ed35 Metadata for audio and video files:
* Make attachment metadata for audio files editable by providing a metabox on the Edit Media page
* Standardize on using the attachment title everywhere
* Label the Caption and Description fields for audio and video appropriately
* Make the playlist Underscore templates more straightforward

See #27574.



git-svn-id: https://develop.svn.wordpress.org/trunk@27862 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-30 19:27:31 +00:00
Drew Jaynes (DrewAPicture) 0e7a34444d Correct misleading verbiage in 'print' hook docs.
Standardizes 'print' hook docs on the concept that hooks are fired when scripts and styles are printed.

Props ericlewis for the initial patch.
Fixes #26924.


git-svn-id: https://develop.svn.wordpress.org/trunk@27695 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-25 08:04:44 +00:00
Andrew Nacin 48391a7444 Use correct variable. see [27373].
props TobiasBg.
fixes #14424.


git-svn-id: https://develop.svn.wordpress.org/trunk@27675 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 03:24:33 +00:00
Andrew Ozz 263d9c7f33 Plupload: switch to urlstream upload method when the 'flash' runtime is used in non IE browsers. This ensures cookies are sent but limits the maximum file size that flash can handle.
By default only IE9 and older use flash so this change is mostly for completeness. It would affect only the (extremely rare) cases where a plugin disables the html5 runtime.

git-svn-id: https://develop.svn.wordpress.org/trunk@27662 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-23 23:44:20 +00:00
Dominik Schilling (ocean90) 9e92a95ec5 Remove "Show" prefix from filter dropdowns, see #26743.
git-svn-id: https://develop.svn.wordpress.org/trunk@27626 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-19 22:12:13 +00:00
Andrew Nacin 6aa60cf530 Assign correct variable.
props nendeb55.
fixes #27351. see #14424, [27373].


git-svn-id: https://develop.svn.wordpress.org/trunk@27501 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-11 13:23:14 +00:00
Andrew Nacin 4bbd5ef1d6 maybe_regenerate_attachment_metadata() is now wp_maybe_generate_attachment_metadata().
props kovshenin.
fixes #26825.


git-svn-id: https://develop.svn.wordpress.org/trunk@27441 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-06 19:33:32 +00:00
Mark Jaquith 7937358328 Eliminate some of our last remaining create_function() instances
* Moved some into private function callbacks
* Eliminated some that weren't necessary anymore

props obenland, markjaquith, nacin. fixes #14424

git-svn-id: https://develop.svn.wordpress.org/trunk@27373 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-03 16:20:12 +00:00
Andrew Nacin f3a23fb43f Reference https://wordpress.org rather than http://wordpress.org in strings, links, comments, etc.
props Ipstenu, markjaquith.
see #27115.


git-svn-id: https://develop.svn.wordpress.org/trunk@27369 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-03 02:33:24 +00:00
Scott Taylor 07f14d6434 * Videos should always render at the same aspect ratio.
* Don't force a pseudo-mime-type for `.m4v` files
* Uniformly adapt to `$content_width` when setting video dimensions on the front end
* Add the `height` attribute to the initial `<video>` in the video playlist JS template
* Add some defensive/responsive CSS for a/v on the Edit Media page

See #27243.



git-svn-id: https://develop.svn.wordpress.org/trunk@27328 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-28 21:27:40 +00:00
Andrew Ozz 11586e8ebe Upgrade Plupload to 2.1.1, props kovshenin, see #25663
git-svn-id: https://develop.svn.wordpress.org/trunk@27316 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-27 20:00:55 +00:00
Scott Taylor d6cb8c399e Introduce maybe_regenerate_attachment_metadata( $attachment ). On the Edit Media screen, call it for Audio and Video files.
The functions checks if the item is lacking metadata altogether. If a video or audio file was uploaded prior to 3.6, it does not have any metadata. This tries to fix it. Implements locking via a transient to protect against this running in parallel with another request.

This is the minimum viable product for #26825, but leaving the ticket open unless this function needs to be called in other places.

See #26825.



git-svn-id: https://develop.svn.wordpress.org/trunk@27127 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-07 22:40:32 +00:00
Andrew Ozz 88fecbeff9 Remove table cellspacing attribute from the admin, part-props MattyRob, fixes #22086.
git-svn-id: https://develop.svn.wordpress.org/trunk@27036 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-26 20:27:21 +00:00
Andrew Ozz 48d24f6bf5 Remove all "valign" attributes from tables in wp-admin, props MikeHansenMe, Marventus. Fixes #22712.
git-svn-id: https://develop.svn.wordpress.org/trunk@27029 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-24 19:05:15 +00:00
Drew Jaynes 00f318650d Inline documentation for hooks in wp-admin/includes/media.php.
Props kpdesign, DrewAPicture.
Fixes #25375.


git-svn-id: https://develop.svn.wordpress.org/trunk@26908 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-06 05:47:51 +00:00
Scott Taylor 4aa0066736 Use parens to ensure that RegEx OR matches the front when determining that mime-type matches audio|video in attachment_submitbox_metadata().
Props kovshenin.
See #23926.



git-svn-id: https://develop.svn.wordpress.org/trunk@25727 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-08 15:31:32 +00:00
Helen Hou-Sandi ab117ae99c Make sure the attachment file exists before calling filesize() on it. props DrewAPicture. fixes #25170.
git-svn-id: https://develop.svn.wordpress.org/trunk@25608 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-24 20:22:24 +00:00
Helen Hou-Sandi 435c2b5686 Add file size to attachment publish meta box. props desrosj. fixes #25170.
git-svn-id: https://develop.svn.wordpress.org/trunk@25403 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 15:09:35 +00:00
Helen Hou-Sandi bde3435a63 Alignment standards for [25296]. props DrewAPicture. see #25171.
git-svn-id: https://develop.svn.wordpress.org/trunk@25300 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-07 22:06:21 +00:00
Helen Hou-Sandi ed6316d44b Add dynamic classes for attachment metadata submitbox sections. see #22333, #25171.
git-svn-id: https://develop.svn.wordpress.org/trunk@25297 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-07 16:19:39 +00:00
Helen Hou-Sandi e9173ef83b Add media_submitbox_misc_sections and audio_submitbox_misc_sections filters to allow removing or adding of attachment submitbox sections containing attachment metadata. props desroj, DrewAPicture. fixes #25171.
git-svn-id: https://develop.svn.wordpress.org/trunk@25296 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-07 16:18:26 +00:00
Sergey Biryukov e8daea7de7 Use correct array key for filling the attachment title in image_attachment_fields_to_save(). props pross.
Use wp_basename() to avoid issues with UTF-8 characters.
fixes #25236.

git-svn-id: https://develop.svn.wordpress.org/trunk@25277 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 14:09:07 +00:00
Helen Hou-Sandi 5ea9e40fed Add more descriptive classes to submit meta box sections. props nofearinc. fixes #22333.
git-svn-id: https://develop.svn.wordpress.org/trunk@25083 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-22 15:23:41 +00:00
Dion Hulse b971127bac Remove the usage of @$_GET and @$_POST and just check to see if the indicies are set. Fixes #22429
git-svn-id: https://develop.svn.wordpress.org/trunk@25025 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-15 06:05:54 +00:00
Andrew Nacin b43712e0f7 New develop.svn.wordpress.org repository based on the old core.svn repository.
* All WordPress files move to a src/ directory.
 * New task runner (Grunt), configured to copy a built WordPress to build/.
 * svn:ignore and .gitignore for Gruntfile.js, wp-config.php, and node.js.
 * Remove Akismet external from develop.svn. Still exists in core.svn.
 * Drop minified files from src/. The build process will now generate these.

props koop.
see #24976.

and see http://wp.me/p2AvED-1AI.



git-svn-id: https://develop.svn.wordpress.org/trunk@25001 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-07 05:25:25 +00:00