Commit Graph

10 Commits

Author SHA1 Message Date
Gary Pendergast
a75d153eee Coding Standards: Upgrade WPCS to 1.0.0
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.



git-svn-id: https://develop.svn.wordpress.org/trunk@43571 602fd350-edb4-49c9-b593-d223f7449a82
2018-08-17 01:50:26 +00:00
Gary Pendergast
8f95800d52 Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.



git-svn-id: https://develop.svn.wordpress.org/trunk@42343 602fd350-edb4-49c9-b593-d223f7449a82
2017-11-30 23:09:33 +00:00
Sergey Biryukov
c2db3e5baf Embeds: Avoid "Division by zero" warning in embed-content.php template if a thumbnail has a zero height.
Props stevenlinx, aegis123.
Fixes #40931.

git-svn-id: https://develop.svn.wordpress.org/trunk@41902 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 15:08:58 +00:00
Sergey Biryukov
fa9892a8a3 Embeds: Introduce embed_thumbnail_id filter for thumbnail image ID in the embed template.
Props ketuchetan, Dency, jontyravi, Ov3rfly.
Fixes #39759.

git-svn-id: https://develop.svn.wordpress.org/trunk@41565 602fd350-edb4-49c9-b593-d223f7449a82
2017-09-22 17:34:24 +00:00
Dominik Schilling
3edf3be241 Embeds: Don't print the HTML for a featured image if a post has no featured image.
See [36693].
Fixes #37288.

git-svn-id: https://develop.svn.wordpress.org/trunk@37988 602fd350-edb4-49c9-b593-d223f7449a82
2016-07-06 17:07:19 +00:00
Drew Jaynes
32418ef8ed Docs: Standardize DocBlock summaries for hooks that serve to "print" something to use third-person singular verbs.
See #36913.


git-svn-id: https://develop.svn.wordpress.org/trunk@37560 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-25 16:04:37 +00:00
Drew Jaynes
d11f7ed391 Docs: Standardize filter docs in remaining wp-includes/* files to use third-person singular verbs per the inline documentation standards for PHP.
See #36913.


git-svn-id: https://develop.svn.wordpress.org/trunk@37518 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-22 18:49:05 +00:00
Pascal Birchler
e4ed65d87b Embeds: Change attachment metadata condition to prevent a warning in the embeds template.
See #35237.
Fixes #36838 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@37452 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-17 20:32:09 +00:00
Drew Jaynes
b26e3d0508 Docs: Reference the correct embed templates and template parts filenames in headers for embed files introduced or changed in 4.5.
See [36693], #34561. See #35986. Fixes #36352.


git-svn-id: https://develop.svn.wordpress.org/trunk@37087 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-28 18:23:53 +00:00
Drew Jaynes
177351364c Embeds: Introduce embed templates into the template hierarchy via theme-compat.
Splits wp-includes/embed-template.php, introduced in 4.4, into five new templates that can be individually overridden by themes:

* embed.php
* embed-404.php
* embed-content.php
* header-embed.php
* footer-embed.php

Also introduces a new template tag for outputting the site title, `the_embed_site_title()`.

The five new templates live in theme-compat, allowing for graceful fallbacks should themes prefer not to override any or all of them.

Props swissspidy, imath, ocean90, DrewAPicture.
See #34561.


git-svn-id: https://develop.svn.wordpress.org/trunk@36693 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-24 20:56:18 +00:00