Commit Graph

19048 Commits

Author SHA1 Message Date
Sergey Biryukov
ac47170bb5 Docs: Document the $wpdb global in WP_Debug_Data::get_mysql_var().
Follow-up to [51522].

See #53845.

git-svn-id: https://develop.svn.wordpress.org/trunk@51523 602fd350-edb4-49c9-b593-d223f7449a82
2021-08-01 14:03:09 +00:00
Sergey Biryukov
495f4f7641 Site Health: Add some more MySQL information to the Site Health Info screen.
This adds three values to the debug info in the Database section:

* Max allowed packet size
* Max connections number
* Query cache size

Props zodiac1978, donmhico, mukesh27, SergeyBiryukov.
Fixes #53845.

git-svn-id: https://develop.svn.wordpress.org/trunk@51522 602fd350-edb4-49c9-b593-d223f7449a82
2021-08-01 14:00:17 +00:00
Sergey Biryukov
d373e6e0d6 Upgrade/Install: Skip any node_modules directories when removing Genericons example.html files on update.
This can significantly reduce the time required to complete the process in a development environment.

Follow-up to [32386].

Props bobbingwide, afragen, desrosj, SergeyBiryukov.
Fixes #52765.

git-svn-id: https://develop.svn.wordpress.org/trunk@51521 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-31 10:31:51 +00:00
Sergey Biryukov
812d110c5d Taxonomy: Pass correct default value for $post_id to wp_terms_checklist() in the posts list table.
This matches the documented type of the `$post_id` argument and is consistent with other instances of `wp_terms_checklist()` calls.

Per the function documentation, the default value is integer `0`, not `null`.

Follow-up to [13535].

Props tareiking, donmhico, jrf.
Fixes #43639.

git-svn-id: https://develop.svn.wordpress.org/trunk@51520 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-31 09:49:35 +00:00
John Blackbourn
8f3d2b46ad Site Health: Standardise site health check status message punctuation.
Fixes #53594


git-svn-id: https://develop.svn.wordpress.org/trunk@51519 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-30 19:37:54 +00:00
John Blackbourn
4205214eba Docs: Replace $this in hook param docs with more appropriate names.
`$this` is a pseudo-variable that cannot be used as the name of a function parameter, so renaming these helps prevent errors when implementing hook callback functions.

Fixes #53457


git-svn-id: https://develop.svn.wordpress.org/trunk@51518 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-30 19:34:39 +00:00
John Blackbourn
108d4d1ae5 Docs: Add missing documentation for the minute parameter of WP_Query.
See #53399


git-svn-id: https://develop.svn.wordpress.org/trunk@51514 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-30 10:52:39 +00:00
John Blackbourn
ccbfd22833 Docs: Correct the documented allowed range for the minute and second parameters of WP_Query.
These are correctly documented and validated in `WP_Date_Query` as 0-59.

See #53399


git-svn-id: https://develop.svn.wordpress.org/trunk@51513 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-30 10:22:11 +00:00
Jonathan Desrosiers
12a820379a Build/Test Tools: Revert the test and coding standards changes in [51511].
These were temporary for testing Slack messages when GitHub Action workflows fail.

See #52644.

git-svn-id: https://develop.svn.wordpress.org/trunk@51512 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-29 20:02:53 +00:00
Jonathan Desrosiers
7a60b8eb8b Build/Test Tools: Post a message to #core in Slack when a workflow fails.
This adds an additional step to each GitHub Action workflow file that posts a message to #core in Slack every time a workflow run fails.

A minor test and spacing change is included in this commit in order to that messages are posted correctly and will be reverted after testing.

See #52644.

git-svn-id: https://develop.svn.wordpress.org/trunk@51511 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-29 19:47:43 +00:00
Sergey Biryukov
2905c5a9bc Themes: Add "Template Editing" to the list of WordPress theme features.
Follow-up to [meta11158].

Props poena, desrosj.
Fixes #53556. See #meta5802.

git-svn-id: https://develop.svn.wordpress.org/trunk@51510 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-29 14:46:48 +00:00
gziolo
ad976addb3 Build: Split packages and blocks to their webpack configs
It aligns with the changes proposed added in Gutenberg: https://github.com/WordPress/gutenberg/pull/33293.

The idea here is to split the growing webpack config into two parts: blocks and  packages.

We need to add handling for JavaScript files that are going to be used with blocks on the frontend. They didn't work quite well with the current setup for entry points created for packages.

As part of the effort, it adds support for `viewScript` in `block.json` metadata file that is later translated to `$view_script` in `WP_Block_Type` class and exposed as `view_script` from the REST API endpoint for block types.

Props youknowriad, desrosj, aristath.
Fixes #53690.



git-svn-id: https://develop.svn.wordpress.org/trunk@51501 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-28 10:05:01 +00:00
Sergey Biryukov
31c328d990 Networks and Sites: Replace two remaining occurrences of "blog" with "site" in user-facing strings.
Follow-up to [36386], [36416], [36417], [46213].

Props audrasjb.
Fixes #53775.

git-svn-id: https://develop.svn.wordpress.org/trunk@51500 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-28 10:00:51 +00:00
Jonathan Desrosiers
e6ed1b2be9 Coding Standards: Apply some alignment fixes from composer format.
Follow up to [51475].

See #53729.

git-svn-id: https://develop.svn.wordpress.org/trunk@51499 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-27 19:00:54 +00:00
Jonathan Desrosiers
82e4df4cce Upgrade/Install: Add files for 5.8 to the $_old_files list that were missed.
Follow up to [51133], [51459].

Props WFMattR, audrasjb, ocean90, johnbillion, pbiron.
Fixes #53702.

git-svn-id: https://develop.svn.wordpress.org/trunk@51497 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-27 13:56:54 +00:00
Sergey Biryukov
38891dbbcb Bundled Themes: Remove extra trailing spaces from translatable strings in block patterns.
Follow-up to [49583], [51045].

Props audrasjb, mukesh27.
Fixes #53774.

git-svn-id: https://develop.svn.wordpress.org/trunk@51496 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-27 11:26:23 +00:00
Sergey Biryukov
3207c62104 Docs: Clarify the @return value for WP_Filesystem_Base::getnumchmodfromh().
Follow-up to [9117], [51494].

See #53399.

git-svn-id: https://develop.svn.wordpress.org/trunk@51495 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-27 11:00:25 +00:00
Sergey Biryukov
7bb0a17b46 Docs: Correct @return type for WP_Filesystem_Base::getnumchmodfromh().
Follow-up to [9117].

Props ankitmaru, johnbillion.
Fixes #53793.

git-svn-id: https://develop.svn.wordpress.org/trunk@51494 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-27 09:27:51 +00:00
Peter Wilson
000068f637 Bundled Themes: Version Bump 2010, 2011 and 2012.
Version bump three bundled themes to avoid file not found and fatal errors introduced for child themes during the 5.8 release cycle.

* Twenty Ten: Version 3.5 (fatal error & 404)
* Twenty Eleven: Version 3.9 (404)
* Twenty Twelve: Version 3.5 (404)

These updates will be released mid 5.8.1 cycle due to the severity of the issues.

Follow up to [51482,51483].

Props dd32, peterwilsoncc.
Fixes #53777.



git-svn-id: https://develop.svn.wordpress.org/trunk@51486 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-26 03:13:19 +00:00
Sergey Biryukov
9ea5645ec2 Media: Check the posts_per_page value in wp_ajax_query_attachments() before using it as a divisor.
This avoids a "Division by zero" PHP warning if a plugin changes the `posts_per_page` value to zero.

Follow-up to [51145].

Props 2linctools, kapilpaul, audrasjb.
Fixes #53773.

git-svn-id: https://develop.svn.wordpress.org/trunk@51485 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-25 09:55:33 +00:00
Sergey Biryukov
301eb3c8f6 Media: Remove unused code from wp-admin/includes/media.php.
Folow-up to [7043], [7062].

Props rudlinkon, hellofromTonya.
Fixes #53764.

git-svn-id: https://develop.svn.wordpress.org/trunk@51484 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-24 13:02:29 +00:00
Sergey Biryukov
c696a2f773 Bundled Themes: Use correct path for loading images in block patterns.
By using `get_template_directory_uri()` instead of `get_stylesheet_directory_uri()`, we make sure to include the images from the parent theme.

This avoids displaying missing images in block patterns when using a child theme of Twenty Ten, Twenty Eleven, or Twenty Twelve.

Follow-up to [51033], [51103], [51106].

Props audrasjb.
Fixes #53769.

git-svn-id: https://develop.svn.wordpress.org/trunk@51483 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-24 12:40:28 +00:00
Sergey Biryukov
bedd023c3a Twenty Ten: Use correct path for loading block patterns.
By using `get_template_directory()` instead of `get_stylesheet_directory()`, we make sure to include the `block-patterns.php` file from the parent theme.

This avoids a PHP fatal error when using a child theme of Twenty Ten.

Follow-up to [51106].

Props ryelle, sabernhardt, loranrendel.
Fixes #53752.

git-svn-id: https://develop.svn.wordpress.org/trunk@51482 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-23 13:12:31 +00:00
John Blackbourn
0871a0ddc2 Docs: Miscellaneous docblock corrections and improvements.
See #53399


git-svn-id: https://develop.svn.wordpress.org/trunk@51477 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-22 16:53:59 +00:00
Sergey Biryukov
41df21e70d Docs: Add a comment about the $title global usage in various admin files.
This should make it clear that the variable is used as part of the HTML `<title>` tag on admin screens.

Props ravipatel, hellofromTonya, sabernhardt, audrasjb, SergeyBiryukov.
Fixes #53729.

git-svn-id: https://develop.svn.wordpress.org/trunk@51475 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-22 13:51:58 +00:00
Sergey Biryukov
49b11dcad7 Docs: Correct a comment about WebP constants in wp-includes/compat.php.
Follow-up to [50810], [50814].

Props GaryJ, rtm909.
Fixes #53680.

git-svn-id: https://develop.svn.wordpress.org/trunk@51474 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-22 13:06:55 +00:00
Sergey Biryukov
70c9aabf0d Help/About: Add / character to <img> and <source> tags.
While this has no effect on void elements in HTML5, it fixes a minor inconsistency with the rest of core.

Follow-up to [47493], [48834], [50556], [51418].

Props radixweb, ankitmaru, TobiasBg, sabernhardt, audrasjb.
Fixes #53716.

git-svn-id: https://develop.svn.wordpress.org/trunk@51473 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-22 12:57:48 +00:00
Greg Ziółkowski
3f83b50743 I18n: Fix broken loop in WP_Theme_JSON_Resolver
Related issue in Gutenberg: https://github.com/WordPress/gutenberg/issues/33552

The loop in WP_Theme_JSON_Resolver to extract translatable paths was broken, as it contained an immediate and unconditional return. This caused the loop to immediately exit again after the first iteration, thus never actually looping.

Follow-up to [50959].

Props schlessera.
 


git-svn-id: https://develop.svn.wordpress.org/trunk@51472 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-22 10:05:33 +00:00
Greg Ziółkowski
211d94b710 Editor: Conditionally load registered styles for block variations
In WordPress 5.8 we added the ability to only load styles for blocks when these blocks are rendered. However, these optimizations left out block-styles that get added using the register_block_style() function/API.

Props aristath.
Fixes #53616.



git-svn-id: https://develop.svn.wordpress.org/trunk@51471 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-22 08:36:11 +00:00
Jonathan Desrosiers
09bbc174c0 External Libraries: Correct the underscore version used when registering.
The correct version is `1.13.1`.

Follow up to [50650], [50778].

Props david.binda.
Fixes #53713.

git-svn-id: https://develop.svn.wordpress.org/trunk@51469 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-21 12:32:57 +00:00
Jonathan Desrosiers
ca214a3b4c External Libraries: Correct the jquery-form version used when registering.
The correct version is `4.3.0`.

Follow up to [50546].

Props david.binda.
Fixes #53714.

git-svn-id: https://develop.svn.wordpress.org/trunk@51468 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-21 12:19:26 +00:00
Jonathan Desrosiers
0e08acda70 External Libraries: Correct the hoverIntent version used when registering.
Follow up to [50521].

Props david.binda.
Fixes #53715.

git-svn-id: https://develop.svn.wordpress.org/trunk@51467 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-21 12:16:35 +00:00
John Blackbourn
0167d6dd50 Application Passwords: Improve various user-facing and developer-facing terminology.
Fixes #53503, #53691


git-svn-id: https://develop.svn.wordpress.org/trunk@51463 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-19 21:13:36 +00:00
Jonathan Desrosiers
fd872e56fd Upgrade/Install: Add additional files to $_old_files for 5.8.
Follow up to [51134].

Fixes #53367.

git-svn-id: https://develop.svn.wordpress.org/trunk@51459 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-19 00:58:50 +00:00
Jonathan Desrosiers
2001b2252e Build/Test Tools: Update the caniuse browser data and regenerate CSS.
This includes three minor updates to generated CSS files:

- A single `-webkit-` prefix is removed for `min-width`, which was required for Safari <= 10.1 (0.06% total global usage). WordPress only supports the last two versions.
- 2 instances where the `-o-` prefix are added for `tab-size`. This appears to be for Opera Mobile, which has creeped back over the 1% global usage.

Props peterwilsoncc, jorbin.
Fixes #53686.

git-svn-id: https://develop.svn.wordpress.org/trunk@51456 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-19 00:40:49 +00:00
Jonathan Desrosiers
d69216bf55 Bundled Themes: Bump bundled theme versions for WordPress 5.8.
This bumps the version for all bundle themes in preparation for release with WordPress 5.8. The new versions are as follows:

- Twenty Twenty-One: 1.4
- Twenty Twenty: 1.8
- Twenty Nineteen: 2.1
- Twenty Seventeen: 2.8
- Twenty Sixteen: 2.5
- Twenty Fifteen: 3.0
- Twenty Fourteen: 3.2
- Twenty Thirteen: 3.4
- Twenty Twelve: 3.4
- Twenty Eleven: 3.8
- Twenty Ten: 3.4

Props mukesh27, kapilpaul.
Fixes #53277.

git-svn-id: https://develop.svn.wordpress.org/trunk@51455 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-18 23:03:08 +00:00
Riad Benguella
a74568e96d Block Editor: Backport fixes targetted for WordPress 5.8 RC4.
This includes:

 - Suggestion List: Check if a node exists to scroll into view.
 - Autocomplete: reset state for empty text.
 - Adds auxiliary class names for editor styles in the widgets editor.
 - Extract snackbars into a separate component.
 - Rich text: run input rules after composition end.
 - iframe: load inline styles.
 - Multi select: select all: restore ref callback.
 - Writing flow: allow select all from empty selection.
 - Post Excerpt: Fix excerpt_more filter conflict and remove wordCount attribute.
 - Add the percent unit to the default units in Core.

Props desrosj.
See #53397.


git-svn-id: https://develop.svn.wordpress.org/trunk@51443 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-15 18:53:34 +00:00
Jonathan Desrosiers
025e59a1ef Media: Document edge cases with the new image_editor_output_format filter.
More testing has revealed that the `image_editor_output_format` filter has some interesting edge cases that developers should be aware of when electing to use this filter (see #53667 and #53668).

Because this is a new filter that was intended to be used for experimenting with different ways to handle generating image sizes and has not yet been adopted in the wild, expanding the inline documentation is an acceptable temporary solution while these edge cases are explored further and addressed.

Props mikeschroder, antpb, desrosj, adamsilverstein, ianmjones.
See #5366, #53668, #35725.

git-svn-id: https://develop.svn.wordpress.org/trunk@51442 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-15 17:38:57 +00:00
Joe Dolson
41ba4acb83 Media: Fix JS error in Media Library when infinite scroll enabled.
Wrap call to this.updateLoadMoreView() is wrapped in a check that infinite scroll is disabled to prevent JS errors.

Props wildworks.
Fixes #53672.

git-svn-id: https://develop.svn.wordpress.org/trunk@51440 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-15 16:59:26 +00:00
Andrew Ozz
f17f4f5f7e Media: When resizing WebP images set the compression to "lossy" by default. Fixes a bug where the compression was set to "lossless" when the uploaded WebP images have extended file format (VP8X).
Props adamsilverstein, mikeschroder, mmxxi, linux4me2.
Fixes #53653.

git-svn-id: https://develop.svn.wordpress.org/trunk@51435 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-15 00:41:44 +00:00
Jonathan Desrosiers
256a0eea8a Bundled Themes: Revert the [51372] update to block patterns in bundled themes.
Upon further examination, this change was not great for backwards compatibility, resulting in block validation errors when running on older versions of WordPress.

While there are currently many `console.info()` notices caused by older format block syntax being updated to the current version included in WordPress 5.8, the blocks do not break.

Block patterns do not currently have a versioning mechanism, or a means to indicate which versions of WordPress are supported.

See #53617.

git-svn-id: https://develop.svn.wordpress.org/trunk@51434 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-14 20:01:21 +00:00
Jonathan Desrosiers
906c450e94 Widgets: Prevent widgets unintentionally being moved to the inactive sidebar.
This fixes a bug where widgets are unintentionally moved to the `wp_inactive_widgets` sidebar when batch updates occur through the REST API.

When batch requests are processed, only `$_wp_sidebars_widgets is updated by previous calls to `WP_REST_Widgets_Controller::create_item()`. `$sidebars_widgets` is not aware of the new widget’s intended location, and `retrieve_widgets()` mistakenly flags the widget as inactive.

Calling `wp_get_sidebars_widgets()` before `retrieve_widgets()` ensures both global variables match and is intended as a temporary fix until the root cause of the problem can be fixed.

Props zieladam, htmgarcia, timothyblynjacobs.
Fixes #53657.

git-svn-id: https://develop.svn.wordpress.org/trunk@51432 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-14 16:44:59 +00:00
Jonathan Desrosiers
9f760e96b4 Privacy: Ensure the copy button actually copies the suggested privacy policy text.
Follow up to [50609].

Props walbo, SergeyBiryukov.
Fixes #53652. See #52891.

git-svn-id: https://develop.svn.wordpress.org/trunk@51431 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-14 16:16:41 +00:00
Sergey Biryukov
4eb17be18c Docs: Synchronize the $post_id argument description for some post and attachment functions.
See #53399.

git-svn-id: https://develop.svn.wordpress.org/trunk@51430 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-14 08:12:24 +00:00
Jonathan Desrosiers
a828773635 Editor: Second round of package updates ahead of RC3.
Props ellatrix, peterwilsoncc, get_dave, mcsf, talldanwp, youknowriad, desrosj.

git-svn-id: https://develop.svn.wordpress.org/trunk@51426 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-13 23:56:18 +00:00
Sergey Biryukov
96d3c4c5e5 Docs: Correct documentation for wp_get_post_parent_id().
The `$post` parameter is required and does not have a default value.

Follow-up to [42397].

Props denisco.
See #53399.

git-svn-id: https://develop.svn.wordpress.org/trunk@51425 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-13 18:33:10 +00:00
Jonathan Desrosiers
7cb4cc175b Coding Standards: Use the correct formatting for multi-line comments.
Follow up to [51414].

git-svn-id: https://develop.svn.wordpress.org/trunk@51423 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-13 18:01:58 +00:00
Riad Benguella
bed9d00fbd Block Editor: Include the fixes targetted for WordPress 5.8 RC3.
This includes the following fixes:
 - Safari: see if compositing layer size is more reasonable when position fixed divs are not inserted into content.
 - Site Logo Block: update Site Logo block UI and option syncing.
 - Fix moving inner blocks in the Widgets Customizer.
 - Allow themes to provide empty values for color.duotone and spacing.units
 - Update getTermsInfo() to workaround parsing issue for translatable strings.
 - Specify what settings can be part of settings.layout.
 - Update conditions to hide duotone panel.
 - Prevent entering invalid values in the Query Loop block config.
 - Prevent color panel from showing as empty.
 - Avoid calling gutenberg_ functions within code shipped through WordPress Core.

Props desrosj.
See #53397.


git-svn-id: https://develop.svn.wordpress.org/trunk@51421 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-13 16:39:05 +00:00
Kelly Choyce-Dwan
16d538c0f8 Help/About: Update the About page for 5.8.
Use a larger image for theme.json on retina screens, and update the spacing of sections on the page.

Props javiarce.
See #52775.



git-svn-id: https://develop.svn.wordpress.org/trunk@51418 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-13 15:38:12 +00:00
Mike Schroder
84a22c3f98 Customizer: Don’t always set normalizedTransitionendEventName to null.
Reverts [51389].

Unprops mikeschroder.
See #53562.



git-svn-id: https://develop.svn.wordpress.org/trunk@51417 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-13 14:03:19 +00:00