Commit Graph
129 Commits
Author SHA1 Message Date
Scott Taylor c8a44d437a Add @static* annotations where they are missing.
Initialize all static vars that are not, most to `null`.

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32650 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 15:42:40 +00:00
Scott Taylor 928dc46a3b Add missing doc blocks to formatting.php.
Rehabilitate the spacing of various doc blocks.
Standardize some return values that are adjacent to similar functions.

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32590 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-25 02:58:00 +00:00
Boone Gorges 5de66efda6 In sanitize_option(), pass the unsanitized $value to the filter.
Props simonwheatley, MikeHansenMe.
Fixes #26199.

git-svn-id: https://develop.svn.wordpress.org/trunk@32520 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-21 17:59:58 +00:00
Andrew Ozz 099c066e24 Check if running from /src or SCRIPT_DEBUG is defined in print_emoji_detection_script().
See #32118.

git-svn-id: https://develop.svn.wordpress.org/trunk@32482 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-10 18:23:21 +00:00
Sergey Biryukov 04ef03636e Check if SCRIPT_DEBUG is defined before using it in print_emoji_detection_script().
props Craig Ralston.
fixes #32118 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@32296 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-26 10:35:53 +00:00
Gary Pendergast 96f12cc588 Clean up some edge cases in sanitize_sql_orderby().
Props vortfu, dd32.



git-svn-id: https://develop.svn.wordpress.org/trunk@32164 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 05:41:37 +00:00
Andrew Nacin 62b51d8c0b Clean up wp_staticize_emoji() and friends.
* DOMDocument was removed in [31752] but not the check.
 * wp_staticize_emoji() has never accepted a second arg; remove it from calls.
 * Remove wp_staticize_emoji_for_feeds(), no need for it.
 * Remove _ and @ignore from wp_staticize_emoji_for_email(), no need for it.

see #31242.


git-svn-id: https://develop.svn.wordpress.org/trunk@32161 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 04:14:32 +00:00
pento cd9374f061 Emoji: The emoji JS files should be run through the script_loader_src filter, as they would be if they were registered scripts.
Props peterwilsoncc.

Fixes #31938.



git-svn-id: https://develop.svn.wordpress.org/trunk@32097 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-09 11:06:03 +00:00
Gary Pendergast dcfb3532c1 Emoji: Tidy up the wp_encode_emoji() regex, and clarify the function comment on Unicode 8 support.
git-svn-id: https://develop.svn.wordpress.org/trunk@32096 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-09 04:36:57 +00:00
Drew Jaynes b04e2d5611 Various docs syntax fixes in wp-includes/formatting.php.
See #31888.


git-svn-id: https://develop.svn.wordpress.org/trunk@32039 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-05 15:50:53 +00:00
Gary Pendergast 01cbacb308 Emoji: [31938] forgot a / in the emoji CDN URL.
See #31651.



git-svn-id: https://develop.svn.wordpress.org/trunk@31977 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-02 00:10:36 +00:00
Scott Taylor bcf98c7742 Alter the regex in wptexturize() to properly handle input like: <> "Hello world" <>.
Updates unit test data.

Props miqrogroove.
Fixes #30344.


git-svn-id: https://develop.svn.wordpress.org/trunk@31965 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 19:08:31 +00:00
Gary Pendergast 48e551feb5 Emoji: Change the emoji CDN to w.org, from wp.com.
See #31651.



git-svn-id: https://develop.svn.wordpress.org/trunk@31938 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-31 04:30:38 +00:00
Gary Pendergast 3945ee3f86 Emoji: When encoding emoji into HTML entities, 0 was being incorrectly trimmed from the right side of the hex string, causing some characters to be encoded incorrectly.
git-svn-id: https://develop.svn.wordpress.org/trunk@31926 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-30 03:26:44 +00:00
Gary Pendergast 2fd1791bc1 Emoji: When staticizing emoji into <img> tags, include an alt attribute of the original Emoji, to match both Smiley and Twemoji <img> tags.
git-svn-id: https://develop.svn.wordpress.org/trunk@31924 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-30 03:08:28 +00:00
Gary Pendergast eced539d8b Emoji: [31864] changed emoji image's inline style from height to max-height. Unfortunately, anything using feedparser.py (for example, NewsBlur) strips out max-height, which gives us massive emoji in feeds.
This re-adds `height`, and also reminds us why we can't have nice things.

See #31719.



git-svn-id: https://develop.svn.wordpress.org/trunk@31909 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-27 02:11:45 +00:00
Gary Pendergast 76eee7be6a Emoji: Add a comment to print_emoji_detection_script() explaining how the include statement works as part of the grunt build process.
See #31701.



git-svn-id: https://develop.svn.wordpress.org/trunk@31881 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-25 04:08:07 +00:00
Gary Pendergast 5a0564bb8f Emoji: Instead of loading the emoji JS files automatically, we now include a small JS shim in the header, to test if the user's browser needs Twemoji. It then loads the emoji JS files only if they're needed.
Props pento, azaozz.

Fixes #31701.



git-svn-id: https://develop.svn.wordpress.org/trunk@31875 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-24 23:32:23 +00:00
Gary Pendergast b3e3766233 Emoji: Gmail doesn't obey an <img>'s inline CSS height rule, transforming it to min-height. To avoid giant smiley faces everywhere, we're changing the height rule to max-height, which Gmail plays nicer with.
Props janhenckens.

Fixes #31719.



git-svn-id: https://develop.svn.wordpress.org/trunk@31864 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-23 12:07:47 +00:00
Gary Pendergast 4d8a13fe33 Emoji: Set the emoji image protocol with set_url_scheme(), instead of defaulting to HTTPS.
Props extendwings.

Fixes #31735.



git-svn-id: https://develop.svn.wordpress.org/trunk@31861 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-23 02:10:35 +00:00
Gary Pendergast 48cb73bba1 Emoji: When we're replacing emoji with <img>s in email, we can only do that if the Content-Type is text/html - otherwise, they'll show up in the email as the HTML string.
Fixes #31720 



git-svn-id: https://develop.svn.wordpress.org/trunk@31860 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-22 23:15:34 +00:00
Drew Jaynes b939e06b06 Add more verbose inline documentation inside of wpautop() to more clearly explain what's going on.
Props ericlewis, johneckman, azaozz.
Fixes #31041.


git-svn-id: https://develop.svn.wordpress.org/trunk@31852 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-20 19:46:41 +00:00
Gary Pendergast e3b2637699 When converting emoji in email to static images, check that the message is defined, otherwise we could cause PHP warnings.
Props nerrad.

Fixes #31708.




git-svn-id: https://develop.svn.wordpress.org/trunk@31847 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-20 12:31:30 +00:00
Gary Pendergast 2b3cfead22 Emoji: Rename the email and feed filter functions to be _ prefixed, and @ignore-d in the PHPDocs.
See #31242



git-svn-id: https://develop.svn.wordpress.org/trunk@31791 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-16 10:45:29 +00:00
Sergey Biryukov 47c69c3207 Fix typo in a comment in [31752].
see #31242.

git-svn-id: https://develop.svn.wordpress.org/trunk@31790 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-16 01:55:53 +00:00
Drew Jaynes 7bbdceb336 Clean up some inline documentation for emoji functionality, including a missing @since for mail_emoji(), and a changelog entry for wp_insert_post().
See #31242.


git-svn-id: https://develop.svn.wordpress.org/trunk@31789 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-16 01:42:26 +00:00
Andrew Ozz 005ff9a8c8 Emoji:
- Add the styling for the replacement images to the admin CSS.
- Revert to using `.emoji` as replacement image class.
- When pasting in the editor, convert emoji images to our format so we can replace them with chars on saving.
- Some more clean up of both the plugin and wp-emoji.js.
See #31242.

git-svn-id: https://develop.svn.wordpress.org/trunk@31786 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-15 23:15:28 +00:00
Gary Pendergast 3503aa4820 Smilies: The new smilies added in [31733] and [31745] are larger than the old smilies. While this is taken care of by the CSS on normal pages, it means they're disproportionally large when seen in RSS and email.
By adding a little bit of inline style to them, we get pleasingly sized smilies everywhere. :-)

See #31242



git-svn-id: https://develop.svn.wordpress.org/trunk@31781 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-15 11:40:16 +00:00
Sergey Biryukov 870da19630 Emoji and smiley images should be displayed inline.
see #31242.

git-svn-id: https://develop.svn.wordpress.org/trunk@31771 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-13 18:44:40 +00:00
Gary Pendergast fa3131ee02 Emoji: There's a little tear in my eye as I remove DOMDocument from the Emoji staticizer. It was a beautiful dream, but it wasn't to be.
Instead, let's use the tried and trusted smiley replacement algorithm, which has stood the test of time.

See #31242



git-svn-id: https://develop.svn.wordpress.org/trunk@31752 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-12 13:16:34 +00:00
Gary Pendergast 1357e7fc2e Add emoji URL support, and Twemoji fallback for displaying slugs in wp-admin, when the browser doesn't natively support emoji.
Props pento, SergeyBiryukov and boonebgorges.

Fixes #31328



git-svn-id: https://develop.svn.wordpress.org/trunk@31734 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-11 22:54:49 +00:00
Gary Pendergast ae391ec226 Add emoji support, with Twemoji fallback.
Replace exisiting smilies with equivalent emoji, or with shiny new smiley images where no emoji existed.

Props batmoo, joen and mkaz for the original plugin upon which this is based.

Props pento, iseulde, kraftbj and peterwilsoncc for making the internet's dreams come true.

See #31242



git-svn-id: https://develop.svn.wordpress.org/trunk@31733 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-11 22:48:16 +00:00
Scott Taylor edf982fcd5 Avoid function calls on each iteration of a for loop.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31678 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-08 23:00:21 +00:00
Scott Taylor 79706ee8a8 Don't call the size function count() as part of a test condition in loops. Compute the size beforehand, and not on each iteration.
Scrutinizer added a Performance label: these are the only violations.

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31554 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-26 05:47:53 +00:00
Gary Pendergast 3a87ef36e2 Texturize: Add "em" as a cockney term, so that "'em" is texturized with an apostrophe, instead of an open quote.
Fixes #29813.

Props miqrogroove.



git-svn-id: https://develop.svn.wordpress.org/trunk@31249 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-20 18:43:30 +00:00
Gary Pendergast c8c8b66bae When a hyphen - or double hyphen -- was at the start or the end of a string, it wasn't texturized correctly.
Fixes #31030



git-svn-id: https://develop.svn.wordpress.org/trunk@31199 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 03:54:00 +00:00
Scott Taylor 0c71d0033a Ensure that <figcaption> is not autop'd.
Fixes #29219.


git-svn-id: https://develop.svn.wordpress.org/trunk@31186 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 00:26:36 +00:00
Scott Taylor 979ba60a57 Fix some @param docs that have chars too close them.
Add `@property` annotations to `WP_User` and `WP_Post`.
Remove erroneous `@param`s from image editor class methods.
Officially add the property `$_column_headers` to `WP_List_Table`.	

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31127 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-10 06:56:51 +00:00
Scott Taylor 6fd11624d1 The keyword elseif should be used instead of else if so that all control keywords look like single words.
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs. 

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31090 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 07:04:40 +00:00
Scott Taylor 5d6cc49628 Perl-style comments should not be used
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31079 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 05:51:39 +00:00
Gary Pendergast d3d11c704d Options: When updating options, make sure the user isn't trying to insert characters that aren't supported by the database character set.
See #30361.


git-svn-id: https://develop.svn.wordpress.org/trunk@31064 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-07 04:14:32 +00:00
Scott Taylor 218dd4fd6b For clarity, initialize some arrays that previously were only assigned via short circuit in loops.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30982 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 22:46:53 +00:00
Dion Hulse 8a5ea24f61 In the links_add_base() callback, use a HTTP-aware URL joining function, rather than a filesystem joining function to avoid PHP warnings on certain systems.
Fixes #29950


git-svn-id: https://develop.svn.wordpress.org/trunk@30766 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 03:18:06 +00:00
Mark Jaquith 71bb091cc3 Revert [28719] and no longer math-process multiplication of negative numbers
see #19308
fixes #30445
props rmccue

git-svn-id: https://develop.svn.wordpress.org/trunk@30752 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-06 21:23:12 +00:00
Scott Taylor 4d46475b3d Improve various @param docs for src/wp-includes/*.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30681 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 01:33:34 +00:00
Dion Hulse 01b2c45025 Fix the PHPDoc example for _split_str_by_whitespace().
Props voldemortensen. Fixes #30504


git-svn-id: https://develop.svn.wordpress.org/trunk@30575 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-26 03:51:48 +00:00
Drew Jaynes (DrewAPicture) ac07c17400 Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements in wp-includes/formatting.php:
* Markdown-indent code snippets in the description for `wptexturize()`
* Backtick-escape inline code in a parameter description for `_wptexturize_pushpop_element()`
* Backtick-escape inline code in the description for `shortcode_unautop()`
* Backtick-escape HTML tags in the description for `convert_chars()`
* Markdown-indent a code snippet in the description for `_split_str_by_whitespace()`
* Backtick-escape an `<img>` tag in the description for `translate_smiley()`
* Add markdown formatting to the description for `links_add_target()`
* Backtick-escape HTML tags in the description for `wp_strip_all_tags()`

Props rarst.
See #30473.


git-svn-id: https://develop.svn.wordpress.org/trunk@30540 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 05:29:43 +00:00
Drew Jaynes (DrewAPicture) 6866523f2b Add an entry to the changelog for wp_make_link_relative() noting that intentional support was added for relative URLs.
See #30373.


git-svn-id: https://develop.svn.wordpress.org/trunk@30496 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-21 03:43:06 +00:00
Andrew Nacin fb28a78331 Anchor texturize to shortcodes to improve regex efficiency.
props miqrogroove.
see #29557 for segfault issues.


git-svn-id: https://develop.svn.wordpress.org/trunk@30449 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-20 14:27:08 +00:00
Boone Gorges d1e841c03b Improvements to wp_make_link_relative().
* Support relative URL input.
* When the URL being made relative has another URL as a parameter, don't make the second URL relative.

Props voldemortensen.
Fixes #30373.

git-svn-id: https://develop.svn.wordpress.org/trunk@30383 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-19 01:52:57 +00:00