Commit Graph

8476 Commits

Author SHA1 Message Date
Sergey Biryukov
aee17a059f Docs: Use code formatting for tags in img_caption_shortcode() DocBlock.
See #34595.

git-svn-id: https://develop.svn.wordpress.org/trunk@42705 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-12 21:39:40 +00:00
Sergey Biryukov
32e994e478 Media: Pass original attribute values to img_caption_shortcode_width filter instead of markup pieces.
Add `caption_id` to the list of documented `[caption]` shortcode attributes.

See #34595.

git-svn-id: https://develop.svn.wordpress.org/trunk@42704 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-12 21:36:36 +00:00
Sergey Biryukov
6a43b1658f Comments: Avoid a PHP notice in paginate_comments_links() if type argument is set to array.
The function is a wrapper for `paginate_links()`, which returns an array if requested.

Props anantajitjg.
Fixes #43299.

git-svn-id: https://develop.svn.wordpress.org/trunk@42703 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-12 21:11:13 +00:00
Sergey Biryukov
a62a77eeb7 Media: After [42695], remove redundant check that is already performed a few lines above.
Props gnif.
See #43255.

git-svn-id: https://develop.svn.wordpress.org/trunk@42702 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-11 21:54:23 +00:00
Sergey Biryukov
9cde54cbda Database: In require_wp_db(), check if database constants are defined before using them.
Otherwise, `wp-admin/setup-config.php` triggers an undefined constant warning in PHP 7.2.

Props mariusvw, jryancard for initial patch.
Fixes #35560.

git-svn-id: https://develop.svn.wordpress.org/trunk@42701 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-11 18:46:48 +00:00
Sergey Biryukov
1ac83e86f5 Docs: Fix typo in term_exists() DocBlock.
Props milana_cap, danieltj.
Fixes #43268.

git-svn-id: https://develop.svn.wordpress.org/trunk@42699 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-11 17:15:47 +00:00
Sergey Biryukov
2e2fd97287 Networks and Sites: In get_site_by_path(), use single domain and path parameters if there's only one item to look for.
This should increase the chances of `WP_Site_Query::get_sites()` hitting an existing cache.

Props spacedmonkey.
Fixes #42299.

git-svn-id: https://develop.svn.wordpress.org/trunk@42698 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-11 17:08:58 +00:00
Sergey Biryukov
4bc7afd701 Media: Add aac to the list of allowed file types.
Props desrosj.
Fixes #42919.

git-svn-id: https://develop.svn.wordpress.org/trunk@42697 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-11 16:39:54 +00:00
Sergey Biryukov
fca30d4b0e Docs: Fix typo in wp_audio_extensions and wp_video_extensions filter descriptions.
See #42505.

git-svn-id: https://develop.svn.wordpress.org/trunk@42696 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-11 16:28:29 +00:00
Sergey Biryukov
909424b9af Media: In WP_Image_Editor::make_image(), close previously opened output buffer if the file could not be created.
Props dhanendran, gnif.
Fixes #43255.

git-svn-id: https://develop.svn.wordpress.org/trunk@42695 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-11 16:24:05 +00:00
Sergey Biryukov
0711e585fb Media: After [42693], update HTML4 markup in img_caption_shortcode() to avoid an empty ID attribute as well.
Add a unit test for `aria-describedby` in `img_caption_shortcode()`.

See #34595.

git-svn-id: https://develop.svn.wordpress.org/trunk@42694 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-11 15:39:20 +00:00
Sergey Biryukov
bff366759c Media: Only add aria-describedby in img_caption_shortcode() if a non-empty attachment ID attribute was provided.
See #34595.

git-svn-id: https://develop.svn.wordpress.org/trunk@42693 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-11 15:19:58 +00:00
Sergey Biryukov
b66da520b3 Media: Make sure $caption_id does not depend on an undefined variable.
See #34595.

git-svn-id: https://develop.svn.wordpress.org/trunk@42692 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-11 14:52:03 +00:00
Sergey Biryukov
10ee22ee46 Media: Add aria-describedby to img_caption_shortcode() output to improve image/caption relationship.
Props joedolson.
Fixes #34595.

git-svn-id: https://develop.svn.wordpress.org/trunk@42691 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-11 14:43:40 +00:00
Sergey Biryukov
2b08bfb954 Media: Convert concatenation in img_caption_shortcode() to sprintf() for clarity.
See #34595.

git-svn-id: https://develop.svn.wordpress.org/trunk@42690 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-11 14:16:43 +00:00
Sergey Biryukov
5e9067e8b9 Administration: Remove erroneous transition-delay values from CSS files.
Although unitless zero is allowed for `<length>` CSS data type, it's invalid for `<time>` data type.

Props chetan200891, manuel_84, GaryJ.
Fixes #43195.

git-svn-id: https://develop.svn.wordpress.org/trunk@42689 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-11 12:54:15 +00:00
Drew Jaynes
849fb422f5 Docs: Fix a copy paste error in the DocBlock summary for wp_ssl_constants(), see [13062].
Props terriann.
Fixes #43272.


git-svn-id: https://develop.svn.wordpress.org/trunk@42683 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-09 18:20:15 +00:00
John Blackbourn
9f154bbf21 HTTP API: Add the URL as a paramter to various HTTP related filters.
Props paulschreiber, purnendu

Fixes #42186


git-svn-id: https://develop.svn.wordpress.org/trunk@42682 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-09 18:10:15 +00:00
John Blackbourn
a88b338034 Docs: Un-correct an incorrection correction.
See [42680]

See #42505


git-svn-id: https://develop.svn.wordpress.org/trunk@42681 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-09 17:56:07 +00:00
John Blackbourn
5e0b06da49 Docs: Correct some secondary documentation for the https_local_ssl_verify and https_ssl_verify filters.
See #42505


git-svn-id: https://develop.svn.wordpress.org/trunk@42680 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-09 17:47:19 +00:00
John Blackbourn
4836686b6f Docs: Add missing code formatting to various @since entries.
See #42505


git-svn-id: https://develop.svn.wordpress.org/trunk@42678 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-09 16:54:58 +00:00
Anton Timmermans
6e125f017e Docs: Improve JSDoc for media/views/spinner.js.
Props avillegasn.
Fixes #43230.


git-svn-id: https://develop.svn.wordpress.org/trunk@42675 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-09 14:31:18 +00:00
Sergey Biryukov
90fe609bc4 Customize: Avoid extra tabs in a textarea in WP_Customize_Control::render_content().
See #43252.

git-svn-id: https://develop.svn.wordpress.org/trunk@42673 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-08 10:57:41 +00:00
John Blackbourn
37a1552e39 Docs: Copy a helpful inline doc into the function header for visibility.
See #42505


git-svn-id: https://develop.svn.wordpress.org/trunk@42664 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-07 22:12:50 +00:00
Boone Gorges
fa266b4724 Improve parameter description for 'allow_empty_comments'.
Introduced in [42661].

Props swissspidy.
See #16979.

git-svn-id: https://develop.svn.wordpress.org/trunk@42662 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-07 20:49:26 +00:00
Boone Gorges
4f22e04244 Comments: Introduce 'allow_empty_comment' filter.
This filter allows plugin authors to allow empty comments on a selective
basis during comment submission.

Props jpurdy647.
Fixes #16979.

git-svn-id: https://develop.svn.wordpress.org/trunk@42661 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-07 20:08:47 +00:00
Drew Jaynes
602117f2b9 Docs: Fix a typo in the DocBlock description for get_bloginfo() illustrating the URL structure for RDF feeds.
Props ibachal.
See #42505.


git-svn-id: https://develop.svn.wordpress.org/trunk@42660 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-07 19:41:29 +00:00
Drew Jaynes
79a06efdb8 Docs: Document default arguments for wp_tag_cloud() in a hash notation, noting that full lists of additionally-supported arguments are already documented in get_terms() and wp_generate_tag_cloud().
Props birgire, johnbillion.
Fixes #42019.


git-svn-id: https://develop.svn.wordpress.org/trunk@42658 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-07 15:21:25 +00:00
Felix Arntz
ea13c56d7f Options: Unhook default option filter when setting is unregistered.
Fixes #43207.


git-svn-id: https://develop.svn.wordpress.org/trunk@42655 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-06 14:48:46 +00:00
Dion Hulse
e04b4d47b4 Updates: Partially revert [42584], as this branch of code should always be run after a core update check.
This code branch is responsible for running all autoupdates, including plugins and themes - which should run regardless of if there's a core autoupdate available.

This revert does not revert the `$timeout` changes, as these should still use cached data if it's available.
Ideally this should be decoupled from the core update check to allow background updates to operate even when the core update check is disabled or running more often than twice daily.

See #43103.


git-svn-id: https://develop.svn.wordpress.org/trunk@42653 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-06 11:03:55 +00:00
Dion Hulse
5789855ed1 XML-RPC: Add default values to IXR_Message for PHP 7.2 compatibility to avoid PHP Warnings.
Fixes #43216 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@42652 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-06 02:55:38 +00:00
Peter Wilson
5c378e02dd Taxonomy: Stop warming term meta cache unnecessarily.
Prevent several core function calls to `get_terms()` from warming the term meta cache.

Props peterwilsoncc, boonebgorges, jrf.
Fixes #43142.



git-svn-id: https://develop.svn.wordpress.org/trunk@42649 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-05 04:09:27 +00:00
Peter Wilson
f317869c7f General: Replace Cheatin’ uh? with friendlier error messages.
While intended as a playful error message, `Cheatin’ uh?` can be interpreted as insulting or accusatory in an already stressful situation. This replaces Cheatin’ with more meaningful error messages, depending on the error that occurs.

Props ElectricFeet, EricMeyer, karmatosed, dd32, BandonRandon, melchoyce for language; dmsnell for original patch; peterwilsoncc.
Fixes #38332.



git-svn-id: https://develop.svn.wordpress.org/trunk@42648 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-05 02:29:53 +00:00
John Blackbourn
d512973c84 Canonical: Add $x_redirect_by parameter to wp_safe_redirect().
See [42633] and [42408].

Fixes #42313.


git-svn-id: https://develop.svn.wordpress.org/trunk@42647 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-04 16:04:10 +00:00
Andrea Fercia
ce61a7f676 Administration: CSS coding standards: use double quotes for values that require quotes.
As per the WordPress CSS coding standards, CSS properties with values that require quotes must use double quotes.
Also fixes some indentation and spacing.

Fixes #43220.


git-svn-id: https://develop.svn.wordpress.org/trunk@42641 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-03 13:18:40 +00:00
Sergey Biryukov
3bbe18ee1c Docs: Convert $args array description for wp_get_themes() to a hash notation.
Props milana_cap.
Fixes #43213.

git-svn-id: https://develop.svn.wordpress.org/trunk@42640 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-02 09:37:47 +00:00
Sergey Biryukov
579f04fb06 Media: Avoid a PHP warning in wp_calculate_image_srcset() if a plugin returns a non-array value via wp_calculate_image_srcset filter.
Props mrmadhat, codegrau.
Fixes #43201.

git-svn-id: https://develop.svn.wordpress.org/trunk@42639 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-02 07:47:03 +00:00
Sergey Biryukov
534f096302 Menus: Remove $_menu_item_sort_prop global reference from wp_get_nav_menu_items(), unused since [38928].
Props PieWP, welcher.
Fixes #40947.

git-svn-id: https://develop.svn.wordpress.org/trunk@42634 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-01 15:41:55 +00:00
Sergey Biryukov
40f76ae917 Canonical: Add $x_redirect_by parameter to wp_redirect() that allows applications doing the redirect to identify themselves.
This complements the `x_redirect_by` filter added in [42408].

Props NathanAtmoz, johnbillion.
Fixes #42313.

git-svn-id: https://develop.svn.wordpress.org/trunk@42633 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-01 15:05:50 +00:00
Dion Hulse
212c880d71 Themes: Use api.wordpress.org/themes/info/1.2/ to query theme information.
See #43192.


git-svn-id: https://develop.svn.wordpress.org/trunk@42632 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-01 05:18:54 +00:00
Sergey Biryukov
cc9a5641a6 Docs: Correct erroneous class references in @see tags.
Props coffee2code.
Fixes #43158.

git-svn-id: https://develop.svn.wordpress.org/trunk@42630 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-01 01:19:50 +00:00
Sergey Biryukov
1c0257d340 Code Editor: Add Ctrl/Cmd+F as aliases for persistent search for more intuitive behaviour.
Keep Alt+F as well for users who already expect that.

Props Desertsnowman.
See #42586.

git-svn-id: https://develop.svn.wordpress.org/trunk@42625 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-31 22:21:53 +00:00
Andrea Fercia
37e81feb9f Media: avoid page scrolling when opening the media modal.
Moves focus to a proper element within the media modal to avoid the underlying
page to scroll to the bottom. Removes the media modal `freeze` option.

Props andreiglingeanu, adamsilverstein.
Fixes 39859.


git-svn-id: https://develop.svn.wordpress.org/trunk@42624 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-31 17:02:27 +00:00
Adam Silverstein
d6788fec51 Correct the version term_search_min_chars changed. Ammends r42614.
git-svn-id: https://develop.svn.wordpress.org/trunk@42616 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-30 00:29:29 +00:00
Weston Ruter
0e818c7aee Customize: Ensure customize_autosaved requests only use revision of logged-in user.
Props dlh, westonruter.
See #42433, #39896.
Fixes #42450.


git-svn-id: https://develop.svn.wordpress.org/trunk@42615 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-30 00:20:37 +00:00
Adam Silverstein
04b0a0f77c Taxonomy: Use REST API for ajax tag search.
Deprecate wp_ajax_ajax_tag_search and switch to using the REST API when searching tags in the tags meta box.

Props nacin, chriscct7, afercia, swissspidy, jnylen0, rmccue, ryelle.
Fixes #38922.



git-svn-id: https://develop.svn.wordpress.org/trunk@42614 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-30 00:16:37 +00:00
Weston Ruter
07e4b7565e Customize: Ensure media playlists get initialized after selective refresh; expose new wp.playlist.initialize() API.
In particular allows audio and video playlists to be added to the Text widget and previewed.

Props bpayton, westonruter.
See #40854.
Fixes #42495.


git-svn-id: https://develop.svn.wordpress.org/trunk@42613 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-29 23:55:44 +00:00
Weston Ruter
8561f22f4d Customize: Ensure heartbeat keeps changeset locked when in branching mode.
Props dlh.
See #42024.
Fixes #42658.


git-svn-id: https://develop.svn.wordpress.org/trunk@42612 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-29 23:04:22 +00:00
Weston Ruter
b31563e561 Customize: Include nav menu item for Home custom link in search results for "Home".
Props audrasjb, westonruter.
Fixes #42991.


git-svn-id: https://develop.svn.wordpress.org/trunk@42611 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-29 22:09:55 +00:00
Gary Pendergast
afb4f45e62 Emoji: Tweak the generated emoji arrays to not cause coding standards errors.
Props netweb, jrf.
Fixes #43150.



git-svn-id: https://develop.svn.wordpress.org/trunk@42610 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-25 01:05:01 +00:00