vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-08-30 13:40:25 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
28,624 Commits 1 Branch 0 Tags
b23a9d9dff29016a4b7e43aed3bcafbb642c6b33
Commit Graph
2176 Commits
Author SHA1 Message Date
Scott Taylor b23a9d9dff In Custom_Background: 
* In [28481], `$admin_header_callback` and `$admin_image_div_callback` were set to `private` based on their erroneous `@param` value
* `$admin_header_callback` and `$admin_image_div_callback` are used as hook callbacks - as such, they must be `public`
* In [28521] and [28524], magic methods were added for back-compat
* Currently, there are 2 properties marked `private`, `$page` and `$updated` - `$page` is never used and `$updated` was added by me in [30186] during 4.1

Set `$admin_header_callback` and `$admin_image_div_callback` to `public`.
Remove the `$page` property - it duplicated the `$page` local var and is referenced/used nowhere.
Remove the magic methods - they were beyond overkill and rendered moot by the above changes.

See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31133 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 21:58:19 +00:00
Scott Taylor 358b309da9 In edit-form-advanced.php: 
* `get_permalink( $post_ID )` can return `false`, set it to a variable and check it
* Using the variable allows us to replace 11 separate calls to `get_permalink( $post_ID )` in the file
* These notices were triggered by the potential for `false` to be passed to `esc_url()`

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31131 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 21:20:01 +00:00
Scott Taylor d4c4205f31 get_header_image() can return false. In Custom_Image_Header->step_1(), check the value before setting the background-image portion of the style attribute. Setting the the URL to empty string will cause the current request to be set as the source of the background image. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31130 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 21:07:54 +00:00
Scott Taylor 0f54cc95b3 Since get_theme_mod() returns false on failure, $background_image_thumb can be set to it and checked instead of calling get_background_image() 3 times in Custom_Background->admin_page(). 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31129 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 20:43:12 +00:00
Scott Taylor 061daaa7ee Declare $action as a global in wp-admin/comment.php. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31128 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 20:41:04 +00:00
Scott Taylor 979ba60a57 Fix some @param docs that have chars too close them. 
Add `@property` annotations to `WP_User` and `WP_Post`.
Remove erroneous `@param`s from image editor class methods.
Officially add the property `$_column_headers` to `WP_List_Table`.	

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31127 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 06:56:51 +00:00
Scott Taylor 349e5cb318 Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Constructors do not have meaningful return values, anything that is returned from here is discarded. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31126 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 06:53:48 +00:00
Scott Taylor cb85e15f06 Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value - anything that is returned is discarded. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31125 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 06:12:25 +00:00
Scott Taylor bc723548a7 Declare $wp_version, $required_php_version, and $required_mysql_version as globals in install and upgrade admin files. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31124 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 05:56:45 +00:00
Scott Taylor 38e18d800c In wp-admin/includes/revision.php, $post->modified is a coding error. It should be $post->post_modified. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31123 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 05:49:24 +00:00
Scott Taylor 164b4f21c9 WP_Upgrader will take any "skin" that is passed to it, and set ->skin via composition. The default type of ->skin is WP_Upgrader_Skin, which doesn't have methods declared for ->bulk_header() and ->bulk_footer(). Add noop methods to WP_Upgrader_Skin. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31122 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 05:41:05 +00:00
Scott Taylor 77cffd8edf Admin globals: 
* Declare `$wp_importers` as a global in `admin.php`
* Declare `$post_type`, `$post_type_object`, and  `$post` as globals where applicable

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31121 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 05:28:46 +00:00
Scott Taylor 44a3c002f5 In wp_ajax_upload_attachment(), wp_check_filetype_and_ext() doesn't need a 3rd param - it already defaults to null. Passing false would fail a strict check 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31119 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 04:54:13 +00:00
Andrew Ozz 23d6e28390 TinyMCE editor-expand: when kitchensink is off hide the statusbar on loading, and when the editor is shorter then the viewport. Props avryl, fixes #30961. 
git-svn-id: https://develop.svn.wordpress.org/trunk@31118 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 01:32:00 +00:00
Scott Taylor b3322a9604 In Custom_Background and Custom_Header: 
* In `->init()`, don't check `current_user_can()` since `add_theme_page()` will return `false` immediately if the cap check fails. 
* Bail if `add_theme_page()` returns `false`
* `wp_check_filetype_and_ext()` doesn't need a 3rd param, it already defaults to `null`. Passing `false` would fail a strict check.

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31116 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-09 21:06:13 +00:00
Sergey Biryukov 68191cc15c Add variable type for sync_category_tag_slugs() parameters. 
props tillkruess.
fixes #30718.

git-svn-id: https://develop.svn.wordpress.org/trunk@31113 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-09 11:18:22 +00:00
Sergey Biryukov 1c88f482bf Use localized format for Last Updated date in plugin details modal, for consistency with [31055]. 
see #30717.

git-svn-id: https://develop.svn.wordpress.org/trunk@31110 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-09 06:20:08 +00:00
Sergey Biryukov b641ca55f5 Improve documentation for media_handle_upload(). 
props ericlewis.
fixes #30962.

git-svn-id: https://develop.svn.wordpress.org/trunk@31109 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-09 05:04:59 +00:00
Scott Taylor 0c37f866f2 After [31105], don't ditch the isset() calls for BC. Declare $page_hook as null so it is initialized for all execution paths but will still fail isset() checks. 
Fixes #30958.


git-svn-id: https://develop.svn.wordpress.org/trunk@31106 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 22:51:30 +00:00
Scott Taylor c4e2ad04a2 Properly declare $hook_suffix, $plugin_page, $typenow, and $taxnow as globals in wp-admin/admin.php. 
Fixes #30958.


git-svn-id: https://develop.svn.wordpress.org/trunk@31105 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 22:14:58 +00:00
Scott Taylor 85595b73cc Overriding methods should do more than simply call the same method in the super class. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31101 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 21:19:24 +00:00
Scott Taylor 0522fcb3f9 Jump statements should not be followed by other statements (there were 5 lingering). 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31100 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 21:14:56 +00:00
Scott Taylor da9057fd6d Use && instead of and in the 3 places where and was used. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31099 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 21:11:46 +00:00
Helen Hou-Sandi 854ea3e3e6 Collapse additional avatar settings if avatars are disabled. 
props markjaquith, krogsgard, valendesigns.
 fixes #30168.


git-svn-id: https://develop.svn.wordpress.org/trunk@31095 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 17:00:15 +00:00
Scott Taylor 1ca58614b2 In wp-includes/plugin.php, collapse 3 else-newline-tab-if statements. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31091 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 07:12:42 +00:00
Scott Taylor 6fd11624d1 The keyword elseif should be used instead of else if so that all control keywords look like single words. 
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs. 

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31090 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 07:04:40 +00:00
Dion Hulse d0767caf54 Enable Pretty Permalinks for new sites during install if the server supports it. 
See #6481, Props valendesigns, DrewAPicture & ericlewis


git-svn-id: https://develop.svn.wordpress.org/trunk@31089 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 06:46:55 +00:00
Scott Taylor 5d6cc49628 Perl-style comments should not be used 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31079 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 05:51:39 +00:00
Scott Taylor 97d6901048 Access Modifiers: 
* In `WP_Plugin_Install_List_Table`, use `public` instead of `var`
* In `WP_User`, `->data` is accessed directly on an instance if the constructor receives it: make it `public`
* In `WP_Locale`, every property is exported to a global and is already `public` via `var`, half of the properties are accessed directly already, make them all `public`
* In `WP_Rewrite`, several properties are accessed publicly in functions via the `$wp_rewrite` global, make those props `public`.
* In `WP_Rewrite`, the property `->comment_feed_structure` was misspelled as `->comments_feed_structure`

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31078 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 05:43:54 +00:00
Scott Taylor 469164785f Pinking Shears. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31077 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 05:02:05 +00:00
Sergey Biryukov 621292d70f In dashboard activity widget, display a front-end link if the user cannot edit the post. 
props UaMV, DrewAPicture.
fixes #29025.

git-svn-id: https://develop.svn.wordpress.org/trunk@31075 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 00:25:26 +00:00
Sergey Biryukov ca34257bd6 Call the init() method for the upgrader in wp_can_install_language_pack() to avoid undefined index notices. 
props ocean90.
fixes #30827 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@31074 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-07 23:42:48 +00:00
Sergey Biryukov dd05a3a40f TinyMCE: Remove dashicon-no-alt.png, unused since [30694]. 
props kpdesign, MattyRob.
fixes #30791 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@31073 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-07 23:31:16 +00:00
Sergey Biryukov 37499b6169 Theme install: Display an appropriate string if theme has not been rated yet. 
props kevdotbadger, valendesigns.
fixes #28147.

git-svn-id: https://develop.svn.wordpress.org/trunk@31072 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-07 23:16:19 +00:00
Andrew Ozz 3fdc11be29 Image file editor: fix a wrong error message when restoring an edited image and IMAGE_EDIT_OVERWRITE is set. Props tiqbiz, fixes #30167. 
git-svn-id: https://develop.svn.wordpress.org/trunk@31070 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-07 22:47:32 +00:00
Sergey Biryukov 23bb9030f2 Remove obsolete help sentence on Edit User screen. 
fixes #30750.

git-svn-id: https://develop.svn.wordpress.org/trunk@31067 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-07 08:22:13 +00:00
Dominik Schilling (ocean90) 8bf3003c67 Customizer: Send JSON success for customize_save and allow response to be filtered. 
props westonruter.
fixes #29098.

git-svn-id: https://develop.svn.wordpress.org/trunk@31062 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-06 21:46:54 +00:00
Sergey Biryukov 8e9b9bc458 Use localized format for Last Updated date on Add Plugins screen. 
props tyxla.
fixes #30717.

git-svn-id: https://develop.svn.wordpress.org/trunk@31055 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-06 01:02:21 +00:00
Sergey Biryukov d33e517bb9 Themes: Fix position of admin notice with .notice class. 
fixes #30895.

git-svn-id: https://develop.svn.wordpress.org/trunk@31054 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-05 20:05:19 +00:00
Sergey Biryukov 7d7b33ff49 Pass comment author name and comment ID to 'get_comment_author_link' filter on Edit Comment screen, for consistency with [30092]. 
props tyxla.
fixes #30894.

git-svn-id: https://develop.svn.wordpress.org/trunk@31053 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-05 19:09:36 +00:00
Scott Taylor 14ddc6c9c0 If IMAGE_EDIT_OVERWRITE is defined as true, ensure that multiple edits to the same image does not result in the file being deleted (updating the meta fails because the old and new paths are identical). 
Props hew.
Fixes #30394.


git-svn-id: https://develop.svn.wordpress.org/trunk@31043 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-04 02:51:20 +00:00
Scott Taylor 621e909a9b Improve the handling of comma-separated mime-types in wp_match_mime_types(), particularly as pertains to the mime-type selector on the Media list table screen. 
Props mdgl.
Fixes #30788.


git-svn-id: https://develop.svn.wordpress.org/trunk@31042 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-04 02:31:29 +00:00
Scott Taylor efc61d054e After [31037], ensure that the library is passed as a map to the Media Grid instance. Remove useless query vars. 
Fixes #30584.


git-svn-id: https://develop.svn.wordpress.org/trunk@31041 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-04 02:06:04 +00:00
Scott Taylor 5df9963414 Respect query vars for taxonomies passed as URL parameters when in grid mode of Media Library. 
Fixes #30584.


git-svn-id: https://develop.svn.wordpress.org/trunk@31037 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-03 08:23:06 +00:00
Scott Taylor ca8fe1a7a4 Use the 'not_found' label when there are no items for a taxonomy in the terms list table. 
Props SergeyBiryukov.
Fixes #30586.


git-svn-id: https://develop.svn.wordpress.org/trunk@31035 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-03 06:19:46 +00:00
Scott Taylor 47f2c42528 Inline <script>s that are only printed in the admin for pages that are served with the HTML5 doctype absolutely do not need CDATA comments. 
Props tw2113 for the initial patch.
See #18788.


git-svn-id: https://develop.svn.wordpress.org/trunk@31034 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-03 05:45:17 +00:00
Scott Taylor d5328fc674 When outputting JS with a Content-Type header: 
`text/javascript` is obsolete, `application/x-javascript` was experimental. `application/javascript` is the recommended type per RFC 4329.

Props sergej.mueller.
Fixes #29196.


git-svn-id: https://develop.svn.wordpress.org/trunk@31029 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-03 02:56:14 +00:00
Andrew Ozz 95fd7b1590 Move the (recently added) .notice admin notices below the first H2, same as the .updated and .error notices. Props sippis, fixes #30885. 
git-svn-id: https://develop.svn.wordpress.org/trunk@31023 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-02 18:51:52 +00:00
Scott Taylor 64784baa95 WP_List_Table's constructor registers an 'admin_footer' callback when AJAX is enabled. As such, if you create multiple instances of the class, you get multiple JS blobs on the page when the callbacks fire. Extra instances get made when wp_comment_reply() invokes the class constructor without checking for the existing instance via the $wp_list_table global. 
We shall check the `$wp_list_table` global in `wp_comment_reply()`.

Props sorich87.
Fixes #17413.


git-svn-id: https://develop.svn.wordpress.org/trunk@31019 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-01 19:54:53 +00:00
Scott Taylor be8211beac Support chromeless Vimeo via MEjs: 
* Bump MediaElement script loader versions to 2.16.2 - missed in [30634], oops!
* Add `Froogaloop` to `js/mediaelement` scripts for Vimeo
* Check for Vimeo in the same locations that YouTube is checked
* Dynamically load Froogaloop script in admin when editing a TinyMCE view
* Edit MediaElement to call `mejs.$.extend` instead of `$.extend` in `mejs.HtmlMediaElementShim.createPlugin()`, since `$` is not available via WP's jQuery (I will report this upstream):
https://github.com/johndyer/mediaelement/blob/6f9a78e008de2de796a1797077a74a94763320f9/src/js/me-shim.js#L631

Fixes #29267.


git-svn-id: https://develop.svn.wordpress.org/trunk@31016 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-31 20:40:05 +00:00