Commit Graph

25 Commits

Author SHA1 Message Date
Scott Taylor
05abd7e56f Cleanup wp_widget_rss_form() after [28734]. "$$input used sanitized variables which contained actual values, unlike $inputs[$input] which in that context contains data about which input fields are hidden."
Props kovshenin.
Fixes #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28787 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 17:28:12 +00:00
Scott Taylor
fa03901cd8 Don't use a variable variable in wp_widget_rss_form(). Sidenote: the logic to show hidden fields is bizarre - would result in duplicate fields.
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28734 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 16:17:56 +00:00
Sergey Biryukov
6bca1ca960 Clean up wp_widget_rss_output():
* Fix appending […] to $summary.
* Use wp_trim_words() instead of wp_html_excerpt().
* Trim $title before checking if it's empty. props UmeshSingla.
* Use correct escaping function for $title.

fixes #28356.

git-svn-id: https://develop.svn.wordpress.org/trunk@28586 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-27 11:07:32 +00:00
Scott Taylor
707c313333 WP_Date_Query was only missing one access modifier.
Add access modifier (`public`) to all default widgets' class methods.

See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28532 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 17:29:42 +00:00
Scott Taylor
8a25c0ea1e Eliminate use of extract() in wp_widget_rss_form().
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28449 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 15:37:53 +00:00
Scott Taylor
1b93413580 Eliminate use of extract() in wp_widget_rss_output().
Add `'items' => 0` to `$default_args`. When `0`, the value is set to `10` (the fallback). 
Every other default arg has a default value of `0`.

`items` is expected to always be passed to this function.

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28440 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 19:41:41 +00:00
Scott Taylor
ce6f3de8ff Eliminate use of extract() in WP_Widget_RSS::widget().
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28439 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 19:35:31 +00:00
Scott Taylor
812493f259 Eliminate use of extract() in default-widgets.php.
Props rzen, wonderboymusic.

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28433 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 16:32:18 +00:00
Mark Jaquith
c4dd499979 Use '— Select —' instead of '-- Select --' for nav menus. Looks nicer.
see #27878

git-svn-id: https://develop.svn.wordpress.org/trunk@28205 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-25 00:34:20 +00:00
Mark Jaquith
65b0b658d7 Force users to choose a nav menu in the custom nav menu widget, for a better customizer UX
Before, they had to make a dummy change to get it to render. Now they
are made to choose a nav menu from the dropdown, which feels more
natural.

fixes #27878 for trunk. props westonruter

git-svn-id: https://develop.svn.wordpress.org/trunk@28197 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-24 20:44:32 +00:00
Dominik Schilling (ocean90)
0202625937 Recent Posts Widget: Use ob_end_flush() instead of ob_flush().
`ob_end_flush()` flushes the output buffer *and* turns output buffering off, same as `ob_get_flush()`.

props m_i_n.
see #28009 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@28195 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-24 19:47:09 +00:00
Dominik Schilling (ocean90)
a2c020e068 WP_Widget: Introduce is_preview() method.
With the Widget Customizer it's possible that previewed widgets can leak data outside of Customizer, when the widget uses the cache API.
The Customizer calls the regular update callback which should already refresh the cache. Since cache additions aren't blocked yet the cache can be filled with preview data.
To prevent this issue `WP_Widget::is_preview()` will return true, when `$wp_customize->is_preview()` returns true. If `is_preview()` is true, cache additions are suspended via `wp_suspend_cache_addition()`. Make sure your object cache drop-in has implemented `wp_suspend_cache_addition()`.

`is_preview()` can/should also be used inside `WP_Widget::widget()`, see WP_Widget_Recent_Posts or WP_Widget_Recent_Comments for examples.

For more info see IRC logs: http://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2014-04-02&sort=asc#m824279

props westonruter.
fixes #27538.

git-svn-id: https://develop.svn.wordpress.org/trunk@27966 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-06 18:47:46 +00:00
Drew Jaynes (DrewAPicture)
5e1914e748 Inline documentation for hooks in wp-includes/default-widgets.php.
Props janw.oostendorp and kpdesign.
Fixes #25638.


git-svn-id: https://develop.svn.wordpress.org/trunk@27697 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-25 08:52:22 +00:00
Andrew Nacin
4983a8b8d0 RSS widgets: Omit the title attribute when the summary is shown.
Trim the title attribute to ensure whitespace isn't rendered.

props SergeyBiryukov.
fixes #26520. see #26552.


git-svn-id: https://develop.svn.wordpress.org/trunk@27691 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 21:07:10 +00:00
Dominik Schilling (ocean90)
adf2b46b8e In Recent Posts widget set default number to 5.
props afercia.
fixes #27417.

git-svn-id: https://develop.svn.wordpress.org/trunk@27561 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-17 17:00:22 +00:00
John Blackbourn
164b860c93 Add context and a missing period to widget descriptions. Fixes #26668. Props pavelevap, Hanni
git-svn-id: https://develop.svn.wordpress.org/trunk@27412 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-05 17:25:11 +00:00
Andrew Nacin
f3a23fb43f Reference https://wordpress.org rather than http://wordpress.org in strings, links, comments, etc.
props Ipstenu, markjaquith.
see #27115.


git-svn-id: https://develop.svn.wordpress.org/trunk@27369 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-03 02:33:24 +00:00
Andrew Ozz
3f7cbafb94 Widgets: improve the help text on the Widgets screen, props siobhan, props Hanni, fixes #26244.
git-svn-id: https://develop.svn.wordpress.org/trunk@26505 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-01 18:28:12 +00:00
Andrew Nacin
f000be8af3 More dash updates.
* Shuffle around some pixels.
 * Rename some things that weren't caught in [26220].
 * Revert default-widgets.php change from [26144].
props lessbloat.
see #25824.


git-svn-id: https://develop.svn.wordpress.org/trunk@26230 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-15 22:22:43 +00:00
Andrew Nacin
3b82749eba Merge the new dashboard design into core.
Merges https://github.com/growthdesigner/wp-dash.

props lessbloat, joen, helen, dbernar1, kraftbj, ryelle, tillkruess, grapplerulrich, markjaquith.
see #25824.


git-svn-id: https://develop.svn.wordpress.org/trunk@26144 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-13 22:08:47 +00:00
Andrew Nacin
f6138dc287 Remove redundant title attributes.
props sabreuse.
see #24766.


git-svn-id: https://develop.svn.wordpress.org/trunk@25675 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 22:50:50 +00:00
Scott Taylor
1a46a76c18 Use wp_get_nav_menus() instead of get_terms('nav_menu') in WP_Nav_Menu_Widget to preserve use of `wp_get_nav_menus' filter.
Props Frank Klein.
Fixes #25263.



git-svn-id: https://develop.svn.wordpress.org/trunk@25332 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 23:29:04 +00:00
Sergey Biryukov
8e4a6b31cd Avoid PHP notices when configuring the Incoming Links dashboard widget. fixes #25250.
git-svn-id: https://develop.svn.wordpress.org/trunk@25298 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-07 18:16:09 +00:00
Dominik Schilling (ocean90)
b308cdbd87 Flush the cache in Recent Comments widget on edit_comment. props pento, fixes #24779.
git-svn-id: https://develop.svn.wordpress.org/trunk@25049 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-17 09:29:52 +00:00
Andrew Nacin
b43712e0f7 New develop.svn.wordpress.org repository based on the old core.svn repository.
* All WordPress files move to a src/ directory.
 * New task runner (Grunt), configured to copy a built WordPress to build/.
 * svn:ignore and .gitignore for Gruntfile.js, wp-config.php, and node.js.
 * Remove Akismet external from develop.svn. Still exists in core.svn.
 * Drop minified files from src/. The build process will now generate these.

props koop.
see #24976.

and see http://wp.me/p2AvED-1AI.



git-svn-id: https://develop.svn.wordpress.org/trunk@25001 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-07 05:25:25 +00:00