Commit Graph

3350 Commits

Author SHA1 Message Date
Sergey Biryukov
b39db8c898 Editor: Add unique classes to .post-attributes-label-wrapper paragraphs for easier JS or CSS targeting.
Props sathyapulse, sabernhardt, garrett-eclipse, noisysocks.
Fixes #44408.

git-svn-id: https://develop.svn.wordpress.org/trunk@47228 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-10 02:27:23 +00:00
Sergey Biryukov
dabec45a08 Import: Remove "Blogroll" import option (for links in OPML format) from the list of popular importer plugins.
Link Manager is disabled for new installations since WordPress 3.5, so core should not encourage importing links.

See #meta4706 for the corresponding WordPress.org API change.

Props Ipstenu, hareesh-pillai, DrewAPicture, nacin, karmatosed, dd32, garrett-eclipse.
Fixes #22994. See #21307.

git-svn-id: https://develop.svn.wordpress.org/trunk@47227 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-10 02:10:52 +00:00
Joe Dolson
1d7cdbeab7 Editor: Fix incorrect usage of ID attributes on custom fields.
Repeated containers used for custom fields have duplicate ID attributes. Duplicate IDs are incorrect HTML, and will also cause unexpected results when trying to manipulate using JS. Duplicate IDs are changed to matching classes; CSS & JS updated to match. 

Props jankimoradiya, audrasjb, donmhico, afercia.
Fixes #46964.


git-svn-id: https://develop.svn.wordpress.org/trunk@47222 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-09 19:39:54 +00:00
Sergey Biryukov
130751cda3 Coding Standards: Use Yoda conditions where appropriate.
See #49222.

git-svn-id: https://develop.svn.wordpress.org/trunk@47219 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-09 16:52:28 +00:00
Sergey Biryukov
ca37df8027 Site Health: Only get MySQL server information in tests where it's actually needed.
This resolves an issue with plugins like HyperDB, which doesn't have a database connection until a query is made.

Props xkon, Otto42, Clorith.
See #47606.

git-svn-id: https://develop.svn.wordpress.org/trunk@47215 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-08 20:08:31 +00:00
Sergey Biryukov
23c2257935 Accessibility: Menus: Make tab panels in Add menu items section more accessible for keyboard users.
Props audrasjb, afercia.
Fixes #49211.

git-svn-id: https://develop.svn.wordpress.org/trunk@47209 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-07 21:36:59 +00:00
Sergey Biryukov
f8b2ff1b53 Coding Standards: Adjust coding standards to always omit parentheses for include/require statements.
These are language constructs, not function calls, so the parentheses are unnecessary.

This updates the PHPCS configuration file the enforce the sniff until it is moved from the `WordPress-Extra` ruleset to the `WordPress-Core` ruleset upstream.

Follow-up to [47198].

Props desrosj, jrf, GaryJ.
Fixes #49376.

git-svn-id: https://develop.svn.wordpress.org/trunk@47207 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-07 19:14:29 +00:00
John Blackbourn
2ce61ea2d6 Posts, Post Types: Add a parameter to the post_locked_dialog action which contains a reference to the user who holds the lock.
Fixes #48443

git-svn-id: https://develop.svn.wordpress.org/trunk@47206 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-07 17:51:09 +00:00
Andrew Ozz
112649ea92 Media: Add link to the original image in the image properties if it was scaled or rotated after uploading.
Fixes #49290.

git-svn-id: https://develop.svn.wordpress.org/trunk@47202 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-07 05:11:45 +00:00
Sergey Biryukov
e72fff9cef Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.
This avoids the performance overhead of the function call every time `dirname( __FILE__ )` was used instead of `__DIR__`.

This commit also includes:

* Removing unnecessary parentheses from `include`/`require` statements. These are language constructs, not function calls.
* Replacing `include` statements for several files with `require_once`, for consistency:
 * `wp-admin/admin-header.php`
 * `wp-admin/admin-footer.php`
 * `wp-includes/version.php`

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

git-svn-id: https://develop.svn.wordpress.org/trunk@47198 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-06 06:31:22 +00:00
Sergey Biryukov
3d43f46907 Posts, Post Types: Change "Featured Image" post label to use sentence case: "Featured image".
This makes it more consistent with other UI elements in the block editor.

Props mcsf.
Fixes #49371.

git-svn-id: https://develop.svn.wordpress.org/trunk@47194 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-05 19:07:33 +00:00
Sergey Biryukov
5a5c1924fd Menus: Introduce wp_nav_menu_item_custom_fields action that fires just before the move buttons of a nav menu item in the menu editor.
Props MikeSchinkel, birgire, sebastian.pisula, desrosj, helgatheviking.
Fixes #47056. See #38904, #18584.

git-svn-id: https://develop.svn.wordpress.org/trunk@47190 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-05 07:41:08 +00:00
Sergey Biryukov
f838035c8f Docs: Correct type for $item and $args parameters in Walker_Nav_Menu_Checklist and Walker_Nav_Menu_Edit to match the parent Walker_Nav_Menu` class.
Follow-up to [38559], [45537].

See #24587, #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47189 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-05 07:23:25 +00:00
Sergey Biryukov
3f050fcf63 Plugins: Remove obsolete plugin_slugs transient from WP_Plugins_List_Table::prepare_items().
The transient is only used in the `wp_dashboard_plugins_output()` function, which is deprecated and unused since [40607].

The function itself also sets the same transient, so it can be removed from `WP_Plugins_List_Table`.

Props aftabmuni.
Fixes #49340.

git-svn-id: https://develop.svn.wordpress.org/trunk@47167 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-02 15:48:37 +00:00
Sergey Biryukov
706daca6a3 Editor: Remove back-compat stub for Classic Editor's old distraction-free writing mode.
The original script was deprecated in [30338] and removed in [32677].

Props Presskopp, ketuchetan.
Fixes #39448.

git-svn-id: https://develop.svn.wordpress.org/trunk@47164 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-02 04:13:25 +00:00
Sergey Biryukov
5e11891a05 Docs: Correct DocBlock formatting for register_setting().
Document the full list of whitelisted option key names.

See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47157 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-01 21:59:14 +00:00
Sergey Biryukov
54c6311c96 Accessibility: Text Changes: Use sentence case for the word Error in various error messages, instead of all caps.
Using all caps should be avoided for better readability and because screen readers may pronounce all-caps words as abbreviations.

Props afercia, ryokuhi, sabernhardt, garrett-eclipse.
See #47656, #43037, #42945.

git-svn-id: https://develop.svn.wordpress.org/trunk@47156 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-01 21:36:44 +00:00
Sergey Biryukov
b3da2c99a1 Text Changes: Capitalize error messages consistently.
Props Presskopp.
Fixes #42945.

git-svn-id: https://develop.svn.wordpress.org/trunk@47154 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-01 20:53:14 +00:00
Sergey Biryukov
db8a038541 Text Changes: Add missing periods to some error messages, for consistency.
Props Presskopp.
Fixes #42735.

git-svn-id: https://develop.svn.wordpress.org/trunk@47153 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-01 20:30:20 +00:00
Sergey Biryukov
d4b892f022 Docs: Document the addition of $json_report_pathname parameter to the wp_privacy_personal_data_export_file_created action.
Follow-up to [47146].

Props xkon.
Fixes #49029.

git-svn-id: https://develop.svn.wordpress.org/trunk@47150 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-01 04:15:15 +00:00
Sergey Biryukov
637b6f5456 Site Health: Rename WP_Site_Health::initialize() introduced in [47063] to ::get_instance(), for clarity and consistency with other core classes.
Use `WP_Site_Health::get_instance()` where it's needed, instead of creating multiple instances of the class.

Props afercia, xkon, Clorith, SergeyBiryukov.
See #47606.

git-svn-id: https://develop.svn.wordpress.org/trunk@47149 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-01 00:37:14 +00:00
Sergey Biryukov
f0b830e62c Privacy: Clarify bulk action labels for personal data export and removal requests.
Props garrett-eclipse, xkon, shariqkhan2012, websupporter, desrosj, JoshuaWold.
Fixes #44674.

git-svn-id: https://develop.svn.wordpress.org/trunk@47148 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-31 03:41:06 +00:00
Sergey Biryukov
b894d8665a Privacy: Introduce a JSON file into the personal data export.
The produced ZIP archive will now include an `export.json` file along with the current `index.html`.

Props xkon.
Fixes #49029. See #46424.

git-svn-id: https://develop.svn.wordpress.org/trunk@47146 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-31 01:34:17 +00:00
Sergey Biryukov
7192a8f562 Privacy: Remove user's email address from personal data export filename.
Use `wp_unique_filename()` to avoid potential collisions instead.

Props xkon, garrett-eclipse, donmhico, Ov3rfly, Clorith, allendav.
Fixes #44197.

git-svn-id: https://develop.svn.wordpress.org/trunk@47144 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-31 00:56:29 +00:00
Sergey Biryukov
b30baca3ca Dashboard: Improve the appearance of "WordPress Events and News" dashboard widget for multi-day events.
If an upcoming event spans over several days, this information is now properly reflected in the widget.

Props imath, casiepa, iandunn, hareesh-pillai, melchoyce, mapk, desrosj, audrasjb, SergeyBiryukov.
Fixes #47798.

git-svn-id: https://develop.svn.wordpress.org/trunk@47124 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-29 02:17:41 +00:00
Sergey Biryukov
7e521e68dc Docs: Fix typos in wp-admin/includes/class-pclzip.php.
With the upstream library not updated in 10 years since the last time it was merged, it should be safe to treat it as "adopted" rather than external, and make these fixes.

Props passoniate, ottok.
Fixes #49163. See #38464.

git-svn-id: https://develop.svn.wordpress.org/trunk@47123 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-29 00:54:21 +00:00
Sergey Biryukov
cfc3b57488 Docs: Improve inline comments per the documentation standards.
Includes minor code layout fixes for better readability.

See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47122 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-29 00:43:23 +00:00
Sergey Biryukov
6bdc961d5f Docs: Improve comments in some wp-admin files per the documentation standards.
Follow-up to [47084].

Props passoniate, apedog.
Fixes #49223, #49227.

git-svn-id: https://develop.svn.wordpress.org/trunk@47119 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-29 00:33:45 +00:00
Sergey Biryukov
191f798201 Docs: Remove extra trailing spaces from wp_add_privacy_policy_content() DocBlock to fix WPCS issues, apply minor formatting changes for consistency.
Follow-up to [47112].

See #49282.

git-svn-id: https://develop.svn.wordpress.org/trunk@47113 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-27 01:04:08 +00:00
Andrew Ozz
9224e14e67 Privacy: Cleanup .wp-policy-help CSS remnants and add back-compat when hiding the tutorial content before copying.
Props garrett-eclipse.
Fixes #49282.

git-svn-id: https://develop.svn.wordpress.org/trunk@47112 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-26 23:00:54 +00:00
Sergey Biryukov
8295b56d9c Docs: Correct @return value for parent_dropdown().
Follow-up to [47100].

See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47102 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-22 00:31:17 +00:00
Sergey Biryukov
8133a247bd Docs: Adjust @return value of parent_dropdown() for consistency with other dropdown functions.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47100 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-22 00:20:21 +00:00
Sergey Biryukov
80e4ef45f1 Docs: Correct @return value for update_core() and Core_Upgrader::upgrade().
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47099 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-22 00:17:24 +00:00
Sergey Biryukov
9b5ac0f6b6 I18N: Add missing placeholders to some translators comments in wp-admin.
Props ramiy.
Fixes #49248.

git-svn-id: https://develop.svn.wordpress.org/trunk@47093 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-20 15:41:50 +00:00
Sergey Biryukov
5f937b4c70 I18N: Correct translator comments in WP_Users_List_Table::get_views() to provide information about each placeholder.
Props ramiy.
Fixes #49242.

git-svn-id: https://develop.svn.wordpress.org/trunk@47089 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-20 14:06:57 +00:00
Sergey Biryukov
a8f4ed69de Docs: Update links to https://secure.php.net/, they now redirect to https://www.php.net/.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47088 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-20 03:12:12 +00:00
Sergey Biryukov
5d8f784daa Networks and Sites: Clarify the recommendation to remove the www prefix from the site domain before creating a network.
The `siteurl` option reference was not quite clear, and the string actually refers to the domain name, not the full URL.

Props kharisblank, tobifjellner, ramiy.
Fixes #49214.

git-svn-id: https://develop.svn.wordpress.org/trunk@47085 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-18 01:13:12 +00:00
Sergey Biryukov
89dc54ee0c Docs: Improve comments in some wp-admin files per the documentation standards.
Props passoniate.
Fixes #49215, #49216.

git-svn-id: https://develop.svn.wordpress.org/trunk@47084 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-18 00:52:28 +00:00
Sergey Biryukov
bd59d22a81 Coding Standards: Remove unnecessary // phpcs:ignore instances in WP_Debug_Data.
`WP_Theme::__get()` accepts `Name`, `Version`, and `Author` theme properties in lower case too.

Additionally, remove one short ternary instance, not allowed per the coding standards.

See #49222.

git-svn-id: https://develop.svn.wordpress.org/trunk@47083 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-18 00:24:57 +00:00
Sergey Biryukov
92fc229ca0 Site Health: Avoid "Undefined property" PHP notices in wp_dashboard_site_health() when the status result transient does not exist yet.
Props dlh for initial patch.
See #47606.

git-svn-id: https://develop.svn.wordpress.org/trunk@47069 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-13 17:25:26 +00:00
Sergey Biryukov
d9501dd5d5 Networks and Sites: Use warning styles for 'Caution' and 'Warning' messages during Multisite installation.
Props dlh.
Fixes #49186.

git-svn-id: https://develop.svn.wordpress.org/trunk@47067 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-13 16:58:06 +00:00
Sergey Biryukov
9b38bca65f Docs: Improve documentation for wp_save_image_file() and related functions.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47065 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-12 16:54:56 +00:00
Sergey Biryukov
396cc8205b Site Health: Introduce Site Health Status dashboard widget.
The widget informs administrators of any potential issues that should be addressed to improve the performance or security of their website, and directs them to the Site Health screen for more details.

Props Clorith, hedgefield, guddu1315.
See #47606.

git-svn-id: https://develop.svn.wordpress.org/trunk@47063 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-12 13:31:49 +00:00
Sergey Biryukov
4c2ee4e9ff Docs: In various @return tags, list the expected type first, instead of false.
Follow-up to [46696].

See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47060 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-11 18:30:58 +00:00
Sergey Biryukov
f9e52f8cd3 Docs: Synchronize @return descriptions for ::handle_row_actions() methods in list tables.
Make sure `WP_Comments_List_Table::handle_row_actions()` and `WP_MS_Sites_List_Table::handle_row_actions()` return a string, for consistency with other classes.

See #49170, #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47059 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-11 17:56:15 +00:00
Sergey Biryukov
1824604fc0 Docs: Correct @return description for WP_List_Table::handle_row_actions().
Props pbiron.
Fixes #49170.

git-svn-id: https://develop.svn.wordpress.org/trunk@47058 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-11 17:55:49 +00:00
Sergey Biryukov
5dbe5a8355 Docs: Correct @return type for Theme_Upgrader::check_parent_theme_filter().
Props diddledan.
Fixes #48570.

git-svn-id: https://develop.svn.wordpress.org/trunk@47057 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-11 02:44:17 +00:00
Sergey Biryukov
b459cddeaf I18N: Replace php.ini, post_max_size, and upload_max_filesize with placeholders in "File is empty" error message.
Props ramiy.
Fixes #48868.

git-svn-id: https://develop.svn.wordpress.org/trunk@47043 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-06 16:14:30 +00:00
Sergey Biryukov
50ed776846 Docs: Fix typo in media_post_single_attachment_fields_to_edit() description.
Props mukesh27.
Fixes #49131.

git-svn-id: https://develop.svn.wordpress.org/trunk@47039 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-04 17:58:37 +00:00
Sergey Biryukov
c9a366e857 Docs: Fix typo in _crop_image_resource() DocBlock.
Props mukesh27.
Fixes #49103.

git-svn-id: https://develop.svn.wordpress.org/trunk@47024 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-31 12:32:19 +00:00