Commit Graph

183 Commits

Author SHA1 Message Date
Andrew Ozz
c602aac562 Drag/drop on the editor to upload: don't trigger the uploader when selected test is being dragged from one window to another. See #27880, for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@28189 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-23 20:34:43 +00:00
Andrew Ozz
db22ae4e32 TinyMCE: fix the "active" state of the Link button when an image wrapped in a link is selected, see #27847, for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@28185 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-22 21:10:14 +00:00
Scott Taylor
4507f1e04f Persisting <track> elements as the body of a [video] shortcode in MCE Views:
* When generating the view's HTML, ensure that the shortcode's `content` is added to the model
* Add a `PostProcess` event in the `wpview` plugin to properly return the shortcode when the editor mode is toggled, ensuring that elements in the body are not dropped.

Props azaozz, wonderboymusic.
See #27915.




git-svn-id: https://develop.svn.wordpress.org/trunk@28183 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-22 18:20:54 +00:00
Andrew Nacin
620fc6660c TinyMCE: Restore old wordpress_adv_hidden editor parameter to enable force-showing the kitchen sink.
props azaozz.
see #27963, for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@28181 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-22 13:49:28 +00:00
Andrew Nacin
51882f8707 Graceful failures for TinyMCE views of video/audio playlists.
props gcorne.
fixes #27821.


git-svn-id: https://develop.svn.wordpress.org/trunk@28144 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-16 00:22:28 +00:00
Andrew Ozz
07885ba6c9 Add hooks to the wpeditimage tinymce plugin and to the image details portion of the media modal.
- Add wp.media.events which is intended to be a global media event bus.
- Add a post-render event to the ImageDetails view that third-party code can leverage to add subviews.
- Performance improvement for the initialization of the PostImage model.
- A bit more markup to the image details template to make it easier to add a view to the advanced options.
Props gcorne, fixes #27698

git-svn-id: https://develop.svn.wordpress.org/trunk@28095 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-13 04:01:53 +00:00
Andrew Ozz
3396375d47 RTL for TinyMCE:
- Add _dir: 'rtl' to the TinyMCE translation object.
- Fix editor.css for RTL.
- Fix the Edit and Delete buttons position for wpview and images.
- For _mce_set_direction(), update documentation and fix adding the 'ltr' button.
Fixes #27773

git-svn-id: https://develop.svn.wordpress.org/trunk@28094 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-13 00:22:56 +00:00
Andrew Ozz
027f0872bd Update the TinyMCE paste plugin to the latest development version. It includes a fix for pasting from Word: removes inline comments and change tracking.
Changeset: f8cffdf342
Fixes #27771

git-svn-id: https://develop.svn.wordpress.org/trunk@28089 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-12 20:00:52 +00:00
Andrew Ozz
17a90fff8b TinyMCE wpViews:
- Prevent undo steps from being added when the body of a wpview changes.
- Add unbind() to handle cleanup on DOM rebuilding in TinyMCE.
- Ensure that MediaElement's cleanup routine is run on every player in all instances of the editor.
- Initialize the players after some delay to ensure CSS is loaded.
Props gcorne and wonderboymusic, fixes #27389

git-svn-id: https://develop.svn.wordpress.org/trunk@28084 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-12 00:45:48 +00:00
Andrew Ozz
8aacd10a8c Don't include the non-minified tinymce.js in /build. Load it when running from /src, else load wp-tinymce.js.gz (production) or tinymce.min.js (SCRIPT_DEBUG). Props nacin, fixes #27739
git-svn-id: https://develop.svn.wordpress.org/trunk@28081 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-11 22:16:01 +00:00
Andrew Ozz
2883034c6a Update TinyMCE to the current development version, 4.0.21.1. Fixes #27744
git-svn-id: https://develop.svn.wordpress.org/trunk@28066 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-10 21:08:41 +00:00
Andrew Ozz
c90a2a5d3b TinyMCE Views in IE8 and 7: change deselect event only for old IE, props gcorne, fixes #27546
git-svn-id: https://develop.svn.wordpress.org/trunk@28063 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-09 15:28:17 +00:00
Andrew Ozz
b253355d2c Fix TinyMCE Views in IE8 and 7:
- Add fallback background images for dashicons.
- Fix hiding the clipboard while still allowing the contents to be selected.
- Work around lack of border-box in gallery styles.
(Includes precommit cleanup for theme.js)
Props gcorne, fixes 27546

git-svn-id: https://develop.svn.wordpress.org/trunk@28062 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-09 00:57:46 +00:00
Andrew Ozz
0e44baa89e Precommit cleanup for theme.js, editor.css amd wpdialogs/plugin.js, See #27055, #26907, #16284
git-svn-id: https://develop.svn.wordpress.org/trunk@28045 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-08 08:28:57 +00:00
Andrew Nacin
288b1fd4f3 Nuke the TinyMCE help dialog as it is duplicated by help tabs. This leaves just Keyboard Shortcuts.
fixes #27100.


git-svn-id: https://develop.svn.wordpress.org/trunk@28032 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-08 02:31:02 +00:00
Andrew Nacin
e0989568d2 TinyMCE help: Break up strings changed in [28027] for ease of changing later.
Restores a not inaccurate paragraph to reduce churn.

see #27100.


git-svn-id: https://develop.svn.wordpress.org/trunk@28028 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-08 01:18:15 +00:00
Andrew Ozz
4360d117e2 TinyMCE help modal:
- Don't load the old tiny_mce_popup.js.
- Add the shortcut for <code> and the second shortcut for link to the shortcuts listing.
- Update some of the text.
See #27100

git-svn-id: https://develop.svn.wordpress.org/trunk@28027 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 23:52:55 +00:00
Andrew Ozz
e28f610ead Fix typo and add more text to the error shown when 'wpdialogs' is not enqueued. Add 'wp_enqueue_editor' action fired when scripts and styles for the editor are being enqueued, fixes #16284
git-svn-id: https://develop.svn.wordpress.org/trunk@28024 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 22:54:13 +00:00
Andrew Ozz
5706a463bd TinyMCE: show an error in the console when a plugin attempts to use the 'wpdialogs' plugin but wpdialog.js is not enqueued, fixes #16284
git-svn-id: https://develop.svn.wordpress.org/trunk@28012 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 21:34:18 +00:00
Scott Taylor
d11d19a2b7 [27640] supported a caption for audio and video shortcodes as part of a UX iteration for the related MCE views. These captions have since be excluded, so the extra code should be removed (it was there for this sole reason).
See #27320.



git-svn-id: https://develop.svn.wordpress.org/trunk@27979 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 06:12:06 +00:00
Dominik Schilling (ocean90)
020e3ef811 Update TinyMCE help for pasting content.
props chiragswadia.
see #27100.

git-svn-id: https://develop.svn.wordpress.org/trunk@27972 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-06 19:45:07 +00:00
Andrew Ozz
548772fcc1 TinyMCE: update the default style for html5-captions, props obenland fixes #26642
git-svn-id: https://develop.svn.wordpress.org/trunk@27949 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 23:11:21 +00:00
Andrew Ozz
48269a7c29 TinyMCE: add image backgrounds for more and nextpage tags (also jshint fix for theme.js). Fixes #27106
git-svn-id: https://develop.svn.wordpress.org/trunk@27944 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 05:22:47 +00:00
Andrew Ozz
ee33326f32 Edit image modal:
- Make the calculation of the aspect ratio more robust.
- Better getting of the image height and width.
Props gcorne, see #27366

git-svn-id: https://develop.svn.wordpress.org/trunk@27942 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 01:48:24 +00:00
Andrew Ozz
641f9f9a93 TinyMCE: improve setting disabled/enabled/activated states on the Unlink button, fixes #27309
git-svn-id: https://develop.svn.wordpress.org/trunk@27934 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 20:04:44 +00:00
Andrew Ozz
26391af850 Edit Image modal:
- Fix issue with adding a link to an image that didn't have one previously.
- Adjust the look-and-feel of the advance options toggle so that it becomes a section heading that can be open/closed.
- Add a Custom Size option to the size drop-down that reveals fields for soft-resizing the image inserted into the post.
Props gcorne, and props sdasse for the design help, see #27366

git-svn-id: https://develop.svn.wordpress.org/trunk@27918 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 03:20:40 +00:00
Andrew Ozz
7b272d3a26 Drag and drop files on the editor to upload: add new argument to wp_editor() to enable, fixes #27465
git-svn-id: https://develop.svn.wordpress.org/trunk@27901 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-02 02:41:24 +00:00
Andrew Ozz
c5f7f95979 Gallery preview: add a "No items found" state which is displayed when rendering the gallery wpview and no attachments are found. Props gcorne, fixes #27558
git-svn-id: https://develop.svn.wordpress.org/trunk@27899 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-02 02:17:39 +00:00
Andrew Ozz
d4f99c2142 Edit Image modal:
- Move all advanced options under a single “Show advanced options” toggle that mirrors the behavior and look-and-feel of the wplink modal.
- Switch to using <select> for the Size and Link To.
- Bring back the field for CSS Class for the image, but don’t incorporate the internally managed WordPress classes (size-, wp-image-, etc…).
- On larger screen sizes, float labels to the left. When the width drops below 900px, stack the label above the fields.
- Keep image at top on screen sizes where the two columns are stacked into a single column.
- Don't replace the nodes in the editor DOM so we don't stomp on any custom attributes that the user may have added via the Text editor or some other mechanism.
Props gcorne, see #27366

git-svn-id: https://develop.svn.wordpress.org/trunk@27898 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-02 01:53:56 +00:00
Andrew Ozz
5977c4332e TinyMCE: update to 4.0.21, see #24067
git-svn-id: https://develop.svn.wordpress.org/trunk@27897 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-01 22:46:00 +00:00
Andrew Ozz
d6e6560980 Editor:
- Use standard button styles for the Quicktags buttons.
- Better style for the TinyMCE buttons (hover/focus/active/disabled).
- Move the fullscreen (DFW) button to the right.
- Better style for the Visual/Text buttons in DFW.
Props avryl, see #27279

git-svn-id: https://develop.svn.wordpress.org/trunk@27857 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-29 23:57:13 +00:00
Andrew Ozz
bbe59d0487 Edit Image modal:
- Bring back some of the advanced settings.
- Make the layout two-column for wider screens, remove the sidebar, and shrink the modal a bit.
- The image reflects the size as inserted in the post as long as it doesn't overflow the column and is not too tall. Changing the size to another intermediate will also update the image "preview."
- Rename "Edit Image" to "Edit Original" to try and better communicate that editing the image will modify the media library item not just the image inserted into the post that is being edited.
(updates two PNGs from precommit)
Props gcorne, see #27366

git-svn-id: https://develop.svn.wordpress.org/trunk@27797 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-27 22:40:06 +00:00
Helen Hou-Sandi
1959b1379b Affix the audio view toolbar to the bottom as opposed to the top of the view. Otherwise it's not accessible when the view is the first item in the content. Said views keep a newline underneath, so there's space for it to appear there instead. fixes #27548, see #27320.
git-svn-id: https://develop.svn.wordpress.org/trunk@27792 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-27 20:09:38 +00:00
Scott Taylor
8312fca652 Make sure Playlist states that are audio are marked as such with proper localized strings.
See #27554.


git-svn-id: https://develop.svn.wordpress.org/trunk@27789 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-27 18:36:03 +00:00
Andrew Nacin
c5717f0aa1 Remove the TinyMCE image toolbar when the image is deleted via the keyboard.
props gcorne.
fixes #27527.


git-svn-id: https://develop.svn.wordpress.org/trunk@27786 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-27 18:06:13 +00:00
Andrew Nacin
ccf21196cb Remove unused JS variables after [27770]. see #27013.
git-svn-id: https://develop.svn.wordpress.org/trunk@27783 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-27 17:31:00 +00:00
Helen Hou-Sandi
5db0c45614 MCE view controls:
* Move controls back over to the left, as they were before. Wide images and muscle memory have been causing frustration.
* Improve the experience and unify the UI of media view controls. Audio and video views now require an initial click to select before further interaction.
* CSS clean up and organization.

fixes #27320, #27542.


git-svn-id: https://develop.svn.wordpress.org/trunk@27777 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-27 07:01:38 +00:00
Andrew Ozz
1c0d6827f5 Remove containment of scrolling inside the editor for now. See #27013
git-svn-id: https://develop.svn.wordpress.org/trunk@27770 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-27 02:34:25 +00:00
Helen Hou-Sandi
efec2a916c Better, more consistent styling for plugin details Thickbox and TinyMCE help.
props avryl. fixes #26952.


git-svn-id: https://develop.svn.wordpress.org/trunk@27765 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-27 00:07:05 +00:00
Andrew Ozz
a8fe109dcd Add the 'attachment_' prefix to caption IDs after editing, see #24409
git-svn-id: https://develop.svn.wordpress.org/trunk@27764 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-27 00:06:50 +00:00
Andrew Nacin
6b9eccd1f0 Add an .html4-captions class to the editor when HTML5 captions are not supported, for theme use.
see #26642.


git-svn-id: https://develop.svn.wordpress.org/trunk@27758 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-26 23:12:48 +00:00
Andrew Ozz
2dcbd7d3ca TinyMCE: fix the More and Next Page tags behavior:
- Append them inside top level <p> tags.
- If the caret is not in a top level <p>, create new paragraph after the current top level tag.
- Do not change placement when edited in the Text editor.
See #27378

git-svn-id: https://develop.svn.wordpress.org/trunk@27729 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-26 02:07:23 +00:00
Andrew Ozz
a00d98a8c2 TinyMCE: bring back removal of the size-* class when the user soft-resizes an image, see #24409
git-svn-id: https://develop.svn.wordpress.org/trunk@27694 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-25 00:15:37 +00:00
Scott Taylor
98921c5ca0 Let us pass jshint:core.
git-svn-id: https://develop.svn.wordpress.org/trunk@27693 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 23:01:15 +00:00
Andrew Nacin
71917873d4 Introduce HTML5 caption support.
When a theme supports HTML5 captions via add_theme_support( 'html5', 'caption' ), figure and figcaption will be used instead of div and p.

There's a bonus. But first, some history: Captions were introduced with an inline style set for the container. This remains, as it is there to force captions to wrap. But this inline style included an extra 10 pixels, which have vexxed theme developers for years. While these pixels were designed to ensure padding around floated images, modern themes handle this with grace. The additional pixels thus feel encumbering.

As the new HTML5 gallery support avoids outputting default gallery styles (again, irking theme developers for years; see #26697), the new HTML5 caption support will also ditch these 10 pixels of unwanted hand-holding. 

The 10 pixels are also removed entirely in the visual editor (and more styles may also disappear here; see #26642), giving themes the power necessary to match the frontend styles.

The filter img_caption_shortcode_width added in 3.7 to work around this madness (see #14380) is skipped entirely when the theme supports HTML5 captions.

props obenland, azaozz.
see #26642. also fixes #9066.


git-svn-id: https://develop.svn.wordpress.org/trunk@27668 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 02:04:56 +00:00
Scott Taylor
d534c8c3eb When inserting a video shortcode into the editor, set the poster attribute automatically if the video has a featured image attached to it.
See #27460.



git-svn-id: https://develop.svn.wordpress.org/trunk@27659 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-23 03:35:50 +00:00
Scott Taylor
42e7ed7c78 General code cleanup and improving video sizing in the admin:
* Abstract the setting of a primary button and its callback in `wp.media.view.MediaFrame.MediaDetails`
* Account for the existence or non-existence of `$content_width` in the TinyMCE views for video
* Make sure video models always have dimensions, even if they are the defaults
* For browsers that are not Firefox, don't use a timeout when setting the `MediaElementPlayer` instance in TinyMCE views

See #27320.



git-svn-id: https://develop.svn.wordpress.org/trunk@27655 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-22 23:25:08 +00:00
Scott Taylor
5c0f7ae4fb Unifying media controls and supporting playlists in the editor:
* Support a `caption` attribute for audio and video shortcodes
* In `wp.media.audio|video`, rename `update` to `shortcode` to allow these models to share the same mixins as `wp.media.collection` subclasses
* When sending an audio or video shortcode to the editor, create a default caption if the user hasn't entered one. This currently only displays in the editor, not on the front end. Captions aren't tied to a specific attachment here because external sources are supported.
* In the `wp.mce.media` mixin, in the `edit` method, read `attr` instead of `data` when attempting to parse the encoded shortcode. `data` does not automatically update when the attribute changes. This was a blessing to debug.
* Add `wp.mce.media.PlaylistView` to support playlist views in TinyMCE
* Expose `WPPlaylistView` to global scope and suppress auto-parsing of playlist nodes when in the admin. Allow `WPPlaylistView` to be passed `metadata` on creation instead of requiring a JSON blob to be parsed.
* Remove all of the playlist logic from the `wpgallery` TinyMCE plugin.
* In `wp_prepare_attachment_for_js()` return more data for audio/video so that playlists can have parity in the admin/front end.

See #27320.



git-svn-id: https://develop.svn.wordpress.org/trunk@27640 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-20 13:33:00 +00:00
Andrew Ozz
9bac9f66d9 wpView: select/deselect views when moving the caret with the arrow keys, don't move the caret after deselect(), props gcorne, see #26959
git-svn-id: https://develop.svn.wordpress.org/trunk@27632 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-20 02:47:15 +00:00
Helen Hou-Sandi
d80da6c3f4 Further unify and refine media and view control styling. see #27320.
git-svn-id: https://develop.svn.wordpress.org/trunk@27628 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-20 00:47:21 +00:00