Commit Graph

28 Commits

Author SHA1 Message Date
John Blackbourn
b20dd081ba Editor: Revert a fix for incorrect usage of ID attributes on custom fields.
This reverts [47222] due to compatibility issues with plugins which are using the `#poststuff` selector.

See #46964

git-svn-id: https://develop.svn.wordpress.org/trunk@47410 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-03 00:35:41 +00:00
Joe Dolson
1d7cdbeab7 Editor: Fix incorrect usage of ID attributes on custom fields.
Repeated containers used for custom fields have duplicate ID attributes. Duplicate IDs are incorrect HTML, and will also cause unexpected results when trying to manipulate using JS. Duplicate IDs are changed to matching classes; CSS & JS updated to match. 

Props jankimoradiya, audrasjb, donmhico, afercia.
Fixes #46964.


git-svn-id: https://develop.svn.wordpress.org/trunk@47222 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-09 19:39:54 +00:00
Sergey Biryukov
1d41c6e787 Accessibility: Remove post format filter links from format icons in the Posts list table.
Introduce a dedicated 'Formats' drop-down filter as a replacement.

Keep the icons as a simple visual indicator of the post format for now.

Props afercia, melchoyce, GaryJ, chiaralovelaces, SergeyBiryukov.
Fixes #35497.

git-svn-id: https://develop.svn.wordpress.org/trunk@44961 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-21 15:30:52 +00:00
Andrea Fercia
fb37359865 Administration: CSS coding standards
- properties should be followed by a colon and a space
- media queries shouldn't use spaces within parenthesis
- indentation should use tabs instead of spaces or mixed spaces / tabs
- the content property should use double quotes
- no double spaces

Props nadim0988, afercia.
Fixes #45185.


git-svn-id: https://develop.svn.wordpress.org/trunk@44637 602fd350-edb4-49c9-b593-d223f7449a82
2019-01-17 07:40:40 +00:00
Andrea Fercia
ce61a7f676 Administration: CSS coding standards: use double quotes for values that require quotes.
As per the WordPress CSS coding standards, CSS properties with values that require quotes must use double quotes.
Also fixes some indentation and spacing.

Fixes #43220.


git-svn-id: https://develop.svn.wordpress.org/trunk@42641 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-03 13:18:40 +00:00
Andrea Fercia
e2c4ae805f Quick/Bulk Edit: Improve the inline error messages styling.
- uses the core `notice` styles for the Quick Edit form inline error messages
- adds missing periods at the end of a few error messages

Props ocean90, karmatosed, melchoyce, afercia.
Fixes #35496.


git-svn-id: https://develop.svn.wordpress.org/trunk@41684 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-02 21:51:09 +00:00
Sergey Biryukov
0c66c82b7c Taxonomy: Convert tag cloud in Tags meta box to a list (<ul>) for better semantics and accessibility.
An unordered list allows screen reader users to know in advance how many tags are within the list.

Props audrasjb, afercia.
Fixes #40187.

git-svn-id: https://develop.svn.wordpress.org/trunk@41563 602fd350-edb4-49c9-b593-d223f7449a82
2017-09-22 11:27:44 +00:00
Andrea Fercia
e232ed28dc Accessibility: Improve the Tags meta box accessibility.
- changes the "X" links in buttons, improves their color contrast ratio and focus style
- adds screen reader text "Remove item: + tagname"
- uses `wp.a11y.speak()` to give screen reader users feedback when adding/removing tags
- makes the `tagcloud-link` toggle a button, with an `aria-expanded` attribute to indicate the tag cloud collapsed/expanded state
- changes colors for the autocomplete highlighted option in order to have a better color contrast ratio
- reduces the font size for the autocomplete on Press This
- removes CSS related to the old `suggest.js` from Press This

Props joedolson, cgrymala, azaozz, afercia.
Fixes #27555.


git-svn-id: https://develop.svn.wordpress.org/trunk@38880 602fd350-edb4-49c9-b593-d223f7449a82
2016-10-23 18:15:07 +00:00
Andrea Fercia
ee7f970ffa Administration: Improve the usage of the button CSS classes.
Introduces some consistency in the usage of the button CSS classes, fixes the
focus style for accessibility and responsiveness of the buttons.

- Adds the `button` class to all primary buttons make them responsive
- Removes all `secondary-button` classes and replaces it with button when needed. `button-secondary` shouldn't be used and exists just for backward compatibility reasons
- Replaces classes inside `submit_button()` with a shorthand for some buttons, and use an empty string for the default `button` class. Passing `button` is unnecessary
- Adjusts `get_submit_button()` to remove empty items

Props iseulde, dimchik, chris_d2d, mhowell, afercia.
Fixes #27314, #37138, #37448.


git-svn-id: https://develop.svn.wordpress.org/trunk@38672 602fd350-edb4-49c9-b593-d223f7449a82
2016-09-28 19:53:07 +00:00
Helen Hou-Sandi
265fabc1c4 Use numeric font weights instead of keywords.
When Open Sans was in use, the `300`, `400`, and `600` weights were loaded. `400` is the equivalent of `normal`; however, `bold` is equivalent to `700`, not `600`. With the move to system fonts, we need to be specific rather than relying on the lack of a `700` weight. Not all system fonts include a `600` weight; in those instances, they will use the `bold`/`700` weight.

The WordPress CSS Coding Standards have been updated accordingly.

props coderste.
see #36753.


git-svn-id: https://develop.svn.wordpress.org/trunk@37740 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-17 18:36:03 +00:00
Andrea Fercia
7e71bb398c Accessibility: Reduce the WordPress shades of grey, Episode 3.
Also, removes some no more used CSS.

See #35783.

git-svn-id: https://develop.svn.wordpress.org/trunk@36904 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-09 19:50:28 +00:00
Andrea Fercia
3ee61161c6 Accessibility: Improve the headings hierarchy in the Add Themes screen.
Fixes #33819.

git-svn-id: https://develop.svn.wordpress.org/trunk@35273 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-19 22:03:48 +00:00
Sergey Biryukov
0916133d43 List tables: Select All should not be a column header.
It sets a redundant relationship with all checkboxes in its column and also conveys wrong information for screen readers.

props afercia, valendesigns.
see #31654.

git-svn-id: https://develop.svn.wordpress.org/trunk@32984 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-28 05:45:49 +00:00
Andrew Ozz
156df52851 Editor:
- Remove the old DFW.
- Add back-compat stub for wp-fullscreen.js.
- Keep wp_ajax_wp_fullscreen_save_post() for now.
See #30949.

git-svn-id: https://develop.svn.wordpress.org/trunk@32677 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-01 17:37:14 +00:00
Helen Hou-Sandi
f64bf71719 Update more instances of default admin blues and grays.
props hugobaeta.
fixes #31234.


git-svn-id: https://develop.svn.wordpress.org/trunk@32051 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-05 21:19:54 +00:00
Helen Hou-Sandi
c6c89eed8a Only apply metabox handle styles and JS events to .postbox .hndle, as opposed to all h3s in a .postbox.
Developers previously relying on the `h3` behavior may be affected. You may want to investigate `do_meta_boxes()` rather than recreating markup.

props SergeyBiryukov, nabil_kadimi.
fixes #28485.


git-svn-id: https://develop.svn.wordpress.org/trunk@28940 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-01 16:22:32 +00:00
Andrew Ozz
48f7c5fce3 TinyMCE: fix icons in IE7, fixes #27829
git-svn-id: https://develop.svn.wordpress.org/trunk@28142 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-16 00:09:10 +00:00
Andrew Ozz
141aaa04c5 DFW: remove unused #wp-fullscreen-title-prompt-text selectors. See #24067.
git-svn-id: https://develop.svn.wordpress.org/trunk@27039 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-27 00:38:19 +00:00
Sergey Biryukov
6f00e4be7e Remove invalid min-width property.
props jorbin.
fixes #26563 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@26886 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-31 10:47:51 +00:00
Ryan Boren
cfd5c395bb The Pinking Shears stir from their slumber, awakened by what may seem, to those
innocent in the ways of The Shears, a triviality, a nothing-of-consequence. But there are consequences indeed for recklessly trailing your whitespace. Naturally, they a dire!

One, two! One, two! And through and through
The Pinking Shears went snicker-snack!
They plucked your tail and with your space
They went sniksnuking back.

Let me tell you, that can be uncomfortable, so always pre-sniksnuk your trailing whites. May The Shears be with you.


git-svn-id: https://develop.svn.wordpress.org/trunk@26851 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-11 19:48:29 +00:00
Andrew Ozz
68f9e4db5e Make older mobile browsers and IE7 usable:
- Text labels in the toolbar.
- Image icons in the visual editor.
- Some IE7 structural css fixes.
Fixes #26369.

git-svn-id: https://develop.svn.wordpress.org/trunk@26819 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-09 02:40:32 +00:00
Matt Thomas
a8a4ce9f0d Reset the login form inputs to the standard sans-serif font in IE8 to prevent invisible password field inputs when webfonts are used. Fixes #26348, props SergeyBiryukov, iammattthomas.
git-svn-id: https://develop.svn.wordpress.org/trunk@26583 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-03 20:11:22 +00:00
Helen Hou-Sandi
17a8516d2e Remove now-unused #adminmenushadow. see #25858.
git-svn-id: https://develop.svn.wordpress.org/trunk@26182 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-14 23:48:44 +00:00
Andrew Nacin
3b82749eba Merge the new dashboard design into core.
Merges https://github.com/growthdesigner/wp-dash.

props lessbloat, joen, helen, dbernar1, kraftbj, ryelle, tillkruess, grapplerulrich, markjaquith.
see #25824.


git-svn-id: https://develop.svn.wordpress.org/trunk@26144 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-13 22:08:47 +00:00
Dominik Schilling (ocean90)
476e4a4778 IE7: Fix width of the password input field on the about page. see #25603.
git-svn-id: https://develop.svn.wordpress.org/trunk@25846 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 17:57:08 +00:00
Dominik Schilling (ocean90)
3b56df670e CSS cleanup for the about page.
Also fixes for IE and support for RTL.

see #25603.

git-svn-id: https://develop.svn.wordpress.org/trunk@25844 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 17:35:39 +00:00
Helen Hou-Sandi
0de512789e Better align the x icons with tag names. props TobiasBg. fixes #25050.
git-svn-id: https://develop.svn.wordpress.org/trunk@25029 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-15 19:58:04 +00:00
Andrew Nacin
b43712e0f7 New develop.svn.wordpress.org repository based on the old core.svn repository.
* All WordPress files move to a src/ directory.
 * New task runner (Grunt), configured to copy a built WordPress to build/.
 * svn:ignore and .gitignore for Gruntfile.js, wp-config.php, and node.js.
 * Remove Akismet external from develop.svn. Still exists in core.svn.
 * Drop minified files from src/. The build process will now generate these.

props koop.
see #24976.

and see http://wp.me/p2AvED-1AI.



git-svn-id: https://develop.svn.wordpress.org/trunk@25001 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-07 05:25:25 +00:00