Commit Graph
8191 Commits
Author SHA1 Message Date
Scott Taylor b59df508cf Theme Editor: ensure that files named index.php in theme subfolders are not labeled as "Main Index Template"
Props MikeHansenMe, wonderboymusic, bravokeyl, Shelob9.
Fixes #27201.


git-svn-id: https://develop.svn.wordpress.org/trunk@34658 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-28 03:10:08 +00:00
Scott Taylor 9d0f206ee1 After [34629], use $size_class instead of $size.
See #32093.


git-svn-id: https://develop.svn.wordpress.org/trunk@34657 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-28 02:49:05 +00:00
Gary Pendergast 2b78c9579a WPDB: Make sure we don't run sanity checks on DB dropins.
Previously, we'd run the sanity checks if `is_mysql` was not set to `false`. This caused problems for DB drop-ins that didn't define `is_mysql` at all. Instead, we can just check if `is_mysql` is `empty()`.

Also fix some unit tests that accidently ran correctly because of the strict `false ===` comparison.

Fixes #33501.



git-svn-id: https://develop.svn.wordpress.org/trunk@34655 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-28 01:16:29 +00:00
Scott Taylor a155c5dcfd After [34200], force 'before' and 'after' to <ul> and </ul> when wp_nav_menu() falls back to wp_page_menu().
See #11095.


git-svn-id: https://develop.svn.wordpress.org/trunk@34653 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 23:38:32 +00:00
Drew Jaynes 8594d93d7b Docs: Improve the hook documentation for the plugins_api_args filter.
Standardizes the hook doc summary and expands on the expected type for the `$args` parameter.

See #34035. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34652 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 23:02:47 +00:00
Drew Jaynes df542a1802 Docs: Improve the hook documentation for the themes_api filter.
Standardizes the hook doc summary and expands on expected behavior when short-circuiting the request, which is dependent on the `$action` type.

Also updates the expected types on the `$override` parameter.

See #34036. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34651 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 23:00:08 +00:00
Drew Jaynes c6c2afd70b Docs: Normalize the data table spacing in the themes_api() DocBlock following a typo fix in [34649].
See #34036.


git-svn-id: https://develop.svn.wordpress.org/trunk@34650 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 22:48:06 +00:00
Drew Jaynes 8fa143dc2e Docs: Fix two typos in the DocBlock description for themes_api():
* The fourth `$action` type is 'feature_list'
* The first `$action` type in the data table should be 'query_themes'

See #34036.


git-svn-id: https://develop.svn.wordpress.org/trunk@34649 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 22:46:37 +00:00
Drew Jaynes 9e4c655b2a Docs: Adjust the themes_api() DocBlock description to clarify the "second" available hook, themes_api, and add new information for the "third" hook, themes_api_result.
See #34036.


git-svn-id: https://develop.svn.wordpress.org/trunk@34648 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 22:44:18 +00:00
Drew Jaynes c82483fcbc Docs: Improve the hook documentation for the plugins_api filter.
Standardizes the hook doc summary and expands on expected behavior when short-circuiting the request, which is dependent on the `$action` type.

See #34035. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34647 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 22:28:38 +00:00
Drew Jaynes ed0ef8e2c0 Docs: Adjust the plugins_api() DocBlock description to clarify the "second" available hook, plugins_api, and add new information for the "third" hook, plugins_api_result.
See #34035.


git-svn-id: https://develop.svn.wordpress.org/trunk@34645 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 22:22:32 +00:00
Drew Jaynes c64bab4531 Docs: Slightly improve the readability of the data table in the DocBlock description for the oembed_providers hook by centering the HTTPS column.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34644 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 22:11:01 +00:00
Scott Taylor 813bff7bdb Canonical: after [34272], don't redirect rewrite endpoints on attachment URLs when pretty permalinks are enabled.
Fixes #19918.


git-svn-id: https://develop.svn.wordpress.org/trunk@34643 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 22:10:08 +00:00
Drew Jaynes b9944f6331 Docs: Update the DocBlock summary for plugins_api() to reflect the "WordPress.org" Plugins API.
See #34035.


git-svn-id: https://develop.svn.wordpress.org/trunk@34642 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 22:06:37 +00:00
Drew Jaynes 40c3091ee3 Docs: Further improve documentation for plugins_api().
* Adds a matrix-like data table demonstrating which arguments are available for the different `$action` types
* Adjusts the return types to accommodate an `array` for the 'hot_tags' `$action` choice

Props ocean90.
See #34035.


git-svn-id: https://develop.svn.wordpress.org/trunk@34641 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 21:59:12 +00:00
Drew Jaynes e712f041e2 Docs: Vastly improve documentation for themes_api().
Adds:
* A hash notation with descriptions for all accepted arguments
* A matrix-like data table demonstrating which arguments are available for the different `$action` types
* A better summary and description with linked hooks
* An improved return description with a link to external information

Props ocean90.
See #34036.


git-svn-id: https://develop.svn.wordpress.org/trunk@34640 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 21:51:18 +00:00
John Blackbourn a0be6bbb12 Don't set CURLOPT_CAINFO when sslverify is false when sending HTTP API requests through cURL. This avoids sending redundant information to cURL, and avoids a bug in Apple's SecureTransport library which causes a request to fail when a CA bundle is set but certificate verification is disabled.
This fixes issues with local HTTPS requests (eg. WP Cron) on OS X where cURL is using SecureTransport instead of OpenSSL.

Fixes #33978


git-svn-id: https://develop.svn.wordpress.org/trunk@34639 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 21:37:00 +00:00
Helen Hou-Sandi deb42cc66f Autoprefixer for [34634].
Normally when there are multiple comma-separated values in CSS, each one would go on its own indented line. However, Autoprefixer appears to be tripping up on gradients at the moment, so it's going to stay on one line until we investigate upstream.

see #33299.


git-svn-id: https://develop.svn.wordpress.org/trunk@34637 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 19:16:35 +00:00
Scott Taylor 8fa5426485 Users List Table: show the "Change role to" dropdown on the top and bottom. Currently only shows on top.
See #27743.


git-svn-id: https://develop.svn.wordpress.org/trunk@34636 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 19:10:08 +00:00
Drew Jaynes b3f49e0cdf Docs: Fix some syntatical issues in the DocBlock for WP::send_headers() following [34632].
See #20226. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34635 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 18:48:14 +00:00
Scott Taylor 4dc810ad3c Feature Image: Improve the preview for transparent background images by using CSS3 to show a checkered background.
Props metodiew.
Fixes #33299.


git-svn-id: https://develop.svn.wordpress.org/trunk@34634 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 18:40:40 +00:00
Scott Taylor f802fef76f Update the docs in WP to explain the need to do [34476].
Fixes #20226.


git-svn-id: https://develop.svn.wordpress.org/trunk@34632 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 18:27:15 +00:00
Drew Jaynes fe14c06e0a Docs: Add documentation for the $browse, $user, $search, $author, $tag, $installed_plugins, and $page parameters in plugins_api().
Props ocean90.
Fixes #34035.


git-svn-id: https://develop.svn.wordpress.org/trunk@34631 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 18:12:59 +00:00
Scott Taylor 61d6854bae Nav Menus: in wp_nav_menu(), $container is already bound to a list of allowed tags. PHP, being its whimsical self, while return true if someone sets $container to true via in_array( true, [ 'div', 'nav' ] ). Check that $container is a string before the in_array() check. 'true' does not pass.
Props shedonist for the original patch.
Fixes #32464.


git-svn-id: https://develop.svn.wordpress.org/trunk@34630 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 18:12:20 +00:00
Scott Taylor b45a72a67c Add size-$size class to <img> in wp_get_attachment_image().
Fixes #32093.


git-svn-id: https://develop.svn.wordpress.org/trunk@34629 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 17:54:01 +00:00
Boone Gorges de0b5c846f Introduce 'the_category_list' filter.
Used to filter categories as structured data, before building markup in
`get_the_category_list()`.

We use this filter in addition to upstream filters (such as
'get_the_categories'`) because those upstream filters are used in numerous
contexts, while `'the_category_list'` is always used for generating markup
for display.

Props KevinB, ericlewis, SergeyBiryukov, DrewAPicture.
Fixes #9227.

git-svn-id: https://develop.svn.wordpress.org/trunk@34625 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 02:21:43 +00:00
Boone Gorges c39a4a6447 Pass the post ID to the get_the_categories filter.
Props SergeyBiryukov.
See #9227.

git-svn-id: https://develop.svn.wordpress.org/trunk@34624 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 02:16:23 +00:00
Drew Jaynes 5d9625c28c Restore and deprecate the WP_Widget_Recent_Comments::flush_widget_cache() method, removed in [34580].
Fixes #25556.


git-svn-id: https://develop.svn.wordpress.org/trunk@34622 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 01:39:37 +00:00
Drew Jaynes 7510d4e58c Docs: Improve documentation for the __construct(), widget(), update(), and form() methods in WP_Nav_Menu_Widget.
Props leemon.
Fixes #34015. Fixes #34013.


git-svn-id: https://develop.svn.wordpress.org/trunk@34621 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 01:15:13 +00:00
Drew Jaynes 982d5b99ea Docs: Improve documentation for the __construct(), widget(), update(), and form() methods in WP_Widget_Archives.
Props leemon.
Fixes #34016. See #34013.


git-svn-id: https://develop.svn.wordpress.org/trunk@34620 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 01:10:38 +00:00
Drew Jaynes 9909c7ff2b Docs: Improve documentation for the __construct(), widget(), update(), and form() methods in WP_Widget_Calendar.
Props leemon.
Fixes #34017. See #34013.


git-svn-id: https://develop.svn.wordpress.org/trunk@34619 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 01:06:20 +00:00
Drew Jaynes b8264d11bc Docs: Improve documentation for the __construct(), widget(), update(), form(), and _get_current_taxonomy() methods in WP_Widget_Categories.
Props leemon.
Fixes #34018. See #34013.


git-svn-id: https://develop.svn.wordpress.org/trunk@34618 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 01:03:31 +00:00
Drew Jaynes aec4d6abe9 Docs: Improve documentation for the __construct(), widget(), update(), and form() methods in WP_Widget_Links.
Props leemon.
Fixes #34019. See #34013.


git-svn-id: https://develop.svn.wordpress.org/trunk@34617 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 00:59:44 +00:00
Drew Jaynes e9f835dc43 Docs: Improve documentation for the __construct(), widget(), update(), and form() methods in WP_Widget_Meta.
Props leemon.
Fixes #34020. See #34013.


git-svn-id: https://develop.svn.wordpress.org/trunk@34616 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 00:57:03 +00:00
Drew Jaynes f90a2dbe1c Docs: Improve documentation for the __construct(), widget(), update(), and form() methods in WP_Widget_Pages.
Props leemon.
Fixes #34021. See #34013.


git-svn-id: https://develop.svn.wordpress.org/trunk@34615 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 00:53:36 +00:00
Drew Jaynes f2af1a6a1f Docs: Improve documentation for the __construct(), recent_comments_style(), widget(), update(), and form() methods in WP_Widget_Recent_Comments.
Also fixes a typo in the class DocBlock.

Props leemon.
Fixes #34022. See #34013.


git-svn-id: https://develop.svn.wordpress.org/trunk@34614 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 00:50:04 +00:00
Drew Jaynes fdd92e64cd Docs: Improve documentation for the __construct(), widget(), update(), and form() methods in WP_Widget_Recent_Posts.
Also fixes a typo in the class DocBlock.

Props leemon.
Fixes #34023. See #34013.


git-svn-id: https://develop.svn.wordpress.org/trunk@34613 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 00:45:42 +00:00
Drew Jaynes 14cac9aded Docs: Improve documentation for the __construct(), widget(), update(), and form() methods in WP_Widget_RSS.
Props leemon.
Fixes #34024. See #34013.


git-svn-id: https://develop.svn.wordpress.org/trunk@34612 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 00:41:47 +00:00
Drew Jaynes f111c41375 Docs: Improve documentation for the __construct(), widget(), update(), and form() methods in WP_Widget_Search.
Props leemon.
Fixes #34025. See #34013.


git-svn-id: https://develop.svn.wordpress.org/trunk@34611 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 00:36:26 +00:00
Drew Jaynes b28f41f852 Docs: Improve the documentation for the __construct(), widget(), update(), and form() methods in WP_Widget_Tag_Cloud.
Props leemon.
Fixes #34026. See #34013.


git-svn-id: https://develop.svn.wordpress.org/trunk@34610 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 00:31:59 +00:00
Drew Jaynes d6169cab23 Docs: Improve documentation for the __construct(), widget(), update(), and form() methods in WP_Widget_Text.
(first!) Props leemon.
Fixes #34027.


git-svn-id: https://develop.svn.wordpress.org/trunk@34609 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 00:26:56 +00:00
Weston Ruter ab7d1ae62d Customize: Prevent showing "Front Page" and "Posts Page" states for pages in list table when show_on_front is not "page".
Changing the `show_on_front` option back to "posts" also resets the `page_on_front` and `page_for_posts` options when updating via the Reading settings page. In the Customizer, however, this is not the case as these other options remain unchanged. This change accounts for this difference in behavior.

Fixes #34004.


git-svn-id: https://develop.svn.wordpress.org/trunk@34605 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 20:53:32 +00:00
Scott Taylor 591b743362 After [34577], alter wp_xmlrpc_server::mw_newMediaObject() to check upload space in multisite.
See #21292.


git-svn-id: https://develop.svn.wordpress.org/trunk@34603 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 19:48:57 +00:00
Boone Gorges eb8b241559 Improve post field lazyloading for comments.
[34583] modified comment queries so that all post fields are no longer loaded
by default. Instead, they are loaded only when requested on individual comment
objects. This changeset improves that flow:

* `WP_Comment` magic methods `__isset()` and `__get()` should only load the post when a post field is being requested.
* The new `update_comment_post_cache` argument for `WP_Comment_Query` allows developers to specify that, when comments are queried, all of the posts matching those comments should be loaded into cache with a single DB hit. This parameter defaults to false, since typical comment queries are linked to a single post.

Fixes #27571.

git-svn-id: https://develop.svn.wordpress.org/trunk@34599 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 16:01:05 +00:00
Dominik Schilling (ocean90) 5da80b3d64 Plugins: Don't request all fields via plugins_api( 'plugin_information' ) for plugin installs and update checks.
The Plugins API returns a lot of data by default (see [34596]) but when installing or checking for updates we don't need all of it. To save bandwidth, memory and time request only required fields.

Fixes #34030.

git-svn-id: https://develop.svn.wordpress.org/trunk@34598 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 15:49:06 +00:00
John Blackbourn 60660b0055 Remove the unnecessary horizontal rules in the oEmbed providers table to tidy up the Code Reference.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@34597 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 15:16:05 +00:00
Drew Jaynes de8abd004f Docs: Add much-needed (and awesome) hash-notation-style documentation for the $args parameter in the plugins_api() DocBlock.
Also fixes up some formatting in the DocBlock summary and description, and adds a link to the function reference, where supplementary information on return object structs and formatting will live.

Props ocean90.
Fixes #34035.


git-svn-id: https://develop.svn.wordpress.org/trunk@34596 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 15:12:51 +00:00
Boone Gorges ecf4b81d72 Use correct property name when setting child comments.
This fixes a typo from [34546], uncovered by unrelated changes in [34583].

See #8071, #27571.

git-svn-id: https://develop.svn.wordpress.org/trunk@34595 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 14:40:15 +00:00
Sergey Biryukov 5569780f8a Replace a stray semicolon on Edit Page screen with a full stop.
Props manolis09, sjmur.
Fixes #33297.

git-svn-id: https://develop.svn.wordpress.org/trunk@34594 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 13:43:31 +00:00
Drew Jaynes 11e0b8d0b0 Docs: Fix a minor typo from [34592]. Meant to be past-tense, not present.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34593 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 13:13:50 +00:00