Commit Graph

4171 Commits

Author SHA1 Message Date
Andrew Ozz
b68a4e3da6 Editor: hide the Move to Trash link for auto-drafts until they are auto-saved.
Props iseulde.
Fixes #16116.

git-svn-id: https://develop.svn.wordpress.org/trunk@36972 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-12 17:21:52 +00:00
Andrew Ozz
9d753fbf5a Editor: correct and update the Visual and Text editors description in the screen help.
Props arush, adamsilverstein, azaozz.
Fixes #35479.

git-svn-id: https://develop.svn.wordpress.org/trunk@36971 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-12 16:42:14 +00:00
Dominik Schilling (ocean90)
39ddaa65cc Docs: Correct grammar when referring to "a URL" vs "an URL" in several places.
Fixes #36218.

git-svn-id: https://develop.svn.wordpress.org/trunk@36970 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-12 12:38:48 +00:00
Pascal Birchler
91d4bbd041 Taxonomy: After [36874], rename $term_id to $tag_ID in wp-admin/edit-tag-form.php.
This ensures that no variables changed in the process of introducing `wp-admin/term.php`, improving overall backward compatibility.

Props Chouby for initial patch.
Fixes #34988.

git-svn-id: https://develop.svn.wordpress.org/trunk@36969 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-11 08:51:13 +00:00
Andrea Fercia
f4ee598def Coding standards after [36510].
git-svn-id: https://develop.svn.wordpress.org/trunk@36967 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 23:17:46 +00:00
Andrea Fercia
2a2539402f Accessibility: Improve accessibility for the Plugin details modal.
The plugin details modal can be invoked from several screens. There's now a new
`.open-plugin-details-modal` CSS class to be used in combination with the
`.thickbox` CSS class that adds everything needed for accessibility.

- Adds an ARIA role `dialog` and an `aria-label` attribute to the modal
- Adds a `title` attribute to the iframe inside the modal
- Constrains tabbing within the modal
- Restores focus back in a proper place when closing the modal

Also, improves a bit the native Thickbox implementation: it should probably be
replaced with some more modern tool but at least keyboard focus should be moved
inside the modal.

Fixes #33305.

git-svn-id: https://develop.svn.wordpress.org/trunk@36964 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 22:36:25 +00:00
Andrea Fercia
474c7da237 Accessibility: Improve the color contrast ratio of the expandable panel "handles".
Fixes #35923.

git-svn-id: https://develop.svn.wordpress.org/trunk@36959 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 21:44:00 +00:00
Rachel Baker
55cda28b18 Comments: On the Edit Comment screen do not show the permalink for unapproved comments.
Fixes #36161.

git-svn-id: https://develop.svn.wordpress.org/trunk@36958 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 21:17:57 +00:00
Dominik Schilling (ocean90)
73a88ca194 Editor: Fix size of the resize handle on RTL sites for HiDPI screens.
Also, add the `/*rtl:ignore*/` control directive so rtlcss doesn't process them again.

Fixes #36193.

git-svn-id: https://develop.svn.wordpress.org/trunk@36934 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 14:05:41 +00:00
Gary Pendergast
28a6bf00f7 About: Run w-logo-white.png through imagemin.
See #35661.



git-svn-id: https://develop.svn.wordpress.org/trunk@36929 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 05:15:33 +00:00
Jeremy Felt
91513893c2 Posts: Call set_url_scheme() consistently on URLs passed through preview_post_link
After [34170], some preview URLs that passed through `set_url_scheme()` no longer do so. We can restore that behavior by applying `set_url_scheme()` whenever `get_preview_post_link()` provides the URL.

Props danielbachhuber.
Fixes #35407.


git-svn-id: https://develop.svn.wordpress.org/trunk@36926 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 04:41:34 +00:00
Konstantin Obenland
6d951b3c5d Customize: Only add custom logo’s header text control if needed.
Dissolves `WP_CustomLogo` and adopts a structure similar to custom header and background (See `_delete_attachment_theme_mod()`).
The option to hide header text only gets added if it’s not already part of custom header, and only if selectors have been registered when theme support for custom logos was declared. Themes can add `postMessage` support for it as well.

Example:
{{{
add_theme_support( 'custom-logo', array(
    'size' => ‘large’,
    'header-text' => array( 'site-title', 'site-description' ),
) );
}}}

See #33755.


git-svn-id: https://develop.svn.wordpress.org/trunk@36915 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-09 23:43:49 +00:00
Mel Choyce
14d0424513 About: Improve color contrast of WP Badge text, and update the logo to use the latest version.
Fixes #35661.
Props @hugobaeta.


git-svn-id: https://develop.svn.wordpress.org/trunk@36910 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-09 21:52:29 +00:00
Weston Ruter
7ececb24f5 Customize: Fix persistence of toggles for displayed nav menu item properties.
* Eliminates need to click more than one checkbox to have preferences saved.
* Adds debouncing to saving user-selected menu item properties.
* Also removes discrepancies between available nav menu item properties on admin page vs Customizer.

Fixes #35273.
Props afercia, westonruter.


git-svn-id: https://develop.svn.wordpress.org/trunk@36908 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-09 21:40:27 +00:00
Konstantin Obenland
326806a961 Customize: Reduce vertical space of site icon control.
Makes the control easier to find, reduces visual clutter, and is more
consistent with Customizer UI conventions.

Props celloexpressions.
Fixes #35943.


git-svn-id: https://develop.svn.wordpress.org/trunk@36907 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-09 21:18:53 +00:00
Andrea Fercia
7e71bb398c Accessibility: Reduce the WordPress shades of grey, Episode 3.
Also, removes some no more used CSS.

See #35783.

git-svn-id: https://develop.svn.wordpress.org/trunk@36904 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-09 19:50:28 +00:00
Sergey Biryukov
11c47a6cb5 Use admin_url() for "Add New" links in wp-admin/users.php.
Props johnjamesjacoby.
Fixes #36186.

git-svn-id: https://develop.svn.wordpress.org/trunk@36902 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-09 19:08:58 +00:00
Sergey Biryukov
96520194c7 Use admin_url() for "Add New" links in wp-admin/upload.php.
Props johnjamesjacoby.
See #36186.

git-svn-id: https://develop.svn.wordpress.org/trunk@36901 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-09 19:08:12 +00:00
Dominik Schilling (ocean90)
6a8cb09f86 Media: Change wording for media files which aren't attached.
The media library can contain files which aren't attached yet. When attaching a file you currently get "Media attachment reattached.", or the opposite "Media attachment detached.". That's redundant and can be inaccurate. It's also not easy to translate in some languages.

This change generalizes the strings to refer to a "media file" instead.

Props SergeyBiryukov, ocean90, netweb.
Fixes #36089.

git-svn-id: https://develop.svn.wordpress.org/trunk@36887 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-08 17:42:45 +00:00
Andrea Fercia
137bcc1fca Accessibility: Remove the title attributes from the old Media UI.
Also, adds better indication and attributes for the required form fields.
Moves some styles to `deprecated-media.css`.

Props andg, afercia.
Fixes #34944.

git-svn-id: https://develop.svn.wordpress.org/trunk@36879 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-07 22:28:15 +00:00
Drew Jaynes
6012464446 Docs: Add a missing @since version to the DocBlock for wp_add_dashboard_widget().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36878 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-07 22:16:56 +00:00
Andrea Fercia
d92e10fbb1 Customizer: Improve the collapsed view when switching to the responsive view.
Props rittesh.patel, afercia.

Fixes #35220.

git-svn-id: https://develop.svn.wordpress.org/trunk@36877 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-07 22:04:29 +00:00
Pascal Birchler
3a51ff4d2e Taxonomy: Improve backward compatibility on the wp-admin/term.php page.
Specifically, run `do_action( 'edit-tags.php' );` on this new term edit page introduced in [36308]. Changes the GET param back to `tag_ID` and properly sets the screen base in `WP_Screen`.

See #34988.

git-svn-id: https://develop.svn.wordpress.org/trunk@36874 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-07 12:55:04 +00:00
Dion Hulse
e9dbf32553 Setup config: Generate the default secret keys & salts from the local CSPRNG if available, falling back to the WordPress.org API and a backup psuedo random source.
Props diddledan.
Fixes #35290


git-svn-id: https://develop.svn.wordpress.org/trunk@36872 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-07 06:31:18 +00:00
Andrea Fercia
b723d3fb75 CSS: Rename the handle for deprecated-media.css after [36341].
The `media` handle is now used for `media.css` thus the stylesheet
for the old media UI needs a different handle name.

See #35229.

git-svn-id: https://develop.svn.wordpress.org/trunk@36869 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-06 15:37:25 +00:00
Sergey Biryukov
74da332c40 Docs: Add wp_add_dashboard_widget() parameter descriptions.
Props meitar for initial patch.
Fixes #36092.

git-svn-id: https://develop.svn.wordpress.org/trunk@36868 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-06 12:07:34 +00:00
Weston Ruter
52d50a6ce9 Customize: Fix image cropping when doing live preview of theme switches.
Ensure that the Customizer gets bootstrapped with the pre-activated `theme` supplied in the `custom-header-crop` admin ajax requests.

Props faishal, rittesh.patel.
Fixes #32783.


git-svn-id: https://develop.svn.wordpress.org/trunk@36866 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-06 01:44:53 +00:00
Dominik Schilling (ocean90)
e5556666cc Themes: Bring the device preview from [31195] to the theme install previewer.
Props celloexpressions.
Fixes #36017.

git-svn-id: https://develop.svn.wordpress.org/trunk@36858 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-05 22:06:57 +00:00
John Blackbourn
48959ec76e Posts, Post Types: Ensure that non-ASCII characters in attachment slugs aren't shown in urlencoded form in the sample permalink UI.
Fixes #35980


git-svn-id: https://develop.svn.wordpress.org/trunk@36853 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-05 03:55:33 +00:00
Eric Andrew Lewis
ae1c49027a Menus: Ensure theme location setting data is saved with a large menu.
[36510] introduced a fix to allow users to save large menus on the Edit Menu screen (70+ menu items). The form data is stored as JSON which is used to inject the `$_POST` variable in the form submission handler. This injection was not setting form items with named array elements properly (e.g. `menu-locations[primary]`), which did not save theme location data in a large form.

Props keraweb.
See #14134.


git-svn-id: https://develop.svn.wordpress.org/trunk@36852 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-05 00:46:45 +00:00
Weston Ruter
084772af80 Customize: Eliminate unnecessary WP_Customize_Site_Logo_Control in favor of re-using WP_Customize_Image_Control.
* Removes double `margin-bottom` from all the media controls.
* All media controls now send `{settingId}-attachment-data` messages to the preview when a media setting is updated so that the preview has access to the attachment data.
* Fixes receiving of `attachment-data` message for `custom_logo` which resulted in instant JS-applied preview not working. See #36096.

See #33755.
Fixes #35941.


git-svn-id: https://develop.svn.wordpress.org/trunk@36851 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-04 23:46:07 +00:00
Dominik Schilling (ocean90)
d9c9742527 I18N: Fix an invalid placeholder added in [36844].
See #36048.

git-svn-id: https://develop.svn.wordpress.org/trunk@36850 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-04 21:09:31 +00:00
Andrew Ozz
b0865cdcd0 TinyMCE, inline link: add styling for the dialog and UI Autocomplete to Press This.
See #33301.

git-svn-id: https://develop.svn.wordpress.org/trunk@36849 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-04 20:30:49 +00:00
Andrew Ozz
a9810a6287 Pres This:
- Change the newly added `press_this_save_post_content` filter to `press_this_save_post` and pass the $post_data array to it.
- Remove the newly added `press_this_useful_html_elements`. It only runs in compatibility mode when a URL is typed by the user.
- Remove the `press_this_suggested_content` filter. It is redundant as the suggested HTML for the editor is already filtered by `press_this_suggested_html`.
- Add some more inline docs and rename couple of vars to make the code more readable.

Fixes #34455.

git-svn-id: https://develop.svn.wordpress.org/trunk@36848 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-04 18:55:23 +00:00
Sergey Biryukov
d8f72707d2 I18N: Move the aria-label text in get_theme_update_available() to a separate string for easier translation.
Add translator comments.

Props ramiy.
Fixes #36048.

git-svn-id: https://develop.svn.wordpress.org/trunk@36845 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-04 11:11:03 +00:00
Sergey Biryukov
9c39e27fde I18N: Move the aria-label text in wp_plugin_update_row() and wp_theme_update_row() to a separate string for easier translation.
Add translator comments.

Props ramiy.
See #36048.

git-svn-id: https://develop.svn.wordpress.org/trunk@36844 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-04 11:07:29 +00:00
Sergey Biryukov
fb7ada9e9a Comment out some CSS files in $_old_files that were added back as a result of [36341].
Add a unit test to make sure the `$_old_files` array does not contain any current project files.

Props joemcgill, swissspidy.
Fixes #36083.

git-svn-id: https://develop.svn.wordpress.org/trunk@36843 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-04 07:55:21 +00:00
Konstantin Obenland
1134b18c6e Customize: Don't show custom image sizes in the media modal.
Custom image sizes for logos should only be used for their intended purpose.

See #33755.


git-svn-id: https://develop.svn.wordpress.org/trunk@36839 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 21:44:26 +00:00
Konstantin Obenland
cf863ab2a8 Customize: Rename custom logo classes after [36837].
Fixes #35945.


git-svn-id: https://develop.svn.wordpress.org/trunk@36838 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 19:58:37 +00:00
Konstantin Obenland
43ff969765 Customize: Site logos are custom logos.
Brings the nomenclature closer to custom headers and backgrounds.

See https://wordpress.slack.com/archives/core/p1456955151003150
See #35945. 


git-svn-id: https://develop.svn.wordpress.org/trunk@36837 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 19:55:15 +00:00
Sergey Biryukov
090e49fe74 Docs: Correct $plugins global type in WP_Plugins_List_Table::prepare_items().
Props mt8.biz.
Fixes #36080.

git-svn-id: https://develop.svn.wordpress.org/trunk@36830 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 10:00:40 +00:00
Pascal Birchler
1178047725 Docs: Move the hook doc for the all_plugins filter in WP_Plugins_List_Table::prepare_items() to directly precede the apply_filters() line.
See #35986.

git-svn-id: https://develop.svn.wordpress.org/trunk@36828 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 09:50:57 +00:00
Drew Jaynes
0a17fdaf07 Docs: Minorly improve the hook doc summary for the pre_network_site_new_created_user action, introduced in [35786].
See #33631. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36826 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 09:02:46 +00:00
Drew Jaynes
c6be176807 Docs: Improve documentation for upgrade_450(), introduced in [36180].
See #27772, #35323. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36825 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 09:00:58 +00:00
Drew Jaynes
7612a6f488 Docs: Minorly improve the hook doc summary for the pre_uninstall_plugin action, introduced in [36124].
See #34569. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36824 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 08:57:22 +00:00
Drew Jaynes
d81a852b48 Docs: Add a more descriptive changelog entry to the hook doc for the privacy_on_link_title filter.
See #35049. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36823 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 08:55:06 +00:00
Drew Jaynes
ecc7d4f1b3 Docs: Improve documentation for WP_Upgrader::release_lock(), introduced in [36349].
See #34878. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36822 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 07:10:58 +00:00
Drew Jaynes
5fc3cdb07e Docs: Improve documentation for WP_Upgrader::create_lock(), introduced in [36349].
See #34878. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36821 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 07:07:31 +00:00
Drew Jaynes
2bd631f227 Docs: Use third-person singular verbs in DocBlock summaries for the WP_Site_Logo class, introduced in [36698].
Also minorly improves various inline docs.

See #33755. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36820 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 07:03:23 +00:00
Drew Jaynes
df578beaf7 Docs: Match the parameter name in the hook docs for the press_this_useful_html_elements filter, introduced in [36672].
See #34455. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36819 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 06:57:21 +00:00