Commit Graph

3708 Commits

Author SHA1 Message Date
Sergey Biryukov
bcb1e8eda2 Docs: Use consistent naming and capitalization of menu names in add_submenu_page() wrappers.
Props atomicjack, Mckilem.
Fixes #34360.

git-svn-id: https://develop.svn.wordpress.org/trunk@35373 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-23 12:01:11 +00:00
dd32
f935d4c26b Updates: Add a generic failure case to the ajax update endpoint for when the WP_Error value hasn't been found.
See #34403


git-svn-id: https://develop.svn.wordpress.org/trunk@35371 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-23 07:34:02 +00:00
Dion Hulse
743fe671f1 Comments: Use a full URL rather than a relative one for links which can contain IPv6 addresses to avoid an issue where the URL was being eaten by escaping functions.
See #34407, #34202
Fixes #34054


git-svn-id: https://develop.svn.wordpress.org/trunk@35368 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-23 05:13:27 +00:00
Scott Taylor
c6354d6bfd Plugins: after [35151], set default $restrict_network_* values to prevent notices.
Props johnjamesjacoby.
Fixes #20104.


git-svn-id: https://develop.svn.wordpress.org/trunk@35361 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 19:55:30 +00:00
Scott Taylor
9aba8ef2aa Options: remove old 'gzipcompression' and 'advanced_edit' options.
Props chriscct7, solarissmoke.
Fixes #12996.


git-svn-id: https://develop.svn.wordpress.org/trunk@35360 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 19:48:38 +00:00
Drew Jaynes
68c5efb7f3 Docs: Add a proper file header to wp-admin/includes/continents-cities.php.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35359 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 19:42:23 +00:00
Helen Hou-Sandi
7adf6e9125 List tables: Move the view mode switcher into screen options for posts.
Having a view mode switcher nestled within table navigation makes no sense, especially now that it's a sticky user option. While less convenient for frequent switching, there is no evidence as of yet that there is a large userbase of frequent view mode switchers.

Introduces a filter for `view_mode_post_types`, which by default is all hierarchical post types with edit UI on.

props Oxymoron.
fixes #22222.


git-svn-id: https://develop.svn.wordpress.org/trunk@35357 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 19:24:10 +00:00
Andrea Fercia
bdffdf0eb6 Plugins: Improve the "Install Now" button vertical alignment in the Plugin Details modal dialog.
Props paulwilde.

Fixes #34199.

git-svn-id: https://develop.svn.wordpress.org/trunk@35343 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 21:54:42 +00:00
Helen Hou-Sandi
9e865f51a8 RIP #21759b, the old WordPress Blue.
The final lingering instances were all for hidden accessibility helper text.

fixes #34388.


git-svn-id: https://develop.svn.wordpress.org/trunk@35340 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 18:35:05 +00:00
Andrea Fercia
ac3edc61fd Press This: Improve the "choose tags" button focus style.
Props adamholisky for the initial patch.

Fixes 34241.

git-svn-id: https://develop.svn.wordpress.org/trunk@35338 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 18:33:46 +00:00
Dominik Schilling (ocean90)
05356ff7dc Options: Hide the week starts on setting for installs that have the default setting already.
The default setting is the value of `$wp_locale->start_of_week` which holds the value per locale, see [35336].

Props swissspidy, ocean90.
Fixes #28344.

git-svn-id: https://develop.svn.wordpress.org/trunk@35337 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 17:38:44 +00:00
Boone Gorges
e4b72ad5ca Don't force comment pagination.
[34561] instituted the policy of forcing pagination for comments. This strategy
was intended to avert problems when 'page_comments' is set to 0 - as it is by
default - and the number of comments on a given post rises into the hundreds or
thousands. By forcing pagination in all cases, we ensured that WordPress would
not time out by processing unwieldy numbers of comments on a given pageload.

The strategy proves problematic, however, because comment permalinks are
generated using the page of the comment. Forcing pagination for posts that
were not previously paginated would change the URL of all comments that do not
appear on the default comment page.

This changeset reintroduces the 'page_comments' setting and its corresponding
checkbox on Settings > Discussion. A number of tests, which were written after
[34561], are modified to work now that 'page_comments' will, once again, be
disabled by default.

See #8071.

git-svn-id: https://develop.svn.wordpress.org/trunk@35331 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 16:25:31 +00:00
Dominik Schilling (ocean90)
9a1b5f93cd List Tables: Replace the hyphen separator for titles and post/media states with a —.
Props McGuive7.
Fixes #23230.

git-svn-id: https://develop.svn.wordpress.org/trunk@35326 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 14:32:02 +00:00
Drew Jaynes
a28e35e462 Filesystem: Following the introduction of the KB|MB|GB|TB_IN_BYTES constants in [35286], use them in various places in core.
Props sudar.
Fixes #22405.


git-svn-id: https://develop.svn.wordpress.org/trunk@35325 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 14:02:59 +00:00
Andrew Ozz
5bc6ae50ab Precommit cleanup, see r35313.
git-svn-id: https://develop.svn.wordpress.org/trunk@35318 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 05:32:54 +00:00
Andrew Ozz
7ba408c93e Widgets: add a button to delete all inactive widgets simultaneously for better UX.
Props cdog.
Fixes #19159.

git-svn-id: https://develop.svn.wordpress.org/trunk@35317 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 05:22:52 +00:00
Scott Taylor
ba1177bf4c Export: add missing labels and improvement accessibility of the Export screen.
Props afercia.
Fixes #33046.


git-svn-id: https://develop.svn.wordpress.org/trunk@35316 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 03:56:22 +00:00
Scott Taylor
6f6c0ebb52 Plugins/Updates: in request_filesystem_credentials(), alter the heading HTML tag based on the current screen for improved semantics.
Props afercia.
Fixes #34267.


git-svn-id: https://develop.svn.wordpress.org/trunk@35315 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 03:50:19 +00:00
Scott Taylor
51637379a2 Formatting: move url_shorten() from wp-admin/includes/misc.php to wp-includes/formatting.php for more global access.
Adds unit tests.

Props mulvane, chriscct7.
Fixes #20166.


git-svn-id: https://develop.svn.wordpress.org/trunk@35314 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 03:47:23 +00:00
Scott Taylor
be739bd6c0 Administration: the current admin menu item should have an aria-haspopup attribute when the menu is folded.
Unify the jQuery selector caching for `window`, `document`, and `body`.

Props afercia.
Fixes #32578.


git-svn-id: https://develop.svn.wordpress.org/trunk@35313 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 03:40:38 +00:00
Scott Taylor
e4bcddecfb Site Icon: make the default value for the site_icon option 0 in schema.php.
Props swissspidy, sebastian.pisula.
Fixes #34339.


git-svn-id: https://develop.svn.wordpress.org/trunk@35312 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 03:27:54 +00:00
Sergey Biryukov
5252cb7fe3 Autoprefixer for [35281].
See #33322.

git-svn-id: https://develop.svn.wordpress.org/trunk@35310 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 03:01:13 +00:00
Weston Ruter
bde89adaf8 Customizer: Introduce customize_loaded_components filter to allow core components to be disabled.
Also move style rule from `customize-nav-menus.css` to `customize-controls.css` so that widgets button is properly styled when `nav_menus` component is excluded from loading. See [35304]. See #33327.

Props westonruter, DrewAPicture.
Fixes #33552.


git-svn-id: https://develop.svn.wordpress.org/trunk@35307 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 22:15:11 +00:00
Andrea Fercia
8774b40dc8 Customizer: Make the widgets "Reorder" and "Add a Widget" buttons... buttons.
For accessibility, UI controls should preferably be native controls. Adds
ARIA attributes and labels to improve accessibility and pair these buttons
with the ones in the Menu Customizer.

Props obenland, TomHarrigan, sanket.parmar, metodiew, afercia.

Fixes #33327.

git-svn-id: https://develop.svn.wordpress.org/trunk@35304 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 20:14:51 +00:00
Weston Ruter
9724c7cdbd Customizer: Implement indicators for invalid nav menu items.
The same indicator on the nav menus admin page is now present for nav menu items in the Customizer. When a menu item is present for a post type that is no longer registered, the menu item will appear with the indicator.

Props kucrut, westonruter.
Fixes #33665.


git-svn-id: https://develop.svn.wordpress.org/trunk@35302 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 19:07:58 +00:00
Konstantin Obenland
e9579b3ed5 Site Icon: Get site icon ID only when needed.
Cuts down on unnecessary queries, especially in environments that rely on
post meta a lot. Reverts [32997].

Props ap.koponen, swissspidy.
Fixes #34368.



git-svn-id: https://develop.svn.wordpress.org/trunk@35299 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 18:22:41 +00:00
Sergey Biryukov
0a614515ac Tags: Avoid a double trailing space after tags separator in auto-suggest.
Props afercia.
Fixes #33881.

git-svn-id: https://develop.svn.wordpress.org/trunk@35292 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 15:59:01 +00:00
Scott Taylor
eb6bdb59cd Dashboard: use the create_posts cap on the post type object when determining if the Quick Press widget can be displayed.
Props jim912, ocean90, chriscct7.
Fixes #25681.


git-svn-id: https://develop.svn.wordpress.org/trunk@35282 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 05:48:11 +00:00
Scott Taylor
f07367d34c Theme Installer: toggle iframe-ready on the overlay to control the spinner animated GIF and high CPU usage.
Props afercia, adamsilverstein.
Fixes #33322.


git-svn-id: https://develop.svn.wordpress.org/trunk@35281 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 05:35:07 +00:00
Scott Taylor
089276d5e8 List Tables: revert the majority of [34467]. This was almost universally abhorred (the JS that disabled the bulk dropdowns).
See #31634.


git-svn-id: https://develop.svn.wordpress.org/trunk@35277 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 04:28:05 +00:00
Andrea Fercia
3ee61161c6 Accessibility: Improve the headings hierarchy in the Add Themes screen.
Fixes #33819.

git-svn-id: https://develop.svn.wordpress.org/trunk@35273 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-19 22:03:48 +00:00
Drew Jaynes
900810e508 Docs: Add a missing file header for wp-admin/includes/class-wp-site-icon.php.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35271 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-19 20:08:34 +00:00
Dion Hulse
063d42a801 In insert_with_markers() restore the 4.3 behaviour of creating the file if it doesn't exist.
This change also makes it bail early (without writing) if the markers content is the same as the existing, and uses `ftell()` rather than `$bytes` for the location to truncate the file to - based on the file pointer being at the end of the written stream.

Props willmot tigertech kevinatelement
See #31767


git-svn-id: https://develop.svn.wordpress.org/trunk@35267 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-19 00:52:08 +00:00
Andrea Fercia
ccb76a5af0 Multisite: Improve the Admin Bar parent menu items color on hover and focus.
Props Nikschavan for the initial patch.
Fixes #34040.

git-svn-id: https://develop.svn.wordpress.org/trunk@35265 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-18 16:21:42 +00:00
Drew Jaynes
84d3e1f305 Administration: Introduce the manage_posts_extra_tablenav action, which fires inside the tablenav for the posts list table, and just outside the "actions" container.
Props hlashbrooke, wonderboymusic.
Fixes #30341.


git-svn-id: https://develop.svn.wordpress.org/trunk@35263 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-18 14:55:52 +00:00
Drew Jaynes
cb2bc30252 Docs: Add a version to the file header for wp-admin/includes/comment.php.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35262 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-18 14:33:31 +00:00
Weston Ruter
f8e79c5bbc Customizer: Fix margin-top calculation for Themes section.
Ensure that the Themes section calculates its `margin-top` as a panel, since the section behaves as one. Fixes regression caused by [35231].

See #33567.



git-svn-id: https://develop.svn.wordpress.org/trunk@35251 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 22:40:10 +00:00
Drew Jaynes
5a0fd03f95 Docs: Add missing file headers to the list table classes and adjust class DocBlocks accordingly.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35241 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 15:12:48 +00:00
Ella Iseulde Van Dorpe
5b5b67ee31 JSHint after [35238]
git-svn-id: https://develop.svn.wordpress.org/trunk@35239 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 07:10:55 +00:00
Ella Iseulde Van Dorpe
112af0751f Admin: fix repositioning notices
Fixes #34294.
Props afercia.


git-svn-id: https://develop.svn.wordpress.org/trunk@35238 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 07:03:30 +00:00
Drew Jaynes
cba5390270 Docs: Add a missing file header for wp-admin/includes/class-wp-list-table.php.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35237 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 06:06:59 +00:00
Sergey Biryukov
5c19a7a704 Replace Quick Edit and Bulk Edit headings with <legend> elements.
Props afercia.
Fixes #34289.

git-svn-id: https://develop.svn.wordpress.org/trunk@35234 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 00:44:12 +00:00
Sergey Biryukov
fe72320f33 Merge two strings for expanding accordion and Customizer sections.
Props pavelevap.
Fixes #33939.

git-svn-id: https://develop.svn.wordpress.org/trunk@35232 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 00:27:44 +00:00
Weston Ruter
370057b5d7 Customizer: Always show Widgets panel initially if sidebars are registered; show notice to users in panel if no widget areas are in current preview.
Widgets panel will not wait to display until the preview loads.

Also fixes problems with `margin-top` in panels where other panels' `active` states change, as well as ensuring sections of deactivated panel collapse before panel is hidden to prevent the pane from becoming empty of controls.

Fixes #33052.
Fixes #33567.


git-svn-id: https://develop.svn.wordpress.org/trunk@35231 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 23:47:56 +00:00
Sergey Biryukov
af36c261e3 Sample permalink: Improve accessibility of changing the permalink on Edit Post screen.
Props afercia.
Fixes #34255.

git-svn-id: https://develop.svn.wordpress.org/trunk@35229 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 23:01:58 +00:00
Sergey Biryukov
0d4a7ee029 In WP_Posts_List_Table, correct the type for $comment_pending_count.
See #11381.

git-svn-id: https://develop.svn.wordpress.org/trunk@35223 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 18:24:25 +00:00
Sergey Biryukov
e4c9f97fb3 In WP_Media_List_Table, rename $pending_count to $comment_pending_count and mark it as protected, for consistency with WP_Posts_List_Table.
See #11381.

git-svn-id: https://develop.svn.wordpress.org/trunk@35222 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 18:22:12 +00:00
Drew Jaynes
ea8e9f89cd Docs: Standardize the file header summary for wp-admin/includes/file.php.
Also adds an `@since` version and corrects the `@subpackage` value.

See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35221 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 16:55:24 +00:00
Andrea Fercia
cb2285f63e Accessibility: Improve headings hierarchy in the Theme browser modal dialog.
Fixes #34288.

git-svn-id: https://develop.svn.wordpress.org/trunk@35220 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 15:55:06 +00:00
Andrea Fercia
e68dfb6c6b Bump H4 headings to H2 in the Updates screen for better accessibility.
Fixes #34265.

git-svn-id: https://develop.svn.wordpress.org/trunk@35219 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 15:44:49 +00:00