vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2025-10-16 12:05:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
30,590 Commits 1 Branch 0 Tags 243 MiB
bcb2d6d0db
Commit Graph

193 Commits

Author SHA1 Message Date
Scott Taylor
f8841653ef wp_audio|video_shortcode() doesn't allow you to pass id, the docs shall reflect that. 
Props thorbrink.
See #32855.


git-svn-id: https://develop.svn.wordpress.org/trunk@33025 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-01 15:00:54 +00:00
Konstantin Obenland
b04ea26df1 After [32866], change filter name. 
While filter names generally don't have to be tied to the function in which they 
are applied, the API for media display generally seems to use the
`wp_get_attachment_*` pattern.

Props DrewAPicture.
Fixes #32363.



git-svn-id: https://develop.svn.wordpress.org/trunk@33018 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-01 03:46:23 +00:00
Scott Taylor
afd45937eb After [32866], fix doc blocks. 
Props DrewAPicture.
See #32363.


git-svn-id: https://develop.svn.wordpress.org/trunk@32949 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-25 21:01:56 +00:00
Scott Taylor
6cded9493a In wp_prepare_attachment_for_js(), when setting filename, call wp_basename() on the result of get_attached_file(), not WP_Post->guid. guid can be set to the result get_permalink(), which is not a file path. 
Props daxelrod.
Fixes #32531.


git-svn-id: https://develop.svn.wordpress.org/trunk@32914 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-23 18:29:44 +00:00
Scott Taylor
9123db3dcb Add a filter in wp_get_attachment_image_src() called attachment_image_src. 
Props eclev91, MikeHansenMe.
Fixes #32363.


git-svn-id: https://develop.svn.wordpress.org/trunk@32866 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-19 21:26:30 +00:00
Scott Taylor
7dd8a1364a In the youtube_embed_url embed handler, make embed a non-capturing group that alternately matches for v - YouTube supports both URL paths. 
Add unit test cases.

Props dmchale for some patch work.
Fixes #32161.


git-svn-id: https://develop.svn.wordpress.org/trunk@32787 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-16 00:34:06 +00:00
Sergey Biryukov
3aad7082a3 Avoid a PHP notice in wp_enqueue_media() if $post is null. 
see #19257.

git-svn-id: https://develop.svn.wordpress.org/trunk@32675 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-31 21:53:35 +00:00
John Blackbourn
68e76c1bbf Remove an embed handler accidentally introduced in r32673. 
git-svn-id: https://develop.svn.wordpress.org/trunk@32674 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-31 16:55:29 +00:00
John Blackbourn
87d5aefe74 Introduce featured_image, set_featured_image, remove_featured_image, and use_featured_image post type labels when registering a post type in order to override the 'Featured Image' text and its related phrases. 
Props johnbillion, mordauk, valendesigns.
Fixes #19257.


git-svn-id: https://develop.svn.wordpress.org/trunk@32673 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-31 16:53:12 +00:00
Scott Taylor
0a892c11c8 Fix doc blocks for media*.php 
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32609 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-26 19:22:12 +00:00
Dominik Schilling (ocean90)
9cddb0f012 Rename get_media_embedded_in_content_allowed filter to media_embedded_in_content_allowed_types. 
The new name fits better with some other `_allowed_` filters.

props DrewAPicture.
fixes #26675.

git-svn-id: https://develop.svn.wordpress.org/trunk@32113 602fd350-edb4-49c9-b593-d223f7449a82
 2015-04-11 21:48:22 +00:00
Drew Jaynes
2b774bf447 Remove unneeded spaces in the hook doc for the attachment_url_to_postid filter. 
See [31867]. See #31888.


git-svn-id: https://develop.svn.wordpress.org/trunk@32043 602fd350-edb4-49c9-b593-d223f7449a82
 2015-04-05 16:06:02 +00:00
Andrew Ozz
fc1d327261 Introduce attachment_url_to_postid filter to let plugins manage the uploads location better. 
Props mattwiebe. Fixes #31717.

git-svn-id: https://develop.svn.wordpress.org/trunk@31867 602fd350-edb4-49c9-b593-d223f7449a82
 2015-03-23 17:23:27 +00:00
Drew Jaynes
34a7cdf926 Add hook documentation for the get_media_embedded_in_content_allowed filter, introduced in [31574]. 
Props valendesigns.
Fixes #26675.


git-svn-id: https://develop.svn.wordpress.org/trunk@31851 602fd350-edb4-49c9-b593-d223f7449a82
 2015-03-20 19:28:30 +00:00
Scott Taylor
42bcec5061 Introduce a function, wp_attachment_is( $type, $post = 0 ), to collapse the logic for determining whether an attachment is an image, audio, or video. 
This is admittedly a first pass. There needs to be a generic handler for when any other type is passed, but for now it accepts the whitelist.

See #25275.


git-svn-id: https://develop.svn.wordpress.org/trunk@31645 602fd350-edb4-49c9-b593-d223f7449a82
 2015-03-06 20:25:09 +00:00
Scott Taylor
65c58832cb Improve get_media_embedded_in_content() so that it returns the media it finds in the same order that it appears in the content. 
Adds unit test, updates another.

Props kopepasah.
See #26675.


git-svn-id: https://develop.svn.wordpress.org/trunk@31574 602fd350-edb4-49c9-b593-d223f7449a82
 2015-02-27 16:11:00 +00:00
Drew Jaynes
d44289d6de Clarify a wide variety of function, parameter, and return descriptions in DocBlocks throughout wp-includes/media.php. 
Props stevegrunwell, DrewAPicture.
Fixes #28408.


git-svn-id: https://develop.svn.wordpress.org/trunk@31530 602fd350-edb4-49c9-b593-d223f7449a82
 2015-02-24 07:41:24 +00:00
Drew Jaynes (DrewAPicture)
0c783b06fb Add changelog entries to the post_gallery and post_playlist hook docs for the $instance variable that was added in [31304]. 
Props ninnypants for the initial patch.
Fixes #31151.


git-svn-id: https://develop.svn.wordpress.org/trunk@31309 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-31 00:32:09 +00:00
Sergey Biryukov
14c3492ff5 Rename $instances to $instance in wp_audio_shortcode() and wp_video_shortcode() for consistency with gallery_shortcode() and wp_playlist_shortcode(). 
see #31151.

git-svn-id: https://develop.svn.wordpress.org/trunk@31305 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-30 16:05:52 +00:00
Sergey Biryukov
45b0513c1b Pass the current shortcode instance ID to post_gallery and post_playlist filters. 
props justincwatt.
fixes #31151.

git-svn-id: https://develop.svn.wordpress.org/trunk@31304 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-30 16:01:25 +00:00
Sergey Biryukov
a036114a4d attachment_url_to_postid() should always return an integer. 
props nathan_dawson, ashfame.
fixes #31044.

git-svn-id: https://develop.svn.wordpress.org/trunk@31239 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-18 20:32:50 +00:00
Scott Taylor
865185903b There are some random add_action() and add_filter() calls littered around some files in wp-includes/. These should be moved to wp-includes/default-filters.php with the rest of the registered hooks. It seems like this was the best practice for awhile and then we randomly stopped. This file loads way before any of the includes, so the hooks will be registered for any request that loads WordPress, even SHORTINIT - a lot of the hooks registered won't run anyways (that's already the case). 
See #30947.


git-svn-id: https://develop.svn.wordpress.org/trunk@31168 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 16:39:39 +00:00
Sergey Biryukov
6ffb5feab9 Make a hint on Edit Selection view in media modal more accurate, as it applies to all media files, not just images. 
props pavelevap.
see #30931.

git-svn-id: https://develop.svn.wordpress.org/trunk@31102 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 21:23:21 +00:00
Scott Taylor
da9057fd6d Use && instead of and in the 3 places where and was used. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31099 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 21:11:46 +00:00
Scott Taylor
6fd11624d1 The keyword elseif should be used instead of else if so that all control keywords look like single words. 
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs. 

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31090 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 07:04:40 +00:00
Scott Taylor
186a94fb78 More-specific docs for wp_embed_handler_youtube(). 
Fixes #30711.


git-svn-id: https://develop.svn.wordpress.org/trunk@31018 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-01 19:20:44 +00:00
Scott Taylor
be8211beac Support chromeless Vimeo via MEjs: 
* Bump MediaElement script loader versions to 2.16.2 - missed in [30634], oops!
* Add `Froogaloop` to `js/mediaelement` scripts for Vimeo
* Check for Vimeo in the same locations that YouTube is checked
* Dynamically load Froogaloop script in admin when editing a TinyMCE view
* Edit MediaElement to call `mejs.$.extend` instead of `$.extend` in `mejs.HtmlMediaElementShim.createPlugin()`, since `$` is not available via WP's jQuery (I will report this upstream):
6f9a78e008/src/js/me-shim.js (L631)

Fixes #29267.


git-svn-id: https://develop.svn.wordpress.org/trunk@31016 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-31 20:40:05 +00:00
Scott Taylor
218dd4fd6b For clarity, initialize some arrays that previously were only assigned via short circuit in loops. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30982 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-20 22:46:53 +00:00
Scott Taylor
0632a3de68 Improve various @param docs. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30674 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-30 23:23:37 +00:00
Scott Taylor
35708f61f8 Use round() instead of floor() when resizing image dimensions. 
Updates unit tests.

Props SergeyBiryukov, kitchin.
Fixes #18532.


git-svn-id: https://develop.svn.wordpress.org/trunk@30660 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-30 19:53:18 +00:00
Drew Jaynes (DrewAPicture)
e587324180 Docs Formatting: Backtick-escape inline code for all remaining dynamic hook docs in wp-includes/*. 
Affects DocBlocks for the following hooks:
* `auth_post_meta_{$meta_key}`
* `term_links-$taxonomy`
* `customize_render_control_ . $this->id`
* `customize_render_panel_{$this->id}`
* `customize_render_section_{$this->id}`
* `customize_preview_{$this->id}`
* `customize_save_ . $this->id_data[ 'base' ]`
* `customize_update_ . $this->type`
* `customize_value_ . $this->id_data[ 'base' ]`
* `customize_sanitize_js_{$this->id}`
* `comment_form_field_{$name}`
* `comment_{$old_status}_to_{$new_status}`
* `comment_{$new_status}_{$comment->comment_type}`
* `extra_{$context}_headers`
* `get_template_part_{$slug}`
* `get_the_generator_{$type}`
* `get_{$adjacent}_post_join`
* `get_{$adjacent}_post_where`
* `get_{$adjacent}_post_sort`
* `{$adjacent}_post_rel_link`
* `{$adjacent}_post_link`
* `{$adjacent}_image_link`
* `blog_option_{$option}`
* `$permastructname . _rewrite_rules`
* `{$type}_template`
* `theme_mod_{$name}`
* `pre_set_theme_mod_$name`
* `current_theme_supports-{$feature}`
* `get_user_option_{$option}`
* `edit_user_{$field}`
* `pre_user_{$field}`
* `user_{$field}`

See #30552.


git-svn-id: https://develop.svn.wordpress.org/trunk@30656 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-30 12:09:56 +00:00
Drew Jaynes (DrewAPicture)
1f66186c4a Improve inline documentation for image_constrain_size_for_editor(). 
Includes:
* Proper formatting, plus adding a type for the `$context` parameter
* Inline `@see` tags in the description and backtick-escaping inline code
* Parameter, type, and description alignment

Props tillkruess for the initial patch.
Fixes #30508.


git-svn-id: https://develop.svn.wordpress.org/trunk@30646 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-30 10:05:26 +00:00
Scott Taylor
b59b9f466a Fix edge-case in media cropping where selection and destination are the same size. 
Adds unit tests.

Props mboynes.
Fixes #19793.


git-svn-id: https://develop.svn.wordpress.org/trunk@30639 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-30 06:26:26 +00:00
Drew Jaynes (DrewAPicture)
2afe26faa5 Remove an invalid parameter from the DocBlock for the gallery_style hook. 
Props keesiemeijer.
Fixes #30507.


git-svn-id: https://develop.svn.wordpress.org/trunk@30635 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-30 05:57:43 +00:00
Drew Jaynes (DrewAPicture)
7c421791c2 Remove return descriptions from the DocBlocks for add_image_size() and set_post_thumbnail_size() as they don't return anything. 
Also document the `$_wp_additional_image_sizes` global, leveraged in `add_image_size()`.

Props stevegrunwell.
Fixes #30511.


git-svn-id: https://develop.svn.wordpress.org/trunk@30633 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-30 05:48:03 +00:00
Drew Jaynes (DrewAPicture)
9a9489db7f Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented. 
Affects DocBlocks for the following core elements:
* Markdown-indent a code snippet in the file header for wp-admin/install-helper.php
* Add markdown formatting and two inline `@see` tags to the description for `translate()`
* Markdown-indent a code snippet in the description for `_n_noop()`
* Remove HTML tags from the summary for `get_media_embedded_in_content()`
* Remove an HTML tag from the summary for `wpview_media_sandbox_styles()`

Props rarst.
See #30473.


git-svn-id: https://develop.svn.wordpress.org/trunk@30542 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-24 05:46:04 +00:00
Sergey Biryukov
917a469052 Replace invalid use of ltrim() in attachment_url_to_postid() with substr(). 
props bradyvercher.
fixes #30346.

git-svn-id: https://develop.svn.wordpress.org/trunk@30501 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-21 06:34:23 +00:00
Andrew Nacin
912dbf3fd0 Playlists are video by default. props duck_ 
git-svn-id: https://develop.svn.wordpress.org/trunk@30422 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-20 13:10:45 +00:00
Dominik Schilling (ocean90)
437d90710d Media: Remove another unused string. 
props pavelevap.
see #29741.

git-svn-id: https://develop.svn.wordpress.org/trunk@30342 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-14 17:45:39 +00:00
Dominik Schilling (ocean90)
fd6bf722b7 Media: Remove unused string. 
props pavelevap.
fixes #29741.

git-svn-id: https://develop.svn.wordpress.org/trunk@30341 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-14 17:30:57 +00:00
Scott Taylor
3663a276f1 In wp_audio|video_shortcode(), make sure that autoplay and loop are booleans. Passing 'false' to them will force them to be active, which is bad. 
Fixes #29825.


git-svn-id: https://develop.svn.wordpress.org/trunk@30185 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-03 05:02:18 +00:00
Scott Taylor
143d248292 In gallery_shortcode(), when the link attribute is equal to file, make sure to pass $attr as the 6th (!) argument, not 5th, to wp_get_attachment_link(). 
Props bradyvercher.
Fixes #27402.


git-svn-id: https://develop.svn.wordpress.org/trunk@30161 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 21:46:51 +00:00
Drew Jaynes (DrewAPicture)
7cd15026bd Correct references of @uses $wpdb in core documentation to use @global. 
See #30191, [30105].
Fixes #30217.


git-svn-id: https://develop.svn.wordpress.org/trunk@30122 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-31 17:55:39 +00:00
Drew Jaynes (DrewAPicture)
3cc10d77a0 Remove redundant and erroneous @uses tag from most core inline documentation. 
Per our inline documentation standards, no further use of the `@uses` tag is recommended as used and used-by relationships can be derived through other means. This removes most uses of the tag in core documentation, with remaining tags to be converted to `@global` or `@see` as they apply.

Fixes #30191.


git-svn-id: https://develop.svn.wordpress.org/trunk@30105 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-30 01:04:55 +00:00
Scott Taylor
e6bbbb3db9 Don't hardcode height for videos - this was a workaround for MediaElement internals causing problems. Responsive videos now work properly and don't cause extra whitespace. 
Fixes MediaElement by hand in the interim: https://github.com/johndyer/mediaelement/pull/1337
Video playlists were completely broken by this.

Fixes #30078.



git-svn-id: https://develop.svn.wordpress.org/trunk@30082 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-29 00:46:15 +00:00
Scott Taylor
74ed2089b4 The gallery shortcode used to accept a SQL chunk for the value of the orderby attribute. The reason? get_posts() used to be called in the shortcode handler with a query-string blob of arguments passed to it. To mitigate breakage, sanitize_sql_orderby() was created in [7592]. 
`sanitize_sql_orderby()` expects a comma to be present when multiple `orderby` values were passed. The correct syntax for multiple fields is space-delimited. Since [29027], comma-separated values would never be parsed correctly when passed to `WP_Query->parse_orderby()`.

`sanitize_sql_orderby()` is used nowhere else in core, save for the `playlist` shortcode - I only added it there because I was mimic'ing the `gallery` logic. The function call can be removed from both shortcode handlers.
 
See #6476.
Fixes #23873.


git-svn-id: https://develop.svn.wordpress.org/trunk@30068 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-28 20:42:20 +00:00
Gary Pendergast
0e68ecc0b6 Add wp_json_encode(), a wrapper for json_encode() that ensures everything is converted to UTF-8. 
Change all core calls from `json_encode()` to `wp_json_encode()`.

Fixes #28786.



git-svn-id: https://develop.svn.wordpress.org/trunk@30055 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-28 18:34:16 +00:00
Scott Taylor
076c7e8902 Add a 6th (!) attribute to wp_get_attachment_link() to allow aria-describedby to be added to gallery output. 
Props joedolson, DrewAPicture, rianrietveld.
Fixes #27402.


git-svn-id: https://develop.svn.wordpress.org/trunk@29914 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-16 04:27:07 +00:00
Sergey Biryukov
4ba75673d8 Update @param docs for wp_get_attachment_image(). 
see #29869.

git-svn-id: https://develop.svn.wordpress.org/trunk@29837 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-05 17:51:42 +00:00
Sergey Biryukov
a21e5041dd Pass the requested size to 'wp_get_attachment_image_attributes' filter. 
props mattheu.
fixes #29869.

git-svn-id: https://develop.svn.wordpress.org/trunk@29836 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-05 17:49:32 +00:00