vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-09-15 05:20:23 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
32,543 Commits 1 Branch 0 Tags
bd7bf83886f68f75a7d695301f2a5a7a8c8fed8d
Commit Graph
254 Commits
Author SHA1 Message Date
Scott Taylor bd7bf83886 Media: add a new image size, medium_large. Bumps db version to add new options. 
Adds unit tests.

Props DH-Shredder, joemcgill, azaozz.
Fixes #34196.


git-svn-id: https://develop.svn.wordpress.org/trunk@35479 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-31 20:49:26 +00:00
Andrew Ozz 62c0557b90 Responsive images: few more inline docs fixes. 
Props jaspermdegroot.
See #34430.

git-svn-id: https://develop.svn.wordpress.org/trunk@35465 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-30 23:35:14 +00:00
Andrew Ozz 98a63f523f Responsive images: 
- Merge `wp_image_srcset_attr()` into `wp_calculate_image_srcset()`.
- Remove the `wp_image_srcset` filter.
- Fix the tests for the above changes. 

See #34430.

git-svn-id: https://develop.svn.wordpress.org/trunk@35464 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-30 23:26:44 +00:00
Andrew Ozz 63b27d209a Responsive images: add inline docs for private functions. 
Props swissspidy.
See #34430.

git-svn-id: https://develop.svn.wordpress.org/trunk@35426 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-28 21:54:04 +00:00
Andrew Ozz 2fadc857de Responsive images: 
- Check if wp_get_attachment_metadata() has returned an array to prevent errors when using SVGs.
- Only add the srcset attribute if there will be a sizes attribute.
- Better filter names.
- Some more inline docs fixes.

Props jaspermdegroot.
See #34430.

git-svn-id: https://develop.svn.wordpress.org/trunk@35419 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-28 20:00:14 +00:00
Andrew Ozz 855ba2518b Responsive images: 
- Introduce `wp_calculate_image_srcset()` that replaces `wp_get_attachment_image_srcset_array()` and is used as lower level function for retrieving the srcset data as array.
- Use the new function when generating `srcset` and `sizes` on the front-end. This is faster as no (other) image API functions are used.
- Change the `wp_get_attachment_image_srcset()`. Now it is meant for use in templates and is no longer used in core.
- A few logic fixes and improvements.
- Some names changed to be (hopefully) more descriptive.
- Fixed/updated tests.

Props joemcgill, jaspermdegroot, azaozz.
See #34430.

git-svn-id: https://develop.svn.wordpress.org/trunk@35412 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-28 05:40:04 +00:00
Sergey Biryukov c608146996 After [35402], don't unnecessary run wp_get_attachment_metadata(), wp_get_attachment_image_srcset(), and wp_get_attachment_image_sizes() in wp_img_add_srcset_and_sizes(). 
See #34379.

git-svn-id: https://develop.svn.wordpress.org/trunk@35405 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-26 18:41:31 +00:00
Sergey Biryukov aeca8fcfd8 After [35402], don't unnecessary run wp_get_attachment_image_srcset() and wp_get_attachment_image_sizes() in wp_get_attachment_image() if srcset is passed as an argument. 
See #34379.

git-svn-id: https://develop.svn.wordpress.org/trunk@35404 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-26 18:40:01 +00:00
Sergey Biryukov 9b29cf2574 Remove assignments from conditions in wp_get_attachment_image() and wp_img_add_srcset_and_sizes(). 
See #34379.

git-svn-id: https://develop.svn.wordpress.org/trunk@35402 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-26 16:28:27 +00:00
Sergey Biryukov 558984a8ab Docs: After [34453], correct inline comments in wp_get_attachment_image_sizes(). 
Props jaspermdegroot.
Fixes #34453.

git-svn-id: https://develop.svn.wordpress.org/trunk@35401 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-26 16:16:52 +00:00
Andrew Ozz 2c1f21190d Responsive Images: fix typo in r35358. 
Props aduth.
See #34341.

git-svn-id: https://develop.svn.wordpress.org/trunk@35378 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-23 17:37:35 +00:00
Andrew Ozz 5aa7a8ce78 Responsive Images: limit the size of images included in srcset attributes. Introduce max_srcset_image_width filter to adjust the limit. 
Props joemcgill.
Fixes #34341.

git-svn-id: https://develop.svn.wordpress.org/trunk@35358 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-22 19:30:12 +00:00
Scott Taylor 6a3b784104 Media: in wp_get_attachment_image_sizes(), to streamline and for performance: 
* Change the 3rd arg from `args` to `width`
* Change `wp_image_sizes_args` filter to `wp_get_attachment_image_sizes`

Updates unit tests.

Props joemcgill.
Fixes #34379.


git-svn-id: https://develop.svn.wordpress.org/trunk@35355 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-22 16:45:37 +00:00
Drew Jaynes a28e35e462 Filesystem: Following the introduction of the KB|MB|GB|TB_IN_BYTES constants in [35286], use them in various places in core. 
Props sudar.
Fixes #22405.


git-svn-id: https://develop.svn.wordpress.org/trunk@35325 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-21 14:02:59 +00:00
Drew Jaynes 1ed7489957 Media: Introduce the image_get_intermediate_size filter to its like-named function, making it possible to manipulate returned intermedia image size data. 
Covers both the default and meaningful short-circuit return cases. Also adds a hash notation to the return documentation in the DocBlock.

Props A5hleyRich, DH-Shredder, wonderboymusic.
Fixes #34124.


git-svn-id: https://develop.svn.wordpress.org/trunk@35289 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 07:23:18 +00:00
Scott Taylor 641e372432 Media: in wp_get_attachment_image_sizes(), ensure that $img_width exists when the image does not. 
Props kraftbj.
See #33641.



git-svn-id: https://develop.svn.wordpress.org/trunk@35250 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-17 22:11:28 +00:00
Drew Jaynes c8bf2ce727 Docs: Fix a typo in an inline comment in wp_get_attachment_image_srcset_array(). 
Props neoxx.
Fixes #34319.


git-svn-id: https://develop.svn.wordpress.org/trunk@35210 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-15 20:51:58 +00:00
Scott Taylor e05891a7ec Media: avoid "divide by zero" in wp_get_attachment_image_srcset_array(). 
Fixes #34238.


git-svn-id: https://develop.svn.wordpress.org/trunk@35081 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 20:59:12 +00:00
Drew Jaynes 6ca6c6fc1c Docs: The $size parameter for the get_image_tag hook also accepts an array. 
See #34257. See [35038].


git-svn-id: https://develop.svn.wordpress.org/trunk@35078 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 17:10:59 +00:00
Drew Jaynes 03481541aa Docs: The $size parameter for the get_image_tag_class hook also accepts an array. 
See #34257. See [35037].


git-svn-id: https://develop.svn.wordpress.org/trunk@35077 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 17:08:39 +00:00
Drew Jaynes 0cf4a5e121 Docs: Adjust the order of 'width' and 'height' (for consistency) for the $crop parameter documentation in image_make_intermediate_size(). 
Props jaspermdegroot.
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35054 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:05:30 +00:00
Drew Jaynes 6eb8c85678 Docs: Adjust the order of 'width' and 'height' (for consistency) for the $crop parameter documentation in image_resize_dimensions(). 
Also similarly adjusts the `$crop` parameter description in the corresponding `image_resize_dimensions` hook doc.

Props jaspermdegroot.
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35053 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:01:10 +00:00
Drew Jaynes 4d2fa13bf5 Docs: Adjust the order of 'width' and 'height' (for consistency) for the $crop parameter documentation in set_post_thumbnail_size(). 
Props jaspermdegroot.
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35052 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:59:11 +00:00
Drew Jaynes 1165053220 Docs: Adjust the order of 'width' and 'height' (for consistency) for the $crop parameter documentation in add_image_size(). 
Props jaspermdegroot.
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35051 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:58:13 +00:00
Drew Jaynes ac9254faf8 Docs: Adjust documentation for the $size parameter in adjacent_image_link() to clarify the required order of width and height values when passing an array. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35049 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:52:30 +00:00
Drew Jaynes e1d1e7a4af Docs: Adjust documentation for the $size parameter in next_image_link() to clarify the required order of width and height values when passing an array. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35048 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:49:52 +00:00
Drew Jaynes 0cebe5df94 Docs: Adjust documentation for the $size parameter in previous_image_link() to clarify the required order of width and height values when passing an array. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35047 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:47:50 +00:00
Drew Jaynes da8c9d6c7e Docs: Normalize spacing in the $attr hash notation for gallery_shortcode() following [35045]. 
See #34257. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35046 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:45:23 +00:00
Drew Jaynes 447cdf9fc1 Docs: Adjust documentation for the $size argument in gallery_shortcode to clarify the required order of width and height values when passing an array. 
Also adds the `array` type to the argument documentation.

Props jaspermdegroot.
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35045 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:42:22 +00:00
Drew Jaynes aeb289ca5f Docs: Adjust documentation for the $size parameter in wp_get_attachment_image_url() to clarify the required order of width and height values when passing an array. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35044 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:38:55 +00:00
Drew Jaynes 0d954c2c0b Docs: Adjust documentation for the $size parameter in the wp_get_attachment_image_attributes hook doc to clarify the required order of width and height values when an array is passed. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35043 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:37:17 +00:00
Drew Jaynes 4781b9d5d3 Docs: Adjust documentation for the $size parameter in wp_get_attachment_image() to clarify the required order of width and height values when passing an array. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35042 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:35:17 +00:00
Drew Jaynes 479532865d Docs: Adjust documentation for the $size parameter in the wp_get_attachment_image_src hook doc to clarify the required order of width and height values when an array is passed. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35041 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:33:48 +00:00
Drew Jaynes 43c2e54456 Docs: Adjust documentation for the $size parameter in wp_get_attachment_image_src() to clarify the required order of width and height values when passing an array. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35040 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:30:24 +00:00
Drew Jaynes cc1bcb6add Docs: Adjust documentation for the $size parameter in image_get_intermediate_size() to clarify the required order of width and height values when passing an array. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35039 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:28:45 +00:00
Drew Jaynes bb5c3bff20 Docs: Adjust documentation for the $size parameter in the get_image_tag hook doc to clarify the required order of width and height values when an array is passed. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35038 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:26:44 +00:00
Drew Jaynes 3fc7fea5f8 Docs: Adjust documentation for the $size parameter in the get_image_tag_class hook doc to clarify the required order of width and height values when an array is passed. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35037 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:25:41 +00:00
Drew Jaynes ac370db0cb Docs: Adjust documentation for the $size parameter in get_image_tag() to clarify the required order of width and height values when passing an array. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35036 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:20:55 +00:00
Drew Jaynes eae2d93f08 Docs: Adjust documentation for the $size parameter in the image_downside hook doc to clarify the required order of width and height values when an array is passed. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35035 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:19:13 +00:00
Drew Jaynes 259077deb5 Docs: Adjust documentation for the $size parameter in image_downsize() to clarify the required order of width and height values when passing an array. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35034 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:17:21 +00:00
Drew Jaynes bdfb256110 Docs: Adjust documentation for the $size parameter in image_constrain_size_for_editor() to clarify the required order of width and height values when passing an array. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35033 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:15:07 +00:00
Drew Jaynes 843cdf1f73 Docs: Update an inline comment in wp_get_attachment_image_sizes(), which came in as part of the Responsive Images merge in [34855]. 
Props joemcgill.
See #33641.


git-svn-id: https://develop.svn.wordpress.org/trunk@34876 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-06 17:46:30 +00:00
Scott Taylor fabd554bb2 Merge the Responsive Images feature plugin into core, initial commit. See: https://github.com/ResponsiveImagesCG/wp-tevko-responsive-images/ 
New functions in `media.php`:
* `wp_get_attachment_image_srcset_array()` - Returns an array of image candidate string data used to build a `srcset` value for an attachment given an `$attachement_id` and `$size`.
* `wp_get_attachment_image_srcset()` - Returns the `srcset` value for an attachment given an `$attachement_id` and `$size`.
* `wp_get_attachment_image_sizes()` - Returns the `sizes` value for an attachment given an `$attachement_id` and `$size` and optional arguments used to alter its output.
* `wp_make_content_images_responsive()` - A display filter for adding `srcset` and `sizes` to images embedded in content.
* `wp_img_add_srcset_and_sizes()` - A utility function used by `wp_make_content_images_responsive()` to add `srcset` and `sizes` to a single `<img>` element.

Modifies existing core functions:
* Modify `wp_get_attachment_image()` so the HTML returned for an image includes `srcset` and `sizes`.
* Modify `get_media_embedded_in_content()` (sup, 3.6 leftover) by adding `<img>` to the list of accepted tags that can be matched in content. This is used in `wp_make_content_images_responsive()` to find all of the images embedded in content before passing them off to `wp_img_add_srcset_and_sizes()`.

Tests:
* Add a new factory method to `WP_UnitTest_Factory_For_Attachment` named `create_upload_object()`
* Adds unit tests
* Updates unit tests

Props joemcgill, tevko, jaspermdegroot, mdmcginn, barryceelen, peterwilsoncc, fsylum, wonderboymusic, chriscoyier, benjaminpick, jrfnl, #12kingkool68, janhenckens, ryanmarkel, side777, ryelle, wturrell, micahmills, mattbagwell, coliff, DrewAPicture.
See #33641.


git-svn-id: https://develop.svn.wordpress.org/trunk@34855 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-06 04:58:21 +00:00
Scott Taylor 3eb876d7e9 Embeds: move some functions from media.php to a new file, embed-functions.php, via svn cp 
See #32522.


git-svn-id: https://develop.svn.wordpress.org/trunk@34851 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-06 03:58:42 +00:00
Scott Taylor 9d0f206ee1 After [34629], use $size_class instead of $size. 
See #32093.


git-svn-id: https://develop.svn.wordpress.org/trunk@34657 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-28 02:49:05 +00:00
Scott Taylor b45a72a67c Add size-$size class to <img> in wp_get_attachment_image(). 
Fixes #32093.


git-svn-id: https://develop.svn.wordpress.org/trunk@34629 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-27 17:54:01 +00:00
John Blackbourn 1bb2876fe6 callback is not a valid type in PHP, PSR-5, or phpDocumentor. callable should be used instead. 
Fixes #34032


git-svn-id: https://develop.svn.wordpress.org/trunk@34566 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 23:57:46 +00:00
Scott Taylor d98165d1c3 Media Modal: move the translation strings for insertIntoPost and uploadedToThisPost to the get_post_type_labels() array as insert_into_item and uploaded_to_this_item. 
Props flixos90.
Fixes #33616.


git-svn-id: https://develop.svn.wordpress.org/trunk@34472 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 03:21:11 +00:00
Scott Taylor 000b9e2fb3 Include fourth array parameter in return value doc block for wp_get_attachment_image_src(). 
Props kadamwhite.
Fixes #33905.


git-svn-id: https://develop.svn.wordpress.org/trunk@34470 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 03:13:08 +00:00
Scott Taylor 3c0ecff16e Media: Add a new function, wp_get_attachment_image_url(), which is a shortcut for wp_get_attachment_image_src() - same function signature, but returns just the URL based on $size. 
Adds unit test.

Props dipesh.kakadiya, swissspidy, sebastian.pisula.
Fixes #33878.


git-svn-id: https://develop.svn.wordpress.org/trunk@34372 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 04:12:44 +00:00