Commit Graph
80 Commits
Author SHA1 Message Date
Sergey Biryukov b2a468c1fc After [31941], use the decoupled strings from wp-admin/network/themes.php in wp-admin/network/site-themes.php as well.
fixes #28502.

git-svn-id: https://develop.svn.wordpress.org/trunk@32029 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-05 14:57:35 +00:00
Helen Hou-Sandi 35df5592f1 Admin notices: Make (most) core notices dismissible.
These no longer return upon refreshing the page when JS is on and working, so users should be able to dismiss them. This is particularly important on the post edit screen when DFW is triggered, but pretty much all notices can be dismissed if needed. A post on Make/Core will follow with information on how this can be leveraged in plugins.

props valendesigns, afercia, paulwilde, adamsilverstein, helen.
fixes #31233. see #23367.


git-svn-id: https://develop.svn.wordpress.org/trunk@31973 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 22:05:17 +00:00
Sergey Biryukov f898c8bd3d Merge title strings on Edit Site screens.
props ramiy.
fixes #31844.

git-svn-id: https://develop.svn.wordpress.org/trunk@31962 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 17:59:25 +00:00
Sergey Biryukov 3ecaee903e Add translator comments for placeholders in network-related strings.
props ramiy.
fixes #31834.

git-svn-id: https://develop.svn.wordpress.org/trunk@31956 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 13:25:55 +00:00
Sergey Biryukov 0d55562fd7 Decouple strings where the singular and plural form are not just the same string with different numbers, but essentially two different strings.
This allows for using proper plural forms in languages with more than two forms, and also resolves string conflicts when the same string is present in both singular and plural form.

fixes #28502.

git-svn-id: https://develop.svn.wordpress.org/trunk@31941 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-31 18:44:46 +00:00
Dominik Schilling (ocean90) 3bb3d2f1a5 Screen Options: Improve items per page option label.
Previously the label just said "Posts", "Pages", or "Comments". This was bad in terms of accessibility and internationalization because of missing context.
This change adds a default label "Number of items per page:" to `WP_Screen->render_per_page_options()` and removes all the existing one-word labels.

props afercia.
fixes #31349, #15576.

git-svn-id: https://develop.svn.wordpress.org/trunk@31696 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-10 15:31:54 +00:00
Scott Taylor 3c810c5872 There are a few functions that have the ability to return false instead of a string, so the return value should be checked before being passed to functions that expect string.
These are trivial, but they clear out some Scrutinizer issues.

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31681 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-09 02:10:36 +00:00
Jeremy Felt a5fcc34a50 Return HTTP status code 403 in network admin when access is forbidden.
When the error message "You do not have permission to access this page" is used in network admin screens, return an HTTP status code of 403 to match. Previously: [30356] and [31300].

Props yo-l1982.

Fixes #31422.


git-svn-id: https://develop.svn.wordpress.org/trunk@31658 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-07 05:59:17 +00:00
Jeremy Felt f0b524dad0 Improve experience when deleting users from a multisite network.
When deleting a user who is not associated with any sites, the current messaging can be confusing as only users associated with at least one site actually appear on the confirmation page for deletion.

This experience can be improved by showing all users being deleted as well as their current site associations.

* If an empty array of users is passed, don't attempt to confirm deletion.
* If one user is passed, show a message crafted for a user of one.
* If multiple users are passed, show a message crafted for many.
* Show the pending results of all users to be deleted.
* Update messaging around the deletion/confirmation process to be less misleading.

Props Idealien, HarishChaudhari, DrewAPicture.

Fixes #18132.


git-svn-id: https://develop.svn.wordpress.org/trunk@31656 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-07 04:39:13 +00:00
Jeremy Felt ff0b2f7a6f Provide proper label associations and descriptions throughout the network admin
* Add labels previously missing for many inputs throughout the network admin screen.
* Add proper `aria-describedby` attributes to provide better descriptions.
* Wrap grouped inputs with `fieldset` elements.
* Remove now unneeded `title` attributes when appropriate.

Props cfoellmann, afercia, rianrietveld.

Fixes #38406.


git-svn-id: https://develop.svn.wordpress.org/trunk@31517 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-23 02:28:41 +00:00
Scott Taylor 83b6fad852 In HTML5, the action attribute is no longer required. Remove this attribute when empty.
The admin HTML is served with the HTML5 doctype.

"The action and formaction content attributes, if specified, must have a value that is a valid non-empty URL potentially surrounded by spaces." 
http://www.w3.org/html/wg/drafts/html/master/forms.html#attr-fs-action

Props voldemortensen.
Fixes #30126.


git-svn-id: https://develop.svn.wordpress.org/trunk@31200 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 04:15:52 +00:00
Jeremy Felt 331262b544 Update home and siteurl after path slashes are validated in update_blog_details()
When editing a site, if `home` and `siteurl` are checked to be updated along with a site's domain and path, they should receive the results of any modifications in `update_blog_details()` rather than trusting the POST data.

Previously, it was possible to save a value without a leading slash on the path, causing an invalid URL to be stored.

Props earnjam.

Fixes #30417.


git-svn-id: https://develop.svn.wordpress.org/trunk@31156 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-12 01:56:04 +00:00
Scott Taylor 47f2c42528 Inline <script>s that are only printed in the admin for pages that are served with the HTML5 doctype absolutely do not need CDATA comments.
Props tw2113 for the initial patch.
See #18788.


git-svn-id: https://develop.svn.wordpress.org/trunk@31034 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-03 05:45:17 +00:00
John Blackbourn 3f2827c5be Admin help text changes for the General Settings screen, post editing screen, network settings screen, and user editing screen.
Fixes #30547
Props kpdesign


git-svn-id: https://develop.svn.wordpress.org/trunk@30705 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 05:14:38 +00:00
Drew Jaynes (DrewAPicture) 57ff8aff0a Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-admin/network/*.
Affects DocBlocks for the following hooks:
* `network_admin_edit_' . $_GET['action']`
* `network_sites_updated_message_' . $_GET['updated']`

See #30552.


git-svn-id: https://develop.svn.wordpress.org/trunk@30647 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 11:20:32 +00:00
Drew Jaynes (DrewAPicture) 403f4feb27 4.1 Docs Audit: Clarify the DocBlock summary for network_settings_add_js() to specify that it's specific to the Network Settings screen.
See #30469.


git-svn-id: https://develop.svn.wordpress.org/trunk@30603 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-28 09:08:08 +00:00
Dominik Schilling (ocean90) 17cefe0288 Network Admin: Improve width of input fields on Add New Site and Edit Site screens.
props honeysilvas.
fixes #16383.

git-svn-id: https://develop.svn.wordpress.org/trunk@30578 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-26 19:50:20 +00:00
John Blackbourn 4e1e4745ff Switch to a 403 response code in places where it is more appropriate than a 500 due to permissions errors.
Fixes #10551
Props nacin


git-svn-id: https://develop.svn.wordpress.org/trunk@30356 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-16 06:15:29 +00:00
Dominik Schilling (ocean90) dc8e01fa9b Site Language: Install translations on the fly.
The language dropdown now includes installed languages and all available translations when the filesystem is writable by WordPress.
Go to wp-admin/options-general.php, select one of the available translations, submit the form and let WordPress handle the rest.
Works for Multisite's Default Language too.

see #29395.

git-svn-id: https://develop.svn.wordpress.org/trunk@30335 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-13 17:00:08 +00:00
Jeremy Felt 42773dc11b Optimize site query when performing network database upgrades
We only use `blog_id` from the query, so we don't need a wildcard.

props marcosf
Fixes #30097


git-svn-id: https://develop.svn.wordpress.org/trunk@30029 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-26 22:09:46 +00:00
Sergey Biryukov f9101c1de9 Users screen in network admin:
* Remove unused $key variables.
* Rename $val to $user_id for clarity.

props ipm-frommen.
fixes #30096.

git-svn-id: https://develop.svn.wordpress.org/trunk@30020 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-25 13:51:36 +00:00
Boone Gorges 5bc62ad1e4 Allow apostrophes in email addresses when adding users via the Dashboard.
Email addresses entered in a number of interfaces were not being stripslashed
properly, with the result that the emails were not being recognized as valid.

Fixes #18039.

git-svn-id: https://develop.svn.wordpress.org/trunk@29966 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-19 20:29:33 +00:00
Jeremy Felt f12a68e7c6 Differentiate between invalid and missing admin emails when adding a new site
Check the emptiness of the admin email before using `sanitize_email()` and `is_email()` to determine if the address is valid.

Fixes #17890


git-svn-id: https://develop.svn.wordpress.org/trunk@29877 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-12 00:21:02 +00:00
Dominik Schilling (ocean90) e9be4237ba Language packs: Remove translations when deleting a theme or a plugin.
This is for translation files in WP_LANG_DIR which are installed through a language pack.
Change `wp_get_installed_translations()` to only return a translation if the .mo file also exists.

fixes #29860.

git-svn-id: https://develop.svn.wordpress.org/trunk@29856 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-08 19:04:05 +00:00
Sergey Biryukov 65a0f4933a Network Admin: Properly check if the theme is active on the main site to avoid deleting it via bulk actions.
props ocean90.
fixes #29861.

git-svn-id: https://develop.svn.wordpress.org/trunk@29839 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-05 20:36:11 +00:00
Scott Taylor 46b4ea2a6c Network Admin Menu:
* Don't display update count for Themes when the user doesn't have the 'update_themes' cap
* Don't display update count for Plugins when there aren't any/count is `0`

Props peterchester.
Fixes #29651.


git-svn-id: https://develop.svn.wordpress.org/trunk@29817 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 15:48:36 +00:00
Sergey Biryukov d552ba29bc * Declare $site_mimes before using it in check_upload_mimes().
* Use the same default value for 'upload_filetypes' as on Network Settings screen.

props rmccue.
fixes #29512 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@29718 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-07 10:10:33 +00:00
Dominik Schilling (ocean90) 1f793ea9b2 Language packs: No WPLANG anymore.
* The WPLANG constant is no longer needed. Remove define('WPLANG', ''); from wp-config-sample.php. Populate WPLANG option based on the WPLANG constant. When get_option('WPLANG') is an empty string it will override WPLANG.
* Introduce translations_api() which is available to communicate with the translation API. Move translation install related functions to a new file.
* Replace mu_dropdown_languages() with wp_dropdown_languages(). wp_dropdown_languages() is now populated by the translation API.
* Remove wp_install_load_language() and allow load_default_textdomain() to switch a core translation.

fixes #13069, #15677, #19760, #28730, #29281. 

git-svn-id: https://develop.svn.wordpress.org/trunk@29630 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-26 19:58:33 +00:00
Drew Jaynes (DrewAPicture) 6ddc1e5f6d Fix syntax for single- and multi-line comments in wp-admin-directory files.
See #28931.


git-svn-id: https://develop.svn.wordpress.org/trunk@29206 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 09:13:53 +00:00
John Blackbourn 0a4e8b2b7e Implement email and url input types where appropriate. Props Kau-Boy. Fixes #22183.
git-svn-id: https://develop.svn.wordpress.org/trunk@29030 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-08 17:51:58 +00:00
Scott Taylor 2d56abdd2e Add new action 'delete_user_form' in wp-admin/users.php and wp-admin/network/users.php.
Props SergeyBiryukov, usermrpapa.
Fixes #27230.


git-svn-id: https://develop.svn.wordpress.org/trunk@28885 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-28 04:42:24 +00:00
Scott Taylor 84ad12b439 Replace all uses of like_escape() with $wpdb->esc_like().
Props miqrogroove.
See #10041.


git-svn-id: https://develop.svn.wordpress.org/trunk@28712 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 00:43:32 +00:00
Sergey Biryukov 9120e6a9d7 Display the site scheme, not the current scheme on Edit Site screen in network admin.
props johnbillion.
fixes #28406.

git-svn-id: https://develop.svn.wordpress.org/trunk@28643 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 22:00:45 +00:00
Scott Taylor e43d2a73d8 Fix some hackificator odds and ends in wp-admin:
* `wp-activate.php` and `wp-admin/themes.php` don't need the closing PHP tag
* Switch single quotes for HTML attribute values to double in a few places
* Convert `include_once file.php` syntax to `include_once( 'file.php' )`
* Add access modifiers to methods/members in: `_WP_List_Table_Compat`, `Walker_Nav_Menu_Edit`, `Walker_Nav_Menu_Checklist`, `WP_Screen`, `Walker_Category_Checklist`
* `edit_user()` doesn't need to import the `$wpdb` global
* `wp_list_widgets()` doesn't need to import the `$sidebars_widgets` global
* switch/endswitch syntax is not supported in Hack
* A `<ul>` in `wp-admin/users.php` is unclosed

See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28500 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 05:03:44 +00:00
Scott Taylor eef0d99ed8 hackificator doesn't like mixed quote styles in some generated HTML. The switch from single to double allows these files to be parsed.
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28497 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 01:58:28 +00:00
wonderboymusic 1da6728dc0 In wp-admin/network/users.php, break is unreachabled after exit.
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28309 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:10:01 +00:00
Scott Taylor aa7cef0549 In wp-admin/network/themes.php, break is unreachabled after exit.
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28308 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:07:33 +00:00
Drew Jaynes (DrewAPicture) b5612f8b80 Priority fixes for various existing hook documentation.
Props kpdesign.
See #26869


git-svn-id: https://develop.svn.wordpress.org/trunk@28083 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-12 00:00:32 +00:00
Andrew Nacin 101863ea1d Network Admin: Case-insensitive comparisons for the network-site comparison in the bootstrap.
props jeremyfelt.
fixes #17168.


git-svn-id: https://develop.svn.wordpress.org/trunk@27725 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-25 21:06:26 +00:00
Andrew Nacin b2ad4105e3 Network Admin: Fix pagination on site-themes and site-users.
props kawauso, jeremyfelt.
fixes #17545.


git-svn-id: https://develop.svn.wordpress.org/trunk@27715 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-25 16:56:45 +00:00
Andrew Nacin 137fe5a7dd Remove HTML from a new string. see #26709.
git-svn-id: https://develop.svn.wordpress.org/trunk@27605 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-19 05:27:37 +00:00
Andrew Nacin 4cf6fc1a99 Use SSL when linking to WordPress.org. see #27115.
git-svn-id: https://develop.svn.wordpress.org/trunk@27469 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-08 04:13:28 +00:00
Dominik Schilling (ocean90) 95b13bb758 Add missing Dashicons classes to Network Admin menu, see #26630.
git-svn-id: https://develop.svn.wordpress.org/trunk@27444 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-06 22:51:53 +00:00
Dominik Schilling (ocean90) 8f1a77a070 Introduce a .dashicons-before CSS class.
If you want to use a Dashicon before an element you can use the class because it will not change the elements content styling. With that you don't need to copy the entire `.dashicons` styling to your :before styling anymore.
To demonstrate this change, Admin Menu now uses Dashicons classes directly.

And it fixes a glitch in IE.

fixes #26630.

git-svn-id: https://develop.svn.wordpress.org/trunk@27418 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-05 20:03:33 +00:00
Helen Hou-Sandi 640cc81949 Indicate that the user deletion process affects all content attributed to a given user, not just posts. props seanchayes. fixes #26709.
git-svn-id: https://develop.svn.wordpress.org/trunk@27416 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-05 19:19:52 +00:00
Sergey Biryukov 8ac662c73b Display site deletion confirmation as a regular admin page.
props jeremyfelt.
fixes #27223.

git-svn-id: https://develop.svn.wordpress.org/trunk@27348 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-02 08:38:47 +00:00
Sergey Biryukov 9bcb738064 Use wp_dropdown_roles() in wp-admin/network/site-users.php.
props jeremyfelt.
fixes #27215.

git-svn-id: https://develop.svn.wordpress.org/trunk@27310 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-27 10:21:13 +00:00
DrewAPicture ac4774ddbd Inline documentation for hooks in wp-admin/network/sites.php.
Props NikV, kpdesign.
Fixes #26124.


git-svn-id: https://develop.svn.wordpress.org/trunk@27088 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-04 07:48:03 +00:00
Andrew Nacin d1cc542e1f Ensure the last separator is removed from the user and network admin menus.
props johnjamesjacoby.
fixes #25425.


git-svn-id: https://develop.svn.wordpress.org/trunk@27066 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 06:18:44 +00:00
Helen Hou-Sandi 91b0e15ef8 Autocomplete for the new site admin email. Better than trying to remember which email address you used.
fixes #25348.


git-svn-id: https://develop.svn.wordpress.org/trunk@27046 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-27 23:09:08 +00:00