Commit Graph

5981 Commits

Author SHA1 Message Date
Weston Ruter
c2c1c3fd3a Customize: Remove selective refresh error message from appearing inline within the preview.
The error message will still be available in the developer console.

Removes part of [36586].
See #27355.
Fixes #36164.


git-svn-id: https://develop.svn.wordpress.org/trunk@36890 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-09 04:36:51 +00:00
Weston Ruter
dcbbeffc57 Customize: Fix regressions and harden implementation of selective refresh for nav menus.
* Request full refresh if there are nav menu instances that lack partials for a changed setting.
* Restore `WP_Customize_Nav_Menus::$preview_nav_menu_instance_args` and `WP_Customize_Nav_Menus::export_preview_data()` from 4.3, and keeping a tally of all `wp_nav_menu()` calls regardless of whether they can use selective refresh.
* Ensure that all instances of `wp_nav_menu()` are tallied, regardless of whether they are made during the initial preview call or during subsequent partial renderings. Export `nav_menu_instance_args` with each partial rendering response just as they are returned when rendering the preview as a whole.
* Fix issues with Custom Menu widget where nav menu items would fail to render when switching between menus when a menu lacked items to begin with.
* Make sure the fallback behavior is invoked when the partial is no longer associated with a menu.
* Do fallback behavior to refresh preview when all menu items are removed from a menu.

Follows [36586].
See #27355.
Fixes #35362.


git-svn-id: https://develop.svn.wordpress.org/trunk@36889 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-09 00:08:51 +00:00
Drew Jaynes
f07f2252fe Menus: Avoid a notice when outputting a description for an existing archive menu item for a post type that doesn't.
Props bradyvercher.
See [36859]. Fixes #35324.


git-svn-id: https://develop.svn.wordpress.org/trunk@36888 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-08 18:24:50 +00:00
Dominik Schilling (ocean90)
6a8cb09f86 Media: Change wording for media files which aren't attached.
The media library can contain files which aren't attached yet. When attaching a file you currently get "Media attachment reattached.", or the opposite "Media attachment detached.". That's redundant and can be inaccurate. It's also not easy to translate in some languages.

This change generalizes the strings to refer to a "media file" instead.

Props SergeyBiryukov, ocean90, netweb.
Fixes #36089.

git-svn-id: https://develop.svn.wordpress.org/trunk@36887 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-08 17:42:45 +00:00
Dominik Schilling (ocean90)
dfc6f47841 Update Random_Compat from 1.1.6 to 1.2.1.
Changes: https://github.com/paragonie/random_compat/compare/1.1.6...v1.2.1

See #35665.

git-svn-id: https://develop.svn.wordpress.org/trunk@36886 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-08 17:14:52 +00:00
Dominik Schilling (ocean90)
7826b7b205 Script Loader: Enqueue the minified version of farbtastic if SCRIPT_DEBUG is false.
The files are available since [36341].

See #36083, #35229.

git-svn-id: https://develop.svn.wordpress.org/trunk@36884 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-08 16:03:35 +00:00
Dion Hulse
8d9b0a9d22 Filesystem: Support Windows shares/DFS roots in wp_normalize_path().
Props rilwis for initial patch.
Fixes #35996.


git-svn-id: https://develop.svn.wordpress.org/trunk@36881 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-08 05:59:45 +00:00
Dion Hulse
d32216787e oEmbed: During discovery, only request the first 150kb of linked content to avoid timouts requesting larger documents.
Fixes #35979.


git-svn-id: https://develop.svn.wordpress.org/trunk@36880 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-08 05:57:13 +00:00
Pascal Birchler
bae3fb43a5 Embeds: Add support for embeds in the theme template hierarchy.
This allows themes to directly override the default template. The order in which the template is retrieved is as follows: `embed-$post_type-$post_format.php` -> `embed-$post_type.php` -> `embed.php`.

The `embed_template` filter gets replaced by the dynamic `{$type}_template` filter in `get_query_template()`.

Props ChriCo, swissspidy.
See #34561. Fixes #34278.

git-svn-id: https://develop.svn.wordpress.org/trunk@36876 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-07 19:33:01 +00:00
Pascal Birchler
3a51ff4d2e Taxonomy: Improve backward compatibility on the wp-admin/term.php page.
Specifically, run `do_action( 'edit-tags.php' );` on this new term edit page introduced in [36308]. Changes the GET param back to `tag_ID` and properly sets the screen base in `WP_Screen`.

See #34988.

git-svn-id: https://develop.svn.wordpress.org/trunk@36874 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-07 12:55:04 +00:00
Pascal Birchler
afdf1c9ec1 Embeds: Adjust the iframe title attribute for improved accessibility.
Changes the title attribute from `Embedded WordPress Post` to `"Post name" — site title`.

Props ramiy.
Fixes #35804.

git-svn-id: https://develop.svn.wordpress.org/trunk@36873 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-07 09:59:02 +00:00
Dominik Schilling (ocean90)
00e87b40c8 Dependencies: Improve group processing of script dependencies.
This is a follow-up to [36604].

When processing dependencies `$this->group` will be the minimum of the script's registered group and all preceding siblings. This is wrong because only a scripts ancestors in the dependency chain should affect where it is loaded. Effectively `$this->group` introduced a form of global state which potentially corrupted the group of dependencies. Sorting covers up this problem.
The issue in #35873 was that script were not moving their dependencies to a lower group when necessary.

The fix:
* In `WP_Dependencies::all_deps()` pass the new `$group` value to `WP_Dependencies::all_deps()`. Previously the wrong value was passed because the parent script could have moved with `WP_Scripts::set_group()`.
* In `WP_Scripts::all_deps()` pass the `$group` parameter to `WP_Dependencies::all_deps()` so it doesn't always use `false` for `$group`. Same for `WP_Styles::all_deps()`.

Props stephenharris, gitlost.
Fixes #35956.

git-svn-id: https://develop.svn.wordpress.org/trunk@36871 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-06 19:49:54 +00:00
Pascal Birchler
92bdac8474 HTTP: Avoid an undefined index notice in wp_http_validate_url().
Props perezlabs.
Fixes #34164.

git-svn-id: https://develop.svn.wordpress.org/trunk@36870 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-06 15:54:13 +00:00
Andrea Fercia
b723d3fb75 CSS: Rename the handle for deprecated-media.css after [36341].
The `media` handle is now used for `media.css` thus the stylesheet
for the old media UI needs a different handle name.

See #35229.

git-svn-id: https://develop.svn.wordpress.org/trunk@36869 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-06 15:37:25 +00:00
Weston Ruter
52d50a6ce9 Customize: Fix image cropping when doing live preview of theme switches.
Ensure that the Customizer gets bootstrapped with the pre-activated `theme` supplied in the `custom-header-crop` admin ajax requests.

Props faishal, rittesh.patel.
Fixes #32783.


git-svn-id: https://develop.svn.wordpress.org/trunk@36866 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-06 01:44:53 +00:00
Aaron Jorbin
4af0645ae8 Ensure Description is respected in post type archive menu items.
Tested scenarios include: using the default (which is the post type description), Setting a custom description for that individual menu item, and setting a custom description that is blank. Introduced in r35382.

Props Toro_Unit, mayukojpn, extendwings, jorbin.
Fixes #35324. See #16075.



git-svn-id: https://develop.svn.wordpress.org/trunk@36859 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-05 22:56:31 +00:00
Andrew Ozz
25838b4c23 TinyMCE:
- Fix the icon for the native dialogs close button.
- Highlight the button on :focus.

See #36035.

git-svn-id: https://develop.svn.wordpress.org/trunk@36857 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-05 22:00:45 +00:00
Weston Ruter
084772af80 Customize: Eliminate unnecessary WP_Customize_Site_Logo_Control in favor of re-using WP_Customize_Image_Control.
* Removes double `margin-bottom` from all the media controls.
* All media controls now send `{settingId}-attachment-data` messages to the preview when a media setting is updated so that the preview has access to the attachment data.
* Fixes receiving of `attachment-data` message for `custom_logo` which resulted in instant JS-applied preview not working. See #36096.

See #33755.
Fixes #35941.


git-svn-id: https://develop.svn.wordpress.org/trunk@36851 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-04 23:46:07 +00:00
Drew Jaynes
04d3748efa Docs: Improve DocBlock syntax and add a missing @return notation for WP_Image_Editor_Imagick::strip_meta(), introduced in [36700].
See: #33642, #30402, #28634. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36847 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-04 17:36:10 +00:00
Drew Jaynes
1dfbf0fb1b Docs: Improve the hook doc summary for the image_strip_meta filter, introduced in [36700].
See: #33642, #30402, #28634. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36846 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-04 17:32:35 +00:00
Drew Jaynes
43399f4ff7 Docs: Improve syntax and correct documentation throughout a variety of methods in WP_Customize_Widgets.
See #32246. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36842 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-04 02:01:15 +00:00
Drew Jaynes
a9cce93ff2 Docs: Improve documentation for WP_Customize_Widgets::customize_dynamic_partial_args(), introduced in [36586].
See #27355. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36841 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-04 01:44:19 +00:00
Drew Jaynes
9775eef208 Docs: Remove an errant period following the @access tag in the DocBlock for wpdb::close(), mistakenly introduced in [36493].
Props markoheijnen.
See #34903. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36840 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-04 00:02:56 +00:00
Konstantin Obenland
cf863ab2a8 Customize: Rename custom logo classes after [36837].
Fixes #35945.


git-svn-id: https://develop.svn.wordpress.org/trunk@36838 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 19:58:37 +00:00
Konstantin Obenland
43ff969765 Customize: Site logos are custom logos.
Brings the nomenclature closer to custom headers and backgrounds.

See https://wordpress.slack.com/archives/core/p1456955151003150
See #35945. 


git-svn-id: https://develop.svn.wordpress.org/trunk@36837 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 19:55:15 +00:00
Drew Jaynes
2d64d06594 Docs: Improve DocBlock syntax for WP_Customize_Nav_Menus::customize_dynamic_partial_args(), introduced in [36586].
See #27355. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36836 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 16:06:41 +00:00
Drew Jaynes
9c74b86880 Docs: Improve documentation for WP_Customize_Nav_Menus::filter_nonces(), introduced in [36414].
See #27355, #35617. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36835 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 16:04:43 +00:00
Drew Jaynes
c4ab9aeda8 Docs: Standardize the changelog entry for the new $author_url argument, introduced in [36224].
See #35377. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36834 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 16:01:41 +00:00
Drew Jaynes
8424db5879 Docs: Improve the DocBlock summary and add a missing initial @since version for WP_Admin_Bar::add_node().
See #32246. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36833 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 15:57:46 +00:00
Joe Hoyle
b38ea44e9a OPTIONS requests to REST API should return Allow header.
An OPTIONS request was incorrectly returning an "Accept" header which
was a typo of "Allow". This meant Accept was showing "GET, POST" for example,
however it was also not running the permission checks on the endpoints.

Instead, the correct route needs to be set on the request object, which means
the normal handling for the Allow header will kick in. This technically
breaks backwards compatibility, however given the value of Accept was also wrong
then this should not be an issue.

Fixes #35975.


git-svn-id: https://develop.svn.wordpress.org/trunk@36829 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 09:54:32 +00:00
Pascal Birchler
94b2ed9303 Docs: Improve documentation for the update_welcome_user_email() filter, introduced in [26538].
See #25598. See #35986.

git-svn-id: https://develop.svn.wordpress.org/trunk@36827 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 09:11:34 +00:00
Gary Pendergast
94a5b546d7 Emoji: Fix some jshint warnings introduced in [36816].
See #35300.



git-svn-id: https://develop.svn.wordpress.org/trunk@36818 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 05:47:55 +00:00
Gary Pendergast
e736153adf Emoji: Add some extra IE11 compatibility.
IE 11's implementation of MutationObserver is buggy. It unnecessarily splits text nodes when it encounters a HTML template interpolation symbol ( "{{", for example ). So, we join the text nodes back together as a work-around.

Fixes #35977 for trunk.



git-svn-id: https://develop.svn.wordpress.org/trunk@36817 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 05:20:19 +00:00
Gary Pendergast
637ea44652 Emoji: Clean up the emoji browser support tests.
As new sets of emoji are added to Unicode, and browsers add support for them at random intervals, we'll inevitably need to add new tests to the emoji loader. This change makes it much easier to add new tests as they're needed.

Fixes #35300.



git-svn-id: https://develop.svn.wordpress.org/trunk@36816 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 05:16:53 +00:00
Mike Schroder
fa4b1164c3 Post 4.5-beta2 version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@36815 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 04:58:45 +00:00
Mike Schroder
ecee08f639 4.5-beta2
git-svn-id: https://develop.svn.wordpress.org/trunk@36814 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 03:57:14 +00:00
John Blackbourn
81d90c0e44 Uploads: Remove an unnecessary static var from wp_is_mobile() to allow its direct and indirect use within unit tests. The static `$is_m
obile` var was only used to avoid a handful of calls to `strpos()`, which are exceptionally fast and result in no measurable increase in
processing time on each call to `wp_is_mobile()`.

See #35976, #20014


git-svn-id: https://develop.svn.wordpress.org/trunk@36813 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 03:24:02 +00:00
John Blackbourn
4b15b87299 Revert r36811.
git-svn-id: https://develop.svn.wordpress.org/trunk@36812 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 03:22:54 +00:00
John Blackbourn
c94a2890fa git-svn-id: https://develop.svn.wordpress.org/trunk@36811 602fd350-edb4-49c9-b593-d223f7449a82 2016-03-03 03:16:55 +00:00
Dominik Schilling (ocean90)
4c8b3511a2 Customizer: Merge two translator comments.
git-svn-id: https://develop.svn.wordpress.org/trunk@36809 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-02 23:09:12 +00:00
Andrew Ozz
ecc0b97857 TinyMCE: then toggling the paste in plain text mode disable the warning message after the second time.
Fixes #28612.

git-svn-id: https://develop.svn.wordpress.org/trunk@36807 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-02 22:09:51 +00:00
Andrew Ozz
bc41261ba4 TinyMCE, inline link:
- Add `uiAutocompleteL10n` with translatable strings for use in UI Autocomplete live region.
- Use the above strings in both the editor plugin and wplink.js.

See #33301.

git-svn-id: https://develop.svn.wordpress.org/trunk@36806 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-02 20:05:04 +00:00
azaozz
c507baa261 TinyMCE: update to 4.3.7. Has few bug/regression fixes. Changelog: https://github.com/tinymce/tinymce-dist/blob/4.3.7/changelog.txt.
Fixes #36035.

git-svn-id: https://develop.svn.wordpress.org/trunk@36803 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-02 18:12:02 +00:00
Dominik Schilling (ocean90)
c119ce9ac2 I18N: Don't use the locale for the HTML language attribute.
Locales are codes to identify a language in WordPress which can be different from the specification for language tags, see https://www.w3.org/International/articles/language-tags/.
An example is `de_DE_formal` or `nl_NL_formal` where the subtag `formal` isn't officially supported.

To give translators the possibility to specify the language tag of their language introduce a string `html_lang_attribute` which can be translated into the language tag which conforms to the specification.

Props SergeyBiryukov.
Fixes #33511.

git-svn-id: https://develop.svn.wordpress.org/trunk@36802 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-02 16:10:00 +00:00
Weston Ruter
0c3716670a Customize: Define params on WP_Customize_Partial::render_callback() for the sake of subclasses overriding this method.
Fixes a strict standards notice regarding the method signature needing to be compatible.

See #27355.


git-svn-id: https://develop.svn.wordpress.org/trunk@36801 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-02 06:08:38 +00:00
Sergey Biryukov
711b9d9227 Docs: Correct filter reference in pre_get_avatar filter description.
Props henry.wright.
Fixes #36031.

git-svn-id: https://develop.svn.wordpress.org/trunk@36800 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-02 03:40:42 +00:00
Andrew Ozz
237146cac1 TinyMCE: fix the close button position in the paste in text mode warning.
See #36035.

git-svn-id: https://develop.svn.wordpress.org/trunk@36799 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-02 01:14:45 +00:00
Andrew Ozz
b4db71a2f8 TinyMCE: update to 4.3.6. Changelog: https://github.com/tinymce/tinymce/blob/master/changelog.txt.
Fixes #36035.

git-svn-id: https://develop.svn.wordpress.org/trunk@36798 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-01 23:12:43 +00:00
Weston Ruter
462a7c2c70 Customize: Ensure autofocus deep-linking applies for dynamically-created panels, sections, and controls.
Removes overly-zealous filtering of autofocus panels, sections, and controls which are unrecognized or for which the user doesn't have the capability to focus (in which case it would no-op anyway). Also defers autofocus logic until instances are created, even after initial `ready` event. This ensures that autofocus can apply for any panels, sections, or controls that get created via the loaded preview.

See #28650.
Fixes #36018.


git-svn-id: https://develop.svn.wordpress.org/trunk@36796 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-01 22:03:27 +00:00
Sergey Biryukov
436a4adb60 I18N: Move the aria-label text in comment_form() to a separate string for easier translation.
Add translator comments.

Props ramiy.
Fixes #36014.

git-svn-id: https://develop.svn.wordpress.org/trunk@36794 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-01 02:13:48 +00:00