Drew Jaynes
ef099f8082
Fix a typo in the PHPDoc for comment_author_email_link().
...
See #27083 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27157 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-10 04:06:36 +00:00
Drew Jaynes
3d67904bc7
Inline documentation cleanup in wp-includes/comment-template.php.
...
This cleanup follows [25567] and brings the docs in-line with standards that at the time had not yet been finalized.
These changes include
* Moving in-line `@see` tags to their own lines
* Using docs-specific variables in hook docs
* Fixing line-wrapping throughout
* Typos and punctuation
* Converting hash notation values to variables per the standard
Fixes #27083 . See #20495 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27156 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-10 03:19:13 +00:00
Andrew Ozz
4951bdc964
Remove unused arg from wp_auth_check(), see #27081 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27154 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 22:33:56 +00:00
Andrew Nacin
e1f6ab1ea9
Run wp_auth_check on every heartbeat tick.
...
wp_heartbeat_received only runs when data is sent. We want to always pass this data back, though.
fixes #27081 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27153 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 22:27:57 +00:00
Scott Taylor
3fce77b44d
Collect the post and link ids that will be reassigned before running the update in remove_user_from_blog(). Use array_walk() instead of array_map() when invalidating the caches for the collected ids.
...
Props kovshenin.
Fixes #25545 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27152 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 21:46:43 +00:00
Dominik Schilling (ocean90)
586cb2b140
Nav Menu: Remove post/page items from the Nav Menu when the post/page is deleted.
...
This was broken through a change in [25163]. `_menu_item_object` in wp_get_associated_nav_menu_items() is not relevant for post types.
Adds unit tests.
props UmeshSingla for initial patch.
fixes #26795 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27150 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 21:36:15 +00:00
Drew Jaynes
d670819b03
Improve inline documentation for wp_new_user_notification().
...
Props antorome for the initial patch.
Fixes #26703 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27149 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 21:07:01 +00:00
Drew Jaynes
eaff87706b
Improve inline documenation for get_the_time() and `get_post_time().
...
Props ruud@joyo for the initial patch.
Fixes #26682 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27148 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 21:02:36 +00:00
Drew Jaynes
b013aaf4c9
Fixes for hooks documentation in wp-includes/wp-db.php.
...
See #26869 , #25229 and [25284].
git-svn-id: https://develop.svn.wordpress.org/trunk@27147 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 20:50:42 +00:00
Andrew Ozz
0ae2aa696a
Remove a stray </div> from the Edit Image template, was breaking it in IE < 9. Props gcorne, see #24409
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27143 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 18:44:40 +00:00
Scott Taylor
e966a23683
Reuse the terms cache group for taxonomy cache invalidation.
...
See #22526 , #14485 , [27101], [27102].
git-svn-id: https://develop.svn.wordpress.org/trunk@27142 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 17:41:07 +00:00
Drew Jaynes
eb43703bba
Improve inline documentation for several 'last_changed'-related functions introduced in [27101] and [27102].
...
Functions include:
* `get_taxonomy_last_changed()`
* `set_taxonomy_last_changed()`
* `post_taxonomy_is_fresh()`
* `taxonomy_hierarchy_is_fresh()`
Fixes #22526 , #14485 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27141 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 02:01:28 +00:00
Andrew Nacin
ee280cf8dd
has_image_size()'s parameter should be required. see [27139], see #26951 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27140 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-08 23:52:40 +00:00
Drew Jaynes
c0a7cd58e7
Inline documentation tweaks for has_image_size() and remove_image_size().
...
See #26951 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27139 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-08 22:54:47 +00:00
Drew Jaynes
75c028e042
Inline documentation for the wp_insert_attachment_data filter hook, added in [27130].
...
Fixes #20547 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27138 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-08 22:46:25 +00:00
Sergey Biryukov
a3a869fdfd
Fix validation issue in get_the_password_form() caused by wpautop().
...
props andykeith.
fixes #27071 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27134 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-08 13:22:40 +00:00
Andrew Nacin
f3cbc44076
Add meetup.com oEmbed support. see #23171 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27133 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-08 01:13:52 +00:00
Andrew Nacin
522670cef2
Various JSHint fixes. see #26446 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27131 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-08 00:51:14 +00:00
Scott Taylor
2238c7fb7f
Add a filter wp_insert_attachment_data in wp_insert_attachment(). This is similar to the wp_insert_post_data filter in wp_insert_post().
...
Fixes #20547 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27130 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-08 00:43:16 +00:00
Andrew Nacin
baeadcfedc
Add remove_image_size() and tests for it and has_image_size(), added in [27128].
...
props mordauk, markoheijnen.
fixes #26768 . see #26951 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27129 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-08 00:40:15 +00:00
Scott Taylor
d80685a46b
Introduce has_image_size( $name ), a utility function that helps avoid loading the $_wp_additional_image_sizes global.
...
Props mordauk.
Fixes #26951 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27128 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-08 00:19:29 +00:00
Scott Taylor
d6cb8c399e
Introduce maybe_regenerate_attachment_metadata( $attachment ). On the Edit Media screen, call it for Audio and Video files.
...
The functions checks if the item is lacking metadata altogether. If a video or audio file was uploaded prior to 3.6, it does not have any metadata. This tries to fix it. Implements locking via a transient to protect against this running in parallel with another request.
This is the minimum viable product for #26825 , but leaving the ticket open unless this function needs to be called in other places.
See #26825 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27127 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-07 22:40:32 +00:00
Scott Taylor
4b047c21ab
Add some inline docs to media-views.js and remove some unnecessary comments from a few super calls.
...
Props gcorne.
See #26870 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27126 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-07 20:20:38 +00:00
Scott Taylor
81679ef453
When a term_id matches in _get_term_children(), recurse through its children until there is no more depth in the hierarchy. Since get_terms() return terms with a count of 0 when their children are not empty, we must return all children so that get_terms() can check their count.
...
In [27108], #26903 was fixed, but only because we were using the example in the ticket, leaving out infinite depth for hierarchical taxonomies.
Adds unit tests, including `Tests_Term_getTerms::test_get_terms_seven_levels_deep()`.
Fixes #26903 . Again.
git-svn-id: https://develop.svn.wordpress.org/trunk@27125 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-07 19:53:01 +00:00
Sergey Biryukov
ab112fecb8
Fix typo in wp_set_auth_cookie() description.
...
props drozdz.
fixes #27046 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27116 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-07 09:46:19 +00:00
Andrew Nacin
4f5608f653
Use a float for last_changed microtime cache values.
...
microtime() by default returns a string with a space, which isn't allowed for keys in some cache backends.
props _jameslee, drozdz.
fixes #27000 . see #23448 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27115 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-07 08:13:37 +00:00
Andrew Nacin
99c1b7323c
Add imgur to the list of oEmbed providers.
...
props bradparbs.
fixes #21632 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27113 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-06 23:11:21 +00:00
Andrew Nacin
1304fb3463
Fix the conditional enqueueing/printing of colors stylesheets, without breaking dependencies.
...
fixes #18380 .
see #20729 which should properly fix this.
git-svn-id: https://develop.svn.wordpress.org/trunk@27111 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-06 22:15:25 +00:00
Andrew Ozz
4d7d68b565
Fix scrolling inside the Visual editor on MacOS, add the same functionality to the Text editor, see #27013
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27110 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-06 19:33:13 +00:00
Scott Taylor
8dad11bfe2
In get_terms(), don't set automatically hierarchical to false when parent => 0 is passed. The default value for parent is ''.
...
In `_get_term_children()`, don't skip a top-level term without first including its children in the returned term list. Ironically, the call to `_get_term_children()` in `get_terms()` has a comment stating `"Make sure we show empty categories that have children."`, but it didn't work if you were retrieving top-level categories only.
All unit tests pass. Added a unit test based on the use case described in this ticket.
Fixes #26903 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27108 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-06 17:44:50 +00:00
Helen Hou-Sandi
802baab31a
Merge colors.css into wp-admin.css. Non-default color schemes became overloads rather than swaps in the 3.8 redesign. Benefits include:
...
* No more border-width, border-style, border-color insanity.
* Point releases are much less likely to require extra finagling to avoid rebuilding the color schemes.
* Yours truly has a better overall vision of ~14,000 lines of admin CSS and where we go from here.
1,065 net lines of red, y'all.
props helen, jorbin. fixes #18380 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27106 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-06 06:24:36 +00:00
Andrew Nacin
7ff0442a07
JSHint fixes for media-views and Gruntfile.
...
props gcorne.
fixes #27032 , #27033 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27105 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-06 05:31:22 +00:00
Scott Taylor
50a96f165e
Regenerate the term hierarchy cache ({taxonomy}_children) when it is out of sync with the passed taxonomy's last_changed value.
...
Introduces `taxonomy_hierarchy_is_fresh()`, which is only called in `_get_term_hierarchy()`. The taxonomy's `last_changed` value is checked against the value of `wp_cache_get( 'hierarchy_last_changed', $taxonomy )`.
Adds a unit test - `Tests_Term:test_hierachy_invalidation()`.
See [27101], which makes this type of cache invalidation possible.
Fixes #14485 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27102 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-06 01:58:01 +00:00
Scott Taylor
e33ef0c6ac
Add cache invalidation when updating a term, example: create a category, assign it to a post, edit the category. Currently, the post's term cache is not updated. When updating terms in a given taxonomy, invalidate the object term caches linked to that taxonomy.
...
Introduce `get_taxonomy_last_changed()`, `set_taxonomy_last_changed()`, and `post_taxonomy_is_fresh()`.
`post_taxonomy_is_fresh()` is only called in `get_object_term_cache()` - at which point the taxonomy's `last_changed` value is checked against the post's `{$taxonomy}_last_changed` value.
`set_taxonomy_last_changed()` is called whenever directory database queries are made that insert new terms or affect existing terms.
Fixes #22526 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27101 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-06 01:40:05 +00:00
Andrew Ozz
5a3fb502cb
TinyMCE: set the proper caption width when clicking image resize handle on image with caption. Props gcorne, fixes #27009 , see #24067 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27098 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-05 02:06:10 +00:00
wonderboymusic
71947f18d3
When a video shortcode has content in its body, append it as inner HTML in the resulting <video>.
...
Reverts [27096].
Fixes #26628 .
See #27016 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27097 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-05 01:42:02 +00:00
Andrew Ozz
89b8edf8f1
TinyMCE: don't scroll the main window when scrolling the editor content with a mouse wheel or trackpad and reaching the end. Fixes #27013 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27095 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-05 01:09:42 +00:00
Andrew Ozz
6a0251847b
Consolidate handling of <object>, <audio> and <video> in wpautop() and add unit tests for them. Part props wonderboymusic, see #26864
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27094 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-05 00:45:53 +00:00
Andrew Ozz
b33135c08d
When using wp_editor(), make it easier to specify which editor is shown first, fixes #20822
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27093 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-05 00:33:49 +00:00
Andrew Nacin
6aaad4785a
Autosave: Fix typo in event namespace. props avryl, see #25272 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27092 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-04 16:06:13 +00:00
Scott Taylor
050e4f26e9
Invalidate the post cache for posts associated with a user who has been removed from a blog in remove_user_from_blog(). Adds a unit test.
...
Props nprasath002 for the initial patch.
Fixes #25545 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27087 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-04 04:12:52 +00:00
Andrew Ozz
840423ea10
Minor cleanup (jshint) of wp-fullscreen.js and /wordpress/plugin.js, see #24067
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27085 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-03 21:30:25 +00:00
Andrew Ozz
5ff41a8635
Add back missing var definition in wplink.js, props TobiasBg, see #24067
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27084 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-03 21:26:39 +00:00
Andrew Ozz
c24e451ae3
TinyMCE: don't replace <i> with <em> and <b> with <strong> and don't remove them when empty, see #24067 , see #23037 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27083 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-03 20:25:08 +00:00
Sergey Biryukov
0d8921de03
Add braces around conditionals. props TobiasBg. fixes #25704 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27082 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-03 20:16:08 +00:00
Scott Taylor
28bab15d16
Properly invalidate the cache for wp_count_posts() on insert, trash, or when transitioning post_status inside of _transition_post_status(). Introduces _count_posts_cache_key(). Adds unit tests.
...
Props mark8barnes, for bringing this to our attention in an initial patch.
Fixes #21879 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27081 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-03 19:41:40 +00:00
Andrew Ozz
9fd8c54ef9
Consolidate "close on Escape" in the media modal, DFW, wpLink and Thickbox. Props kovshenin, fixes #26854 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27080 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-03 05:30:12 +00:00
Andrew Ozz
90662a17f4
Editor: add :focus style for the Quicktags buttons, fixes #26932
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27078 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 22:37:37 +00:00
Andrew Nacin
ed1ece6e3b
Remove an unnecessary variable passed to wpdb::prepare() during multisite load.
...
props jeremyfelt.
fixes #26941 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27076 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 22:08:14 +00:00
Andrew Nacin
194d6a94b7
When the MySQL server has "gone away," attempt to reconnect and retry the query.
...
props pento.
see #5932 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27075 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 22:06:42 +00:00