Commit Graph
4576 Commits
Author SHA1 Message Date
Drew Jaynes 4d9d985a64 Inline documentation for hooks in wp-admin/network/site-users.php.
Props sboisvert for the initial patch. Props kpdesign.
Fixes #25497.


git-svn-id: https://develop.svn.wordpress.org/trunk@25939 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-26 20:32:14 +00:00
Drew Jaynes acb441a519 Inline documentation for hooks in wp-admin/includes/schema.php.
Props johnafish, kpdesign.
Fixes #25498.


git-svn-id: https://develop.svn.wordpress.org/trunk@25938 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-26 20:28:34 +00:00
Drew Jaynes 25becc93f9 Inline documentation for hooks in wp-admin/tool.php.
Props dougwollison for the initial patch.
Fixes #25496.


git-svn-id: https://develop.svn.wordpress.org/trunk@25937 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-26 19:22:08 +00:00
Drew Jaynes eef2e83b13 Inline documentation for hooks in wp-admin/includes/nav-menu.php.
Props Faison.
Fixes #25474.


git-svn-id: https://develop.svn.wordpress.org/trunk@25935 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-26 17:47:33 +00:00
Andrew Nacin 9a2bf56fc3 Avoid a notice for an undefined $checksums variable when updating from pre-3.7 to post-3.7.
props GaryJ.
fixes #25689 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@25915 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-25 20:14:23 +00:00
Andrew Nacin 7508e7c03b Add editimage.min.js to $_old_files. see #24999.
git-svn-id: https://develop.svn.wordpress.org/trunk@25897 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-24 19:26:11 +00:00
Andrew Nacin 391b22a4de Confirm delete_site_option() exists before calling it during an update.
This function won't yet exist when updating from 2.7 [sic].

fixes #25682 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@25893 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-24 18:17:41 +00:00
Andrew Nacin 9c5420d74d Remove debug code from WP_Automatic_Updater::send_email().
props markmcwilliams for initial patch.
see #25678.


git-svn-id: https://develop.svn.wordpress.org/trunk@25891 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-24 01:50:09 +00:00
Andrew Nacin ed15997210 About page: Cache our zxcvbn calls and limit the variation of the animation.
Diff is mostly whitespace.

props jorbin, azaozz.
fixes #25603.


git-svn-id: https://develop.svn.wordpress.org/trunk@25884 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-23 19:50:30 +00:00
Andrew Nacin 1d33726b1a About page, updates section: Don't show a message on about.php if the updater is 100% disabled. Don't show it if the user can't update core. Don't show the email if notifications are disabled. New string.
see #25603.


git-svn-id: https://develop.svn.wordpress.org/trunk@25883 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-23 19:47:39 +00:00
Andrew Nacin 3d2776d023 Introduce a send_core_update_notification_email filter to control whether to send update notifications.
Currently, this is dependent on whether the automatic updater is enabled (generally). This is likely to be decoupled in a future release.

This refocuses the auto_core_update_send_email filter to specifically be for success/fail emails for auto updates, while the new filter is more general.

see #25603.


git-svn-id: https://develop.svn.wordpress.org/trunk@25882 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-23 19:46:33 +00:00
Ryan Boren 30f822b8ee Pinking shears
git-svn-id: https://develop.svn.wordpress.org/trunk@25880 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-23 14:37:54 +00:00
Andrew Nacin ff69fb4b8f Make some changes to the email templates to account for the fact that an auto update offer might not be to the latest version.
For example, 3.7.2 install is served a 3.7.3 update, but the current version is 3.8.1.

This commit also allows for core update notification emails to be sent even when we are unable to run an auto update due to filesystem configuration (VCS checkout or file permissions). But, since these emails go through WP_Automatic_Updater, they will not be sent if the updater is outright disabled.

fixes #25654.


git-svn-id: https://develop.svn.wordpress.org/trunk@25873 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-22 21:18:09 +00:00
Andrew Nacin aab4ffb29d Show the nag we show for a stuck .maintenance file when an auto update failed.
see #25654.


git-svn-id: https://develop.svn.wordpress.org/trunk@25872 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-22 21:14:06 +00:00
Andrew Nacin ddbc271329 "some files" instead of "certain files". Less stuffy.
props markjaquith.
see #25652.


git-svn-id: https://develop.svn.wordpress.org/trunk@25871 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-22 18:40:20 +00:00
Andrew Nacin f36fbb550c New, better error message when we realize we won't be able to copy a file and continue with the update.
fixes #25652.


git-svn-id: https://develop.svn.wordpress.org/trunk@25870 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-22 18:20:51 +00:00
Andrew Nacin 1a7bfffd0b Only enforce disk free space checks when doing background updates.
see #25652.


git-svn-id: https://develop.svn.wordpress.org/trunk@25869 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-22 18:17:13 +00:00
Andrew Nacin c87ad6023d Spell out duplicate hook locations.
props DrewAPicture.
fixes #25658.


git-svn-id: https://develop.svn.wordpress.org/trunk@25868 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-22 17:21:32 +00:00
Andrew Nacin ea7d0de723 Updates: Disable maintenance mode once we've finished copying files, to minimize disruption.
props dd32.
fixes #25655.


git-svn-id: https://develop.svn.wordpress.org/trunk@25866 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-22 17:19:48 +00:00
Andrew Nacin d0d07cf614 Updates: Saner stats and rollback handling. WP.org now collects basic stats on non-auto updates as they have been hugely informative.
props dd32 for initial patch.
fixes #25657.


git-svn-id: https://develop.svn.wordpress.org/trunk@25863 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-22 09:48:36 +00:00
Andrew Nacin bce2656e6d Move upgrader_process_complete for core to its proper place in Core_Upgrader.
This means it will be firing as a JS redirect is taking place if the update is from pre-3.4. Acceptable.

props dd32.
fixes #25659.


git-svn-id: https://develop.svn.wordpress.org/trunk@25861 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-22 04:36:54 +00:00
Andrew Nacin 597e82e94c Rename the automatic_updates_send_email filter to auto_core_update_send_email. (Final name change.)
fixes #25653. Also:
 * Fully document all new hooks, methods, and classes in the upgrader.
 * Rename 'language' to 'translation' inside the upgrader.
 * Improve the readability of the crazy do-while loop in the is_vcs_checkout() method.


git-svn-id: https://develop.svn.wordpress.org/trunk@25859 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-21 22:28:07 +00:00
Drew Jaynes a6d9b5e57a Improve inline documentation for hooks in wp-admin/customize.php.
Props kpdesign.
Fixes #25444.


git-svn-id: https://develop.svn.wordpress.org/trunk@25858 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-21 21:17:00 +00:00
Andrew Nacin d96b64c116 Commit [25823] should not have renamed AUTOMATIC_UPDATER_DISABLED to AUTOMATIC_UPDATES_DISABLED.
The proper constant is AUTOMATIC_UPDATER_DISABLED. Keep the filter in line with that too.

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25851 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 21:23:43 +00:00
Dominik Schilling (ocean90) 5d7ee6ce93 Vendor-prefixes for [25845]. props jorbin. see #25603.
git-svn-id: https://develop.svn.wordpress.org/trunk@25849 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 19:24:18 +00:00
Andrew Nacin 278b180b2f About page: Prevent the meter from briefly sticking on 'Strong' when the animation resets.
props jorbin.
see #25603.


git-svn-id: https://develop.svn.wordpress.org/trunk@25848 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 18:49:47 +00:00
Andrew Nacin c85914b57e Since we're dealing with a huge password meter, don't bold half of the result strings unnecessarily. see #25603.
git-svn-id: https://develop.svn.wordpress.org/trunk@25847 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 18:36:01 +00:00
Dominik Schilling (ocean90) 476e4a4778 IE7: Fix width of the password input field on the about page. see #25603.
git-svn-id: https://develop.svn.wordpress.org/trunk@25846 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 17:57:08 +00:00
Andrew Nacin f4bf16102d About page: Use box-sizing: border-box on the password meter so pixels line up.
Also eliminates a duplicate width: 100% property.

fixes #25603.


git-svn-id: https://develop.svn.wordpress.org/trunk@25845 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 17:46:54 +00:00
Dominik Schilling (ocean90) 3b56df670e CSS cleanup for the about page.
Also fixes for IE and support for RTL.

see #25603.

git-svn-id: https://develop.svn.wordpress.org/trunk@25844 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 17:35:39 +00:00
Andrew Nacin fda5b39db2 Use correct variable. fixes #10787.
git-svn-id: https://develop.svn.wordpress.org/trunk@25843 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 17:15:36 +00:00
Andrew Nacin a028b8f2dc Use full paths to images so they work on wp-admin/network/about.php and user/about.php. see #25603.
git-svn-id: https://develop.svn.wordpress.org/trunk@25842 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 16:50:00 +00:00
Andrew Nacin 0b22aae62d Notify administrators of successful, failed, and pending core updates.
Blocks future background updates after critical failures, but allow retries in certain situations. More in the ticket.

fixes #10787.


git-svn-id: https://develop.svn.wordpress.org/trunk@25841 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 16:29:16 +00:00
Andrew Nacin 77730d6377 Remove rarr from about page text. Use a subtle background instead.
props markjaquith.
see #25603.


git-svn-id: https://develop.svn.wordpress.org/trunk@25840 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 08:41:40 +00:00
Andrew Nacin 6810bc9069 Awesome about page design for WordPress 3.7.
The page includes a giant password meter that serves as both an animated example and a working demo. How cool is that?

props jorbin, melchoyce.
see #25603.


git-svn-id: https://develop.svn.wordpress.org/trunk@25839 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 08:10:43 +00:00
Andrew Nacin 142d8c3d30 Delete expired transients on database upgrades.
Reverts [25416], which had all transients being cleared. This leaves much to be desired, but we don't want a core update to be blamed for breaking a site that incorrectly assumes transients aren't transient.

props dartiss, pento.
fixes #20316.


git-svn-id: https://develop.svn.wordpress.org/trunk@25838 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 07:47:44 +00:00
Andrew Nacin 92c2bc7797 Introduce email templates for automatic background updates.
The four templates are:
 1. We successfully updated their site. If any of their themes or plugins are out of date, it also mentions that. ('success')
 2. We are not configured to update their site, so we notify them of the new release. ('notify')
 3. We tried but failed to update their site. The error was early in the process, so no harm, no foul. This is the same as template #2, plus one sentence. ('fail')
 4. We tried to update their site, and failed while copying files. ('critical')

With assistance from markjaquith.

see #10787.


git-svn-id: https://develop.svn.wordpress.org/trunk@25837 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 06:32:27 +00:00
Andrew Nacin aa4635548d set_current_screen() is now unnecessary in Automatic_Upgrader_Skin, which is good because it breaks things in the network admin.
fixes #25622.


git-svn-id: https://develop.svn.wordpress.org/trunk@25836 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-17 23:23:42 +00:00
Andrew Nacin 8cb344e237 In automatic background updates, standardize on 'update'.
New, final filter names:
 * auto_update_{$type} (plugin, theme, core, language)
 * automatic_updates_is_vcs_checkout
 * automatic_updates_disabled

New class name is WP_Automatic_Updater. Method names include update() and should_update().

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25835 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-17 23:20:56 +00:00
Andrew Nacin ba10ec2cba Remove redundant code. see #25603, #22704, [25833].
git-svn-id: https://develop.svn.wordpress.org/trunk@25834 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-17 20:29:12 +00:00
Andrew Nacin ab77984329 Check if background core updates are supported on about.php.
see #25603, #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25833 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-17 20:28:38 +00:00
Andrew Nacin f555490bee Update the text for the about page, so translators can get started. Design is in flux.
props nacin, markjaquith, jorbin, jenmylo.
see #25603.


git-svn-id: https://develop.svn.wordpress.org/trunk@25832 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-17 20:16:36 +00:00
Dion Hulse 3ce626a96b Silence PHP warnings from disk_free_space(). disk_free_space() will produce a warning in error conditions in addition to returning false, this includes a case where the bytes free is greater than PHP_INT_MAX (which is a error condition we don't need to check).
See #25576, #22704


git-svn-id: https://develop.svn.wordpress.org/trunk@25831 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-17 18:39:04 +00:00
Drew Jaynes 8166a14066 Inline documentation for hooks in wp-admin/options-general.php.
Props siobhyb for the initial patch.
Fixes #25454.


git-svn-id: https://develop.svn.wordpress.org/trunk@25830 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-17 06:17:20 +00:00
Drew Jaynes eb3d658b7e Inline documentation for hooks in wp-admin/options-discussion.php.
Props siobhyb, ericlewis.
Fixes #25453.


git-svn-id: https://develop.svn.wordpress.org/trunk@25829 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-17 05:59:54 +00:00
Dion Hulse d2d9b963a2 For Background updates, ensure that only one update process runs at the same time by using the options table as a lock.
This prevents multiple cron spawns and/or long-running updates from causing multiple update processes to spin up.
This also fixes a case where the upgrader might kick in for ( ! is_main_network() || ! is_main_site() ) in mulisite installs.
See #22704


git-svn-id: https://develop.svn.wordpress.org/trunk@25828 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-17 05:23:35 +00:00
Drew Jaynes 5de9864891 Inline documentation for hooks in wp-admin/customize.php.
Props andg, rzen.
Fixes #25444.


git-svn-id: https://develop.svn.wordpress.org/trunk@25826 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-17 04:52:38 +00:00
Andrew Nacin 4644bb87f6 Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone.
see #27704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25825 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-17 04:01:06 +00:00
Andrew Nacin c39143fd2e Make WP_Automatic_Upgrader a proper object that gets instantiated. Renames nearly all of its methods.
Also renames wp_auto_updates_maybe_update() to wp_maybe_auto_update().

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25823 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-17 00:54:15 +00:00
Dion Hulse d0bd68cf5f Remove a duplicate semicolon that snuck in. Props JustinSainton. See #18200
git-svn-id: https://develop.svn.wordpress.org/trunk@25822 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-17 00:11:25 +00:00