vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-07-26 12:00:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
29,105 Commits 1 Branch 0 Tags
c9913583e344bc12baa899b1893d0e5dc137e7ed
Commit Graph

61 Commits

Author SHA1 Message Date
Sergey Biryukov
7f69e6430b Themes: Add feedback for screen readers when search results are changed. 
props obenland, joedolson.
see #26600.

git-svn-id: https://develop.svn.wordpress.org/trunk@31497 602fd350-edb4-49c9-b593-d223f7449a82
 2015-02-22 10:14:45 +00:00
Dominik Schilling (ocean90)
23d0e8392e Remove a stray $ from [30793]. 
props ipm-frommen.
see #30553.

git-svn-id: https://develop.svn.wordpress.org/trunk@30794 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-09 11:26:27 +00:00
Dominik Schilling (ocean90)
4975d4255f Themes: Use Customizer deep-links inside the theme modal. 
props DrewAPicture, ocean90.
see #25569, #25571.
fixes #30553.

git-svn-id: https://develop.svn.wordpress.org/trunk@30793 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-08 22:22:23 +00:00
John Blackbourn
16ec77cd70 Prevent the deletion of a theme while it has an active child theme. 
Fixes #29580
Props karpstrucking, jesin


git-svn-id: https://develop.svn.wordpress.org/trunk@30697 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-02 02:20:14 +00:00
John Blackbourn
4e1e4745ff Switch to a 403 response code in places where it is more appropriate than a 500 due to permissions errors. 
Fixes #10551
Props nacin


git-svn-id: https://develop.svn.wordpress.org/trunk@30356 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-16 06:15:29 +00:00
Sergey Biryukov
ac90567ef1 Use proper functions for escaped translations. 
pros jcastaneda.
fixes #30012.

git-svn-id: https://develop.svn.wordpress.org/trunk@29961 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-18 20:10:47 +00:00
Sergey Biryukov
97b07876cb Themes: Make "Live Preview" the primary action and "Activate" secondary. 
props celloexpressions.
fixes #26899.

git-svn-id: https://develop.svn.wordpress.org/trunk@29957 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-18 18:16:23 +00:00
Dominik Schilling (ocean90)
3d6d32d9e6 Themes: Make it possible to delete broken themes. 
props ideag, obenland.
fixes #28165.

git-svn-id: https://develop.svn.wordpress.org/trunk@29924 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-16 19:45:26 +00:00
Helen Hou-Sandi
f187cf1dec Make filter bar CSS less verbose and redundant. 
Also removes an unused handler in the theme feature filter.

see #28794.


git-svn-id: https://develop.svn.wordpress.org/trunk@29596 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-25 15:57:34 +00:00
Sergey Biryukov
40d1133c6f Fix duplicate Customize button in theme details modal. 
props afercia.
fixes #28987.

git-svn-id: https://develop.svn.wordpress.org/trunk@29324 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-29 16:01:13 +00:00
Helen Hou-Sandi
021750b4f4 Use more generic, reusable CSS for the filter bar on Add Themes. This will allow us to reuse the UI in other places, such as the Media Library. props paulwilde. fixes #28794. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29217 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-18 03:39:04 +00:00
Dominik Schilling (ocean90)
60b1befd8e Customizer: Add meta capability customize which is mapped to edit_theme_options. 
You can now allow users to access the Customizer, say for any user who can `edit_posts`, via `map_meta_cap` or `user_has_cap` filter. See ticket for examples.

props westonruter, nacin.
fixes #28605.

git-svn-id: https://develop.svn.wordpress.org/trunk@29170 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-14 19:00:24 +00:00
Sergey Biryukov
08969ece9e Show a "No themes found" message if the search for an installed theme doesn't produce any results. 
props gauravmittal1995 for initial patch.
fixes #28587.

git-svn-id: https://develop.svn.wordpress.org/trunk@28890 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-29 09:15:08 +00:00
Scott Taylor
e43d2a73d8 Fix some hackificator odds and ends in wp-admin: 
* `wp-activate.php` and `wp-admin/themes.php` don't need the closing PHP tag
* Switch single quotes for HTML attribute values to double in a few places
* Convert `include_once file.php` syntax to `include_once( 'file.php' )`
* Add access modifiers to methods/members in: `_WP_List_Table_Compat`, `Walker_Nav_Menu_Edit`, `Walker_Nav_Menu_Checklist`, `WP_Screen`, `Walker_Category_Checklist`
* `edit_user()` doesn't need to import the `$wpdb` global
* `wp_list_widgets()` doesn't need to import the `$sidebars_widgets` global
* switch/endswitch syntax is not supported in Hack
* A `<ul>` in `wp-admin/users.php` is unclosed

See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28500 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 05:03:44 +00:00
Andrew Nacin
e73e290712 Themes: Hide 'Add New' with no JS. see #27055. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27936 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-03 23:05:01 +00:00
Andrew Nacin
814de88f7a Themes screen: Use a normal error for WP_Theme errors. 
see #27235 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@27760 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-26 23:36:42 +00:00
Andrew Nacin
8c3ac32372 More translation cleanups. 
Affects widgets (see #27112), custom headers (see #21785), theme installer (see #27055, reverts [27614]), and some media stuff. Untranslates some complicated strings that need additional study.

see #27453.


git-svn-id: https://develop.svn.wordpress.org/trunk@27620 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-19 08:17:08 +00:00
Andrew Nacin
4cf6fc1a99 Use SSL when linking to WordPress.org. see #27115. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27469 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-08 04:13:28 +00:00
Mark Jaquith
43e78ac29a Improve pushState, replaceState and routing for Themes page 
* Uses `pushState()` generally
* Uses `replaceState()` when updating a search query (so no history cruft from typing)

fixes #27198. props gcorne, adamsilverstein.

git-svn-id: https://develop.svn.wordpress.org/trunk@27268 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-25 19:21:58 +00:00
Sergey Biryukov
5b7c8cf7c1 Use .screen-reader-text class instead of an alt attribute for overlay button labels on Themes screen. 
props bramd.
fixes #26603 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@27119 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-07 17:32:31 +00:00
Andrew Nacin
b663efb313 Themes screen: Add aria-describedby attributes to provide better information to screen readers. 
props joedolson for initial patch.
fixes #26602 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@27012 602fd350-edb4-49c9-b593-d223f7449a82
 2014-01-22 20:59:29 +00:00
Andrew Nacin
972b6ef466 Keyboard navigation friendliness for themes.php. 
props matveb, azaozz, jorbin.
see #26527.


git-svn-id: https://develop.svn.wordpress.org/trunk@26922 602fd350-edb4-49c9-b593-d223f7449a82
 2014-01-08 21:34:03 +00:00
Andrew Nacin
ff215b1af8 Don't use a JS reserved word in a Backbone template, this breaks IE8. 
props ocean90.
fixes #26539.


git-svn-id: https://develop.svn.wordpress.org/trunk@26853 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-11 22:48:03 +00:00
Ryan Boren
cfd5c395bb The Pinking Shears stir from their slumber, awakened by what may seem, to those 
innocent in the ways of The Shears, a triviality, a nothing-of-consequence. But there are consequences indeed for recklessly trailing your whitespace. Naturally, they a dire!

One, two! One, two! And through and through
The Pinking Shears went snicker-snack!
They plucked your tail and with your space
They went sniksnuking back.

Let me tell you, that can be uncomfortable, so always pre-sniksnuk your trailing whites. May The Shears be with you.


git-svn-id: https://develop.svn.wordpress.org/trunk@26851 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-11 19:48:29 +00:00
Andrew Nacin
0fff0660b4 Themes: use explicit 'search installed themes' label and placeholder. 
fixes #26496.


git-svn-id: https://develop.svn.wordpress.org/trunk@26827 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-09 07:40:56 +00:00
Ryan Boren
85d5a58809 Make the Backbone routes pushSTate capable with ?theme=themename type urls instead of hashes. Same applies to search queries. 
Props adamsilverstein, nacin
fixes #25963


git-svn-id: https://develop.svn.wordpress.org/trunk@26767 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-07 03:10:44 +00:00
Andrew Nacin
bed7328d1d Update the help text on themes.php. The Install Themes tab is now an Add New button. 
props ethitter.
fixes #26285.


git-svn-id: https://develop.svn.wordpress.org/trunk@26759 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-07 00:44:15 +00:00
Andrew Nacin
195465ce38 Remove screenshotGallery. see #25948. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26728 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-06 17:10:38 +00:00
Andrew Nacin
b9cb349dc0 No-JavaScript and no-Customizer support for the new Themes screen. 
JavaScript is rarely disabled, but graceful degradation is still important. For example, syntax errors can occur, usually with major WP updates that overhaul entire experiences and update external libraries combined with themes or plugins doing weird or old things. If this error is due to their current theme, a user needs to be able to access the themes screen to switch away from the theme. A more subtle issue could make things painful to diagnose.

This commit renders the grid in PHP (the template is duplicated, but it lightweight, fairly mundane, and easy to sync). On Backbone render, the grid is then re-rendered from JavaScript so searches can occur. Customize and Live Preview is disabled if JS fails to kick in. If JS is disabled, old-school "Preview" links are displayed.

No-Customizer support: The customizer is only supported when the browser supports postMessage (IE8+), and if the frontend is a different domain, CORS (IE10+). We use the .hide-if-no-customize class for this. Pre-customize "Preview" links should use .hide-if-customize.

The .load-customize class should be used to declare a link that opens the customizer. This enables customize-loader.js to intercept this link and load the customizer on top of the current window, making for a smoother experience.

fixes #25964.


git-svn-id: https://develop.svn.wordpress.org/trunk@26726 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-06 16:10:25 +00:00
Andrew Nacin
efed19d3df Map old -width theme tags to new -layout tags for the purposes of translation in the admin. 
see #21442.


git-svn-id: https://develop.svn.wordpress.org/trunk@26725 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-06 14:36:07 +00:00
Andrew Nacin
eb0406a401 Themes: Switch to a text overlay instead of an icon on hover. Numerous reasons outlined in the ticket. 
props shaunandrews.
fixes #26440.


git-svn-id: https://develop.svn.wordpress.org/trunk@26708 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-05 23:42:05 +00:00
Andrew Nacin
74ea276315 Theme: When showing an author in the grid (during a search), don't include the author's link. 
fixes #26433.


git-svn-id: https://develop.svn.wordpress.org/trunk@26684 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-05 19:08:01 +00:00
Andrew Nacin
2cf98e4e00 Themes: Refine how we display the current theme. 
props shaunandrews, kwight, matveb.
see #26003.


git-svn-id: https://develop.svn.wordpress.org/trunk@26681 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-05 18:41:44 +00:00
Andrew Nacin
7750ea96cd Allow HTML in the theme name for the themes.php template. 
props matveb.
fixes #26411.


git-svn-id: https://develop.svn.wordpress.org/trunk@26638 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-04 21:40:20 +00:00
Andrew Nacin
0c0a90bfc1 For the current theme, display all available actions, as dictated by the admin menu. 
Restores 3.7 behavior. This could include things like Header and Background as well as theme options pages.

see #25948.


git-svn-id: https://develop.svn.wordpress.org/trunk@26531 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-02 18:57:32 +00:00
Dion Hulse
dd5f228729 Themes: Update notifiations shouldn't be a <a> if they're not links, data.update already contains <p> tags. See #25948 
git-svn-id: https://develop.svn.wordpress.org/trunk@26524 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-02 08:37:58 +00:00
Dion Hulse
4a62bbe5d8 Themes: Standardise on dot notation for object access in the Templates. See #25948 
git-svn-id: https://develop.svn.wordpress.org/trunk@26523 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-02 07:33:57 +00:00
Dion Hulse
ca6e76914f Themes: Remove some HTML from a new string and put it in the replacement value instead. See #25948 
git-svn-id: https://develop.svn.wordpress.org/trunk@26522 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-02 07:19:40 +00:00
Dion Hulse
91b903fb6d Themes: Indent the HTML for proper indentation after r26519 added an extra div. See #25961, #26192 
git-svn-id: https://develop.svn.wordpress.org/trunk@26520 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-02 07:13:11 +00:00
Dion Hulse
919b03d9ce Themes: Make the Theme Detail view div use more of the available viewport, Fix the Header and Footer in the viewport and only scroll the theme details, Prefix some more theme CSS classes. Props shaunandrews for the initial viewport patch. Fixes #25961, #26192 
git-svn-id: https://develop.svn.wordpress.org/trunk@26519 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-02 07:11:43 +00:00
Dion Hulse
0ef7e951d6 Themes: Add a updated Help text. Props designsimply & hanni. See #26285 
git-svn-id: https://develop.svn.wordpress.org/trunk@26517 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-02 03:22:03 +00:00
Sergey Biryukov
1d4807f7c5 Fix Customize link in theme info window. props kovshenin. see #25948. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26508 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-01 21:08:15 +00:00
Dominik Schilling (ocean90)
c52896dbae Themes: Fix HTML markup for screenshots. props kovshenin. fixes #25959. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26504 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-01 17:59:32 +00:00
Dominik Schilling (ocean90)
5ec5f0d9e2 Themes: Merge theme.css into wp-admin.css. fixes #25966. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26484 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-30 17:31:02 +00:00
Dominik Schilling (ocean90)
81557ba37c Themes: Add missing close tag, see [26462]. see #25959. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26473 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-29 17:16:46 +00:00
Dion Hulse
5b22bc3a50 Themes: Restore a label accidentally removed in r26470. Props SergeyBiryukov. See #25948 
git-svn-id: https://develop.svn.wordpress.org/trunk@26472 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-29 12:03:30 +00:00
Dion Hulse
66fb039ffe Themes: Do extra Cap checks before outputting links, and use full URI's. See #25948 
git-svn-id: https://develop.svn.wordpress.org/trunk@26470 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-29 09:00:23 +00:00
Dion Hulse
e937af37af Themes: Add a default image for when a theme doesn't have a screenshot. Props matveb. See #25959 
git-svn-id: https://develop.svn.wordpress.org/trunk@26462 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-29 04:03:30 +00:00
Dion Hulse
503b0e73c4 Themes: Display Activated/Deleted messages below the H2, before the Themes. See #26305 
git-svn-id: https://develop.svn.wordpress.org/trunk@26461 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-29 02:39:15 +00:00
Dion Hulse
23f2fbc433 Themes: Remove an unused Delete Theme link on the multiple view. See #25948 
git-svn-id: https://develop.svn.wordpress.org/trunk@26459 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-29 01:54:25 +00:00