Commit Graph

1367 Commits

Author SHA1 Message Date
Sergey Biryukov
ca40b4ef9f CSS Coding Standards: Use unitless values for line-height in wp-admin/css/install.css.
Props ianbelanger, pbiron, afercia.
Fixes #46513. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45465 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 11:52:20 +00:00
Sergey Biryukov
e9f7b9a81d CSS Coding Standards: Use unitless values for line-height in wp-admin/css/forms.css.
Props ianbelanger, pbiron, afercia.
Fixes #46512. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45464 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 11:48:09 +00:00
Andrea Fercia
79e2b83b8f Administration: Improve the Site Health tables layout for small screens.
Props immeet94, jankimoradiya, desrosj, shashank3105, chetan200891, Clorith, hedgefield.	
Fixes #46960.


git-svn-id: https://develop.svn.wordpress.org/trunk@45463 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-29 18:21:45 +00:00
Sergey Biryukov
663c2f6562 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/edit.css.
Props ianbelanger, pbiron, afercia.
Fixes #46511. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45462 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-29 16:04:38 +00:00
Sergey Biryukov
febf206326 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/dashboard.css.
Props ianbelanger, pbiron, afercia.
Fixes #46510. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45461 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-29 16:02:49 +00:00
Sergey Biryukov
84efe08557 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/customize-widgets.css.
Props ianbelanger, pbiron, afercia.
Fixes #46509. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45460 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-29 16:00:40 +00:00
Andrea Fercia
d013696652 Accessibility: Improve toggling the "Post locked" information visibility.
- effectively hides the "Post locked" information from assistive technologies
- when a post is locked, reveals the "Post locked" information without CSS animation
- the height CSS animation didn't work anyways after [24906]

See #24553.
Fixes #44946.


git-svn-id: https://develop.svn.wordpress.org/trunk@45417 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-25 17:14:29 +00:00
Sergey Biryukov
56b2957c2e CSS Coding Standards: Update unitless values for line-height in wp-admin/css/widgets.css with more precise calculations.
Props ianbelanger.
Fixes #46531.

git-svn-id: https://develop.svn.wordpress.org/trunk@45415 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-25 14:43:29 +00:00
Sergey Biryukov
1752bc29a7 CSS Coding Standards: Update unitless values for line-height in wp-admin/css/nav-menus.css with more precise calculations.
Props ianbelanger.
Fixes #46516.

git-svn-id: https://develop.svn.wordpress.org/trunk@45414 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-25 14:41:55 +00:00
John Blackbourn
a4d9f02eef I18N: Add a language icon next to language selectors.
This change means that users who can't read the site's current language can more easily identify controls that allow them to change either the site language or their own admin area language.

Props janak007, atlasmahesh, afercia, birgire, JoshuaWold

Fixes #43144


git-svn-id: https://develop.svn.wordpress.org/trunk@45402 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-24 20:42:06 +00:00
John Blackbourn
2756e6a27f Administration: Don't apply italic formatting to code blocks in setting descriptions.
Props chetan200891

Fixes #42651


git-svn-id: https://develop.svn.wordpress.org/trunk@45389 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-23 23:13:51 +00:00
Jonathan Desrosiers
c18460698f Privacy: Prevent email field for personal data requests from overflowing.
Props anischarolia, ianbelanger, afercia.
Fixes #46961.

git-svn-id: https://develop.svn.wordpress.org/trunk@45326 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-16 20:44:41 +00:00
Jonathan Desrosiers
cd511054a0 Menus: Fix alignment of menu actions on mobile.
In [41197], changes were made to improve the responsive view for the Menu Name field and Save buttons. This caused the Delete Menu button to be misaligned.

Props ianbelanger, audrasjb, afercia, mukesh27.
Fixes #47173.

git-svn-id: https://develop.svn.wordpress.org/trunk@45324 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-16 19:04:42 +00:00
Jonathan Desrosiers
b7a79cf126 Site Health: Improve alignment and spacing for section headers.
This changes the CSS for Site Health headers to use flexbox, which helps ensure the text is vertically aligned center and consistently spaced in both the Status and Info tabs. It also fixes an issue where the loading spinner GIF was cut off on smaller screens (originally reported in #47203.

Props Presskopp, odminstudios, kjellr, afercia, desrosj, hedgefield, ianbelanger, xavortm.
Fixes #47063.

git-svn-id: https://develop.svn.wordpress.org/trunk@45322 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-16 18:29:47 +00:00
Jonathan Desrosiers
851cb8b8f2 Site Health: Improve vertical alignment of icons in test result descriptions.
This change removes redundant CSS properties for different health check statuses in favor of utilizing the `.dashicons` class already in Core to define them more consistently. This also fixes the vertical alignment issues.

Props chetan200891, Clorith, desrosj.
Fixes #46940.

git-svn-id: https://develop.svn.wordpress.org/trunk@45309 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-15 14:24:15 +00:00
Andrea Fercia
cae0608a7f Accessibility: Improve the "skip links" position for medium and small screens.
Fixes #47065.


git-svn-id: https://develop.svn.wordpress.org/trunk@45301 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-09 21:10:20 +00:00
Jonathan Desrosiers
a72dd388f5 Administration: Prevent cards on the Tools page from overflowing on small screens.
Props anischarolia, mukesh27.
Fixes #46972.

git-svn-id: https://develop.svn.wordpress.org/trunk@45296 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-09 14:55:18 +00:00
Jonathan Desrosiers
6289d9e304 Help/About: Final 5.2 about page updates.
Use final image URLs and fix a bug in IE11 where images were being cut off.

Props afercia, SergeyBiryukov, ianbelanger, desrosj, audrasjb.
See #46901.

git-svn-id: https://develop.svn.wordpress.org/trunk@45287 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-07 17:18:34 +00:00
Jonathan Desrosiers
994950ea8c Help/About: Polish the About page for 5.2.
- The About page now uses a CSS grid to layout its design, making the page’s structure more obvious and hopefully easier for contributors in the future.
- Removes some code that is no longer used (such as videos, mejs elements, etc.).
- Update images.
- Unnecessary HTML is removed from a string on the page. This was a regression.
- Only users with the correct capability should be instructed to check their site status.
- Fixes the placement of commas.

Reviewed by melchoyce, afercia, jeremyfelt, and desrosj.

Props ryelle, melchoyce, cathibosco1, man4toman, SergeyBiryukov, afercia, ramiy, kjellr, tellyworth, earnjam, andreamiddleton, marybaum.
See #46901.

git-svn-id: https://develop.svn.wordpress.org/trunk@45278 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-02 15:43:10 +00:00
Jonathan Desrosiers
f33df7cde4 Help/About: Fix tab display issues.
This change restores About page tab heights and fixes bugs with the tab bottom border caused by [44905] and [45243].

Reviewed by SergeyBiryukov and desrosj.

Props ixkaito, ianbelanger, afercia, SergeyBiryukov.
See #46901.
Fixes #47075.

git-svn-id: https://develop.svn.wordpress.org/trunk@45276 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-02 10:36:02 +00:00
Gary Pendergast
3477102cec Admin: Add the text for the WordPress 5.2 About page.
This changes includes placeholder images for now, they'll be replaced by the final images before final release.

Props chanthaboune, melchoyce, karmatosed, pento, marybaum, birgire, earnjam, andreamiddleton.
See #46901.



git-svn-id: https://develop.svn.wordpress.org/trunk@45271 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-26 00:56:57 +00:00
Gary Pendergast
b074b74489 CSS: Remove the units from line-height properties in common.css.
Props ianbelanger, talldanwp.
Fixes #46493.



git-svn-id: https://develop.svn.wordpress.org/trunk@45243 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-18 06:01:56 +00:00
Andrea Fercia
e1022a6184 Site Health: Improve the accordions styles for small screens.
Also, changes the hex color values to lowercase.

Props subrataemfluence, man4toman, garrett-eclipse, chetan200891, mukesh27, melchoyce, karmatosed, Clorith.
Fixes #46949.


git-svn-id: https://develop.svn.wordpress.org/trunk@45229 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-17 10:59:12 +00:00
Andrea Fercia
f969e1dfd7 Administration: Improve the Site Health "Passed tests" button style for small screens.
Props chetan200891.
Fixes #46939.


git-svn-id: https://develop.svn.wordpress.org/trunk@45217 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-16 16:22:41 +00:00
Mel Choyce
1442389a75 Administration: Update chevron color in Site Health.
Props afercia.
Fixes #46934. See #46730.


git-svn-id: https://develop.svn.wordpress.org/trunk@45202 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-15 18:55:34 +00:00
Andrea Fercia
94af7683fe Administration: Add a chevron icon to the Site Health "Passed tests" button.
The chevron icon helps clarify what the button does.

Props garrett-eclipse, Clorith, xkon, melchoyce.
Fixes #46730.


git-svn-id: https://develop.svn.wordpress.org/trunk@45201 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-15 18:00:57 +00:00
Sergey Biryukov
5f93c86b84 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/customize-controls.css.
Props ianbelanger, audrasjb, pbiron, afercia.
Fixes #46494. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45189 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-13 04:36:01 +00:00
Sergey Biryukov
4de00af6f8 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/themes.css.
Props ianbelanger, mukesh27, audrasjb, pbiron, afercia.
Fixes #46518. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45188 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-13 04:31:08 +00:00
Sergey Biryukov
eb2f56da08 CSS Coding Standards: Use unitless values for line-height for count bubbles in wp-admin/css/admin-menu.css.
Missed in [45186].

Props ianbelanger.
See #46489, #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45187 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-13 04:19:52 +00:00
SergeyBiryukov
10112902ce CSS Coding Standards: Use unitless values for line-height in wp-admin/css/admin-menu.css.
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46489. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45186 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-13 00:16:01 +00:00
Andrew Ozz
05981179e4 Site health: Load the "Info" tab immediately and notify the user while gathering site data. Changes the Info tab to work similarly to the Status tab: it does separate request to fetch the directories sizes and doesn't "block" the loading of the page.
Props xkon, afercia, Clorith, azaozz.
See #46707.

git-svn-id: https://develop.svn.wordpress.org/trunk@45176 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 19:23:13 +00:00
Andrew Ozz
ac97906269 TinyMCE: Fix keyboard navigation when the dfw button is present but hidden. Ensure that button is added last in the DOM to match where it appears visually.
Props afercia, azaozz.
Fixes #46640.

git-svn-id: https://develop.svn.wordpress.org/trunk@45172 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 18:07:47 +00:00
Jonathan Desrosiers
94b6167a04 Site Health: Add missing actions to tests.
This change adds missing actions for several tests. This ensures that the user is provided with a next step, whenever possible.

Also, change the URL displayed in the WordPress.org communication test description to `api.wordpress.org` for accuracy.

Props: garrett-eclipse, Clorith, vaishalipanchal.
Fixes #46734.

git-svn-id: https://develop.svn.wordpress.org/trunk@45170 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 17:39:37 +00:00
Jonathan Desrosiers
3bba7f2f31 Site Health: Improve the test badge implementation.
Label badges for each Site Health test currently display in either red, orange, or green, regardless of if the test passed or failed. This is confusing, as seeing red labels in the “Passed Test” section could alarm users (when really everything is OK and no action is required), and seeing green labels in the “Failed Tests” section would not appropriately encourage the user to take appropriate action.

This change makes several improvements to the label badges:

- Always right align the badges for consistent display.
- Remove background fill for badges. Instead, use a border.
- Use a consistent styling for all tests (passed and failed).
- The text color no longer uses true black (#000000).
- The `.badge.pink` CSS definition has been switched to `.badge.purple`, and the definitions for blue, gray, and green have also been updated to more closely follow the official WordPress color palette.

Props: pbiron, garrett-eclipse, hedgefield, Clorith, xkon, melchoyce, mdwolinski, alexdenning.
Fixes #46623.

git-svn-id: https://develop.svn.wordpress.org/trunk@45169 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 17:03:24 +00:00
Andrea Fercia
af0242a37b Accessibility: Improve the image "Alternative Text" field in the Edit Media screen.
Brings parity with the changes for the Media Views introduced in [44900].
- moves the alt text field to the top as first field
- adds an explanatory text with a link pointing to the W3C "alt decision tree" tutorial
- adds `aria-describedby` to target the explanatory text
- adjusts the CSS and indentation

Props chetan200891.
Fixes #46875.


git-svn-id: https://develop.svn.wordpress.org/trunk@45158 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-10 19:59:16 +00:00
Andrea Fercia
36787a2716 Login and Registration: improve the CSS padding on the login input fields.
The right padding added in [44895] needs to be set only on the input fields in the Reset Password screen and exclude other login screens.

Amends [44895].
Fixes #42853.


git-svn-id: https://develop.svn.wordpress.org/trunk@45157 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-10 16:11:56 +00:00
Gary Pendergast
8eca6fd949 Site Health: Remove animated ellipsis from the status loading indicator.
This animation wasn't particularly reliable across browsers.

Props Clorith, afercia.
Fixes #46684.



git-svn-id: https://develop.svn.wordpress.org/trunk@45145 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 23:28:27 +00:00
Sergey Biryukov
965e7fa46e CSS Coding Standards: Use unitless values for line-height in wp-admin/css/color-picker.css.
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46492. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45131 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-07 05:53:37 +00:00
Sergey Biryukov
6ba1388522 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/about.css.
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46495. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45130 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-07 05:50:18 +00:00
Sergey Biryukov
1b69643969 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/customize-nav-menus.css.
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46495. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45129 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-07 05:48:05 +00:00
Sergey Biryukov
8c6239c27b CSS Coding Standards: Use unitless values for line-height in wp-admin/css/site-health.css.
Props mukesh27, ianbelanger, pbiron, afercia.
Fixes #46760. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45128 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-07 05:43:12 +00:00
Sergey Biryukov
bd25bc4473 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/nav-menus.css.
Props ianbelanger, audrasjb, pbiron, afercia.
Fixes #46516. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45123 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-06 16:09:42 +00:00
Felix Arntz
a511415d0a Administration: Improve user experience and clarify when in recovery mode.
This changeset introduces several changes around usability when recovery mode is active:

* Display a notice in the admin clarifying that the user is in recovery mode.
* Use a highlight color for the admin bar link to exit recovery mode.
* Exit recovery mode automatically when logging out.
* Include a recovery mode indicator in the title tag.

Props aandrewdixon, azaozz, dhanukanuwan, flixos90, henrywright, karmatosed, mapk, melchoyce, spacedmonkey, TimothyBlynJacobs, tinkerbelly.
See #46608.


git-svn-id: https://develop.svn.wordpress.org/trunk@45117 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-05 16:59:34 +00:00
Andrea Fercia
1e0ef359fc Administration: Site Health: reserve some space for the admin notices.
Props xkon, Clorith, hedgefield, mapk, karmatosed, afercia.
Fixes #46651.


git-svn-id: https://develop.svn.wordpress.org/trunk@45091 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-01 18:00:58 +00:00
Andrea Fercia
01bc0b9772 Accessibility: Improve the Site Health accordions.
- removes the definition list and uses the markup from the ARIA Authoring Practices example
- removes incorrect ARIA roles
- avoids ARIA landmark regions proliferation

Props mukesh27 for the initial patch.
Fixes #46714.


git-svn-id: https://develop.svn.wordpress.org/trunk@45087 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-01 15:07:30 +00:00
Andrea Fercia
d1dfe7c414 Coding Standards: Improve the Site Health CSS for small screens.
Amends #45071.
See #46685.


git-svn-id: https://develop.svn.wordpress.org/trunk@45074 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-30 14:08:45 +00:00
Andrea Fercia
d52f7c82c1 Administration: Improve the CSS for the Site Health pages header.
Avoids the Site Health pages header layout to break when the Hello Dolly plugin or other floated content is printed out at the top of the page.

Props xkon.
Fixes #46650.


git-svn-id: https://develop.svn.wordpress.org/trunk@45072 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-29 18:54:39 +00:00
Andrea Fercia
328c4f3432 Coding Standards: Clean up the Site Health stylesheet.
- reduces selectors specificity to avoid over-qualified selectors
- removes unused rulesets / properties
- renames some CSS classes

Fixes #46685.


git-svn-id: https://develop.svn.wordpress.org/trunk@45071 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-29 18:43:09 +00:00
Sergey Biryukov
692ecb1f97 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/widgets.css.
Props ianbelanger, audrasjb.
Fixes #46531. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45053 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-28 16:38:09 +00:00
Gary Pendergast
1ab6f67ef5 Site Health: Improve the "Copy to clipboard" button.
The previous method for copying the debug report to the clipboard involved having a hidden `<textarea>`, but this shows up in screen readers and can't be reliably hidden.

To work around this, the button now uses the `clipboard.js` library, which automatically handles browser differences in the Clipboard API, and can load the text to copy from a `data-` attribute on the button.

Props pento, hedgefield, afercia.
Fixes #46647.



git-svn-id: https://develop.svn.wordpress.org/trunk@45044 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-27 22:30:26 +00:00