vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2025-10-16 12:05:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
30,041 Commits 1 Branch 0 Tags 243 MiB
cda77232fe
Commit Graph

79 Commits

Author SHA1 Message Date
Andrew Nacin
cda77232fe Update comment caches in WP_Comment_Query, rather than comments template. 
props dd32.
fixes #31081.


git-svn-id: https://develop.svn.wordpress.org/trunk@32769 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-14 19:20:12 +00:00
Scott Taylor
39ef6a72c5 Use void instead of null where appropriate when pipe-delimiting @return types. If a @return only contains void, remove it. 
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32568 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-24 05:39:47 +00:00
Scott Taylor
abca40cf44 Add missing doc blocks to comment-template.php. 
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32567 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-24 05:18:59 +00:00
Sergey Biryukov
09bd58b4c9 In comment_form(), ensure that filtered arguments contain all required default values. 
props boonebgorges.
fixes #32312 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@32511 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-19 01:03:39 +00:00
Sergey Biryukov
2848b8a911 Replace echo __() with _e(). 
props marsjaninzmarsa.
fixes #32239.

git-svn-id: https://develop.svn.wordpress.org/trunk@32333 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-03 16:17:06 +00:00
Helen Hou-Sandi
3fb766782d Don't add a class for comment authors who are members of the current site. 
Reverts [32245] and [31518]. We'll keep the whitespace and comment clarification, though.

see #24054.


git-svn-id: https://develop.svn.wordpress.org/trunk@32259 602fd350-edb4-49c9-b593-d223f7449a82
 2015-04-21 23:35:55 +00:00
Helen Hou-Sandi
10640611f6 Comment: rename the comment-author-is-site-member class to bysiteuser for consistency. 
Final decision on keeping the class yet to be made.

props DrewAPicture.
see #24054.


git-svn-id: https://develop.svn.wordpress.org/trunk@32245 602fd350-edb4-49c9-b593-d223f7449a82
 2015-04-21 14:19:58 +00:00
Drew Jaynes
e984069608 Remove backtick-escaping around a core function in the hook docs for the comment_form_submit_field filter. 
See [31699]. See #31888.


git-svn-id: https://develop.svn.wordpress.org/trunk@32037 602fd350-edb4-49c9-b593-d223f7449a82
 2015-04-05 15:38:57 +00:00
Dominik Schilling (ocean90)
a3f6767a45 Comments: Move HTML tags for screen reader text into translatable strings. 
Placeholders aren't helpful and it's much easier to make a mistake if you're dealing with placeholders.
Introduced in [31388].

props pento.
fixes #26553.

git-svn-id: https://develop.svn.wordpress.org/trunk@31821 602fd350-edb4-49c9-b593-d223f7449a82
 2015-03-18 21:51:36 +00:00
Drew Jaynes
b9cb22f888 Add a changelog entry to the DocBlock for comment_form() for the class_submit argument added in 4.1. 
See [29809]. See #20446.


git-svn-id: https://develop.svn.wordpress.org/trunk@31803 602fd350-edb4-49c9-b593-d223f7449a82
 2015-03-17 18:37:12 +00:00
Boone Gorges
8072fe7db6 Improved customizability for the Submit button in comment_form(). 
The new 'submit_button' and 'submit_field' parameters for `comment_form()`
allow developers to modify the markup of the submit button and its wrapper.
These params are accompanied by targeted 'comment_form_submit_button' and
'comment_form_submit_field' filters on the concatenated markup.

Props coffee2code, morpheu5, DrewAPicture, boonebgorges.
Fixes #15015.

git-svn-id: https://develop.svn.wordpress.org/trunk@31699 602fd350-edb4-49c9-b593-d223f7449a82
 2015-03-10 19:07:31 +00:00
Jeremy Felt
a86c3114ae Add comment-author-is-site-member class to comment output for site members. 
Add a class to allow targeting of comments made by members of a site rather than users of the entire network.

Props Viper007Bond, MikeHansenMe.

Fixes #24054.


git-svn-id: https://develop.svn.wordpress.org/trunk@31518 602fd350-edb4-49c9-b593-d223f7449a82
 2015-02-23 02:51:49 +00:00
Sergey Biryukov
5aac59d178 Replace hardcoded usage of comment-page with the comment pagination base. 
props johnbillion, SergeyBiryukov, webord.
fixes #18084.

git-svn-id: https://develop.svn.wordpress.org/trunk@31459 602fd350-edb4-49c9-b593-d223f7449a82
 2015-02-14 03:47:02 +00:00
Sergey Biryukov
5d35c181dc Add .comment-reply-login class to get_post_reply_link(), for consistency with get_comment_reply_link(). 
props johnjamesjacoby.
fixes #31298.

git-svn-id: https://develop.svn.wordpress.org/trunk@31412 602fd350-edb4-49c9-b593-d223f7449a82
 2015-02-11 16:10:54 +00:00
Sergey Biryukov
c8a361712b Switch to a string placeholder, as number_format_i18n() returns a string. 
see #26553.

git-svn-id: https://develop.svn.wordpress.org/trunk@31402 602fd350-edb4-49c9-b593-d223f7449a82
 2015-02-10 05:44:21 +00:00
Sergey Biryukov
74ad70419e Use _n() in comments_popup_link() when setting the default string to display if there are more than one comment. 
see #26553.

git-svn-id: https://develop.svn.wordpress.org/trunk@31401 602fd350-edb4-49c9-b593-d223f7449a82
 2015-02-10 02:50:58 +00:00
Aaron Jorbin
5abd98618d Add translator comments for new strings. 
These strings were added in [31388].

Props ocean90.
Fixes 26553.



git-svn-id: https://develop.svn.wordpress.org/trunk@31389 602fd350-edb4-49c9-b593-d223f7449a82
 2015-02-09 20:14:19 +00:00
Aaron Jorbin
cf09359d34 Use screen reader text instead of a title attribute in comments_popup_link 
To better understand screen reader text, check out https://make.wordpress.org/accessibility/2015/02/09/hiding-text-for-screen-readers-with-wordpress-core/

Screen Reader text improves the user experience for screen reader users. It provides additional context for links, document forms and other pieces of a page that may exist visually, but are lost when looking only at the html of a site.  This does change the output of comments_popup_link if you don't pass in values for $zero, $one, $more or $none. Theme authors can and should style <code>.screen-reader-text</code> in ways that are recommended in the above article to hide it visually.

Props joedolson
Fixes #26553





git-svn-id: https://develop.svn.wordpress.org/trunk@31388 602fd350-edb4-49c9-b593-d223f7449a82
 2015-02-09 19:26:56 +00:00
Scott Taylor
db1ace58ca In comment_form(), add the HTML5 required attribute next to aria-required in fields that utilize it. 
Props MMN-o.
Fixes #24732.


git-svn-id: https://develop.svn.wordpress.org/trunk@31204 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 15:55:50 +00:00
Sergey Biryukov
c96947757a Remove a redundant inline comment with a typo. 
props nicnicnicdevos.
fixes #30956.

git-svn-id: https://develop.svn.wordpress.org/trunk@31103 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 21:28:11 +00:00
Scott Taylor
6fd11624d1 The keyword elseif should be used instead of else if so that all control keywords look like single words. 
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs. 

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31090 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 07:04:40 +00:00
Scott Taylor
fdef2cc755 Remove whitespace side effects from comment_form(). 
Props timersys.
Fixes #30500.


git-svn-id: https://develop.svn.wordpress.org/trunk@31036 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-03 06:26:38 +00:00
Drew Jaynes (DrewAPicture)
205a43ed05 Correctly capitalize JavaScript throughout core docs. 
Fixes #30569.


git-svn-id: https://develop.svn.wordpress.org/trunk@30695 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-02 00:30:59 +00:00
Scott Taylor
4d46475b3d Improve various @param docs for src/wp-includes/*. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30681 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-01 01:33:34 +00:00
Drew Jaynes (DrewAPicture)
e587324180 Docs Formatting: Backtick-escape inline code for all remaining dynamic hook docs in wp-includes/*. 
Affects DocBlocks for the following hooks:
* `auth_post_meta_{$meta_key}`
* `term_links-$taxonomy`
* `customize_render_control_ . $this->id`
* `customize_render_panel_{$this->id}`
* `customize_render_section_{$this->id}`
* `customize_preview_{$this->id}`
* `customize_save_ . $this->id_data[ 'base' ]`
* `customize_update_ . $this->type`
* `customize_value_ . $this->id_data[ 'base' ]`
* `customize_sanitize_js_{$this->id}`
* `comment_form_field_{$name}`
* `comment_{$old_status}_to_{$new_status}`
* `comment_{$new_status}_{$comment->comment_type}`
* `extra_{$context}_headers`
* `get_template_part_{$slug}`
* `get_the_generator_{$type}`
* `get_{$adjacent}_post_join`
* `get_{$adjacent}_post_where`
* `get_{$adjacent}_post_sort`
* `{$adjacent}_post_rel_link`
* `{$adjacent}_post_link`
* `{$adjacent}_image_link`
* `blog_option_{$option}`
* `$permastructname . _rewrite_rules`
* `{$type}_template`
* `theme_mod_{$name}`
* `pre_set_theme_mod_$name`
* `current_theme_supports-{$feature}`
* `get_user_option_{$option}`
* `edit_user_{$field}`
* `pre_user_{$field}`
* `user_{$field}`

See #30552.


git-svn-id: https://develop.svn.wordpress.org/trunk@30656 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-30 12:09:56 +00:00
Drew Jaynes (DrewAPicture)
f240af96da 4.1 Docs Audit: Various formatting fixes for inline documentation in class-wp-list-table.php and comment-template.php. 
See #30469.


git-svn-id: https://develop.svn.wordpress.org/trunk@30610 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-28 11:21:40 +00:00
Peter Westwood
7e349ec5c4 Fix the passing of commenter cookie data to the comment API so that we don't try and fetch all unapproved comments for users with no-email address when we only have an author. 
Fixes #19623


git-svn-id: https://develop.svn.wordpress.org/trunk@30547 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-24 10:50:38 +00:00
Drew Jaynes (DrewAPicture)
ad50389634 Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented. 
Affects DocBlocks for the following core elements:
* Remove HTML tag from parameter description in `comment_form()`
* Remove HTML tag from a summary for the `comment_form_top` hook
* Markdown-indent a code snippet in the description for `get_linkobjectsbyname()`
* Markdown-indent a code snippet and format an unordered list in the description for `get_linkobjects()`
* Backtick-escape some inline code in the description for `clean_pre()`
* Remove HTML tag from the summary for the `rss_tag_pre` hook
* Various formatting fixes in the descriptions for `get_filesystem_method()` and `request_filesystem_credentials()`

Props rarst for the initial patch.
See #30473.


git-svn-id: https://develop.svn.wordpress.org/trunk@30538 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-24 05:18:56 +00:00
Drew Jaynes (DrewAPicture)
325c0622c9 Update the changelogs for the comment hook parameters added in [30092]. 
Parameters were added to the `get_comment_author`, `comment_author`, `get_comment_author_email`, `author_email`, `comment_email`, `get_comment_author_link`, `get_comment_author_IP`, `get_comment_author_url`, `comment_url`, `get_comment_excerpt`, `comment_excerpt`, `get_comment_ID`, and `get_comment_type` filters.

Fixes #22380.


git-svn-id: https://develop.svn.wordpress.org/trunk@30111 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-30 03:51:28 +00:00
Peter Westwood
ed19e5a1f3 Comment Template Tags: Improve the availability of context information in comment template tag filters. 
Fixes #22380 props momo360modena, tareq1988.


git-svn-id: https://develop.svn.wordpress.org/trunk@30092 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-29 19:07:00 +00:00
Sergey Biryukov
2672e35d43 Add 'comment_reply_link_args' filter for get_comment_reply_link() arguments. 
props joedolson, aaroncampbell, DrewAPicture.
fixes #10569.

git-svn-id: https://develop.svn.wordpress.org/trunk@30039 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-27 11:44:40 +00:00
Boone Gorges
348c8958da Use the comment API rather than direct SQL queries in comments_template(). 
`comments_template()` is used by most themes to display a post's comments. It
shows all comments that have been approved, and also shows all pending comments
by the current visitor (as determined by the comment cookies). However, the
comments API previously had no way of querying for "all comments that are
either approved, or are unapproved but written by foo@example.com". The
workaround was a direct SQL query: uncached, not subject to the same filters as
other comment queries, and just generally icky.

The new `include_unapproved` parameter for `WP_Comment_Query` accepts an array
of user IDs or email addresses. Pending comments associated with users in this
array will be included in query results, regardless of the value of the 'status'
parameter. In `comments_template()`, we leap from direct SQL queries to
`get_comments()` plus `include_unapproved', striving to put right what once
went wrong.

Props boonebgorges, simonwheatley, hardy101, jesin.
Fixes #19623.

git-svn-id: https://develop.svn.wordpress.org/trunk@29965 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-19 19:38:16 +00:00
Dominik Schilling (ocean90)
5d7e30e7d9 Comments: Don't print an empty HTML markup when comment_reply_link() returns no link. 
props obenland.
fixes #29895.

git-svn-id: https://develop.svn.wordpress.org/trunk@29908 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-15 21:55:31 +00:00
Sergey Biryukov
564598f068 Add aria-describedby attributes to comment_form(). 
props joedolson, bramd.
fixes #24148.

git-svn-id: https://develop.svn.wordpress.org/trunk@29846 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-06 22:10:08 +00:00
Sergey Biryukov
dc62eeff36 Make link construction in get_comment_reply_link() and get_post_reply_link() more readable. 
see #16433.

git-svn-id: https://develop.svn.wordpress.org/trunk@29823 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-02 20:44:34 +00:00
Sergey Biryukov
07cf5c5c76 Add an aria-label attribute with commenter's name to get_comment_reply_link(). 
props joedolson, merty, andrewryno.
fixes #16433.

git-svn-id: https://develop.svn.wordpress.org/trunk@29822 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-02 20:40:35 +00:00
Sergey Biryukov
6dca7d1023 Add a class attribute for submit button in comment form. 
props bainternet.
fixes #20446.

git-svn-id: https://develop.svn.wordpress.org/trunk@29809 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-02 01:43:32 +00:00
Scott Taylor
f0318988c4 Correct a few @param docs for $walker. 
Props dnaber-de.
Fixes #29011.


git-svn-id: https://develop.svn.wordpress.org/trunk@29293 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-24 22:24:07 +00:00
Drew Jaynes (DrewAPicture)
551f829c55 Inline documentation cleanup for 4.0 audit. 
Various improvements:
* Adds `@see` reference for `wp_list_comments()` in 'wp_list_comments_args' filter docs, added in [28285]
* Various phpDoc tweaks for the 'run_wptexturize' filter docs, added in [28715]
* Sentence and wrapping changes for `is_https_url()`, added in [28894]
* Documents the `$args` parameter for `wp_dropdown_languages()`, added in [29007]
* Adds a period to the parameter description for `_update_posts_count_on_delete()`, added in [28835]
* Documents a global in `is_customize_preview()`, added in [28999]
* phpDoc tweaks, adds an access modifier for `wpdb::esc_like()`, added in [28711]

See #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29163 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-14 01:01:22 +00:00
Scott Taylor
3cda5caafd Revert [28563]. See #18298. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29044 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-09 18:06:54 +00:00
Drew Jaynes (DrewAPicture)
b1b454c7a0 Remove backticks on $post variables in some short parameter descriptions. 
See [28653], [28654].
See #28388.


git-svn-id: https://develop.svn.wordpress.org/trunk@28976 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-03 19:27:54 +00:00
Scott Taylor
be32c3485a Add a function, get_comments_number_text(), that returns instead of echoing. comments_number() wraps it. 
Props kapeels, nbachiyski.
Fixes #10177.


git-svn-id: https://develop.svn.wordpress.org/trunk@28912 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-29 23:12:34 +00:00
Scott Taylor
73fe9d548b Ensure that a has_children parameter is given to Walker::start_el(). 
Adds unit tests.

Props scribu, obenland.
Fixes #14041.


git-svn-id: https://develop.svn.wordpress.org/trunk@28824 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-24 17:05:56 +00:00
Scott Taylor
76bd35fa79 In comment_form(), allow name_submit to be passed to change the name attribute of the submit button. 
Props obenland.
Fixes #22792.


git-svn-id: https://develop.svn.wordpress.org/trunk@28813 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-24 00:09:51 +00:00
Drew Jaynes (DrewAPicture)
d068c888f3 Ensure $post_id is documented as optional where applicable. 
See #28388.


git-svn-id: https://develop.svn.wordpress.org/trunk@28654 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-03 04:43:47 +00:00
Scott Taylor
3d48e21248 Fix an error caused by [28604] in get_comments_number() unit tests. 
Props SergeyBiryukov.
Fixes #26240.



git-svn-id: https://develop.svn.wordpress.org/trunk@28638 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-30 19:46:05 +00:00
Dominik Schilling (ocean90)
0af37cccdb Pass $post->ID to get_comments_number filter. 
Also fixes indentation and a typo in corresponding filter docs.

see #26240.

git-svn-id: https://develop.svn.wordpress.org/trunk@28604 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-28 22:35:21 +00:00
Drew Jaynes (DrewAPicture)
d201ded99e Fix parameter description for the $post_id argument in get_comments_number() to note that it is optional. 
Also fixes the corresponding filter docs, as `$post_id`, not `$post` is passed to the filter.

See [27156]. Fixes #26240.


git-svn-id: https://develop.svn.wordpress.org/trunk@28602 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-28 22:04:59 +00:00
Scott Taylor
70f735669a Replaces all uses of TEMPLATEPATH and STYLESHEETPATH in core with get_template_directory() and get_stylesheet_directory(). 
Add `@deprecated` annotations to `TEMPLATEPATH` and `STYLESHEETPATH` definitions.

Props obenland, aaroncampbell. 
Fixes #18298.


git-svn-id: https://develop.svn.wordpress.org/trunk@28563 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-23 20:11:08 +00:00
Scott Taylor
1061a15eaf Allow get_comments_number() to officially accept $post or $post_id. Adds unit tests. 
Props coffee2code, JanHenkG.
Fixes #26240.


git-svn-id: https://develop.svn.wordpress.org/trunk@28558 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-23 17:43:03 +00:00