Commit Graph

4190 Commits

Author SHA1 Message Date
Weston Ruter
cfd07d69cf Customize: Fix toggle of title attribute field visibility on nav menus admin page.
Improves alignment with nav menus in the Customizer, fixing regression introduced in [36908].

See #35273.
Props sidati, westonruter.
Fixes #36353.


git-svn-id: https://develop.svn.wordpress.org/trunk@37153 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-30 21:54:45 +00:00
Weston Ruter
0bc533e10b Customize: Put focus on change button instead of remove button in media control.
Allow controls to specify the primary element to receive focus by adding a `control-focus` class.

Props adamsilverstein, westonruter.
Fixes #36337.


git-svn-id: https://develop.svn.wordpress.org/trunk@37152 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-30 21:40:43 +00:00
Aaron Jorbin
565ac1efc6 Remove Debugging code introduced in [37145]
git-svn-id: https://develop.svn.wordpress.org/trunk@37148 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-30 18:57:26 +00:00
Aaron Jorbin
bd0c3bf0c7 Add Nonce to updating wporg_favorites user meta field
git-svn-id: https://develop.svn.wordpress.org/trunk@37145 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-30 18:35:37 +00:00
Nikolay Bachiyski
f1680acb86 Add nonce to AJAX action for script compression setting
git-svn-id: https://develop.svn.wordpress.org/trunk@37143 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-30 18:20:31 +00:00
Jeremy Felt
914df85ab4 Multisite: Improve escaping in network settings.
git-svn-id: https://develop.svn.wordpress.org/trunk@37124 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-30 15:58:29 +00:00
Dominik Schilling (ocean90)
7987d26847 Multisite: Validate new email address confirmations.
git-svn-id: https://develop.svn.wordpress.org/trunk@37103 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-30 14:44:00 +00:00
Pascal Birchler
b4c43b0005 Taxonomy: After [36874], run the correct load-edit-tags.php hook on the new term edit page.
When not misspelled, this hook is useful (and needed) for backward compatibility.

Unprops swissspidy.
Fixes #34988.

git-svn-id: https://develop.svn.wordpress.org/trunk@37084 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-27 15:15:48 +00:00
Dominik Schilling (ocean90)
f903fb5160 Common CSS: Reset bottom padding for .nav-tab-wrapper.
Props ericdaams.
Fixes #35960.

git-svn-id: https://develop.svn.wordpress.org/trunk@37073 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-23 20:13:57 +00:00
Weston Ruter
43b9dedeea Customize: Prevent preview iframe from showing until fully loaded.
Fixes issue where the Customizer preview window can appear to momentarily bounce to the top when being refreshed. Regression from [36532].

See #31195.
Fixes #36276.


git-svn-id: https://develop.svn.wordpress.org/trunk@37060 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-23 00:52:20 +00:00
Dominik Schilling (ocean90)
6c0a66cf49 Users: In edit_user() check for a blank password when adding a user.
Props wesleye, gitlost, adamsilverstein.
Fixes #35715.

git-svn-id: https://develop.svn.wordpress.org/trunk@37059 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-22 23:06:29 +00:00
Weston Ruter
4569f93d3e Customize: Require opt-in for selective refresh of widgets.
* Introduces `customize-selective-refresh-widgets` theme support feature and adds to themes.
* Introduces `customize_selective_refresh` arg for `WP_Widget::$widget_options` and adds to all core widgets.
* Remove `selective_refresh` from being a component that can be removed via `customize_loaded_components` filter.
* Add `WP_Customize_Widgets::get_selective_refreshable_widgets()` and `WP_Customize_Widgets::is_widget_selective_refreshable()`.
* Fix default `selector` for `Partial` instances.
* Implement and improve Masronry sidebar refresh logic in Twenty Thirteen and Twenty Fourteen, including preservation of initial widget position after refresh.
* Re-initialize ME.js when refreshing `Twenty_Fourteen_Ephemera_Widget`.

See #27355.
Fixes #35855.


git-svn-id: https://develop.svn.wordpress.org/trunk@37040 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-21 21:58:02 +00:00
Andrew Ozz
058a2f558d Media: fix erroneously inserting a rel attribute in get_image_send_to_editor(). Reverts most of [34259] and [34260] and adds a unit test.
Props joemcgill, azaozz.
Fixes #36084.

git-svn-id: https://develop.svn.wordpress.org/trunk@37035 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-18 20:04:19 +00:00
Dominik Schilling (ocean90)
b0302d4d30 I18N: Move translatable Codex URLs to separate strings in wp-admin/includes/meta-boxes.php.
Props ramiy.
Fixes #35751.

git-svn-id: https://develop.svn.wordpress.org/trunk@37016 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-16 16:57:36 +00:00
Andrew Ozz
3858c09d02 Editor: fix exiting DFW with the keyboard shortcut on Mac (Opt+Ctrl+W).
Fixes #36222.

git-svn-id: https://develop.svn.wordpress.org/trunk@37003 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-16 02:47:29 +00:00
John Blackbourn
6152c81dd1 Docs: The $update_result parameter passed to WP_Automatic_Updater::after_core_update() is never a WP_Error. If an error is returned, the error object lives in the result property of the paramter.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@36995 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-14 22:42:36 +00:00
Sergey Biryukov
f653932157 Media: Fix typo introduced in [36887].
Props claudiosanches.
Fixes #36230. See #36089.

git-svn-id: https://develop.svn.wordpress.org/trunk@36987 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-14 08:59:49 +00:00
Andrew Ozz
289e9473df TinyMCE, inline link:
- Remove unused user setting for wpLink.
- Remove redundant text and variable from wp_link_dialog().

Props afercia, azaozz.
See #33301.

git-svn-id: https://develop.svn.wordpress.org/trunk@36985 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-14 01:38:09 +00:00
Eric Andrew Lewis
7552b192a8 Editor: Fix Mac keyboard shortcut for distraction free writing.
Fixes #36214.


git-svn-id: https://develop.svn.wordpress.org/trunk@36973 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-12 17:43:33 +00:00
Andrew Ozz
b68a4e3da6 Editor: hide the Move to Trash link for auto-drafts until they are auto-saved.
Props iseulde.
Fixes #16116.

git-svn-id: https://develop.svn.wordpress.org/trunk@36972 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-12 17:21:52 +00:00
Andrew Ozz
9d753fbf5a Editor: correct and update the Visual and Text editors description in the screen help.
Props arush, adamsilverstein, azaozz.
Fixes #35479.

git-svn-id: https://develop.svn.wordpress.org/trunk@36971 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-12 16:42:14 +00:00
Dominik Schilling (ocean90)
39ddaa65cc Docs: Correct grammar when referring to "a URL" vs "an URL" in several places.
Fixes #36218.

git-svn-id: https://develop.svn.wordpress.org/trunk@36970 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-12 12:38:48 +00:00
Pascal Birchler
91d4bbd041 Taxonomy: After [36874], rename $term_id to $tag_ID in wp-admin/edit-tag-form.php.
This ensures that no variables changed in the process of introducing `wp-admin/term.php`, improving overall backward compatibility.

Props Chouby for initial patch.
Fixes #34988.

git-svn-id: https://develop.svn.wordpress.org/trunk@36969 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-11 08:51:13 +00:00
Andrea Fercia
f4ee598def Coding standards after [36510].
git-svn-id: https://develop.svn.wordpress.org/trunk@36967 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 23:17:46 +00:00
Andrea Fercia
2a2539402f Accessibility: Improve accessibility for the Plugin details modal.
The plugin details modal can be invoked from several screens. There's now a new
`.open-plugin-details-modal` CSS class to be used in combination with the
`.thickbox` CSS class that adds everything needed for accessibility.

- Adds an ARIA role `dialog` and an `aria-label` attribute to the modal
- Adds a `title` attribute to the iframe inside the modal
- Constrains tabbing within the modal
- Restores focus back in a proper place when closing the modal

Also, improves a bit the native Thickbox implementation: it should probably be
replaced with some more modern tool but at least keyboard focus should be moved
inside the modal.

Fixes #33305.

git-svn-id: https://develop.svn.wordpress.org/trunk@36964 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 22:36:25 +00:00
Andrea Fercia
474c7da237 Accessibility: Improve the color contrast ratio of the expandable panel "handles".
Fixes #35923.

git-svn-id: https://develop.svn.wordpress.org/trunk@36959 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 21:44:00 +00:00
Rachel Baker
55cda28b18 Comments: On the Edit Comment screen do not show the permalink for unapproved comments.
Fixes #36161.

git-svn-id: https://develop.svn.wordpress.org/trunk@36958 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 21:17:57 +00:00
Dominik Schilling (ocean90)
73a88ca194 Editor: Fix size of the resize handle on RTL sites for HiDPI screens.
Also, add the `/*rtl:ignore*/` control directive so rtlcss doesn't process them again.

Fixes #36193.

git-svn-id: https://develop.svn.wordpress.org/trunk@36934 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 14:05:41 +00:00
Gary Pendergast
28a6bf00f7 About: Run w-logo-white.png through imagemin.
See #35661.



git-svn-id: https://develop.svn.wordpress.org/trunk@36929 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 05:15:33 +00:00
Jeremy Felt
91513893c2 Posts: Call set_url_scheme() consistently on URLs passed through preview_post_link
After [34170], some preview URLs that passed through `set_url_scheme()` no longer do so. We can restore that behavior by applying `set_url_scheme()` whenever `get_preview_post_link()` provides the URL.

Props danielbachhuber.
Fixes #35407.


git-svn-id: https://develop.svn.wordpress.org/trunk@36926 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 04:41:34 +00:00
Konstantin Obenland
6d951b3c5d Customize: Only add custom logo’s header text control if needed.
Dissolves `WP_CustomLogo` and adopts a structure similar to custom header and background (See `_delete_attachment_theme_mod()`).
The option to hide header text only gets added if it’s not already part of custom header, and only if selectors have been registered when theme support for custom logos was declared. Themes can add `postMessage` support for it as well.

Example:
{{{
add_theme_support( 'custom-logo', array(
    'size' => ‘large’,
    'header-text' => array( 'site-title', 'site-description' ),
) );
}}}

See #33755.


git-svn-id: https://develop.svn.wordpress.org/trunk@36915 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-09 23:43:49 +00:00
Mel Choyce
14d0424513 About: Improve color contrast of WP Badge text, and update the logo to use the latest version.
Fixes #35661.
Props @hugobaeta.


git-svn-id: https://develop.svn.wordpress.org/trunk@36910 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-09 21:52:29 +00:00
Weston Ruter
7ececb24f5 Customize: Fix persistence of toggles for displayed nav menu item properties.
* Eliminates need to click more than one checkbox to have preferences saved.
* Adds debouncing to saving user-selected menu item properties.
* Also removes discrepancies between available nav menu item properties on admin page vs Customizer.

Fixes #35273.
Props afercia, westonruter.


git-svn-id: https://develop.svn.wordpress.org/trunk@36908 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-09 21:40:27 +00:00
Konstantin Obenland
326806a961 Customize: Reduce vertical space of site icon control.
Makes the control easier to find, reduces visual clutter, and is more
consistent with Customizer UI conventions.

Props celloexpressions.
Fixes #35943.


git-svn-id: https://develop.svn.wordpress.org/trunk@36907 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-09 21:18:53 +00:00
Andrea Fercia
7e71bb398c Accessibility: Reduce the WordPress shades of grey, Episode 3.
Also, removes some no more used CSS.

See #35783.

git-svn-id: https://develop.svn.wordpress.org/trunk@36904 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-09 19:50:28 +00:00
Sergey Biryukov
11c47a6cb5 Use admin_url() for "Add New" links in wp-admin/users.php.
Props johnjamesjacoby.
Fixes #36186.

git-svn-id: https://develop.svn.wordpress.org/trunk@36902 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-09 19:08:58 +00:00
Sergey Biryukov
96520194c7 Use admin_url() for "Add New" links in wp-admin/upload.php.
Props johnjamesjacoby.
See #36186.

git-svn-id: https://develop.svn.wordpress.org/trunk@36901 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-09 19:08:12 +00:00
Dominik Schilling (ocean90)
6a8cb09f86 Media: Change wording for media files which aren't attached.
The media library can contain files which aren't attached yet. When attaching a file you currently get "Media attachment reattached.", or the opposite "Media attachment detached.". That's redundant and can be inaccurate. It's also not easy to translate in some languages.

This change generalizes the strings to refer to a "media file" instead.

Props SergeyBiryukov, ocean90, netweb.
Fixes #36089.

git-svn-id: https://develop.svn.wordpress.org/trunk@36887 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-08 17:42:45 +00:00
Andrea Fercia
137bcc1fca Accessibility: Remove the title attributes from the old Media UI.
Also, adds better indication and attributes for the required form fields.
Moves some styles to `deprecated-media.css`.

Props andg, afercia.
Fixes #34944.

git-svn-id: https://develop.svn.wordpress.org/trunk@36879 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-07 22:28:15 +00:00
Drew Jaynes
6012464446 Docs: Add a missing @since version to the DocBlock for wp_add_dashboard_widget().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36878 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-07 22:16:56 +00:00
Andrea Fercia
d92e10fbb1 Customizer: Improve the collapsed view when switching to the responsive view.
Props rittesh.patel, afercia.

Fixes #35220.

git-svn-id: https://develop.svn.wordpress.org/trunk@36877 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-07 22:04:29 +00:00
Pascal Birchler
3a51ff4d2e Taxonomy: Improve backward compatibility on the wp-admin/term.php page.
Specifically, run `do_action( 'edit-tags.php' );` on this new term edit page introduced in [36308]. Changes the GET param back to `tag_ID` and properly sets the screen base in `WP_Screen`.

See #34988.

git-svn-id: https://develop.svn.wordpress.org/trunk@36874 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-07 12:55:04 +00:00
Dion Hulse
e9dbf32553 Setup config: Generate the default secret keys & salts from the local CSPRNG if available, falling back to the WordPress.org API and a backup psuedo random source.
Props diddledan.
Fixes #35290


git-svn-id: https://develop.svn.wordpress.org/trunk@36872 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-07 06:31:18 +00:00
Andrea Fercia
b723d3fb75 CSS: Rename the handle for deprecated-media.css after [36341].
The `media` handle is now used for `media.css` thus the stylesheet
for the old media UI needs a different handle name.

See #35229.

git-svn-id: https://develop.svn.wordpress.org/trunk@36869 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-06 15:37:25 +00:00
Sergey Biryukov
74da332c40 Docs: Add wp_add_dashboard_widget() parameter descriptions.
Props meitar for initial patch.
Fixes #36092.

git-svn-id: https://develop.svn.wordpress.org/trunk@36868 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-06 12:07:34 +00:00
Weston Ruter
52d50a6ce9 Customize: Fix image cropping when doing live preview of theme switches.
Ensure that the Customizer gets bootstrapped with the pre-activated `theme` supplied in the `custom-header-crop` admin ajax requests.

Props faishal, rittesh.patel.
Fixes #32783.


git-svn-id: https://develop.svn.wordpress.org/trunk@36866 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-06 01:44:53 +00:00
Dominik Schilling (ocean90)
e5556666cc Themes: Bring the device preview from [31195] to the theme install previewer.
Props celloexpressions.
Fixes #36017.

git-svn-id: https://develop.svn.wordpress.org/trunk@36858 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-05 22:06:57 +00:00
John Blackbourn
48959ec76e Posts, Post Types: Ensure that non-ASCII characters in attachment slugs aren't shown in urlencoded form in the sample permalink UI.
Fixes #35980


git-svn-id: https://develop.svn.wordpress.org/trunk@36853 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-05 03:55:33 +00:00
Eric Andrew Lewis
ae1c49027a Menus: Ensure theme location setting data is saved with a large menu.
[36510] introduced a fix to allow users to save large menus on the Edit Menu screen (70+ menu items). The form data is stored as JSON which is used to inject the `$_POST` variable in the form submission handler. This injection was not setting form items with named array elements properly (e.g. `menu-locations[primary]`), which did not save theme location data in a large form.

Props keraweb.
See #14134.


git-svn-id: https://develop.svn.wordpress.org/trunk@36852 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-05 00:46:45 +00:00
Weston Ruter
084772af80 Customize: Eliminate unnecessary WP_Customize_Site_Logo_Control in favor of re-using WP_Customize_Image_Control.
* Removes double `margin-bottom` from all the media controls.
* All media controls now send `{settingId}-attachment-data` messages to the preview when a media setting is updated so that the preview has access to the attachment data.
* Fixes receiving of `attachment-data` message for `custom_logo` which resulted in instant JS-applied preview not working. See #36096.

See #33755.
Fixes #35941.


git-svn-id: https://develop.svn.wordpress.org/trunk@36851 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-04 23:46:07 +00:00