This changeset capitalizes the letter of keyboard shortcuts and replaces `CTRL` with `Ctrl`, for better consistency.
Props Presskopp, sabernhardt, joyously, SergeyBiryukov, audrasjb.
Fixes#40582.
git-svn-id: https://develop.svn.wordpress.org/trunk@52808 602fd350-edb4-49c9-b593-d223f7449a82
This changeset removes the Live Preview link for block-based themes when installing for a zip archive, since the customizer is disabled by default for block themes.
Follow-up to [52353].
Props alanjacobmathew, hellofromTonya, antonvlasenko, ironprogrammer.
Fixes#54578.
git-svn-id: https://develop.svn.wordpress.org/trunk@52802 602fd350-edb4-49c9-b593-d223f7449a82
This changeset replaces `#mailserver_port` to a more generic selector, fixes a coding standard issue, and adds a bigger margin to the field.
Follow-up to [52649].
Props SergeyBiryukov, kebbet, pyrobd.
Fixes#50177.
git-svn-id: https://develop.svn.wordpress.org/trunk@52801 602fd350-edb4-49c9-b593-d223f7449a82
This change adds a blue focus outline to the icon on plugin cards, for consistency with the text part of the link.
Props hitendra-chopda, SergeyBiryukov, afercia, themattroyal, imokol, sabernhardt, audrasjb.
Fixes#45209.
git-svn-id: https://develop.svn.wordpress.org/trunk@52790 602fd350-edb4-49c9-b593-d223f7449a82
Point releases about page changelog should not be committed to trunk. This changeset reverts [52783].
Unprops audrasjb.
git-svn-id: https://develop.svn.wordpress.org/trunk@52784 602fd350-edb4-49c9-b593-d223f7449a82
This commit makes the site editor follow what we do in the front-end, where theme styles are loaded after global styles by default.
Props oandregal, ntsekouras.
Fixes#55188.
git-svn-id: https://develop.svn.wordpress.org/trunk@52752 602fd350-edb4-49c9-b593-d223f7449a82
This change adds a CSS exception for when the "Dashboard" heading is missing or located below the Welcome Panel.
Props critterverse, sabernhardt, rolfsiebers, audrasjb.
Fixes#54977.
git-svn-id: https://develop.svn.wordpress.org/trunk@52735 602fd350-edb4-49c9-b593-d223f7449a82
#38231 added support for files fetched remotely to have their filename defined by the host using the `Content-Disposition` header. This would then take priority over the existing temporary file name created with `wp_tempnam()` earlier in the process.
The change unintentionally omitted the temporary directory path used during uploads, since the `wp_tempnam()` function would have added it previously, so that files with this header ended up being stored in the WordPress root folder, or wp-admin folder, when triggered by WP_Cron or user interactions respectively.
This change makes sure the file path includes the temporary directory location when the header is used.
Follow-up to [51939].
Props antonynz, azouamauriac.
Fixes#55109.
git-svn-id: https://develop.svn.wordpress.org/trunk@52734 602fd350-edb4-49c9-b593-d223f7449a82
* Use strict comparison in various conditions.
* Fix a `Variable "$system_webServer_node" is not in valid snake_case format` WPCS warning.
Includes minor code layout fixes for better readability.
Follow-up to [10607], [11350], [22253], [26137].
Props azouamauriac, SergeyBiryukov.
See #54728.
git-svn-id: https://develop.svn.wordpress.org/trunk@52721 602fd350-edb4-49c9-b593-d223f7449a82
This brings the naming more in line with other variables like `$current_user`.
Follow-up to [2872].
See #54728.
git-svn-id: https://develop.svn.wordpress.org/trunk@52689 602fd350-edb4-49c9-b593-d223f7449a82
The `link_updated` field is unused as of WordPress 3.0 and was never updated via `wp_insert_link()`, only via the `wp-admin/update-links.php` file removed in [13744].
Follow-up to [13744], [49487].
Props dshanske, dharm1025, SergeyBiryukov.
Fixes#54880.
git-svn-id: https://develop.svn.wordpress.org/trunk@52659 602fd350-edb4-49c9-b593-d223f7449a82
An unvisited site may have an undefined cron array, resulting in `_get_cron_array()` returning the value `false`. Previously this would trigger warning in `upgrade_590()` as the function assumed `_get_cron_array()` would alway return an array.
No database version change is required as the upgrade routine was successful on sites with a cron array during 5.9.0. On sites without a cron array, the error has already been thrown if they are running db version 51917. This fix is only required for new sites or those upgrading that have skipped 5.9.0.
Follow up to [51917].
Props chrisvanpatten, kapilpaul, SergeyBiryukov.
Fixes#54906.
See #53940.
git-svn-id: https://develop.svn.wordpress.org/trunk@52656 602fd350-edb4-49c9-b593-d223f7449a82
This change fixes an overlapping issue on small screens in the Writing Settings screen.
Props pravinparmar2404, afercia, utz119, thimalw, sabernhardt, audrasjb.
Fixes#50177.
git-svn-id: https://develop.svn.wordpress.org/trunk@52649 602fd350-edb4-49c9-b593-d223f7449a82
This ensures that the preview ratio remains accurate for the user's screen size when the sidebar is open.
Follow-up to [19995], [20110], [20133], [20138], [28033].
Props shreyasikhar26, costdev, sumitsingh, SergeyBiryukov.
Fixes#54764.
git-svn-id: https://develop.svn.wordpress.org/trunk@52647 602fd350-edb4-49c9-b593-d223f7449a82
This change removes a dispensable target blank attribute from Edit links displayed in the asynchronous file uploader.
Follow-up to [22755].
Props kebbet, SergeyBiryukov.
Fixes#54945.
See #23432.
git-svn-id: https://develop.svn.wordpress.org/trunk@52646 602fd350-edb4-49c9-b593-d223f7449a82
Before this changeset, `translation_api` and `translation_api_result` filters were incorrectly marked as taking object as their first argument. The correct type is an array as `json_decode()` is asked to return an associative array.
Props volodymyrkolesnykov.
Fixes#54959.
git-svn-id: https://develop.svn.wordpress.org/trunk@52645 602fd350-edb4-49c9-b593-d223f7449a82
The [https://api.jquery.com/toggle-event/ .toggle( handler, handler )] method signature was deprecated in jQuery 1.8 and removed in jQuery 1.9.
This commit updates the click handler function to work with jQuery 1.9+.
Follow-up to [9441], [9543], [42785], [48323].
Props malinevskiy, SergeyBiryukov.
Fixes#54886.
git-svn-id: https://develop.svn.wordpress.org/trunk@52644 602fd350-edb4-49c9-b593-d223f7449a82
This change replaces "Current theme" with "Active theme" in various DocBlocks for better consistency with user-facing strings.
Follow-up to [52580].
Props Presskopp, audrasjb, costdev.
Fixes#54831.
See #54770.
git-svn-id: https://develop.svn.wordpress.org/trunk@52610 602fd350-edb4-49c9-b593-d223f7449a82
This change adds support for various HTML entities in the News & Events dashboard widget.
Props nickciske, kpegoraro, iandunn, shedonist, sayedulsayem, sabernhardt, audrasjb, SergeyBiryukov, ocean90.
Fixes#41208.
git-svn-id: https://develop.svn.wordpress.org/trunk@52608 602fd350-edb4-49c9-b593-d223f7449a82
Remote block patterns from wp.org were to be loaded through a callback hooked into the `current_screen` filter. Within 2 callbacks, i.e. `_load_remote_featured_patterns()` and `_load_remote_block_patterns()`, a guard clause bailed out early if the `$current_screen->is_block_editor` is `false`.
However, the `current_screen` filter is unreliable to detect the block editor. Why? In the block and Site Editor screens, `$current_scren->is_block_editor` is not set until after the filter is executed. Whoopsie.
This commit no longer uses the `current_screen` filter. Instead, it explicitly loads the remote block patterns by invoking both private functions (now not callbacks) directly in the screen files for the block and site editor screens.
With this change, passing `WP_Screen` object into these functions is no longer needed. As the `_load_remote_block_patterns()` function was introduced in 5.8.0, its function parameter is now deprecated and the guard clause retained for backwards compatibility.
Follow-up to [51021], [52377].
Props poena, noisysocks, peterwilsoncc, hellofromTonya, audrasjb.
Fixes#54806.
git-svn-id: https://develop.svn.wordpress.org/trunk@52593 602fd350-edb4-49c9-b593-d223f7449a82
In PHP 8+, `@` no longer suppresses fatal errors:
> The `@` operator will no longer silence fatal errors (`E_ERROR`, `E_CORE_ERROR`, `E_COMPILE_ERROR`, `E_USER_ERROR`, `E_RECOVERABLE_ERROR`, `E_PARSE`).
Reference: [https://www.php.net/manual/en/migration80.incompatible.php PHP 8: Backward Incompatible Changes].
`disk_free_space()` may be disabled by hosts, which will throw a fatal error on a call to undefined function.
This change prevents the fatal error, and falls back to `false` when `disk_free_space()` is unavailable.
Follow-up to [25540], [25774], [25776], [25831], [25869].
Props costdev, jrf, swb1192, SergeyBiryukov.
Fixes#54826. See #54730.
git-svn-id: https://develop.svn.wordpress.org/trunk@52585 602fd350-edb4-49c9-b593-d223f7449a82
This mirrors a similar check a few lines below and includes minor code layout fixes for better readability.
Follow-up to [9955], [13931], [14176], [15315], [45407], [50129].
See #54728.
git-svn-id: https://develop.svn.wordpress.org/trunk@52581 602fd350-edb4-49c9-b593-d223f7449a82
This change replaces "Current theme" with "Active theme" in user-facing strings. It brings better consistency across the Administration.
Props Presskopp, audrasjb, costdev.
Fixes#54770.
git-svn-id: https://develop.svn.wordpress.org/trunk@52580 602fd350-edb4-49c9-b593-d223f7449a82
This change adds a verification of the `$position` parameter in `add_menu_page()` to ensure an integer is used. If not, the function informs developers of the wrong parameter type via a `_doing_it_wrong` message. This brings consistency with a similar check used in `add_submenu_page()`.
This change also typecasts any floating number to string to ensure that in case a float value was passed, at least it doesn't override existing menus.
Follow-up to [46570].
Props kirtan95.
Fixes#54798. See #48249.
git-svn-id: https://develop.svn.wordpress.org/trunk@52569 602fd350-edb4-49c9-b593-d223f7449a82
Use the correct Field Guide link. Update the SVGs used on Freedoms and Privacy. Add more spacing between sections on the About page, fixed spacing between rows on Freedoms page.
Props critterverse, audrasjb, versusbassz.
See #54270.
git-svn-id: https://develop.svn.wordpress.org/trunk@52563 602fd350-edb4-49c9-b593-d223f7449a82
Tone down the brightness of the dashboard panel by using a white background behind the main text, and use the highlight color from each color scheme for the main background. This also introduces a `$scheme-name` SCSS variable to allow overrides for specific color schemes.
Props critterverse, sabernhardt, joedolson, audrasjb.
See #54489.
git-svn-id: https://develop.svn.wordpress.org/trunk@52562 602fd350-edb4-49c9-b593-d223f7449a82
This change updates the HelpHub Documentation link to "Managing Themes" to make it more consistent with other Help tabs.
Props SergeyBiryukov, jdy68.
Fixes#54707.
git-svn-id: https://develop.svn.wordpress.org/trunk@52545 602fd350-edb4-49c9-b593-d223f7449a82
This change replaces the title of the Appearance Themes Screen to make it consistent with the main heading of the screen and with other Admin screens. It also adds a link to the related HelpHub Documentation in the Help tab of the screen.
Props jdy68.
Fixes#54707.
git-svn-id: https://develop.svn.wordpress.org/trunk@52543 602fd350-edb4-49c9-b593-d223f7449a82
During automatic core upgrades, if installation results in a `WP_Error`, the `error` method is called on the skin with the details. However, in this case, two parameters are passed to `$skin->error`, but only one is accepted. This change passes only the running `WP_Error` instance as the sole parameter to `$skin->error`.
Also, this change adds an additional error to `$upgrade_result` before finally being passed to `$skin->error`, indicating that the installation failed. This adds additional context to the failure.
Props desrosj, sainthkh, devutpol, SergeyBiryukov.
Fixes#53284.
git-svn-id: https://develop.svn.wordpress.org/trunk@52539 602fd350-edb4-49c9-b593-d223f7449a82
The workshops page doesn't specifically show 5.9 content at this stage (and likely won't until much later), so it needs to be changed to learn.wordpress.org homepage.
Props hlashbrooke, audrasjb, davidbaumwald.
Fixes#54755.
git-svn-id: https://develop.svn.wordpress.org/trunk@52453 602fd350-edb4-49c9-b593-d223f7449a82
In the Themes Screen Help Tab, the "Documentation on Adding New Themes" link previously targeted the "Using Themes" HelpHub post whereas it had to target the "Install Themes" section of "Appearance Themes Screen" HelpHub post, which is more relevant.
Props jdy68.
Fixes#54709.
git-svn-id: https://develop.svn.wordpress.org/trunk@52452 602fd350-edb4-49c9-b593-d223f7449a82
