Commit Graph

69 Commits

Author SHA1 Message Date
Pascal Birchler
d2b96ce6b9 Plugins: Make sure the 'Beta testing' tab is first in the plugin installer.
This makes feature plugins more discoverable for people running development builds.

Fixes #29631.

git-svn-id: https://develop.svn.wordpress.org/trunk@36297 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-14 09:06:12 +00:00
Konstantin Obenland
e4b8679d17 Plugins: Use plugin file rather than slug as identifier
The plugin file is unique while there can be more than one plugin with the
same slug. This also allows us to simplify the way updates from the plugin
detail iframe are executed.

See [36205].
Fixes #35350.



git-svn-id: https://develop.svn.wordpress.org/trunk@36221 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-08 17:47:18 +00:00
Sergey Biryukov
54c918d407 Remove redundant title attribute from wp_star_rating(). Hide the visible number of ratings from assistive technologies.
This data is redundant, as the same information is already conveyed by the text hidden with `.screen-reader-text` class.

Props afercia.
Fixes #35141.

git-svn-id: https://develop.svn.wordpress.org/trunk@36092 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-26 00:47:35 +00:00
Sergey Biryukov
b5b92d9cbd Accessibility: Add missing label for the theme upload input.
See [11152] for plugins.

Props mercime.
Fixes #35113.

git-svn-id: https://develop.svn.wordpress.org/trunk@35958 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-16 07:55:31 +00:00
Scott Taylor
7301c115aa Accessibility: add missing alt attributes to a gaggle of <img>s.
Props afercia.
Fixes #34583.


git-svn-id: https://develop.svn.wordpress.org/trunk@35567 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-07 16:11:38 +00:00
Andrea Fercia
e69aca18dc Accessibility: bump headings one level up on the Add Plugins screen for a better headings hierarchy.
Fixes #33818.

git-svn-id: https://develop.svn.wordpress.org/trunk@35009 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-10 15:16:04 +00:00
Drew Jaynes
80e4265277 Docs: Also clarify the expected element types depending on the value of $action in the hook doc for the plugins_api filter.
See [34763] for context.

See #34035.


git-svn-id: https://develop.svn.wordpress.org/trunk@34764 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-02 04:51:39 +00:00
Drew Jaynes
4c6d50413b Docs: Clarify the expected replacement element type if replacing the object or array in plugins_api() via the plugins_api hook.
If the `$action` type is 'query_plugins' or 'plugin_information', the API will return an object, thus an object should be passed if replacing it. For 'hot_tags' and 'hot_categories', the same logic applies, but with arrays instead.

See #34035.


git-svn-id: https://develop.svn.wordpress.org/trunk@34763 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-02 04:47:14 +00:00
Drew Jaynes
8594d93d7b Docs: Improve the hook documentation for the plugins_api_args filter.
Standardizes the hook doc summary and expands on the expected type for the `$args` parameter.

See #34035. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34652 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 23:02:47 +00:00
Drew Jaynes
c82483fcbc Docs: Improve the hook documentation for the plugins_api filter.
Standardizes the hook doc summary and expands on expected behavior when short-circuiting the request, which is dependent on the `$action` type.

See #34035. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34647 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 22:28:38 +00:00
Drew Jaynes
ed0ef8e2c0 Docs: Adjust the plugins_api() DocBlock description to clarify the "second" available hook, plugins_api, and add new information for the "third" hook, plugins_api_result.
See #34035.


git-svn-id: https://develop.svn.wordpress.org/trunk@34645 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 22:22:32 +00:00
Drew Jaynes
b9944f6331 Docs: Update the DocBlock summary for plugins_api() to reflect the "WordPress.org" Plugins API.
See #34035.


git-svn-id: https://develop.svn.wordpress.org/trunk@34642 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 22:06:37 +00:00
Drew Jaynes
40c3091ee3 Docs: Further improve documentation for plugins_api().
* Adds a matrix-like data table demonstrating which arguments are available for the different `$action` types
* Adjusts the return types to accommodate an `array` for the 'hot_tags' `$action` choice

Props ocean90.
See #34035.


git-svn-id: https://develop.svn.wordpress.org/trunk@34641 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 21:59:12 +00:00
Drew Jaynes
fe14c06e0a Docs: Add documentation for the $browse, $user, $search, $author, $tag, $installed_plugins, and $page parameters in plugins_api().
Props ocean90.
Fixes #34035.


git-svn-id: https://develop.svn.wordpress.org/trunk@34631 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 18:12:59 +00:00
Drew Jaynes
de8abd004f Docs: Add much-needed (and awesome) hash-notation-style documentation for the $args parameter in the plugins_api() DocBlock.
Also fixes up some formatting in the DocBlock summary and description, and adds a link to the function reference, where supplementary information on return object structs and formatting will live.

Props ocean90.
Fixes #34035.


git-svn-id: https://develop.svn.wordpress.org/trunk@34596 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 15:12:51 +00:00
John Blackbourn
d8a59791f0 Avoid a PHP notice if the last_updated property isn't present in a plugin's data from the Plugins API.
Fixes #33024
Props icetee


git-svn-id: https://develop.svn.wordpress.org/trunk@34458 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-23 15:09:42 +00:00
Helen Hou-Sandi
9aaa278e02 Notices: Add styles for use against white backgrounds.
These colored backgrounds can be accessed by adding the `.notice-alt` class to a notice.

There is also now a large version when using the `.notice-large` class, and a `.notice-title` class that is appropriate for headline text within a large notice.

props paulwilde, hugobaeta, melchoyce.
fixes #32244.


git-svn-id: https://develop.svn.wordpress.org/trunk@34365 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-21 15:25:37 +00:00
Scott Taylor
3b8c5529cb foreach is a statement, not a function.
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33734 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 20:27:56 +00:00
Scott Taylor
a297e1532e In install_dashboard() (plugin-install, FWIW), make sure slug is populated and degrease the unfortunate whitespace that was present.
Props tyxla.
Fixes #32889.


git-svn-id: https://develop.svn.wordpress.org/trunk@33114 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 19:18:03 +00:00
Scott Taylor
986990163f Add doc blocks to functions that are missing them.
If the function has no need for `@param` or `@return`, do an archeaological dig to find `@since`.

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32672 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-31 03:17:50 +00:00
Scott Taylor
60e5c90e62 Add (more) missing doc blocks to wp-admin/includes/*.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32655 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 21:16:59 +00:00
Scott Taylor
d55800a4f2 In the style of #30947 and default-filters.php, add 2 new files to wp-admin/includes:
`admin-filters.php`
`ms-admin-filters.php`

There are random actions and filters littered among files like `misc.php`. These files contain functions that won't work outside of admin context and are typically only loaded in files that have already loaded the admin bootstrap.

See #32529.


git-svn-id: https://develop.svn.wordpress.org/trunk@32653 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 17:03:13 +00:00
Scott Taylor
23ce2efd12 Add @global annotations for wp-admin/*.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32642 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-28 21:40:27 +00:00
Aaron Jorbin
43623c464c Enable users to initiate a shiny update from plugin detail modal
The plugin detail modal can contain a link to update a plugin.  When it does, we should initiate a shiny update.

This relies upon postMessage which isn't available in all browsers, specifically it isn't in IE versions below 8 so this is going to be a progressive enhancement that some small percentage of users will miss out on.  These are the same users that can't use the customizer. 

Fixes #31739




git-svn-id: https://develop.svn.wordpress.org/trunk@32062 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-07 03:08:38 +00:00
Dion Hulse
248c73b1cf Plugins Browser: Replace the download count with the number of Active installs of the plugin.
Fixes #31865


git-svn-id: https://develop.svn.wordpress.org/trunk@31990 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-02 23:48:26 +00:00
Dion Hulse
9eb9342a54 Remove ambiguity in the time display format in core, switches to using 24hr notation where am/pm isn't specified.
* `H:i - 09:54`
* `g:i a - 9:54 am`
* `F j, Y - January 3, 2015`

These shouldn't be used without a/A (am/AM)
* `h:i - 01:23`
* `G:i - 1:23`

Props iseulde. Fixes #31121


git-svn-id: https://develop.svn.wordpress.org/trunk@31862 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-23 02:13:50 +00:00
Scott Taylor
2f20da29b5 Replace array_shift() with reset() where appropriate for performance.
Props SergeyBiryukov.
Fixes #31259.


git-svn-id: https://develop.svn.wordpress.org/trunk@31829 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-19 03:55:39 +00:00
Sergey Biryukov
8aac5ba74e Avoid inadvertent stomping of the original $args parameter passed to plugins_api_result and themes_api_result filters in plugins_api() and themes_api(), respectively.
Fixes a regression introduced in [25956].

props Corphi, obenland.
fixes #29079.

git-svn-id: https://develop.svn.wordpress.org/trunk@31363 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-07 06:20:42 +00:00
Gary Pendergast
748d595b5c Shiny Updates: Add ajax-y updates to the plugin list page, and ajax-y updates and installs to the plugin card page.
This also includes JS architecture that can be expanded to support theme, core and language pack updates.

Props pento, ericlewis, lgladdy, adamsilverstein, DrewAPicture

See #29820



git-svn-id: https://develop.svn.wordpress.org/trunk@31333 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-05 04:18:57 +00:00
dd32
5f13a0e3e5 Remove an unused parameter on install_plugins_upload().
Props michalzuber. Fixes #28964


git-svn-id: https://develop.svn.wordpress.org/trunk@31326 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-03 06:13:02 +00:00
Scott Taylor
83b6fad852 In HTML5, the action attribute is no longer required. Remove this attribute when empty.
The admin HTML is served with the HTML5 doctype.

"The action and formaction content attributes, if specified, must have a value that is a valid non-empty URL potentially surrounded by spaces." 
http://www.w3.org/html/wg/drafts/html/master/forms.html#attr-fs-action

Props voldemortensen.
Fixes #30126.


git-svn-id: https://develop.svn.wordpress.org/trunk@31200 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 04:15:52 +00:00
Sergey Biryukov
1c88f482bf Use localized format for Last Updated date in plugin details modal, for consistency with [31055].
see #30717.

git-svn-id: https://develop.svn.wordpress.org/trunk@31110 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-09 06:20:08 +00:00
Scott Taylor
6fd11624d1 The keyword elseif should be used instead of else if so that all control keywords look like single words.
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs. 

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31090 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 07:04:40 +00:00
Dominik Schilling (ocean90)
7560f4cf8c Pass locale to wordpress.org theme/plugin API.
In the future this will be used to return localized plugin/theme info.

see #30735.

git-svn-id: https://develop.svn.wordpress.org/trunk@30944 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 22:38:52 +00:00
Andrew Nacin
855ff22a53 Update/add plugin recommendation strings.
Update [30887], add a translation function to the Vine string.

fixes #30337. see #30435.


git-svn-id: https://develop.svn.wordpress.org/trunk@30889 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 10:05:09 +00:00
Andrew Ozz
c8e8281a05 Plugins: move the recommender results to a separate tab. Any outstanding quality issues will be fixed on the API side without needing core changes. Props tellyworth, fixes #30337.
git-svn-id: https://develop.svn.wordpress.org/trunk@30782 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 23:39:54 +00:00
Scott Taylor
8a4fa5662b Improve various @param docs for src/wp-admin/*.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30680 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 00:59:43 +00:00
Dominik Schilling (ocean90)
3ebd474750 Improve the focus style for review links in the plugin info modal.
props johnbillion.
fixes #30375.

git-svn-id: https://develop.svn.wordpress.org/trunk@30555 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 22:58:12 +00:00
Helen Hou-Sandi
a8821f6b57 Admin notices: Add more variety and make more generically usable.
There is now a base class of `notice`, with additional classes of `notice-success`, `notice-warning`, `notice-error`, and a new blue `notice-info`.

Also corrects some misleading notice colors, such as plugin tested up to warnings and login messages.

props avryl, melchoyce.
fixes #27418.


git-svn-id: https://develop.svn.wordpress.org/trunk@30505 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-21 16:40:29 +00:00
Sergey Biryukov
9f8e03c390 Avoid PHP notices if 'plugin' is not set for tab=plugin-information.
props avryl.
fixes #29936.

git-svn-id: https://develop.svn.wordpress.org/trunk@29882 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-12 13:05:55 +00:00
Dominik Schilling (ocean90)
f7a4e22bdb Plugin search: Wrap results in a form to fix pagination's paged input field.
props jesin, ocean90.
see #18724, for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@29829 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-03 13:07:18 +00:00
Sergey Biryukov
3d0f4d9656 Use correct links for filtering plugin reviews.
props OriginalEXE.
fixes #29754.

git-svn-id: https://develop.svn.wordpress.org/trunk@29826 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-03 08:08:27 +00:00
Andrew Nacin
8564e3a491 Plugin installer: Minor adjustments to aid with discovery.
fixes #29387.


git-svn-id: https://develop.svn.wordpress.org/trunk@29636 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-27 02:52:29 +00:00
Andrew Nacin
322991024f Plugin/Theme Uploads: New capabilities; unify UIs; ensure compatibility with old filters.
Introduce upload_plugins and upload_themes capabilities to allow blocking of plugin and theme uploads, versus the old hacky (and not secure) ways of just hiding UI tabs. These are simply meta capabilities that map to install_plugins and install_themes.
 
Also:
 * Use the same nice design for the plugin upload screen as the theme upload screen.
 * Better compatibility for the old install_themes_tabs filter added in [29002]. see #28578.
 * Ensure using the install_plugins_tabs filter to remove the upload tab removes the new button.
 * Use 'Add Plugins' instead of 'Install Plugins' to match 'Add Themes'.

fixes #29236.


git-svn-id: https://develop.svn.wordpress.org/trunk@29634 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-27 01:31:05 +00:00
Helen Hou-Sandi
9252fbec58 Only show one search form for the plugin installer.
The field dropdown now appears in the filter bar only when doing a search.

see #28785.


git-svn-id: https://develop.svn.wordpress.org/trunk@29597 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 16:02:43 +00:00
Sergey Biryukov
91f11ca349 Plugin compatibility warnings should be red, not green.
props avryl.
fixes #29309.

git-svn-id: https://develop.svn.wordpress.org/trunk@29574 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-22 03:56:51 +00:00
Sergey Biryukov
de313ebf30 * Add span to the list of allowed tags in plugin sections in plugin details modal.
* Don't strip class attribute from div/span tags in plugin sections.

props tellyworth.
see #28884.

git-svn-id: https://develop.svn.wordpress.org/trunk@29511 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-16 03:06:26 +00:00
Dominik Schilling (ocean90)
e22782e068 Plugin details: Use translation functions.
props jesin.
fixes #29220.

git-svn-id: https://develop.svn.wordpress.org/trunk@29510 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-15 20:50:51 +00:00
Dominik Schilling (ocean90)
8314367632 Plugin details: Escape the donate link.
see #27440.

git-svn-id: https://develop.svn.wordpress.org/trunk@29506 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-15 17:16:16 +00:00
Helen Hou-Sandi
f37a0e160d Plugin details modal:
* Scroll all content, rather than the dual-pane scrolling awkwardness.
* Better align the header image and title overlay with the display on WordPress.org, at least at full-width.
* Move the close button outside of the modal itself, rather than overlay on top of colors we can't predict.

props stephdau, tellyworth, helen. fixes #27440.


git-svn-id: https://develop.svn.wordpress.org/trunk@29474 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-12 23:01:38 +00:00