Commit Graph

929 Commits

Author SHA1 Message Date
Andrew Ozz
d688a2ddc2 TinyMCE, inline link toolbar: fix z-index bug in iOS Safari.
See #32604.

git-svn-id: https://develop.svn.wordpress.org/trunk@32958 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-26 20:28:59 +00:00
Andrew Ozz
8b77a613c1 TinyMCE: add the editor focusing help the Keyboard Shortcuts modal.
See #31913.

git-svn-id: https://develop.svn.wordpress.org/trunk@32957 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-26 18:48:02 +00:00
Scott Taylor
d0c3281ea8 In Media microtemplates after [32467], use <button> instead of <a> for several more non-links.
Props afercia.
Fixes #26550.


git-svn-id: https://develop.svn.wordpress.org/trunk@32952 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-26 05:00:42 +00:00
Andrew Ozz
9b671bdf9e TinyMCE: update the Keyboard Shortcuts help modal, use the TinyMCE UI API instead of an iframe.
Props iseulde, azaozz. Fixes #31913.

git-svn-id: https://develop.svn.wordpress.org/trunk@32951 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-26 04:39:11 +00:00
Andrew Ozz
017d27a2c1 TinyMCE, inline link toolbar:
- Add max-width for all floating toolbars.
- Ensure the inline link toolbar doesn't exceed the width on small screen devices.
- Do not cut/concatenate the URL when it is less than 40 characters long.
- Show more of the URL if the beginning part plus the ending part are less than 40 characters long.
See #32604.

git-svn-id: https://develop.svn.wordpress.org/trunk@32937 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 04:41:34 +00:00
Ella Iseulde Van Dorpe
7fc64e8adb wplink: update TinyMCE UI after updating the link
See #32604.


git-svn-id: https://develop.svn.wordpress.org/trunk@32932 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 23:22:44 +00:00
Ella Iseulde Van Dorpe
ed5625f831 TinyMCE: wplink: add inline toolbar
Now the URL can be viewed as soon as you put the cursor in an anchor tag. Clicking on it will open the page in a new tab. You also have the edit and remove button close at hand.

First run.
See #32604.


git-svn-id: https://develop.svn.wordpress.org/trunk@32931 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 23:04:46 +00:00
Scott Taylor
7192f7e9cf Because programming is fun. After [32915], _.find() will return undefined if an empty array is passed - in that case, the function should return true.
See #32746.


git-svn-id: https://develop.svn.wordpress.org/trunk@32916 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-23 19:42:50 +00:00
Scott Taylor
75b6e0755d When filtering media by type in wp.media.model.Attachments.filters.type(), account for the library's type being an array of full mime-types.
Fixes #32746.


git-svn-id: https://develop.svn.wordpress.org/trunk@32915 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-23 19:39:21 +00:00
Scott Taylor
ff871b3603 Refresh attachment links in the media modal are unneeded since bringing the image editor into it in [27445].
Props rommelxcastro.
Fixes #32550.


git-svn-id: https://develop.svn.wordpress.org/trunk@32909 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-22 21:32:04 +00:00
Scott Taylor
3b17ffb990 In wp.media.view.UploaderStatus.filename(), don't truncate the filename.
Props helen.
Fixes #31216.


git-svn-id: https://develop.svn.wordpress.org/trunk@32908 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-22 21:25:19 +00:00
Andrew Ozz
e366658072 Update the TinyMCE initialization:
- Replace `wp_htmledit_pre()` and `wp_richedit_pre()` with `format_for_editor()`.
- Replace the `'htmledit_pre'` and `'richedit_pre'` filters with `'format_for_editor'`.
- Do not run the post content through `wpautop()` in PHP when the visual editor is default. Run the textarea content through the JS wpautop on initializing TinyMCE.
- Simplify both editors initialization.
- Improve setting of `wpActiveEditor` in Quicktags.
- Improve editor.js, use `tinymce.$` when possible.
See #32425.

git-svn-id: https://develop.svn.wordpress.org/trunk@32899 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-21 22:00:42 +00:00
Andrew Ozz
57daea7230 Fix error when dropping files for uploading on the editor before the media modal is initialized.
Props rommelxcastro, sebastiantiede. Fixes #32527.

git-svn-id: https://develop.svn.wordpress.org/trunk@32894 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-20 21:07:03 +00:00
azaozz
f366ccf053 Editor: add ARIA labels to the Quicktags buttons to improve accessibility.
Props afercia, azaozz. Fixes #31522.

git-svn-id: https://develop.svn.wordpress.org/trunk@32883 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-20 02:15:04 +00:00
Scott Taylor
73fd2d1d81 Ugrade MediaElement to 2.17.0
Changelog: https://github.com/johndyer/mediaelement/compare/2.16.4...2.17.0

Fixes #32698.


git-svn-id: https://develop.svn.wordpress.org/trunk@32864 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 20:41:12 +00:00
Scott Taylor
da826f59a5 Media Library Bulk Select button size should be smaller.
Props afercia.
Fixes #32325.


git-svn-id: https://develop.svn.wordpress.org/trunk@32862 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 18:55:52 +00:00
Ella Iseulde Van Dorpe
fa5ec5077b Editor: restructure word count
* The WordCounter should only do one thing: count words. This makes it also easier to test.
* Add some really basic unit tests.
* Instead of only refreshing the count on enter and delete, refresh the count when the user stops typing. Also look at paste and content changes in TinyMCE.
* Use `match` instead of `replace` when it is appropriate.
* More readable code.

See #30966. Fixes #26620.



git-svn-id: https://develop.svn.wordpress.org/trunk@32856 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 10:34:59 +00:00
Konstantin Obenland
2ae17175b2 Use https for Google API external libraries.
Google recommends it and users are more likely to have the https version cached in their browser already.

Props rommelxcastro.
Fixes #32552.



git-svn-id: https://develop.svn.wordpress.org/trunk@32843 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 15:50:42 +00:00
Ella Iseulde Van Dorpe
9941421f72 TinyMCE: wptextpattern: escape should undo
Props azaozz.
See #31441.


git-svn-id: https://develop.svn.wordpress.org/trunk@32836 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 12:58:07 +00:00
Ella Iseulde Van Dorpe
fa1a214eb6 TinyMCE: wptextpattern: fix issue that removes content
* If the resulting text node is empty, don't remove all the content from the paragraph.
* If there's an empty text node at the start of the paragraph, ignore it and consider the next node to be the start.

See #31441.


git-svn-id: https://develop.svn.wordpress.org/trunk@32832 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 11:33:11 +00:00
Ella Iseulde Van Dorpe
b1446f4221 TinyMCE: show inline toolbar after scroll/resize
Also:

* Reduce the amount of callbacks.
* Move everything under `preinit` (but prepend to the callback). The API shouldn't be availbale earlier, and some UI is not available yet, neither is `editor.dom`.
* Hide the toolbar if the target is out of view.

See #32604.



git-svn-id: https://develop.svn.wordpress.org/trunk@32831 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 11:09:56 +00:00
Ella Iseulde Van Dorpe
361e7d9717 TinyMCE: show active inline toolbar after focus
This makes sure that e.g. the image toolbar shows up again after closing the media library modal.

See #32604.


git-svn-id: https://develop.svn.wordpress.org/trunk@32818 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-17 07:07:50 +00:00
Ella Iseulde Van Dorpe
f81208f55a TinyMCE: wplink: don't link a URL with a pasted URL
Fixes #32357.



git-svn-id: https://develop.svn.wordpress.org/trunk@32817 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-17 05:04:23 +00:00
Ella Iseulde Van Dorpe
33e63b7bda TinyMCE: improve reposition method inline toolbars
* Make sure the toolbar does not overlap the target, unless it is higher than half the visible editor area's height.
* Allow the toolbar to have the preference to position itself above or below the target.
* Cache DOM lookups.
* Simplify the logic and fix various positioning issues.

See #32604.



git-svn-id: https://develop.svn.wordpress.org/trunk@32816 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-17 04:41:59 +00:00
Dominik Schilling (ocean90)
c0a66eba79 Add menu management to the Customizer.
This brings in the Menu Customizer plugin: https://wordpress.org/plugins/menu-customizer/.

props celloexpressions, westonruter, valendesigns, voldemortensen, ocean90, adamsilverstein, kucrut, jorbin, designsimply, afercia, davidakennedy, obenland.
see #32576.

git-svn-id: https://develop.svn.wordpress.org/trunk@32806 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 22:07:08 +00:00
Scott Taylor
a6a0480eb0 Add a class method to wpLink, buildHtml(). This will allows devs to duck-punch the implementation.
Props martinsachse.
Fixes #32180.


git-svn-id: https://develop.svn.wordpress.org/trunk@32802 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 20:19:54 +00:00
Ella Iseulde Van Dorpe
a65f178bbb TinyMCE: wptextpattern: Add blockquote and headings
As discussed in the editor meeting 9 June.
We should re-evaluate these additions towards the end of the release.

See #31441.


git-svn-id: https://develop.svn.wordpress.org/trunk@32795 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 13:51:37 +00:00
Scott Taylor
93e01e68b5 Add an abort class method to the Promise instance returned by wp.ajax.send().
Props westonruter.
Fixes #32628.


git-svn-id: https://develop.svn.wordpress.org/trunk@32747 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-13 14:29:42 +00:00
Ella Iseulde Van Dorpe
9f13e05b64 TinyMCE: wpviews: cache iframe heights
Cache iframe heights per instance so it can be reused. This will prevent to content from moving in the editor when undoing or redoing changes.

Fixes #32593.


git-svn-id: https://develop.svn.wordpress.org/trunk@32711 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-08 21:31:39 +00:00
Ella Iseulde Van Dorpe
c345382dee TinyMCE: views: fix typo in createInstance
This prevented instances from being reused.

Fixes #32591.


git-svn-id: https://develop.svn.wordpress.org/trunk@32710 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-08 19:53:35 +00:00
Ella Iseulde Van Dorpe
ea5ba64400 Editor: link modal: use link as fallback for text
If there is no link text provided, use the link as the text. This is better than silently failing.

Props bcole808.
Fixes #32323.


git-svn-id: https://develop.svn.wordpress.org/trunk@32705 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-07 21:10:17 +00:00
Ella Iseulde Van Dorpe
fc74e695f5 TinyMCE: wptextpattern: add docs
Props DrewAPicture and iseulde.
See #31441.


git-svn-id: https://develop.svn.wordpress.org/trunk@32703 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-07 19:59:11 +00:00
Ella Iseulde Van Dorpe
b866b19a20 TinyMCE: wptextpattern: disable for IE 8 and lower
Props azaozz, iseulde.
See #31441.


git-svn-id: https://develop.svn.wordpress.org/trunk@32700 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-06 22:37:13 +00:00
Ella Iseulde Van Dorpe
5bac5f7ccd TinyMCE: add wptextpattern plugin
This plugin can automatically format text patterns as you type. It includes two patterns: unordered (`* ` and `- `) and ordered list (`1. ` and `1) `). If the transformation in unwanted, the user can undo the change by pressing backspace, using the undo shortcut, or the undo button in the toolbar.

This is the first TinyMCE plugin that has unit tests and there's some good groundwork for adding tests to existing plugins in the future.

First run. See #31441.


git-svn-id: https://develop.svn.wordpress.org/trunk@32699 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-06 20:07:00 +00:00
Ella Iseulde Van Dorpe
cb73a0cc1a Browserify after [32677]
See #30949.


git-svn-id: https://develop.svn.wordpress.org/trunk@32697 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-06 19:49:24 +00:00
Andrew Ozz
194d266afb Emoji: make sure we parse only strings or DOM nodes that have children.
Props peterwilsoncc. Fixes #32300.

git-svn-id: https://develop.svn.wordpress.org/trunk@32679 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-01 18:24:12 +00:00
Andrew Ozz
b513402c28 TinyMCE wpView: preserve HTML wrapped in shortcodes.
Fixes #32078.

git-svn-id: https://develop.svn.wordpress.org/trunk@32678 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-01 18:08:19 +00:00
Andrew Ozz
156df52851 Editor:
- Remove the old DFW.
- Add back-compat stub for wp-fullscreen.js.
- Keep wp_ajax_wp_fullscreen_save_post() for now.
See #30949.

git-svn-id: https://develop.svn.wordpress.org/trunk@32677 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-01 17:37:14 +00:00
Ella Iseulde Van Dorpe
f639366590 Link modal: reset search results appropriately
Reset the search results when the input field is emptied with the
browser's "clear" button inside that field.

Fixes #32174.


git-svn-id: https://develop.svn.wordpress.org/trunk@32593 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-25 06:40:27 +00:00
Ella Iseulde Van Dorpe
1e6be9cd89 TinyMCE: wpeditimage: trim class
Don't add extra spaces to classes. It causes some tests in the TinyMCE QUnit test suite to fail.

Fixes #31764.


git-svn-id: https://develop.svn.wordpress.org/trunk@32592 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-25 06:34:27 +00:00
Scott Taylor
11671ad73b In tb_show() in thickbox, when loading content into #TB_ajaxContent, make sure a URL with no ? doesn't break when &random= is appended to it.
Thickbox hasn't been updated since 2007, just FYI.

Fixes #31726.


git-svn-id: https://develop.svn.wordpress.org/trunk@32503 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-13 21:41:47 +00:00
Scott Taylor
23e40ef756 In views/button/select-mode-toggle, don't hide the spinner with JS. This oversight is a symptom of the too-aggressive outside DOM handling that is happening in this view's toggleBulkEditHandler method.
Props afercia.
Fixes #32324.


git-svn-id: https://develop.svn.wordpress.org/trunk@32502 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-13 21:26:22 +00:00
Andrew Ozz
cdd007cc62 Emoji: do not try to replace emoji chars inside dynamic SVGs.
Fixes #32305 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@32478 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-09 23:43:07 +00:00
Scott Taylor
f9fd563ec7 Media Grid: clean up our flawed Backbone.Router implementation so that the browser forward/back buttons work the same way as the left/right keys when the Edit Attachment frame is open.
Fixes #31846.


git-svn-id: https://develop.svn.wordpress.org/trunk@32466 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-09 05:41:01 +00:00
Scott Taylor
8303e8f314 wp.media.view.Button should create <button>s, not <a href="#">s.
Props afercia.
See #32236.


git-svn-id: https://develop.svn.wordpress.org/trunk@32464 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-08 20:38:55 +00:00
Scott Taylor
3fd2730435 In EmbedLink, a URL needs to be at least 11 chars to be useful.
Fixes #32059.


git-svn-id: https://develop.svn.wordpress.org/trunk@32463 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-08 20:29:55 +00:00
Scott Taylor
bbcddbbb72 When creating an EmbedLink view, don't add a spinner - it already exists in Embed.
Use the value of `wp.media.controller.Embed.sensitivity` as the sensitivity value for the debounced method in `EmbedLink` to ensure that the spinner toggles don't stutter or overlap.

Fixes #32036.


git-svn-id: https://develop.svn.wordpress.org/trunk@32462 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-08 20:09:58 +00:00
Scott Taylor
c8ca3c2304 When fetching in media/views/embed/link.js, call abort() on any existing XHRs.
Use `$.ajax` instead of `wp.ajax.send()` to allow this.
Pass `this` as `context` to the options to remove the need to bind callbacks.

Fixes #32035.


git-svn-id: https://develop.svn.wordpress.org/trunk@32460 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-08 19:15:34 +00:00
Scott Taylor
c6592462ef In media/views/embed/link.js, URLs should have a valid protocol before an attempt to fetch them is made.
Fixes #32037.


git-svn-id: https://develop.svn.wordpress.org/trunk@32459 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-08 18:33:34 +00:00
Andrew Ozz
8737968ac2 TinyMCE: update to 4.1.10.
Fixes #32262.

git-svn-id: https://develop.svn.wordpress.org/trunk@32366 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 03:22:04 +00:00