Commit Graph

6729 Commits

Author SHA1 Message Date
Sergey Biryukov
d8c502e966 Coding Standards: Use strict type check for in_array() and array_search().
This addresses all the remaining `WordPress.PHP.StrictInArray.MissingTrueStrict` issues in core.

Includes minor code layout fixes for better readability.

Follow-up to [47550].

See #49542.

git-svn-id: https://develop.svn.wordpress.org/trunk@47557 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-09 15:41:04 +00:00
Sergey Biryukov
adda585fb8 Privacy: Make the deprecated wp_get_user_request_data() function available on front end.
Previously, it was accidentally made available only in admin context.

Follow-up to [44606], [47245].

Props garrett-eclipse, johnjamesjacoby, r-a-y, Dono12.
Fixes #49802.

git-svn-id: https://develop.svn.wordpress.org/trunk@47555 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-08 18:31:21 +00:00
Sergey Biryukov
0b4e2c4604 Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.
This reduces the number of `WordPress.PHP.StrictInArray.MissingTrueStrict` issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

git-svn-id: https://develop.svn.wordpress.org/trunk@47550 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-05 03:00:44 +00:00
Sergey Biryukov
178e16e33a Docs: Add documentation for the $parent parameter of get_admin_page_parent().
Props subrataemfluence.
Fixes #45849.

git-svn-id: https://develop.svn.wordpress.org/trunk@47546 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-03 17:21:25 +00:00
Sergey Biryukov
ceba6b656f Administration: Make the height of dashboard widget headings consistent with that of post meta boxes on smaller screens.
This also ensures that the toggle arrow for dashboard widgets is properly aligned.

Props chetan200891.
Fixes #49727.

git-svn-id: https://develop.svn.wordpress.org/trunk@47535 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-31 02:50:52 +00:00
Sergey Biryukov
4634a4ce3f Help/About: Use CDN URLs for 5.4 About page header images.
See #49295.

git-svn-id: https://develop.svn.wordpress.org/trunk@47532 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-30 17:47:34 +00:00
Sergey Biryukov
936b65887c Filesystem API: Correct punctuation in request_filesystem_credentials() error message.
Props mayankmajeji, kharisblank.
Fixes #49724.

git-svn-id: https://develop.svn.wordpress.org/trunk@47530 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-30 01:30:42 +00:00
Sergey Biryukov
2b52250f1a Site Health: Remove paragraph tag from the actions container in issue template.
Most of the tests pass content that is already wrapped in a paragraph or list tags, thus producing nested paragraphs or invalid markup.

Additionally, don't output an empty `<div>` tag if the test does not provide any actions.

Props maxpertici, afercia.
Fixes #48948.

git-svn-id: https://develop.svn.wordpress.org/trunk@47529 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-30 01:23:47 +00:00
Sergey Biryukov
a73eca1021 Site Health: Correct markup in ::get_test_php_extensions() and ::get_test_background_updates() description.
These tests output an unordered list, which doesn't need to be wrapped in a paragraph tag.

Additionally, pass an empty string as an `actions` parameter in `::get_test_php_default_timezone()`, for consistency with other tests.

Props afercia.
See #48948.

git-svn-id: https://develop.svn.wordpress.org/trunk@47528 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-29 03:44:36 +00:00
Sergey Biryukov
96a35dad0b Site Health: Add pretty links support information to debug data.
Props valentinbora, afragen.
Fixes #49422.

git-svn-id: https://develop.svn.wordpress.org/trunk@47527 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-28 21:18:19 +00:00
Sergey Biryukov
4b42334001 Help/About: Improve accessibility of the 5.4 About page:
* Remove vertical text and unnecessary italics.
* Update H1 headings on About, Credits, Freedoms, Privacy pages to be unique to each page.

Props sabernhardt, ryelle, melchoyce, karmatosed, audrasjb, afercia, davidbaumwald, SergeyBiryukov.
See #49295.

git-svn-id: https://develop.svn.wordpress.org/trunk@47521 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-27 23:39:37 +00:00
Sergey Biryukov
815f0341da Coding Standards: Remove some extra tabs in wp-admin/user-new.php.
Follow-up to [47516], [47519].

See #38665.

git-svn-id: https://develop.svn.wordpress.org/trunk@47520 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-27 22:29:00 +00:00
Sergey Biryukov
c71cefe4c9 Coding Standards: Fix WPCS issues in [47516].
See #38665.

git-svn-id: https://develop.svn.wordpress.org/trunk@47519 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-27 22:23:12 +00:00
John Blackbourn
9c18a5c6e9 Users: Add a user language preference option to the "Add New User" form.
This uses the same language selection control as the user editing screen and allows new users to be invited to a site in their own language.

Props barryceelen, johnbillion

Fixes #38665

git-svn-id: https://develop.svn.wordpress.org/trunk@47516 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-27 21:56:24 +00:00
John Blackbourn
728a031767 Themes: Always list broken themes even if the user cannot take a corresponding action within the admin area.
This prevents broken themes being hidden when the `DISALLOW_FILE_MODS` constant is in use.

Props rebasaurus

Fixes #49268

git-svn-id: https://develop.svn.wordpress.org/trunk@47510 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-26 17:48:07 +00:00
Sergey Biryukov
0f9477d5e8 Docs: Add documentation for WP_Comments_List_Table::floated_admin_avatar().
Props akbarhusen, ayeshrajans, Soean, ajayghaghretiya1, netweb, SergeyBiryukov.
Fixes #41491.

git-svn-id: https://develop.svn.wordpress.org/trunk@47507 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-25 14:41:15 +00:00
Jorge Costa
afe1b96db2 Help/About: Fix a typo on the about page and fix a link.
The text "on your" appeared two times. This commit fixes the issue and removes the duplication. It also updates the field guide permalink.

Props garrett-eclipse, ixkaito, karmatosed, SergeyBiryukov.

git-svn-id: https://develop.svn.wordpress.org/trunk@47500 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-24 15:01:57 +00:00
Sergey Biryukov
630ba8979a Administration: Add / character to <img> tag in WP_Plugin_Install_List_Table::display_rows().
While this has no effect on void elements in HTML5, it fixes a minor inconsistency with the rest of core.

Props adnan.limdi, Soean.
Fixes #41904.

git-svn-id: https://develop.svn.wordpress.org/trunk@47493 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-22 18:35:46 +00:00
Sergey Biryukov
f44d456a4b Upgrade/Install: Return a more appropriate HTTP response status code (409 Conflict) if the wp-config.php file already exists.
Props linyows, ocean90.
Fixes #42466.

git-svn-id: https://develop.svn.wordpress.org/trunk@47478 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-21 15:42:57 +00:00
Sergey Biryukov
7c15916c28 Coding Standards: Fix WPCS issue in [47475].
See #49295.

git-svn-id: https://develop.svn.wordpress.org/trunk@47476 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-20 17:31:13 +00:00
Sergey Biryukov
e45a2eb99d Help/About: Add design for 5.4 About page.
Props melchoyce, marybaum, marktimemedia, elmastudio, ryelle, karmatosed, audrasjb, afercia, francina, sabernhardt.
See #49295.

git-svn-id: https://develop.svn.wordpress.org/trunk@47475 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-20 17:11:35 +00:00
Sergey Biryukov
827d77e341 Administration: Escape admin title on output after the admin_title filter runs, not before.
Props lalitpendhare, adnan.limdi, subrataemfluence, andraganescu.
Fixes #41921.

git-svn-id: https://develop.svn.wordpress.org/trunk@47474 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-20 02:18:53 +00:00
Sergey Biryukov
7ede058b16 Privacy: Correct bottom padding for table of contents on Privacy Policy Guide on smaller screens.
Props jagirbahesh, birgire, garrett-eclipse.
Fixes #49570.

git-svn-id: https://develop.svn.wordpress.org/trunk@47473 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-19 20:43:13 +00:00
Sergey Biryukov
b0889a7639 Post Formats: Pass post type to the disable_formats_dropdown filter in WP_Posts_List_Table::formats_dropdown().
Props MatheusFD, birgire.
Fixes #47959.

git-svn-id: https://develop.svn.wordpress.org/trunk@47472 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-18 19:11:33 +00:00
John Blackbourn
c8d918e476 Docs: Various docblock corrections and improvements.
See #49572

git-svn-id: https://develop.svn.wordpress.org/trunk@47461 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-16 18:38:03 +00:00
Sergey Biryukov
812c92e1e9 Administration: When editing a plugin or theme file, close any active PHP session.
This prevents HTTP requests from timing out when attempting to connect back to the site.

Props bruandet, vjik, donmhico, SergeyBiryukov.
Fixes #43358.

git-svn-id: https://develop.svn.wordpress.org/trunk@47457 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-15 19:43:50 +00:00
Sergey Biryukov
a2861f1277 Site Health: Run the first scheduled site health check a day after the initial site setup.
This reduces the chance of displaying incorrect results due to running the check too early in first time setup scenarios.

Props Clorith, garrett-eclipse, roytanck, joostdevalk.
Fixes #49577.

git-svn-id: https://develop.svn.wordpress.org/trunk@47456 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-14 16:34:54 +00:00
Sergey Biryukov
6095b4467a Help/About: Use consistent vertical whitespace between sections on Freedoms page.
Props chetan200891.
Fixes #49619.

git-svn-id: https://develop.svn.wordpress.org/trunk@47443 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-10 20:37:59 +00:00
Sergey Biryukov
4f06d9a2bb Help/About: Update and correct some strings for 5.4 About page.
Props garrett-eclipse, Ipstenu, ocean90, tobifjellner, la-geek.
Reviewed by ocean90, SergeyBiryukov.
See #49295.

git-svn-id: https://develop.svn.wordpress.org/trunk@47436 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-09 00:09:25 +00:00
Sergey Biryukov
77578e0869 Themes: Prevent tags in Theme Details modal from being partially hidden behind action buttons on smaller screens.
Props sagarjadhav, valentinbora.
Fixes #31783.

git-svn-id: https://develop.svn.wordpress.org/trunk@47435 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-08 01:50:37 +00:00
Sergey Biryukov
f6ff42bee4 Administration: Add missing description for "Page title" element of the admin menu array.
Props ajoah, valentinbora, kaitlin414.
Fixes #42911.

git-svn-id: https://develop.svn.wordpress.org/trunk@47434 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-08 00:16:36 +00:00
Sergey Biryukov
c227b20a0f Customize: Ensure color picker's Clear button is aligned properly.
Props Cybr.
Fixes #49543.

git-svn-id: https://develop.svn.wordpress.org/trunk@47433 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-07 01:11:38 +00:00
Sergey Biryukov
0ffce72ed0 Help/About: Add strings for 5.4 About page.
Props elmastudio, chanthaboune, francina, marybaum, audrasjb.
See #49295.

git-svn-id: https://develop.svn.wordpress.org/trunk@47422 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-03 21:20:45 +00:00
Sergey Biryukov
7dd3e6edd9 Media: Improve the appearance of image editor on small and medium screens.
This prevents the main area of Edit Media screen from being pushed down too far.

Props sabernhardt, afercia, fierevere, sathyapulse, mikeschroder, johnbillion.
Fixes #48780. See #47136.

git-svn-id: https://develop.svn.wordpress.org/trunk@47418 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-03 17:19:55 +00:00
Sergey Biryukov
360c98280c Site Health: Fix typo in Site Health Status dashboard widget.
Follow-up to [47063], [47413].

Props Clorith, dlh.
See #49562.

git-svn-id: https://develop.svn.wordpress.org/trunk@47415 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-03 12:20:35 +00:00
Sergey Biryukov
cd84eaac26 Docs: Correct formatting of some DocBlocks in Plugin_Upgrader and Theme_Upgrader per the documentation standards.
See #49400.

git-svn-id: https://develop.svn.wordpress.org/trunk@47414 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-03 11:38:00 +00:00
Sergey Biryukov
288f5234e9 Site Health: Improve the strings in Site Health Status dashboard widget.
Follow-up to [47063].

Props dlh.
Fixes #49562.

git-svn-id: https://develop.svn.wordpress.org/trunk@47413 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-03 11:20:00 +00:00
John Blackbourn
e45162e496 Privacy: Fix the URLs and legacy redirects for the personal data export and erasure screens.
Props Jurgen Oldenburg, garrett-eclipse

Fixes #49476

git-svn-id: https://develop.svn.wordpress.org/trunk@47412 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-03 00:48:21 +00:00
John Blackbourn
e9c74d09c8 Privacy: Reintroduce consistency to the styling of suggested privacy text from core and plugins.
Props garrett-eclipse

Fixes #49282

git-svn-id: https://develop.svn.wordpress.org/trunk@47411 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-03 00:40:27 +00:00
John Blackbourn
b20dd081ba Editor: Revert a fix for incorrect usage of ID attributes on custom fields.
This reverts [47222] due to compatibility issues with plugins which are using the `#poststuff` selector.

See #46964

git-svn-id: https://develop.svn.wordpress.org/trunk@47410 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-03 00:35:41 +00:00
John Blackbourn
0fcbdc1e2d Upgrade/Install: Improved inline docs for the plugin and theme updater maintenance mode functionality.
Props bookdude13

See #49400

git-svn-id: https://develop.svn.wordpress.org/trunk@47409 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-03 00:27:52 +00:00
John Blackbourn
ac6cb23470 Docs: Miscellaneous docs fixes and improvements.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47398 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-01 10:38:00 +00:00
John Blackbourn
78a6e4febb Docs: Use more specific types in parameter descriptions in place of mixed.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47397 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-01 10:36:38 +00:00
John Blackbourn
ba57b0141c Docs: Correct the parameter documentation of the request_filesystem_credentials filter.
See #48303

git-svn-id: https://develop.svn.wordpress.org/trunk@47396 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-01 10:31:31 +00:00
Sergey Biryukov
5f23c79b1d Privacy: Make the progress indicator for export and erasure visible even if not hovered over.
Follow-up to [47246].

Props pbiron, garrett-eclipse.
Fixes #44264.

git-svn-id: https://develop.svn.wordpress.org/trunk@47395 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-29 23:43:57 +00:00
Sergey Biryukov
0347132f12 Privacy: Switch buttons in Next Steps column of privacy request tables to break-word for better legibility on various screen sizes.
Props garrett-eclipse, afercia, nrqsnchz.
Fixes #46304.

git-svn-id: https://develop.svn.wordpress.org/trunk@47376 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 20:59:08 +00:00
Sergey Biryukov
38e9142a66 Coding Standards: Use strict comparison for normalize_whitespace() checks when comparing revisions or autosaves.
Props dkarfa, itowhid06, TimothyBlynJacobs.
Fixes #47965.

git-svn-id: https://develop.svn.wordpress.org/trunk@47372 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 19:33:22 +00:00
Sergey Biryukov
812773b8fc Widgets: Avoid an overflow issue in widget controls that include <select> form fields.
Props alexischenal, audrasjb, dkarfa.
Fixes #49401.

git-svn-id: https://develop.svn.wordpress.org/trunk@47365 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 17:02:27 +00:00
Sergey Biryukov
af57dcb03e I18N: Replace .htaccess with placeholders in the strings for Site Health custom rules check.
Props ramiy.
Fixes #48864.

git-svn-id: https://develop.svn.wordpress.org/trunk@47345 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-22 18:54:09 +00:00
Sergey Biryukov
74908c06bf I18N: Use a consistent wording for "Unable to write to file" strings.
Props ramiy.
Fixes #48862.

git-svn-id: https://develop.svn.wordpress.org/trunk@47344 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-22 18:31:39 +00:00