Commit Graph

161 Commits

Author SHA1 Message Date
Drew Jaynes
0a17fdaf07 Docs: Minorly improve the hook doc summary for the pre_network_site_new_created_user action, introduced in [35786].
See #33631. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36826 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 09:02:46 +00:00
Sergey Biryukov
0814a33464 I18N: Remove <code> tag from translatable string in wp-admin/network/site-new.php.
Props ramiy.
Fixes #35989.

git-svn-id: https://develop.svn.wordpress.org/trunk@36771 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-29 02:43:47 +00:00
Sergey Biryukov
cc35c82c16 I18N: Remove HTML tags from translatable strings in wp-admin/network/themes.php.
Props ramiy.
Fixes #35988.

git-svn-id: https://develop.svn.wordpress.org/trunk@36770 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-29 02:37:22 +00:00
Dominik Schilling (ocean90)
9a7488aaf8 Spelling: Standardize on "front end"/"back end" (noun) and "front-end"/"back-end" (adjective).
Props obrienlabs, thewanderingbrit.
Fixes #34887.

git-svn-id: https://develop.svn.wordpress.org/trunk@36709 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-25 12:52:33 +00:00
Dominik Schilling (ocean90)
320e8b1642 I18N: Fix placeholders and add translator comments after [36695].
See #35705.

git-svn-id: https://develop.svn.wordpress.org/trunk@36697 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-24 21:48:02 +00:00
jeremyfelt
95ba2c38c0 Multisite: Provide an "Edit user" link after adding a new user
Props codex-m, jeremyfelt.
Fixes #35705.


git-svn-id: https://develop.svn.wordpress.org/trunk@36695 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-24 21:42:02 +00:00
Jeremy Felt
380fc2d093 Multisite: Use "Site Address (URL)" in site-new.php.
This uses the same string as single site and `site-info.php` when editing a site in multisite.

Fixes #35934.


git-svn-id: https://develop.svn.wordpress.org/trunk@36684 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-24 16:13:04 +00:00
Jeremy Felt
8ff43d09f5 Multisite: Show the main site's domain and path in site-info.php
* Use the domain and path combination from `wp_blogs` when displaying the site address for the main site.\
* Update the text from "Site URL" to "Site Address (URL)" for all sites in `site-info.php` to better align with how we refer to this in single site.

Props flixos90, rachelbaker.
Fixes #35632.


git-svn-id: https://develop.svn.wordpress.org/trunk@36682 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-24 16:05:23 +00:00
Sergey Biryukov
d85d32f3a0 I18N: Add translator comments and context to "New Site Created" email notification strings.
Props ramiy.
Fixes #35716.

git-svn-id: https://develop.svn.wordpress.org/trunk@36669 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-24 02:03:25 +00:00
Sergey Biryukov
a476311429 I18N: Add missing periods to two strings in wp-admin/network/sites.php
Props ramiy.
Fixes #35720.

git-svn-id: https://develop.svn.wordpress.org/trunk@36664 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-24 01:08:35 +00:00
Pascal Birchler
9ac7cc3aa0 Themes: Improve error messages for broken themes.
Props mayukojpn for initial patch.
Fixes #35286.

git-svn-id: https://develop.svn.wordpress.org/trunk@36638 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-23 17:19:57 +00:00
Jeremy Felt
e198e92dff Multisite: Avoid a PHP Notice when saving a site address without a path.
Props kjbenk.
Fixes #35631.


git-svn-id: https://develop.svn.wordpress.org/trunk@36561 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-17 20:49:29 +00:00
Jeremy Felt
c74db359c4 Multisite: Add a hook to the end of the network's Add New User form.
The `network_user_new_form` action can be used to extend the new user form.

Props ptahdunbar.
Fixes #15389.


git-svn-id: https://develop.svn.wordpress.org/trunk@36556 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-17 19:14:50 +00:00
Jeremy Felt
181f39d2e0 Multisite: Add a hook to the end of the Add Site form.
The `network_site_new_form` action can be used to extend the new site form.

Props igmoweb, ocean90.
Fixes #34739.


git-svn-id: https://develop.svn.wordpress.org/trunk@36555 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-17 19:02:17 +00:00
ericlewis
3fde994152 Networks and sites: Replace "blog" usage with "site" in docs.
Multisite functions use the term "blog" to refer to what we now call a "site," e.g. `get_current_blog_id()`. These functions are here to stay because of our commitment to backwards compatibility. What we can do is set the documentation straight.

See #35417.


git-svn-id: https://develop.svn.wordpress.org/trunk@36416 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-28 03:34:02 +00:00
Pascal Birchler
cc6fe1179d Allow searching for 0 throughout the admin.
Fixes #31025.

git-svn-id: https://develop.svn.wordpress.org/trunk@36302 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-14 20:05:06 +00:00
Andrea Fercia
3a9259a4c4 Introduce a new generic CSS clearfix utility class.
`.wp-clearfix` is now the recommended way to clear and contain floated elements.
Adds back compatibility for the `.nav-tab-wrapper` navigation tabs.

See #26396.

git-svn-id: https://develop.svn.wordpress.org/trunk@36171 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-05 13:37:56 +00:00
Pascal Birchler
0162f5534a Remove unused variables after [35995] and [35996].
See #34439.

git-svn-id: https://develop.svn.wordpress.org/trunk@35997 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-17 18:40:39 +00:00
Pascal Birchler
a072ac113b Network Admin: Remove the list of files which will be deleted when deleting a theme.
Fixes #34439.

git-svn-id: https://develop.svn.wordpress.org/trunk@35996 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-17 18:34:21 +00:00
jeremyfelt
5f5898d200 MS: Fix pagination in MS Sites List Table when entering a page number.
When a page number is manually entered in the sites list table and no bulk action is selected, add `paged` as a query argument to the redirect.

Fixes #32982.


git-svn-id: https://develop.svn.wordpress.org/trunk@35917 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 02:58:22 +00:00
Jeremy Felt
03310b2e22 MS: Update "Add New Site" address description text for accuracy.
Add hyphens to the list of allowed characters and add the `description` class to helper text paragraph tag.

Props thomaswm for the initial patch.
Fixes #26388.


git-svn-id: https://develop.svn.wordpress.org/trunk@35893 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-13 03:12:11 +00:00
Rachel Baker
c3b6753782 Multisite: Clarify purpose of hook from [35786] and match our naming convention.
`network_site_new_created_user_pending` -> `pre_network_site_new_created_user` 

See #33631


git-svn-id: https://develop.svn.wordpress.org/trunk@35789 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 20:31:04 +00:00
Rachel Baker
a9bf2e7aaa Multisite: Add hook before a new user is created during the creation of a new site.
New `network_site_new_created_user_pending` action fires before a new user will be created via the network site-new.php page. 

Props mackensen
Fixes #33631


git-svn-id: https://develop.svn.wordpress.org/trunk@35786 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 20:09:50 +00:00
Sergey Biryukov
4249f900ca Remove <code> tags from translatable string in wp-admin/network/settings.php.
Add translator comment.

Props ramiy.
Fixes #34618.

git-svn-id: https://develop.svn.wordpress.org/trunk@35570 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-08 01:33:13 +00:00
Helen Hou-Sandi
61ef1ff96f Make some primary action buttons look primary.
* User deletion/removal
* Site status change (multisite)
* Network upgrade
* Import file upload
* Media browser upload

props Dezzy for the initial patch.
fixes #23738.


git-svn-id: https://develop.svn.wordpress.org/trunk@35182 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 03:07:48 +00:00
Jeremy Felt
c8019610c8 MS: Reflect falsy values for upload_space_check_disabled in UI.
If the network option for `upload_space_check_disabled` is missing or an empty string, we should reflect how it will be treated elsewhere in the UI.

Props stephenharris.
Fixes #33986.


git-svn-id: https://develop.svn.wordpress.org/trunk@35026 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 00:00:28 +00:00
Sergey Biryukov
fc9f0b229e Merge two database update strings for consistency.
Props pavelevap.
Fixes #33514.

git-svn-id: https://develop.svn.wordpress.org/trunk@35000 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-10 05:13:57 +00:00
Jeremy Felt
ecb75a16be MS: Show an error if a new site slug conflicts with an existing username.
Props utkarshpatel, dipesh.kakadiya.
Fixes #33804.


git-svn-id: https://develop.svn.wordpress.org/trunk@34996 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-10 01:41:43 +00:00
Andrea Fercia
8483316de5 Bump H3 headings to H2 on the Network Admin > Sites > Edit Site screens.
The navigation tabs appear in an `<h3>` heading immediately following the main `<h1>` and need to have a proper hierarchy.
Also, fix the tabs focus style and introduce a new `.nav-tab-small` CSS class.

Fixes #34079.

git-svn-id: https://develop.svn.wordpress.org/trunk@34913 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-07 17:34:56 +00:00
Jeremy Felt
599fb50e09 Revert [34778], continue using _site_option() for the current network.
The `_network_option()` parameter order will be changing to accept `$network_id` first. The `_site_option()` functions will remain in use throughout core as our way of retrieving a network option for the current network.

See #28290.


git-svn-id: https://develop.svn.wordpress.org/trunk@34912 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-07 17:11:01 +00:00
Scott Taylor
9e267b6e72 List Tables/WP_Screen: in WP_Screen, add methods to store, retrieve, and render screen reader text, primarily used by list table screens.
These additions are based on an audit and recommendations by the Accessibility team. #a11y'all

Props afercia.
Fixes #32147.


git-svn-id: https://develop.svn.wordpress.org/trunk@34891 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-07 01:27:01 +00:00
Drew Jaynes
fe383af11a Multisite: Introduce get_subdirectory_reserved_names(), which returns a filterable list of reserved subdirectory site names.
The function encapsulates the existing `subdirectory_reserved_names` filter and reduces the maintenance burden of keeping the value of (currently) two instances of the same hook in sync.

See #33615.


git-svn-id: https://develop.svn.wordpress.org/trunk@34854 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-06 04:34:03 +00:00
Scott Taylor
9fe13be519 oEmbed: add embed to $subdirectory_reserved_names.
Props jeremyfelt.
See #32522.


git-svn-id: https://develop.svn.wordpress.org/trunk@34850 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-06 03:44:25 +00:00
Jeremy Felt
3c177b8c6f MS: Use *_network_option() functions throughout core.
Replaces all uses of `*_site_option()` with the corresponding "network" function.

This excludes one usage in `wp-admin/admin-footer.php` that needs more investigation.

Props spacedmonkey.
See #28290.


git-svn-id: https://develop.svn.wordpress.org/trunk@34778 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-02 19:07:23 +00:00
Andrea Fercia
b61d943435 Bump H3 headings to H2 on the Network Site Users screen for better accessibility.
Fixes #34081.

git-svn-id: https://develop.svn.wordpress.org/trunk@34742 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-01 14:32:15 +00:00
Scott Taylor
3d06ffcbbc Network Upgrade: switch <h3> to <h2>.
Props afercia.
Fixes #34082.


git-svn-id: https://develop.svn.wordpress.org/trunk@34701 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-29 21:27:42 +00:00
Andrea Fercia
c81fe78b9c Bump H3 headings to H2 on the Network Settings screen for better accessibility.
Fixes #34078.

git-svn-id: https://develop.svn.wordpress.org/trunk@34695 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-29 18:51:20 +00:00
Jeremy Felt
8f4a6370f0 Fixes #33816.
MS: Adjust formatting of code in `site-new.php` to improve readability.

Fixes #34066.


git-svn-id: https://develop.svn.wordpress.org/trunk@34673 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-28 23:29:40 +00:00
Scott Taylor
5dd7bec848 Multisite: as a precaution, make wp-json a reserved subdirectory name.
Props austinginder.
Fixes #33789.


git-svn-id: https://develop.svn.wordpress.org/trunk@34375 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 04:20:41 +00:00
Helen Hou-Sandi
3531c0bc10 Superglobals: Revert [34059] until further notice.
see #33837.


git-svn-id: https://develop.svn.wordpress.org/trunk@34265 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 12:32:20 +00:00
Boone Gorges
de7c9b6015 Move new user notification emails to add_action() callbacks.
When a new user is created in various places throughout the interface,
notifications are sent to the site admin and the new user. Previously, these
notifications were fired through direct calls to `wp_new_user_notification()`,
making it difficult to stop or modify the messages.

This changeset introduces a number of new action hooks in place of direct calls
to `wp_new_user_notification()`, and hooks the new wrapper function
`wp_send_new_user_notifications()` to these hooks.

Props dshanske, thomaswm, boonebgorges.
Fixes #33587.

git-svn-id: https://develop.svn.wordpress.org/trunk@34251 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 22:18:33 +00:00
Boone Gorges
0adb6877b2 Improve validation of user_login and user_nicename length.
The `user_login` field only allows 60 characters, and `user_nicename` allows
50. However, there are no protections in the interface, and few in the code,
that prevent the creation of users with values in excess of these limits. Prior
to recent changes in `$wpdb`, users were generally created anyway, MySQL
having performed the necessary truncation. More recently, the `INSERT`s and
`UPDATE`s simply fail, with no real feedback on the nature of the failure.

This changeset addresses the issue in a number of ways:
* On the user-new.php and network/user-new.php panels, don't allow input in excess of the maximum field length.
* In `wp_insert_user()`, throw an error if the value provided for `'user_login'` or `'user_nicename'` exceeds the maximum field length.
* In `wp_insert_user()`, when using `'user_login'` to generate a default value for `'user_nicename'`, ensure that the nicename is properly truncated, even when suffixed for uniqueness (username-2, etc).

Props dipesh.kakadiya, utkarshpatel, tommarshall, boonebgorges.
Fixes #33793.

git-svn-id: https://develop.svn.wordpress.org/trunk@34218 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-15 22:13:51 +00:00
Dominik Schilling (ocean90)
08098026ce Passwords: Deprecate second parameter of wp_new_user_notification().
The second parameter `$plaintext_pass` was removed in [33023] and restored as `$notify` in [33620] with a different behavior. If you have a plugin overriding `wp_new_user_notification()` which hasn't been updated you would get a notification with your username and the password "both".
To prevent this the second parameter is now deprecated and reintroduced as the third parameter.

Adds unit tests.

Props kraftbj, adamsilverstein, welcher, ocean90.
Fixes #33654.

(Don't ask for new pluggables kthxbye)

git-svn-id: https://develop.svn.wordpress.org/trunk@34116 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-14 12:42:34 +00:00
Scott Taylor
33953cb392 Introduce wp_validate_action( $action = '' ), a helper function that checks $_REQUEST for action and returns it, or empty string if not present. If $action is passed, it checks to make sure they match before returning it, or an empty string. Strings are always returned to avoid returning multiple types.
Implementing this removes 27 uses of direct superglobal access in the admin.

For more reading:
https://codeclimate.com/github/WordPress/WordPress/wp-admin/edit-comments.php

See #33837.


git-svn-id: https://develop.svn.wordpress.org/trunk@34059 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-11 21:07:45 +00:00
Scott Taylor
b1a91e4a28 Move network_settings_add_js() from wp-admin/network/settings.php to wp-admin/includes/ms.php.
See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34026 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 22:23:47 +00:00
Scott Taylor
2fe412793e Move confirm_delete_users() from wp-admin/network/users.php to wp-admin/includes/ms.php.
See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34025 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 22:22:44 +00:00
Jeremy Felt
9b193ad5a4 Multisite: Display content attribution drop down when deleting a user
The previous move from `echo()` to `_e()` left some of the output hanging. Introduced in [32333].

Props figureone.
Fixes #33811 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@34012 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 20:25:07 +00:00
Scott Taylor
f8b6a357a0 Multisite: Don't allow sites to be created with the following reserved slugs: wp-admin, wp-content, wp-includes
Props austinginder.
Fixes #33615.


git-svn-id: https://develop.svn.wordpress.org/trunk@33952 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-08 19:31:52 +00:00
Jeremy Felt
6b5e1e8c9b Multisite: Update help tab text for site-info.php to reference "site URL".
In [32759] and [33586], we combined the domain and path entry for a site to a single "Site URL" field. This updates the help text to reflect that.

Fixes #33748. See #22383.


git-svn-id: https://develop.svn.wordpress.org/trunk@33921 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 20:52:52 +00:00
John Blackbourn
38fe3c4db5 Implement a language chooser on the Network Admin -> Sites -> Add New screen.
Props DrewAPicture
Fixes #33528


git-svn-id: https://develop.svn.wordpress.org/trunk@33920 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 20:47:00 +00:00