Commit Graph

74 Commits

Author SHA1 Message Date
Andrea Fercia
d986f9dcdc Toolbar: remove some unnecessary CSS lines.
They were commented out in `admin-bar.css` since 3 years, see [26770].

Props kafleg, ketuchetan.

Fixes #39137.


git-svn-id: https://develop.svn.wordpress.org/trunk@39533 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-07 17:44:45 +00:00
Andrea Fercia
8a6fa93b84 Accessibility: Revert [38984] as it needs to be better communicated to plugin authors.
See #37513.


git-svn-id: https://develop.svn.wordpress.org/trunk@39147 602fd350-edb4-49c9-b593-d223f7449a82
2016-11-05 16:27:13 +00:00
Andrea Fercia
6cc9480fd8 Accessibility: Hide the Toolbar sub-menu icons from assistive technologies.
CSS generated content is going to be rendered for speech output more and more in
the next future. When it's not intended to be available for speech output, for
example with font icons, then special care should be used to hide it from
assistive technologies. At the moment, the only reliable way to do this is making 
use of a wrapper element and set `aria-hidden="true"` on it.

Fixes #37513.


git-svn-id: https://develop.svn.wordpress.org/trunk@38984 602fd350-edb4-49c9-b593-d223f7449a82
2016-10-27 20:52:20 +00:00
Dominik Schilling (ocean90)
0bab64c370 Toolbar: Update links to the about page if current user can't access the dashboard of the current site.
Add missing focus styling for menu items with an icon.

Fixes #37949.

git-svn-id: https://develop.svn.wordpress.org/trunk@38660 602fd350-edb4-49c9-b593-d223f7449a82
2016-09-27 19:00:35 +00:00
Helen Hou-Sandi
1e21bf9bf7 System fonts: Don't quote single-word font names, per our coding standards.
props ocean90, netweb.
see #36753.


git-svn-id: https://develop.svn.wordpress.org/trunk@38152 602fd350-edb4-49c9-b593-d223f7449a82
2016-07-26 16:38:49 +00:00
Dominik Schilling
e556fec595 Toolbar: Allow 0 as a value for the tabindex property of a menu item.
To enhance accessibility for items without a link you can now define `tabindex="0"`, which makes descendant dropdowns accessible.

Props joedolson, afercia, ocean90.
Fixes #32495.

git-svn-id: https://develop.svn.wordpress.org/trunk@38035 602fd350-edb4-49c9-b593-d223f7449a82
2016-07-12 11:18:00 +00:00
Helen Hou-Sandi
265fabc1c4 Use numeric font weights instead of keywords.
When Open Sans was in use, the `300`, `400`, and `600` weights were loaded. `400` is the equivalent of `normal`; however, `bold` is equivalent to `700`, not `600`. With the move to system fonts, we need to be specific rather than relying on the lack of a `700` weight. Not all system fonts include a `600` weight; in those instances, they will use the `bold`/`700` weight.

The WordPress CSS Coding Standards have been updated accordingly.

props coderste.
see #36753.


git-svn-id: https://develop.svn.wordpress.org/trunk@37740 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-17 18:36:03 +00:00
Helen Hou-Sandi
b34c03c5b0 System font: The stack does not work with the font shorthand property.
see #36753.


git-svn-id: https://develop.svn.wordpress.org/trunk@37442 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-17 01:44:36 +00:00
Helen Hou-Sandi
8d6d88ffbb Admin font: Remove a redundant sans-serif declaration.
props samantha-miller.
see #36753.


git-svn-id: https://develop.svn.wordpress.org/trunk@37419 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-12 02:13:43 +00:00
Jeremy Felt
356514e994 Multisite: Use the admin-multisite Dashicon for sites
This icon was added to Dashicons in 4.3, but not applied to anything in our CSS.

Uses the more appropriate `dashicons-admin-multisite` when displaying the sites menu item.

Props Ipstenu, ocean90.
Fixes #36754.


git-svn-id: https://develop.svn.wordpress.org/trunk@37365 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-05 17:12:12 +00:00
Jeremy Felt
705b36d63d Revert [37362], which incorrectly changed Dashicons CSS
`dashicons.css` is an external-ish library and the change there is incorrect.

See #36754.


git-svn-id: https://develop.svn.wordpress.org/trunk@37364 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-05 15:28:24 +00:00
Jeremy Felt
fdcacb5ca9 Multisite: Use the admin-multisite Dashicon in the admin menu and bar
This icon was added to Dashicons in 4.3, but not applied to anything in our CSS.

Props Ipstenu.
Fixes #36754.


git-svn-id: https://develop.svn.wordpress.org/trunk@37362 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-05 04:28:36 +00:00
Helen Hou-Sandi
0671f3a8d3 Drop Open Sans in the admin in favor of system fonts.
Rejoice, for your admins will feel more native to your surrounding computing environment and likely load faster, especially when offline, as they no longer have to talk to The Google Overlord.

At the time of introduction in 3.8, there were not good system fonts common to all platforms at the time. In the years since, Windows, Android, OS X, iOS, Firefox OS, and various flavors of Linux have all gotten their own (good) system UI fonts.

There will definitely be visual bugs, mainly around alignment and spacing; these should be documented and reported on the ticket and fixed more atomically so that our current and future selves have a better understanding of what happened and why.

The style remains registered, as it is almost certainly in use by themes and plugins.

props mattmiklic.
see #36753.


git-svn-id: https://develop.svn.wordpress.org/trunk@37361 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-04 22:06:27 +00:00
Andrea Fercia
b6d18747fc Accessibility: Improve the color contrast ratio for the input placeholders.
Also, cleans up a bit the CSS removing rules for elements that don't use
placeholders any more.

Fixes #35777.

git-svn-id: https://develop.svn.wordpress.org/trunk@36619 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-22 23:28:43 +00:00
Andrea Fercia
15a26902a6 Accessibility: Improve color contrast updating any #999 gray used for text or icons to a darker gray.
Fixes #35660.

git-svn-id: https://develop.svn.wordpress.org/trunk@36587 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-19 18:43:04 +00:00
Helen Hou-Sandi
9e865f51a8 RIP #21759b, the old WordPress Blue.
The final lingering instances were all for hidden accessibility helper text.

fixes #34388.


git-svn-id: https://develop.svn.wordpress.org/trunk@35340 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 18:35:05 +00:00
Andrea Fercia
ccb76a5af0 Multisite: Improve the Admin Bar parent menu items color on hover and focus.
Props Nikschavan for the initial patch.
Fixes #34040.

git-svn-id: https://develop.svn.wordpress.org/trunk@35265 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-18 16:21:42 +00:00
Sergey Biryukov
c5c5bd31dd Toolbar: Improve padding of toolbar submenu items on small screens.
Props tillkruess.
Fixes #28608.

git-svn-id: https://develop.svn.wordpress.org/trunk@35132 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 07:39:54 +00:00
Scott Taylor
da6e194d93 Admin Bar: fix the alignment of secondary menu item arrows.
Props juhise.
Fixes #33836.


git-svn-id: https://develop.svn.wordpress.org/trunk@35125 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 03:53:16 +00:00
John Blackbourn
811e538325 Update links to the user profile editing screen in the admin toolbar when the current logged in user has no role on the current site. Covers single site and Multisite and introduces tests.
Fixes #25162


git-svn-id: https://develop.svn.wordpress.org/trunk@34122 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-14 17:09:58 +00:00
Scott Taylor
d937112e9f Grunt RTL CSS: swap-dashicons-left-right-arrows in rtlcss:properties expects double-quoted content strings in CSS. It doesn't swap single-quoted values.
Props Ankit K Gupta, yoavf, netweb.
Fixes #33786.


git-svn-id: https://develop.svn.wordpress.org/trunk@34011 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 20:21:57 +00:00
Scott Taylor
b8e30f3ec7 Dashicons CSS: one-word font families don't need quotes. Font families with a space in the name should use double-quotes (doesn't apply here).
Props afercia.
Fixes #32866.


git-svn-id: https://develop.svn.wordpress.org/trunk@33912 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 19:56:15 +00:00
Helen Hou-Sandi
f5043ab022 Toolbar: Disambiguate links to the dashboard vs. to the customizer.
All links in the site name menu now point to admin screens, and Customize is its own top-level link. This makes it clear which context you are about to enter.

fixes #32924. see #32678.


git-svn-id: https://develop.svn.wordpress.org/trunk@33130 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-08 20:02:44 +00:00
Helen Hou-Sandi
e7a184a832 Toolbar: Allow submenus to be closed with a second tap on touch devices.
Also closes submenus when the admin menu is toggled open, as it opens below and thus can be obscured.

props stephdau, seanchayes.
see #29906.


git-svn-id: https://develop.svn.wordpress.org/trunk@33056 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 03:28:15 +00:00
Dominik Schilling (ocean90)
5202111c6a Toolbar: Remove a duplicate CSS selector.
props deconf.
fixes #32634.

git-svn-id: https://develop.svn.wordpress.org/trunk@32750 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-13 14:53:59 +00:00
Helen Hou-Sandi
34ebf98f36 Toolbar: Search item consistency for focus state and IE8.
props afercia.
fixes #31322.


git-svn-id: https://develop.svn.wordpress.org/trunk@32074 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-08 16:07:51 +00:00
Helen Hou-Sandi
f64bf71719 Update more instances of default admin blues and grays.
props hugobaeta.
fixes #31234.


git-svn-id: https://develop.svn.wordpress.org/trunk@32051 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-05 21:19:54 +00:00
Helen Hou-Sandi
e771be8f7c Toolbar: Protect against Firefox font rendering interference by themes.
props cbaldelomar.
fixes #30021.


git-svn-id: https://develop.svn.wordpress.org/trunk@31824 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-18 22:03:12 +00:00
Helen Hou-Sandi
d00ef0f076 Update the default admin color scheme for more unity and refinement.
This removes the red channel from blues and cools the grays a bit for a more cohesive and purposeful color scheme.

props hugobaeta.
fixes #31234.


git-svn-id: https://develop.svn.wordpress.org/trunk@31422 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-11 22:17:02 +00:00
Andrew Ozz
549006887b Admin toolbar: remove unneeded overrides of z-index and left on screens narrower than 782px. Props avryl, babbardel. Fixes #29867.
git-svn-id: https://develop.svn.wordpress.org/trunk@30764 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 03:00:35 +00:00
Dominik Schilling (ocean90)
c0b15e6b6d Toolbar: Make Customize support classes work on narrow viewports too.
fixes #30571.

git-svn-id: https://develop.svn.wordpress.org/trunk@30713 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 22:00:48 +00:00
John Blackbourn
f6a51e7ff3 Don't fix the position of the admin toolbar submenus when the viewport is below 600px. This avoids them becoming detached from the admin toolbar when scrolling.
Fixes #29905
Props avryl


git-svn-id: https://develop.svn.wordpress.org/trunk@30706 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 06:48:24 +00:00
Helen Hou-Sandi
7514ac3218 Use a brighter blue against dark backgrounds in the admin menu and toolbar.
Not only does this pass contrast guidelines, but it also visually appears closer to the original highlight blue used against light backgrounds.

props melchoyce. fixes #30323.


git-svn-id: https://develop.svn.wordpress.org/trunk@30313 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-12 20:27:04 +00:00
Helen Hou-Sandi
71704c1156 Remove a toolbar CSS hack for a Chrome bug that no longer appears to exist. props avryl. fixes #28606. see #18868.
git-svn-id: https://develop.svn.wordpress.org/trunk@28981 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 20:19:08 +00:00
Helen Hou-Sandi
220a45a32d Don't use the box shadow focus styling for the admin menu or toolbar. see #28267.
git-svn-id: https://develop.svn.wordpress.org/trunk@28616 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 14:22:39 +00:00
Sergey Biryukov
2d420d52bb Display Dashboard icon instead of the home icon in toolbar when the link leads to Dashboard.
props ghost1227.
fixes #26754.

git-svn-id: https://develop.svn.wordpress.org/trunk@28599 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-28 13:41:23 +00:00
Andrew Nacin
01b809bf2b Dev/build tools: Use grunt-autoprefixer for CSS vendor prefixes.
We'll be using it for two distinct tasks:
 * Core CSS files will keep prefixes. `grunt autoprefixer:core` will update files directly in src/ as a pre-commit step, rather than doing it on build.
 * Color CSS files will receive prefixes when they are built.

This commit:
 * Adds prefixes we were missing to core CSS.
 * Removes prefixes that we no longer need from core CSS.
 * Removes all prefixes from colors CSS.

props ocean90.
fixes #27078.


git-svn-id: https://develop.svn.wordpress.org/trunk@27174 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-13 08:29:16 +00:00
Matt Thomas
eac3ccc29a Responsive improvements to submenus in the adminbar:
- Remove .ab-sub-wrapper rules in the 782px media query, as they're duplicates of the rules set on line 161.
- Reposition the arrows for submenus at responsive sizes where the menus are taller.
- Set the submenu position to static at smartphone sizes, so it's not positioned outside of its parent (and thus offscreen).

Fixes #26720, props undergroundnetwork, iammattthomas.




git-svn-id: https://develop.svn.wordpress.org/trunk@27006 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 18:37:42 +00:00
Dominik Schilling (ocean90)
69848ed0b9 Dashicons: Update to the latest dashicons files.
props empireoflight, melchoyce.
see #26518 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@26925 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-08 22:25:35 +00:00
Andrew Nacin
586b882437 Adjust widths of toolbar items at mobile sizes for better fitting on narrow screens. Fixes toolbar wrapping when using multisite.
props iammattthomas.
see #26537 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@26920 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-08 21:23:18 +00:00
Andrew Ozz
68f9e4db5e Make older mobile browsers and IE7 usable:
- Text labels in the toolbar.
- Image icons in the visual editor.
- Some IE7 structural css fixes.
Fixes #26369.

git-svn-id: https://develop.svn.wordpress.org/trunk@26819 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-09 02:40:32 +00:00
Andrew Nacin
b3a432a7fb RTL font-family overrides. (Tahoma generally, and Arial for Hebrew.)
props yoavf.
fixes #24977.


git-svn-id: https://develop.svn.wordpress.org/trunk@26816 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-09 01:30:08 +00:00
Matt Thomas
55f9e6b106 Change the site menu icon from a globe to home, which is a better metaphor for what it does. Fixes #25971.
git-svn-id: https://develop.svn.wordpress.org/trunk@26812 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-09 00:40:10 +00:00
Matt Thomas
c438d89ff1 Make the padding added for top-level toolbar items in r26675 more specific and reinstate the previous 10px padding for links within dropdown menus. Fixes #26484.
git-svn-id: https://develop.svn.wordpress.org/trunk@26808 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-08 20:43:42 +00:00
Andrew Ozz
d0689f0564 Toolbar:
- Fix submenus in responsive mode (were ignoring the .hover class on a parent).
- Improve top level items hiding.
Fixes #26476.

git-svn-id: https://develop.svn.wordpress.org/trunk@26803 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-08 17:14:16 +00:00
Matt Thomas
11236ceb8e Comment out these touch-related styles as they break toolbar dropdowns in Chrome for Android. Fixes #25972.
git-svn-id: https://develop.svn.wordpress.org/trunk@26770 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-07 04:58:35 +00:00
Matt Thomas
5112fe565a Provide a default generic avatar icon in the My Account menu if avatars are disabled, ensuring that the link is visible at responsive sizes. See #25858.
git-svn-id: https://develop.svn.wordpress.org/trunk@26744 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-06 21:22:14 +00:00
Matt Thomas
642293800b Add new fit-content rules to accompany intrinsic width on adminbar dropdown wrappers. Fixes #26430, props Jayjdk.
git-svn-id: https://develop.svn.wordpress.org/trunk@26735 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-06 19:15:31 +00:00
Matt Thomas
3cf585f1d3 Make toolbar dropdown submenu links tappable. See #25972, props ninnypants.
git-svn-id: https://develop.svn.wordpress.org/trunk@26716 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-06 05:27:19 +00:00
Matt Thomas
764e70948b At responsive sizes, remove the hard-coded fixed positioning for Comments and Add New in the toolbar. Make links slightly wider to better fill small-screen devices. Fixes #26432.
git-svn-id: https://develop.svn.wordpress.org/trunk@26710 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-06 01:01:40 +00:00